fix(doctor): register onboard check names in doctor-categories to stop unknown-check warnings

doctor.ts pushes runAllOnboardChecks results into the checks list, but the
7 onboard check names (embed_staleness, entity_link_coverage,
timeline_coverage, takes_count, dangling_aliases, pack_upgrade_available,
type_proliferation) were never added to doctor-categories.ts, so every
doctor run emitted an 'unknown check name' stderr warn per onboard check.

Registers the 5 data-quality names under BRAIN and the 2 schema-pack names
under META (alphabetical order preserved), and widens the drift-guard test
to scan src/core/onboard/checks.ts alongside src/commands/doctor.ts so
future onboard checks can't drift uncategorized.

Takeover of #1839, rebased onto master (keeps master's timeline_dedup_index).

Co-authored-by: mvanhorn <mvanhorn@users.noreply.github.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

src/commands/autopilot.ts

@@ -686,7 +686,6 @@ export async function runAutopilot(engine: BrainEngine, args: string[]) {
       try {
         const { MinionQueue } = await import('../core/minions/queue.ts');
         const { computeRecommendations, embeddingProviderConfigured, HOSTED_EMBED_KEY_CONFIG } = await import('../core/brain-score-recommendations.ts');
-        const { countExtractionLag } = await import('../core/remediation/context.ts');
         const queue = new MinionQueue(engine);
         const slotMs = Math.floor(Date.now() / (baseInterval * 1000)) * baseInterval * 1000;
         const slot = new Date(slotMs).toISOString();
@@ -878,9 +877,6 @@ export async function runAutopilot(engine: BrainEngine, args: string[]) {
             return !!(process.env[envVar] || (cfgField ? embedKeyCfg[cfgField] : undefined));
           }),
           hasChatApiKey: !!(process.env.ANTHROPIC_API_KEY || await engine.getConfig('anthropic_api_key')),
-          // Real extraction-lag gate for sync.repo/extract.all — same counter
-          // loadRecommendationContext uses (replaces the health.stale_pages proxy).
-          extractionLagPages: await countExtractionLag(engine),
         };
         // v0.41.18.0 (A5 + A19 + A22, T15): consult onboard recommendations
         // ALONGSIDE doctor's brain-score recommendations. Onboard's 4 new

src/core/brain-score-recommendations.ts

@@ -146,16 +146,6 @@ export interface RecommendationContext {
   chatModel?: string;
   /** Whether the chat provider has a usable API key. */
   hasChatApiKey?: boolean;
-  /**
-   * Count of pages needing link/timeline extraction — the SAME staleness the
-   * `gbrain extract --stale` walk and doctor's `links_extraction_lag` check use
-   * (`engine.countStalePagesForExtraction`). Gates the sync→extract pipeline
-   * (sync.repo / extract.all). Replaces the old `health.stale_pages` gate, which
-   * counted "pages whose updated_at predates their newest timeline entry" — a
-   * proxy that broke when the updated_at-on-timeline-insert trigger was dropped
-   * (migration v10) and never reflected real extraction work.
-   */
-  extractionLagPages?: number;
 }
 
 /** Triage result for one check. */
@@ -202,28 +192,20 @@ export function computeRecommendations(
   const source = ctx.sourceId ?? 'default';
 
   // ---------------------------------------------------------------------
-  // sync.repo + extract.all — the materialization pipeline, gated on the REAL
-  // extraction lag (pages whose link/timeline edges are stale), NOT on the
-  // legacy `health.stale_pages` proxy. `extractionLagPages` comes from the same
-  // counter the `extract --stale` walk + doctor's `links_extraction_lag` use, so
-  // the recommendation can only fire when running extract will actually reduce
-  // it (and clear the rec). See RecommendationContext.extractionLagPages.
-  // sync.repo is the prerequisite: re-sync so pages are current before extract
-  // materializes their edges.
+  // sync.repo — fires when sync hasn't run recently OR pages are stale
   // ---------------------------------------------------------------------
-  const extractionLag = ctx.extractionLagPages ?? 0;
-  if (ctx.repoPath && extractionLag > 0) {
+  if (ctx.repoPath && health.stale_pages > 0) {
     const params = { repoPath: ctx.repoPath, sourceId: ctx.sourceId, noEmbed: true };
     out.push({
       id: 'sync.repo',
       job: 'sync',
       params,
       idempotency_key: idemKey(source, 'sync', params),
-      severity: extractionLag > 50 ? 'high' : 'medium',
-      est_seconds: Math.min(600, 30 + extractionLag * 0.5),
+      severity: health.stale_pages > 50 ? 'high' : 'medium',
+      est_seconds: Math.min(600, 30 + health.stale_pages * 0.5),
       est_usd_cost: 0,  // sync is fs+DB only
       depends_on: [],
-      rationale: `Sync before extracting ${extractionLag} page${extractionLag === 1 ? '' : 's'} with stale link/timeline edges`,
+      rationale: `${health.stale_pages} stale page${health.stale_pages === 1 ? '' : 's'} on disk`,
       status: 'remediable',
     });
   }
@@ -255,7 +237,7 @@ export function computeRecommendations(
       est_seconds: Math.min(3600, 5 + health.missing_embeddings * 0.05),
       est_usd_cost,
       // sync should run first so embed sees fresh pages.
-      depends_on: ctx.repoPath && extractionLag > 0 ? ['sync.repo'] : [],
+      depends_on: ctx.repoPath && health.stale_pages > 0 ? ['sync.repo'] : [],
       rationale: `${health.missing_embeddings} chunk${health.missing_embeddings === 1 ? '' : 's'} invisible to vector search`,
       status: 'remediable',
     });
@@ -285,7 +267,7 @@ export function computeRecommendations(
   // Triggered when sync.repo fires (because sync was set to noEmbed:true,
   // and noExtract:true after T5 lands → extract job is the materializer).
   // ---------------------------------------------------------------------
-  if (ctx.repoPath && extractionLag > 0) {
+  if (ctx.repoPath && health.stale_pages > 0) {
     const params = { mode: 'all', dir: ctx.repoPath };
     out.push({
       id: 'extract.all',
@@ -296,7 +278,7 @@ export function computeRecommendations(
       est_seconds: Math.min(600, 30 + health.page_count * 0.01),
       est_usd_cost: 0,
       depends_on: ['sync.repo'],
-      rationale: `Materialize link + timeline edges for ${extractionLag} page${extractionLag === 1 ? '' : 's'} with stale extraction`,
+      rationale: 'Materialize link + timeline edges from fresh pages',
       status: 'remediable',
     });
   }

src/core/doctor-categories.ts

@@ -35,10 +35,11 @@
  *
  * The doctor renders both side by side.
  *
- * Drift contract: every check name that ships in doctor.ts MUST appear in
+ * Drift contract: every check name that ships through doctor MUST appear in
  * exactly one set below. The drift-guard test in
- * `test/doctor-categories.test.ts` enforces this by reading doctor.ts source
- * via a tagged-string scan and asserting set membership exactly.
+ * `test/doctor-categories.test.ts` enforces this by reading doctor check
+ * emitter sources via a tagged-string scan and asserting set membership
+ * exactly.
  *
  * If you add a new doctor check, you MUST add its name to the appropriate
  * set here. The categorize step in `src/commands/doctor.ts` falls through
@@ -67,12 +68,15 @@ export const BRAIN_CHECK_NAMES: ReadonlySet<string> = new Set([
   'conversation_parser_probe_health',
   'cross_modal_modality_backfill',
   'cycle_freshness',
+  'dangling_aliases',
   'effective_date_health',
+  'embed_staleness',
   'embedding_column_registry',
   'embedding_env_override',
   'embedding_provider',
   'embedding_width_consistency',
   'embeddings',
+  'entity_link_coverage',
   'eval_drift',
   'extract_atoms_backlog',
   'extract_health',
@@ -102,7 +106,9 @@ export const BRAIN_CHECK_NAMES: ReadonlySet<string> = new Set([
   'stub_guard_24h',
   'sync_failures',
   'sync_freshness',
+  'takes_count',
   'takes_weight_grid',
+  'timeline_coverage',
   'unified_multimodal_coverage',
   'voice_gate_health',
 ]);
@@ -170,12 +176,14 @@ export const META_CHECK_NAMES: ReadonlySet<string> = new Set([
   'eval_capture',
   'minions_migration',
   'multi_source_drift',
+  'pack_upgrade_available',
   'schema_pack_active',
   'schema_pack_consistency',
   'schema_pack_source_drift',
   'schema_version',
   'slug_fallback_audit',
   'timeline_dedup_index',
+  'type_proliferation',
   'upgrade_errors',
 ]);
 

src/core/remediation/context.ts

@@ -8,7 +8,6 @@
 
 import type { BrainEngine } from '../engine.ts';
 import type { RecommendationContext } from '../brain-score-recommendations.ts';
-import { LINK_EXTRACTOR_VERSION_TS } from '../link-extraction.ts';
 
 // Re-export so consumers can `import { RecommendationContext } from '../remediation'`
 // — the canonical RecommendationContext type still lives in
@@ -69,29 +68,5 @@ export async function loadRecommendationContext(
     embeddingDimensions,
     embeddingProviderConfigured: embeddingConfigured,
     hasChatApiKey: !!(process.env.ANTHROPIC_API_KEY || fileCfg?.anthropic_api_key),
-    extractionLagPages: await countExtractionLag(engine),
   };
 }
-
-/**
- * Real extraction-lag count — the SAME staleness `gbrain extract --stale`
- * processes (engine.countStalePagesForExtraction with
- * versionTs=LINK_EXTRACTOR_VERSION_TS, matching doctor's links_extraction_lag
- * check — without versionTs, pages stamped before an extractor version bump
- * would lag for doctor/extract but never trip this gate). Drives the
- * sync→extract recommendation pipeline; replaces the legacy
- * `health.stale_pages` proxy that no longer reflected real extraction work
- * after the v10 trigger drop.
- *
- * Shared by loadRecommendationContext AND the D7 per-step recheck in
- * runRemediation — the recheck MUST refresh this gate alongside getHealth,
- * or a completed extract step keeps re-firing off the frozen initial count.
- */
-export async function countExtractionLag(engine: BrainEngine): Promise<number> {
-  try {
-    return await engine.countStalePagesForExtraction({ versionTs: LINK_EXTRACTOR_VERSION_TS });
-  } catch {
-    /* counter unavailable (very old brain / mid-migration) — treat as 0 */
-    return 0;
-  }
-}

src/core/remediation/run.ts

@@ -16,7 +16,7 @@ import {
   computeRecommendations,
 } from '../brain-score-recommendations.ts';
 import type { RemediationStep } from '../remediation-step.ts';
-import { countExtractionLag, loadRecommendationContext } from './context.ts';
+import { loadRecommendationContext } from './context.ts';
 import { computeRemediationPlan } from './plan.ts';
 import type {
   RemediationHooks,
@@ -65,7 +65,7 @@ export async function runRemediation(
     clearRemediationCheckpoint,
   } = await import('../remediation-checkpoint.ts');
 
-  let ctx = await loadRecommendationContext(engine);
+  const ctx = await loadRecommendationContext(engine);
 
   // Pre-flight ceiling check via the shared plan computation.
   const initialPlan = await computeRemediationPlan(engine, { targetScore });
@@ -305,11 +305,6 @@ export async function runRemediation(
       // steps with bumped retry suffix (D1).
       if (recs.length === 0 || stepCount >= maxJobs) break;
       const freshHealth = await engine.getHealth();
-      // Refresh the extraction-lag gate alongside health: ctx was loaded once
-      // before the loop, and a completed sync/extract step is exactly what
-      // drives the count down. Reusing the frozen initial count would re-fire
-      // sync.repo/extract.all every recheck until maxJobs.
-      ctx = { ...ctx, extractionLagPages: await countExtractionLag(engine) };
       recs = computeRecommendations(freshHealth, ctx).filter((r) => r.status === 'remediable');
     }
   };

src/core/types.ts

@@ -1423,15 +1423,6 @@ export interface BrainStats {
 export interface BrainHealth {
   page_count: number;
   embed_coverage: number;
-  /**
-   * LEGACY proxy: count of pages whose `updated_at` predates their newest
-   * timeline entry. This bumped meaningfully only while a trigger updated
-   * `pages.updated_at` on timeline insert; that trigger was dropped in
-   * migration v10, so the metric no longer reflects real "needs work" state.
-   * NO LONGER gates remediations — the sync→extract pipeline now gates on
-   * `RecommendationContext.extractionLagPages` (the real extraction-lag from
-   * `countStalePagesForExtraction`). Retained for the CLI health line + back-compat.
-   */
   stale_pages: number;
   /**
    * Islanded pages — zero inbound AND zero outbound links. A hub page

test/brain-score-recommendations.test.ts

@@ -119,12 +119,13 @@ describe('computeRecommendations', () => {
     expect(recs.find((r) => r.id === 'embed.stale')).toBeUndefined();
   });
 
-  test('extraction lag + dead links produce sync + backlinks + extract', () => {
+  test('stale pages + dead links produce sync + backlinks + extract', () => {
     const health = makeHealth({
+      stale_pages: 25,
       dead_links: 8,
       brain_score: 70,
     });
-    const recs = computeRecommendations(health, { repoPath: '/brain', embeddingProviderConfigured: true, extractionLagPages: 25 });
+    const recs = computeRecommendations(health, { repoPath: '/brain', embeddingProviderConfigured: true });
     const ids = recs.map((r) => r.id);
     expect(ids).toContain('sync.repo');
     expect(ids).toContain('backlinks.fix');
@@ -132,17 +133,18 @@ describe('computeRecommendations', () => {
   });
 
   test('extract.all depends on sync.repo (D14: stable ids)', () => {
-    const health = makeHealth();
-    const recs = computeRecommendations(health, { repoPath: '/brain', embeddingProviderConfigured: true, extractionLagPages: 10 });
+    const health = makeHealth({ stale_pages: 10 });
+    const recs = computeRecommendations(health, { repoPath: '/brain', embeddingProviderConfigured: true });
     const extract = recs.find((r) => r.id === 'extract.all');
     expect(extract?.depends_on).toContain('sync.repo');
   });
 
-  test('embed.stale depends on sync.repo when extraction also needed', () => {
+  test('embed.stale depends on sync.repo when sync also needed', () => {
     const health = makeHealth({
+      stale_pages: 10,
       missing_embeddings: 100,
     });
-    const recs = computeRecommendations(health, { repoPath: '/brain', embeddingProviderConfigured: true, extractionLagPages: 10 });
+    const recs = computeRecommendations(health, { repoPath: '/brain', embeddingProviderConfigured: true });
     const embed = recs.find((r) => r.id === 'embed.stale');
     expect(embed?.depends_on).toContain('sync.repo');
   });
@@ -157,9 +159,9 @@ describe('computeRecommendations', () => {
   test('severity ordering: critical before high before medium', () => {
     const health = makeHealth({
       missing_embeddings: 100,  // critical
+      stale_pages: 80,          // high
     });
-    // extractionLagPages > 50 → sync.repo fires at 'high' severity.
-    const recs = computeRecommendations(health, { repoPath: '/brain', embeddingProviderConfigured: true, extractionLagPages: 80 });
+    const recs = computeRecommendations(health, { repoPath: '/brain', embeddingProviderConfigured: true });
     const critIdx = recs.findIndex((r) => r.severity === 'critical');
     const highIdx = recs.findIndex((r) => r.severity === 'high');
     expect(critIdx).toBeLessThan(highIdx);
@@ -168,10 +170,11 @@ describe('computeRecommendations', () => {
   // D6 #5 — THE critical regression test for the agent contract.
   test('D6 #5: determinism — same input twice produces identical output', () => {
     const health = makeHealth({
+      stale_pages: 10,
       missing_embeddings: 50,
       dead_links: 3,
     });
-    const ctx = { repoPath: '/brain', embeddingProviderConfigured: true, sourceId: 'default', extractionLagPages: 10 };
+    const ctx = { repoPath: '/brain', embeddingProviderConfigured: true, sourceId: 'default' };
     const run1 = computeRecommendations(health, ctx);
     const run2 = computeRecommendations(health, ctx);
     expect(JSON.stringify(run1)).toBe(JSON.stringify(run2));

test/doctor-categories.test.ts

@@ -1,10 +1,10 @@
 /**
  * Drift guard for src/core/doctor-categories.ts.
  *
- * Reads src/commands/doctor.ts source via a literal-string scan, enumerates
- * every `name: '<...>'` Check name, and asserts each appears in exactly ONE
- * category set. The union of the four sets must equal the discovered names
- * exactly — no orphans, no extras.
+ * Reads doctor check emitter source via a literal-string scan, enumerates every
+ * `name: '<...>'` Check name, and asserts each appears in exactly ONE category
+ * set. The union of the four sets must equal the discovered names exactly —
+ * no orphans, no extras.
  *
  * This is the structural failure the v0.41.19.0 plan-eng-review caught:
  * doctor.ts grows new checks regularly; without this guard, the
@@ -25,26 +25,30 @@ import {
 } from '../src/core/doctor-categories.ts';
 
 const DOCTOR_TS_PATH = join(import.meta.dir, '..', 'src', 'commands', 'doctor.ts');
+const ONBOARD_CHECKS_TS_PATH = join(import.meta.dir, '..', 'src', 'core', 'onboard', 'checks.ts');
+const CHECK_SOURCE_PATHS = [DOCTOR_TS_PATH, ONBOARD_CHECKS_TS_PATH];
 
 function enumerateCheckNames(): Set<string> {
-  const source = readFileSync(DOCTOR_TS_PATH, 'utf-8');
   const names = new Set<string>();
-  // 1) Inline object-literal form: `{ name: 'foo', ... }`.
-  for (const m of source.matchAll(/name:\s*['"]([a-z][a-z0-9_]+)['"]/g)) {
-    names.add(m[1]);
-  }
-  // 2) Helper-function form: `const name = 'foo';` inside a check helper.
-  //    Catches checks like `nightly_quality_probe_health` and
-  //    `conversation_facts_backlog` that build the Check from a captured
-  //    name constant.
-  for (const m of source.matchAll(/const\s+name\s*=\s*['"]([a-z][a-z0-9_]+)['"]/g)) {
-    names.add(m[1]);
+  for (const path of CHECK_SOURCE_PATHS) {
+    const source = readFileSync(path, 'utf-8');
+    // 1) Inline object-literal form: `{ name: 'foo', ... }`.
+    for (const m of source.matchAll(/name:\s*['"]([a-z][a-z0-9_]+)['"]/g)) {
+      names.add(m[1]);
+    }
+    // 2) Helper-function form: `const name = 'foo';` inside a check helper.
+    //    Catches checks like `nightly_quality_probe_health` and
+    //    `conversation_facts_backlog` that build the Check from a captured
+    //    name constant.
+    for (const m of source.matchAll(/const\s+name\s*=\s*['"]([a-z][a-z0-9_]+)['"]/g)) {
+      names.add(m[1]);
+    }
   }
   return names;
 }
 
 describe('doctor-categories drift guard', () => {
-  test('every check name in doctor.ts source belongs to exactly one category set', () => {
+  test('every doctor-emitted check name belongs to exactly one category set', () => {
     const discovered = enumerateCheckNames();
     const allCategorized = new Set<string>([
       ...BRAIN_CHECK_NAMES,
@@ -59,7 +63,7 @@ describe('doctor-categories drift guard', () => {
     }
     if (missing.length > 0) {
       throw new Error(
-        `These check names appear in doctor.ts but are not categorized in ` +
+        `These check names appear in doctor check emitters but are not categorized in ` +
           `src/core/doctor-categories.ts: ${missing.sort().join(', ')}. ` +
           `Add each to BRAIN/SKILL/OPS/META_CHECK_NAMES.`,
       );
@@ -86,7 +90,7 @@ describe('doctor-categories drift guard', () => {
     expect(dupes).toEqual([]);
   });
 
-  test('every categorized name is currently used in doctor.ts source (no stale entries)', () => {
+  test('every categorized name is currently used in doctor check emitters (no stale entries)', () => {
     const discovered = enumerateCheckNames();
     const allCategorized = new Set<string>([
       ...BRAIN_CHECK_NAMES,
@@ -124,6 +128,14 @@ describe('categorizeCheck', () => {
     expect(categorizeCheck('sync_freshness')).toBe('brain');
   });
 
+  test('returns the right category for onboard data-quality check names', () => {
+    expect(categorizeCheck('embed_staleness')).toBe('brain');
+    expect(categorizeCheck('entity_link_coverage')).toBe('brain');
+    expect(categorizeCheck('timeline_coverage')).toBe('brain');
+    expect(categorizeCheck('takes_count')).toBe('brain');
+    expect(categorizeCheck('dangling_aliases')).toBe('brain');
+  });
+
   test('returns the right category for a known skill name', () => {
     expect(categorizeCheck('resolver_health')).toBe('skill');
     expect(categorizeCheck('skill_conformance')).toBe('skill');
@@ -140,6 +152,24 @@ describe('categorizeCheck', () => {
     expect(categorizeCheck('upgrade_errors')).toBe('meta');
   });
 
+  test('returns the right category for onboard schema-pack check names without warning', () => {
+    const originalWrite = process.stderr.write.bind(process.stderr);
+    const captured: string[] = [];
+    (process.stderr as { write: typeof process.stderr.write }).write = ((
+      chunk: string | Uint8Array,
+    ) => {
+      captured.push(typeof chunk === 'string' ? chunk : Buffer.from(chunk).toString());
+      return true;
+    }) as typeof process.stderr.write;
+    try {
+      expect(categorizeCheck('pack_upgrade_available')).toBe('meta');
+      expect(categorizeCheck('type_proliferation')).toBe('meta');
+      expect(captured.filter((c) => c.includes('[doctor-categories]'))).toEqual([]);
+    } finally {
+      (process.stderr as { write: typeof process.stderr.write }).write = originalWrite;
+    }
+  });
+
   test('unknown check name falls through to meta with a stderr warn (once per process)', () => {
     const originalWrite = process.stderr.write.bind(process.stderr);
     const captured: string[] = [];

test/remediation-context-extraction-lag.test.ts

@@ -1,62 +0,0 @@
-// test/remediation-context-extraction-lag.test.ts
-//
-// Pins the v-next fix: the sync→extract remediation pipeline gates on REAL
-// extraction lag, not the legacy `health.stale_pages` proxy (which counted
-// "updated_at predates newest timeline entry" — meaningless after the v10
-// trigger drop). loadRecommendationContext now populates `extractionLagPages`
-// from `engine.countStalePagesForExtraction` — the SAME counter the
-// `gbrain extract --stale` walk and doctor's `links_extraction_lag` use — so a
-// recommendation can only fire when running extract will actually reduce it.
-
-import { afterAll, beforeAll, describe, expect, it } from 'bun:test';
-import { PGLiteEngine } from '../src/core/pglite-engine.ts';
-import { loadRecommendationContext } from '../src/core/remediation/context.ts';
-
-let engine: PGLiteEngine;
-
-beforeAll(async () => {
-  engine = new PGLiteEngine();
-  await engine.connect({});
-  await engine.initSchema();
-});
-
-afterAll(async () => {
-  await engine.disconnect();
-});
-
-describe('loadRecommendationContext — extractionLagPages wiring', () => {
-  it('is 0 on an empty brain (nothing to extract)', async () => {
-    const ctx = await loadRecommendationContext(engine);
-    expect(ctx.extractionLagPages).toBe(0);
-  });
-
-  it('reflects the real extraction-lag count once a page needs extraction', async () => {
-    // A freshly-imported page has links_extracted_at = NULL, which the canonical
-    // countStalePagesForExtraction predicate counts as stale-for-extraction.
-    await engine.putPage('p0', {
-      title: 'p0',
-      type: 'note' as never,
-      compiled_truth: 'body that is long enough to pass any minimum-length guards in the codebase',
-      timeline: '',
-      frontmatter: {},
-      source_path: 'p0.md',
-    });
-    const ctx = await loadRecommendationContext(engine);
-    expect(ctx.extractionLagPages).toBeGreaterThan(0);
-  });
-
-  it('counts pages stamped before LINK_EXTRACTOR_VERSION_TS (version-bump arm)', async () => {
-    // Backdate p0 so BOTH the NULL arm and the updated_at arm are quiet:
-    // updated_at < links_extracted_at, but links_extracted_at predates the
-    // extractor version stamp. doctor's links_extraction_lag and
-    // `extract --stale` both count this page; the remediation gate must too.
-    await engine.executeRaw(
-      `UPDATE pages SET updated_at = '2020-01-01T00:00:00Z'::timestamptz,
-                        links_extracted_at = '2020-01-02T00:00:00Z'::timestamptz
-        WHERE slug = 'p0'`,
-      [],
-    );
-    const ctx = await loadRecommendationContext(engine);
-    expect(ctx.extractionLagPages).toBeGreaterThan(0);
-  });
-});

test/remediation-run-d7-refresh.serial.test.ts

@@ -1,81 +0,0 @@
-// test/remediation-run-d7-refresh.serial.test.ts
-//
-// Pins the D7-recheck half of the extraction-lag gate fix: runRemediation
-// loads RecommendationContext ONCE before the step loop, and the per-step
-// recheck (D7) must REFRESH ctx.extractionLagPages alongside getHealth.
-// Without the refresh, a completed sync/extract step keeps re-firing off
-// the frozen initial count — the plan never converges and the loop burns
-// steps until maxJobs.
-//
-// SERIAL (R2): uses top-level mock.module for the minion queue +
-// wait-for-completion so no real worker is needed — mocks leak across
-// files in a shard process, so this file must run in its own process.
-
-import { describe, expect, mock, test } from 'bun:test';
-
-// The fake brain: sync.repo clears the extraction lag when it "runs"
-// (today's sync materializes link/timeline edges; extract.all is the
-// explicit re-materializer). The frozen-ctx bug makes runRemediation
-// ignore that and resubmit sync.repo on every D7 recheck.
-let extractionLag = 25;
-const submittedJobs: string[] = [];
-
-mock.module('../src/core/minions/queue.ts', () => ({
-  MinionQueue: class {
-    constructor(_engine: unknown) {}
-    async add(job: string): Promise<{ id: number }> {
-      submittedJobs.push(job);
-      if (job === 'sync' || job === 'extract') extractionLag = 0;
-      return { id: submittedJobs.length };
-    }
-  },
-}));
-
-mock.module('../src/core/minions/wait-for-completion.ts', () => ({
-  waitForCompletion: async () => ({ status: 'completed' }),
-}));
-
-const health = () => ({
-  page_count: 100,
-  embed_coverage: 1.0,
-  stale_pages: 0, // legacy proxy stays 0 — the real counter drives the gate
-  orphan_pages: 0,
-  missing_embeddings: 0,
-  brain_score: 70,
-  dead_links: 0,
-  link_coverage: 1.0,
-  timeline_coverage: 1.0,
-  most_connected: [],
-  embed_coverage_score: 35,
-  link_density_score: 25,
-  timeline_coverage_score: 15,
-  no_orphans_score: 15,
-  no_dead_links_score: 10,
-});
-
-const fakeEngine = {
-  kind: 'pglite' as const,
-  getHealth: async () => health(),
-  getConfig: async (key: string) =>
-    key === 'sync.repo_path' ? '/tmp/brain-example' : null,
-  countStalePagesForExtraction: async () => extractionLag,
-};
-
-describe('runRemediation D7 recheck — extraction-lag gate refresh', () => {
-  test('a completed materializer step clears the gate; the pipeline is not resubmitted', async () => {
-    const { runRemediation } = await import('../src/core/remediation/run.ts');
-    const result = await runRemediation(
-      // Only the methods the orchestrator touches are needed.
-      fakeEngine as never,
-      { targetScore: 0, maxJobs: 6 },
-    );
-    // Frozen-ctx bug: extractionLagPages stays 25 forever, so every D7
-    // recheck re-introduces the sync/extract pipeline and the loop burns
-    // all 6 maxJobs. With the refresh, the plan converges after the first
-    // completed step: no step id is ever submitted twice.
-    const ids = result.submitted.map((s) => s.id);
-    expect(new Set(ids).size).toBe(ids.length);
-    expect(submittedJobs.length).toBeLessThan(3);
-    expect(extractionLag).toBe(0);
-  });
-});