fix(doctor): register onboard check names in doctor-categories to stop unknown-check warnings

doctor.ts pushes runAllOnboardChecks results into the checks list, but the
7 onboard check names (embed_staleness, entity_link_coverage,
timeline_coverage, takes_count, dangling_aliases, pack_upgrade_available,
type_proliferation) were never added to doctor-categories.ts, so every
doctor run emitted an 'unknown check name' stderr warn per onboard check.

Registers the 5 data-quality names under BRAIN and the 2 schema-pack names
under META (alphabetical order preserved), and widens the drift-guard test
to scan src/core/onboard/checks.ts alongside src/commands/doctor.ts so
future onboard checks can't drift uncategorized.

Takeover of #1839, rebased onto master (keeps master's timeline_dedup_index).

Co-authored-by: mvanhorn <mvanhorn@users.noreply.github.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

src/commands/autopilot.ts

@@ -151,100 +151,6 @@ export function shouldSpawnAutopilotWorker(args: string[]): boolean {
   return !args.includes('--no-worker');
 }
 
-/**
- * #1525 — positional subcommand translation.
- *
- * Pre-fix, `gbrain autopilot status` silently fell through to "start daemon"
- * because `runAutopilot()` only branched on flag forms (`--status`, etc.).
- * `status` was treated as a stray positional and ignored.
- *
- * This translator maps known positional subcommands to their flag form so
- * `autopilot status` is equivalent to `autopilot --status`, then rejects
- * any unrecognized positional with a fail-loud error before any side
- * effect (lockfile, daemon spawn, sync dispatch) runs.
- *
- * Scope decisions:
- *   - Known aliases: `status` → `--status`, `install` → `--install`,
- *     `uninstall` → `--uninstall`, `start` → (drop; default daemon launch).
- *   - `stop` is intentionally NOT aliased here. Stopping a running daemon
- *     is a new behavior (read PID from lock, SIGTERM, drain) that deserves
- *     its own design and PR. Users typing `gbrain autopilot stop` today get
- *     the unknown-positional error with the canonical alternatives.
- *   - At most one positional allowed; multiple positionals fail loud.
- */
-// Every flag that consumes the NEXT argv token. Missing one here makes the
-// translator misread the flag's value as a positional subcommand and exit 2
-// (e.g. `--install --target linux-cron`). Keep in sync with parseArg call sites.
-const AUTOPILOT_VALUE_FLAGS = new Set(['--repo', '--interval', '--target']);
-const AUTOPILOT_POSITIONAL_ALIASES: Record<string, string | null> = {
-  status: '--status',
-  install: '--install',
-  uninstall: '--uninstall',
-  start: null, // drop the positional; default behavior is daemon launch
-};
-
-export type PositionalTranslation =
-  | { ok: true; args: string[] }
-  | {
-      ok: false;
-      reason: 'unknown_subcommand' | 'multiple_subcommands';
-      message: string;
-    };
-
-export function translatePositionalSubcommands(args: string[]): PositionalTranslation {
-  const out: string[] = [];
-  let positionalSeen = false;
-  let i = 0;
-  while (i < args.length) {
-    const a = args[i];
-    if (AUTOPILOT_VALUE_FLAGS.has(a)) {
-      // Pass through the flag and its value untouched. If the value is
-      // missing at end-of-argv, fall through so the existing parseArg
-      // path can report the broken usage.
-      out.push(a);
-      if (i + 1 < args.length) {
-        out.push(args[i + 1]);
-        i += 2;
-      } else {
-        i += 1;
-      }
-      continue;
-    }
-    if (a.startsWith('-')) {
-      out.push(a);
-      i += 1;
-      continue;
-    }
-    // Positional subcommand.
-    if (positionalSeen) {
-      const known = Object.keys(AUTOPILOT_POSITIONAL_ALIASES).join(', ');
-      return {
-        ok: false,
-        reason: 'multiple_subcommands',
-        message: `Multiple subcommands given. Use only one of: ${known}.`,
-      };
-    }
-    positionalSeen = true;
-    if (a in AUTOPILOT_POSITIONAL_ALIASES) {
-      const alias = AUTOPILOT_POSITIONAL_ALIASES[a];
-      if (alias) out.push(alias);
-      i += 1;
-      continue;
-    }
-    const known = Object.keys(AUTOPILOT_POSITIONAL_ALIASES).join(', ');
-    return {
-      ok: false,
-      reason: 'unknown_subcommand',
-      message:
-        `Unknown subcommand: \`${a}\`.\n` +
-        `Allowed subcommands: ${known}.\n` +
-        `Or use the flag form: --status, --install, --uninstall.\n` +
-        `Run \`gbrain autopilot --help\` for full usage.`,
-    };
-  }
-  return { ok: true, args: out };
-}
-
 export function isPidAlive(pid: number): boolean {
   if (!Number.isFinite(pid) || pid <= 0) return false;
   try {
@@ -457,11 +363,6 @@ export async function runAutopilot(engine: BrainEngine, args: string[]) {
       '       gbrain autopilot --install [--repo <path>]\n' +
       '       gbrain autopilot --uninstall\n' +
       '       gbrain autopilot --status [--json]\n\n' +
-      'Subcommand aliases:\n' +
-      '       gbrain autopilot status     → --status\n' +
-      '       gbrain autopilot install    → --install\n' +
-      '       gbrain autopilot uninstall  → --uninstall\n' +
-      '       gbrain autopilot start      → (default daemon launch)\n\n' +
       'Self-maintaining brain daemon. Runs the full maintenance cycle\n' +
       '(lint + backlinks + sync + extract + embed + orphans) on an interval.\n\n' +
       'For a one-shot cron-triggered cycle, see `gbrain dream`.',
@@ -469,16 +370,6 @@ export async function runAutopilot(engine: BrainEngine, args: string[]) {
     return;
   }
 
-  // #1525: translate positional subcommands to their flag form BEFORE any
-  // side effect (lockfile, daemon spawn, sync dispatch). Unknown positionals
-  // fail loud here rather than silently starting the daemon.
-  const translated = translatePositionalSubcommands(args);
-  if (!translated.ok) {
-    console.error(translated.message);
-    process.exit(2);
-  }
-  args = translated.args;
-
   if (args.includes('--install')) {
     await installDaemon(engine, args);
     return;

src/core/doctor-categories.ts

@@ -35,10 +35,11 @@
  *
  * The doctor renders both side by side.
  *
- * Drift contract: every check name that ships in doctor.ts MUST appear in
+ * Drift contract: every check name that ships through doctor MUST appear in
  * exactly one set below. The drift-guard test in
- * `test/doctor-categories.test.ts` enforces this by reading doctor.ts source
- * via a tagged-string scan and asserting set membership exactly.
+ * `test/doctor-categories.test.ts` enforces this by reading doctor check
+ * emitter sources via a tagged-string scan and asserting set membership
+ * exactly.
  *
  * If you add a new doctor check, you MUST add its name to the appropriate
  * set here. The categorize step in `src/commands/doctor.ts` falls through
@@ -67,12 +68,15 @@ export const BRAIN_CHECK_NAMES: ReadonlySet<string> = new Set([
   'conversation_parser_probe_health',
   'cross_modal_modality_backfill',
   'cycle_freshness',
+  'dangling_aliases',
   'effective_date_health',
+  'embed_staleness',
   'embedding_column_registry',
   'embedding_env_override',
   'embedding_provider',
   'embedding_width_consistency',
   'embeddings',
+  'entity_link_coverage',
   'eval_drift',
   'extract_atoms_backlog',
   'extract_health',
@@ -102,7 +106,9 @@ export const BRAIN_CHECK_NAMES: ReadonlySet<string> = new Set([
   'stub_guard_24h',
   'sync_failures',
   'sync_freshness',
+  'takes_count',
   'takes_weight_grid',
+  'timeline_coverage',
   'unified_multimodal_coverage',
   'voice_gate_health',
 ]);
@@ -170,12 +176,14 @@ export const META_CHECK_NAMES: ReadonlySet<string> = new Set([
   'eval_capture',
   'minions_migration',
   'multi_source_drift',
+  'pack_upgrade_available',
   'schema_pack_active',
   'schema_pack_consistency',
   'schema_pack_source_drift',
   'schema_version',
   'slug_fallback_audit',
   'timeline_dedup_index',
+  'type_proliferation',
   'upgrade_errors',
 ]);
 

test/autopilot-positional-subcommands.test.ts

@@ -1,197 +0,0 @@
-/**
- * Tests for translatePositionalSubcommands() — the v0.41.x #1525 fix that
- * prevents `gbrain autopilot status` from silently starting the daemon.
- *
- * IRON RULE regression guard: the exact ticket repro (`gbrain autopilot
- * status`) MUST translate to `--status`, not fall through to the default
- * daemon launch. Verified by the "ticket-exact repro" case below.
- */
-
-import { describe, test, expect } from 'bun:test';
-import { translatePositionalSubcommands } from '../src/commands/autopilot.ts';
-
-describe('translatePositionalSubcommands — known aliases', () => {
-  test('IRON RULE — `autopilot status` translates to `--status` (ticket #1525 repro)', () => {
-    const r = translatePositionalSubcommands(['status']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--status']);
-  });
-
-  test('`install` translates to `--install`', () => {
-    const r = translatePositionalSubcommands(['install']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--install']);
-  });
-
-  test('`uninstall` translates to `--uninstall`', () => {
-    const r = translatePositionalSubcommands(['uninstall']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--uninstall']);
-  });
-
-  test('`start` drops the positional (default daemon launch)', () => {
-    const r = translatePositionalSubcommands(['start']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual([]);
-  });
-
-  test('`start --json` drops only the positional, keeps the flag', () => {
-    const r = translatePositionalSubcommands(['start', '--json']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--json']);
-  });
-});
-
-describe('translatePositionalSubcommands — flag/positional interleaving', () => {
-  test('`status --json` preserves the trailing flag', () => {
-    const r = translatePositionalSubcommands(['status', '--json']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--status', '--json']);
-  });
-
-  test('`--json status` preserves the leading flag', () => {
-    const r = translatePositionalSubcommands(['--json', 'status']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--json', '--status']);
-  });
-
-  test('`--repo /foo status` does not mis-classify the path as positional', () => {
-    const r = translatePositionalSubcommands(['--repo', '/foo', 'status']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--repo', '/foo', '--status']);
-  });
-
-  test('`--interval 300 install` does not mis-classify the number as positional', () => {
-    const r = translatePositionalSubcommands(['--interval', '300', 'install']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--interval', '300', '--install']);
-  });
-
-  test('`--install --target linux-cron` does not mis-classify the target as positional', () => {
-    // --target is installDaemon's value flag; its value must never be read
-    // as a positional subcommand (regression guard for the review fix).
-    const r = translatePositionalSubcommands(['--install', '--target', 'linux-cron']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--install', '--target', 'linux-cron']);
-  });
-
-  test('`install --target macos` keeps the alias translation and the target value', () => {
-    const r = translatePositionalSubcommands(['install', '--target', 'macos']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--install', '--target', 'macos']);
-  });
-
-  test('value-flag at end of argv with missing value passes through (so parseArg can report it)', () => {
-    const r = translatePositionalSubcommands(['--repo']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--repo']);
-  });
-
-  test('value-flag whose value looks like an alias is NOT translated', () => {
-    // `--repo status` means "use repo path 'status'", not "show status".
-    // Translator must not destructure the value of --repo.
-    const r = translatePositionalSubcommands(['--repo', 'status']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--repo', 'status']);
-  });
-});
-
-describe('translatePositionalSubcommands — pass-through cases', () => {
-  test('empty args returns empty args', () => {
-    const r = translatePositionalSubcommands([]);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual([]);
-  });
-
-  test('flag-only invocation passes through unchanged', () => {
-    const r = translatePositionalSubcommands(['--status', '--json']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['--status', '--json']);
-  });
-
-  test('short flag `-h` passes through unchanged', () => {
-    const r = translatePositionalSubcommands(['-h']);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(['-h']);
-  });
-
-  test('all known bare flags pass through unchanged', () => {
-    const flags = ['--help', '--install', '--uninstall', '--status', '--json', '--inline', '--no-worker'];
-    const r = translatePositionalSubcommands(flags);
-    expect(r.ok).toBe(true);
-    if (r.ok) expect(r.args).toEqual(flags);
-  });
-});
-
-describe('translatePositionalSubcommands — rejection of unknown positionals', () => {
-  test('unknown positional `foo` fails with reason=unknown_subcommand + structured message', () => {
-    const r = translatePositionalSubcommands(['foo']);
-    expect(r.ok).toBe(false);
-    if (!r.ok) {
-      expect(r.reason).toBe('unknown_subcommand');
-      expect(r.message).toContain('Unknown subcommand: `foo`');
-      expect(r.message).toContain('status');
-      expect(r.message).toContain('install');
-      expect(r.message).toContain('uninstall');
-      expect(r.message).toContain('--help');
-    }
-  });
-
-  test('unknown positional `stop` fails with reason=unknown_subcommand (NOT silently aliased)', () => {
-    // Stop is mentioned in the ticket but deliberately NOT aliased in this
-    // PR — stopping a running daemon is a new behavior, not just an alias.
-    // Until that feature lands separately, `stop` must fail loud rather
-    // than starting the daemon (the bug we're fixing).
-    const r = translatePositionalSubcommands(['stop']);
-    expect(r.ok).toBe(false);
-    if (!r.ok) {
-      expect(r.reason).toBe('unknown_subcommand');
-      expect(r.message).toContain('Unknown subcommand: `stop`');
-    }
-  });
-
-  test('unknown positional `status-detail` (close-but-not-matching) fails', () => {
-    const r = translatePositionalSubcommands(['status-detail']);
-    expect(r.ok).toBe(false);
-    if (!r.ok) {
-      expect(r.reason).toBe('unknown_subcommand');
-      expect(r.message).toContain('Unknown subcommand: `status-detail`');
-    }
-  });
-
-  test('multiple positionals fail with reason=multiple_subcommands (`start install`)', () => {
-    const r = translatePositionalSubcommands(['start', 'install']);
-    expect(r.ok).toBe(false);
-    if (!r.ok) {
-      expect(r.reason).toBe('multiple_subcommands');
-      expect(r.message).toContain('Multiple subcommands');
-    }
-  });
-
-  test('multiple positionals fail even when both are known aliases (`status install`)', () => {
-    const r = translatePositionalSubcommands(['status', 'install']);
-    expect(r.ok).toBe(false);
-    if (!r.ok) {
-      expect(r.reason).toBe('multiple_subcommands');
-      expect(r.message).toContain('Multiple subcommands');
-    }
-  });
-
-  test('known-then-unknown rejects with multiple_subcommands (first-positional-wins)', () => {
-    // First positional is known, second is not. Rejection comes from the
-    // multiple-positional rule, which fires before the unknown check; the
-    // intent is "only one subcommand allowed."
-    const r = translatePositionalSubcommands(['status', 'garbage']);
-    expect(r.ok).toBe(false);
-    if (!r.ok) expect(r.reason).toBe('multiple_subcommands');
-  });
-
-  test('unknown-then-known rejects on the unknown (unknown fires before second-positional check)', () => {
-    const r = translatePositionalSubcommands(['garbage', 'status']);
-    expect(r.ok).toBe(false);
-    if (!r.ok) {
-      expect(r.reason).toBe('unknown_subcommand');
-      expect(r.message).toContain('garbage');
-    }
-  });
-});

test/doctor-categories.test.ts

@@ -1,10 +1,10 @@
 /**
  * Drift guard for src/core/doctor-categories.ts.
  *
- * Reads src/commands/doctor.ts source via a literal-string scan, enumerates
- * every `name: '<...>'` Check name, and asserts each appears in exactly ONE
- * category set. The union of the four sets must equal the discovered names
- * exactly — no orphans, no extras.
+ * Reads doctor check emitter source via a literal-string scan, enumerates every
+ * `name: '<...>'` Check name, and asserts each appears in exactly ONE category
+ * set. The union of the four sets must equal the discovered names exactly —
+ * no orphans, no extras.
  *
  * This is the structural failure the v0.41.19.0 plan-eng-review caught:
  * doctor.ts grows new checks regularly; without this guard, the
@@ -25,26 +25,30 @@ import {
 } from '../src/core/doctor-categories.ts';
 
 const DOCTOR_TS_PATH = join(import.meta.dir, '..', 'src', 'commands', 'doctor.ts');
+const ONBOARD_CHECKS_TS_PATH = join(import.meta.dir, '..', 'src', 'core', 'onboard', 'checks.ts');
+const CHECK_SOURCE_PATHS = [DOCTOR_TS_PATH, ONBOARD_CHECKS_TS_PATH];
 
 function enumerateCheckNames(): Set<string> {
-  const source = readFileSync(DOCTOR_TS_PATH, 'utf-8');
   const names = new Set<string>();
-  // 1) Inline object-literal form: `{ name: 'foo', ... }`.
-  for (const m of source.matchAll(/name:\s*['"]([a-z][a-z0-9_]+)['"]/g)) {
-    names.add(m[1]);
-  }
-  // 2) Helper-function form: `const name = 'foo';` inside a check helper.
-  //    Catches checks like `nightly_quality_probe_health` and
-  //    `conversation_facts_backlog` that build the Check from a captured
-  //    name constant.
-  for (const m of source.matchAll(/const\s+name\s*=\s*['"]([a-z][a-z0-9_]+)['"]/g)) {
-    names.add(m[1]);
+  for (const path of CHECK_SOURCE_PATHS) {
+    const source = readFileSync(path, 'utf-8');
+    // 1) Inline object-literal form: `{ name: 'foo', ... }`.
+    for (const m of source.matchAll(/name:\s*['"]([a-z][a-z0-9_]+)['"]/g)) {
+      names.add(m[1]);
+    }
+    // 2) Helper-function form: `const name = 'foo';` inside a check helper.
+    //    Catches checks like `nightly_quality_probe_health` and
+    //    `conversation_facts_backlog` that build the Check from a captured
+    //    name constant.
+    for (const m of source.matchAll(/const\s+name\s*=\s*['"]([a-z][a-z0-9_]+)['"]/g)) {
+      names.add(m[1]);
+    }
   }
   return names;
 }
 
 describe('doctor-categories drift guard', () => {
-  test('every check name in doctor.ts source belongs to exactly one category set', () => {
+  test('every doctor-emitted check name belongs to exactly one category set', () => {
     const discovered = enumerateCheckNames();
     const allCategorized = new Set<string>([
       ...BRAIN_CHECK_NAMES,
@@ -59,7 +63,7 @@ describe('doctor-categories drift guard', () => {
     }
     if (missing.length > 0) {
       throw new Error(
-        `These check names appear in doctor.ts but are not categorized in ` +
+        `These check names appear in doctor check emitters but are not categorized in ` +
           `src/core/doctor-categories.ts: ${missing.sort().join(', ')}. ` +
           `Add each to BRAIN/SKILL/OPS/META_CHECK_NAMES.`,
       );
@@ -86,7 +90,7 @@ describe('doctor-categories drift guard', () => {
     expect(dupes).toEqual([]);
   });
 
-  test('every categorized name is currently used in doctor.ts source (no stale entries)', () => {
+  test('every categorized name is currently used in doctor check emitters (no stale entries)', () => {
     const discovered = enumerateCheckNames();
     const allCategorized = new Set<string>([
       ...BRAIN_CHECK_NAMES,
@@ -124,6 +128,14 @@ describe('categorizeCheck', () => {
     expect(categorizeCheck('sync_freshness')).toBe('brain');
   });
 
+  test('returns the right category for onboard data-quality check names', () => {
+    expect(categorizeCheck('embed_staleness')).toBe('brain');
+    expect(categorizeCheck('entity_link_coverage')).toBe('brain');
+    expect(categorizeCheck('timeline_coverage')).toBe('brain');
+    expect(categorizeCheck('takes_count')).toBe('brain');
+    expect(categorizeCheck('dangling_aliases')).toBe('brain');
+  });
+
   test('returns the right category for a known skill name', () => {
     expect(categorizeCheck('resolver_health')).toBe('skill');
     expect(categorizeCheck('skill_conformance')).toBe('skill');
@@ -140,6 +152,24 @@ describe('categorizeCheck', () => {
     expect(categorizeCheck('upgrade_errors')).toBe('meta');
   });
 
+  test('returns the right category for onboard schema-pack check names without warning', () => {
+    const originalWrite = process.stderr.write.bind(process.stderr);
+    const captured: string[] = [];
+    (process.stderr as { write: typeof process.stderr.write }).write = ((
+      chunk: string | Uint8Array,
+    ) => {
+      captured.push(typeof chunk === 'string' ? chunk : Buffer.from(chunk).toString());
+      return true;
+    }) as typeof process.stderr.write;
+    try {
+      expect(categorizeCheck('pack_upgrade_available')).toBe('meta');
+      expect(categorizeCheck('type_proliferation')).toBe('meta');
+      expect(captured.filter((c) => c.includes('[doctor-categories]'))).toEqual([]);
+    } finally {
+      (process.stderr as { write: typeof process.stderr.write }).write = originalWrite;
+    }
+  });
+
   test('unknown check name falls through to meta with a stderr warn (once per process)', () => {
     const originalWrite = process.stderr.write.bind(process.stderr);
     const captured: string[] = [];