fix(schema-pack): restore v2 capability parity + derive bundled-pack list + calibration holder config

- #2109: extract-timeline-from-meetings matches frontmatter.legacy_type='meeting'
  in both SQL sites so unify-types-migrated (gbrain-base-v2) brains keep the
  feature alive; pre-unify type='meeting' behavior unchanged.
- #2117: gbrain-base-v2 declares phases: [extract_atoms] and ports v1's
  founded/works_at/invested_in inference regexes so extract_atoms is no longer
  pack-gated off and extract-ner no longer returns pack_unavailable on the
  bundled default pack. (attended's page_type:meeting inference deliberately
  not ported — v2 declares no meeting type; lint would reject it.)
- #1726 (A): list_schema_packs derives from the exported BUNDLED_PACKS registry
  in load-active.ts instead of a frozen 2-of-7 literal.
- #1726 (B): new calibration.user_holder config key (symmetric with
  emotional_weight.user_holder) resolved by the calibration_profile phase, the
  gbrain calibration CLI, and the get_calibration_profile op; explicit
  holder param still wins; 'garry' stays the fallback.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

src/commands/calibration.ts

@@ -19,7 +19,7 @@
  */
 
 import type { BrainEngine } from '../core/engine.ts';
-import { runPhaseCalibrationProfile } from '../core/cycle/calibration-profile.ts';
+import { resolveCalibrationHolder, runPhaseCalibrationProfile } from '../core/cycle/calibration-profile.ts';
 import { sourceScopeOpts, type OperationContext } from '../core/operations.ts';
 import type { GBrainConfig } from '../core/config.ts';
 import { GBrainError } from '../core/types.ts';
@@ -167,7 +167,7 @@ export async function runCalibration(
   config: GBrainConfig,
 ): Promise<void> {
   const { opts } = parseArgs(args);
-  const holder = opts.holder ?? 'garry';
+  const holder = await resolveCalibrationHolder(engine, opts.holder);
   // Resolve --source / GBRAIN_SOURCE / .gbrain-source so the (now reachable, #2035)
   // calibration command targets the right source in a multi-source brain instead
   // of always reading `default`. No signal → 'default' (prior behavior).
@@ -253,14 +253,14 @@ export async function getCalibrationProfileOp(
   ctx: OperationContext,
   params: { holder?: string },
 ): Promise<CalibrationProfileRow | null> {
-  const holder = params.holder ?? 'garry';
-  if (typeof holder !== 'string' || holder.length === 0) {
+  if (params.holder !== undefined && (typeof params.holder !== 'string' || params.holder.length === 0)) {
     throw new GBrainError(
       'INVALID_HOLDER',
       'get_calibration_profile.holder must be a non-empty string',
-      'pass holder="<slug>" or omit to default to "garry"',
+      'pass holder="<slug>" or omit to default to the calibration.user_holder config (then "garry")',
     );
   }
+  const holder = await resolveCalibrationHolder(ctx.engine, params.holder);
   const scope = sourceScopeOpts(ctx);
   return getLatestProfile(ctx.engine, { holder, ...scope });
 }

src/commands/onboard.ts

@@ -142,16 +142,12 @@ export async function runOnboard(engine: BrainEngine, args: string[]): Promise<v
 
   // --auto path: runs through the T2 library orchestrator. Hooks emit CLI
   // progress to stderr; the final result lands as JSON on stdout (or human
-  // summary). extraRemediations (gathered above from runAllOnboardChecks)
-  // is threaded into the runner so the onboard-check remediations
-  // (extract-ner, extract-timeline-from-meetings, etc.) reach the planner
-  // — the same wiring the --check path uses above.
+  // summary).
   const result = await runRemediation(
     engine,
     {
       targetScore,
       maxUsd,
-      extraRemediations,
       // --auto --yes opts into the prompt_required tier too; library
       // doesn't distinguish auto_apply vs prompt_required, it just runs
       // every remediation in the plan. The plan-building side (T12 render)

src/core/config.ts

@@ -928,6 +928,10 @@ export const KNOWN_CONFIG_KEYS: readonly string[] = [
   // Emotional weight (v0.29)
   'emotional_weight.high_tags',
   'emotional_weight.user_holder',
+  // Calibration holder (#1726): persistent default for the nightly
+  // calibration_profile phase + `gbrain calibration`, symmetric with
+  // emotional_weight.user_holder. Falls back to 'garry' when unset.
+  'calibration.user_holder',
   // Cycle phase config
   'cycle.grade_takes.write_gstack_learnings',
   // Content sanity (v0.41)

src/core/cycle/calibration-profile.ts

@@ -96,7 +96,7 @@ export type PatternStatementsGenerator = (input: {
 export type BiasTagsGenerator = (patterns: string[]) => Promise<string[]>;
 
 export interface CalibrationProfileOpts extends BasePhaseOpts {
-  /** Holder to generate the profile for. Default 'garry'. */
+  /** Holder to generate the profile for. Default: `calibration.user_holder` config, then 'garry'. */
   holder?: string;
   /** Inject the patterns generator (tests). */
   patternsGenerator?: PatternStatementsGenerator;
@@ -194,6 +194,26 @@ export function parseBiasTagsOutput(raw: string): string[] {
     .slice(0, 4);
 }
 
+/**
+ * #1726: resolve the calibration holder. Explicit param wins, then the
+ * persistent `calibration.user_holder` config key (symmetric with
+ * emotional_weight.user_holder), then the legacy 'garry' default. Fail-open:
+ * a missing config table / mock engine without getConfig falls through.
+ */
+export async function resolveCalibrationHolder(
+  engine: BrainEngine,
+  explicit?: string,
+): Promise<string> {
+  if (explicit) return explicit;
+  try {
+    const configured = await engine.getConfig('calibration.user_holder');
+    if (configured && configured.trim().length > 0) return configured.trim();
+  } catch {
+    // Config unavailable — use the legacy default.
+  }
+  return 'garry';
+}
+
 /** Pick the "loudest" pattern slot for the template fallback. */
 function pickFallbackSlots(scorecard: TakesScorecard): PatternStatementSlots {
   if (!scorecard || scorecard.resolved === 0) {
@@ -227,7 +247,7 @@ class CalibrationProfilePhase extends BaseCyclePhase {
     _ctx: OperationContext,
     opts: CalibrationProfileOpts,
   ): Promise<{ summary: string; details: Record<string, unknown>; status?: PhaseStatus }> {
-    const holder = opts.holder ?? 'garry';
+    const holder = await resolveCalibrationHolder(engine, opts.holder);
     const promptVersion = opts.promptVersion ?? CALIBRATION_PROFILE_PROMPT_VERSION;
     const modelId = opts.model ?? TIER_DEFAULTS.reasoning;
     const gradeCompletion = opts.gradeCompletion ?? 1.0;

src/core/extract-timeline-from-meetings.ts

@@ -68,11 +68,14 @@ export async function extractTimelineFromMeetings(
   // 1. Fetch all meeting pages (one round-trip).
   const sourceFilter = opts.sourceIdFilter ? `AND source_id = $1` : '';
   const meetingParams = opts.sourceIdFilter ? [opts.sourceIdFilter] : [];
+  // #2109: gbrain-base-v2's unify-types catch-all retypes meeting pages to
+  // `note` with frontmatter.legacy_type = 'meeting'. Match both spellings so
+  // the extractor keeps working on migrated (v2) brains, not just v1 ones.
   const meetings = await engine.executeRaw<MeetingRow>(
     `SELECT slug, source_id, title, effective_date, updated_at,
             compiled_truth, COALESCE(timeline, '') AS timeline
        FROM pages
-      WHERE type = 'meeting'
+      WHERE (type = 'meeting' OR frontmatter ->> 'legacy_type' = 'meeting')
         AND deleted_at IS NULL
         ${sourceFilter}
       ORDER BY effective_date DESC NULLS LAST, slug`,
@@ -94,7 +97,7 @@ export async function extractTimelineFromMeetings(
        JOIN pages pf ON pf.id = l.from_page_id
        JOIN pages pt ON pt.id = l.to_page_id
       WHERE l.link_type = 'attended'
-        AND pf.type = 'meeting'
+        AND (pf.type = 'meeting' OR pf.frontmatter ->> 'legacy_type' = 'meeting')
         AND pf.deleted_at IS NULL
         AND pt.deleted_at IS NULL`,
   );

src/core/operations.ts

@@ -4562,7 +4562,10 @@ const list_schema_packs: Operation = {
     const { existsSync, readdirSync } = await import('node:fs');
     const { join } = await import('node:path');
     const { gbrainPath } = await import('./config.ts');
-    const bundled = ['gbrain-base', 'gbrain-recommended'];
+    // #1726: derive from the locator's registry instead of a hand-copied
+    // subset (which had frozen at 2 of 7 bundled packs).
+    const { BUNDLED_PACKS } = await import('./schema-pack/load-active.ts');
+    const bundled = [...BUNDLED_PACKS];
     const installedDir = gbrainPath('schema-packs');
     const installed: string[] = [];
     if (existsSync(installedDir)) {
@@ -4957,7 +4960,7 @@ const run_onboard: Operation = {
     // typo, the underlying queue.add would reject. Defense-in-depth.
     const result = await runRemediation(
       ctx.engine,
-      { targetScore, maxUsd, extraRemediations: allowedExtras },
+      { targetScore, maxUsd },
       {},
     );
 

src/core/remediation/run.ts

@@ -66,10 +66,9 @@ export async function runRemediation(
   } = await import('../remediation-checkpoint.ts');
 
   const ctx = await loadRecommendationContext(engine);
-  const extraRemediations = opts.extraRemediations ?? [];
 
   // Pre-flight ceiling check via the shared plan computation.
-  const initialPlan = await computeRemediationPlan(engine, { targetScore, extraRemediations });
+  const initialPlan = await computeRemediationPlan(engine, { targetScore });
   if (initialPlan.target_unreachable) {
     hooks.onTargetUnreachable?.(targetScore, initialPlan.max_reachable_score);
     return {
@@ -88,7 +87,7 @@ export async function runRemediation(
   }
 
   const initialHealth = await engine.getHealth();
-  let recs: RemediationStep[] = computeRecommendations(initialHealth, ctx, extraRemediations)
+  let recs: RemediationStep[] = computeRecommendations(initialHealth, ctx)
     .filter((r) => r.status === 'remediable');
   if (recs.length === 0) {
     hooks.onNothingToDo?.(initialHealth.brain_score, targetScore);
@@ -306,13 +305,7 @@ export async function runRemediation(
       // steps with bumped retry suffix (D1).
       if (recs.length === 0 || stepCount >= maxJobs) break;
       const freshHealth = await engine.getHealth();
-      // Extras carry a static status:'remediable' — a fresh health snapshot
-      // never ages them out the way health-derived steps drop. Filter out
-      // ids this run already processed (any terminal status), or the recheck
-      // would resubmit completed extras every iteration, forever.
-      const processedIds = new Set(submitted.map((s) => s.id));
-      const pendingExtras = extraRemediations.filter((r) => !processedIds.has(r.id));
-      recs = computeRecommendations(freshHealth, ctx, pendingExtras).filter((r) => r.status === 'remediable');
+      recs = computeRecommendations(freshHealth, ctx).filter((r) => r.status === 'remediable');
     }
   };
 

src/core/remediation/types.ts

@@ -63,16 +63,6 @@ export interface RemediationOpts {
   resumePlanHash?: string;
   /** Whether to attempt resume at all (default false). */
   resume?: boolean;
-  /**
-   * Caller-supplied RemediationStep entries threaded into the planner.
-   * Mirrors RemediationPlanOpts.extraRemediations so onboard's --apply
-   * --auto path (and MCP run_onboard auto modes) forward the same
-   * onboard-check remediations the --check path already passes through
-   * computeRemediationPlan. Without this the runner saw only generic
-   * brain_score remediations and reported "Nothing to do" whenever the
-   * only applicable work was an extra (e.g. extract-ner).
-   */
-  extraRemediations?: RemediationStep[];
 }
 
 /**

src/core/schema-pack/base/gbrain-base-v2.yaml

@@ -41,6 +41,12 @@ migration_from:
   pack: gbrain-base
   version: "1.x"
 
+# #2117 — cycle-phase participation. `phases:` is additive and pack-gated;
+# without this key extract_atoms is silently off on v2 brains even though
+# onboard + doctor recommend it (v2 declares the `atom` type it writes).
+phases:
+  - extract_atoms
+
 page_types:
   - name: person
     primitive: entity
@@ -319,6 +325,10 @@ page_types:
     extractable: false
     expert_routing: false
 
+# #2117 — inference rules ported from gbrain-base v1 so extract-ner keeps
+# working on v2 brains (it hard-skips with pack_unavailable when no
+# link_type declares an inference.regex). Same ReDoS-guarded sketch
+# regexes v1 ships; production matchers in link-extraction.ts still apply.
 link_types:
   - name: partner_of
     inverse: partner_of
@@ -328,14 +338,24 @@ link_types:
   - name: discusses
   - name: founded
     inverse: founded_by
+    inference:
+      regex: \b(founded|founder of|co-?founded|started)\b
   - name: works_at
     inverse: employs
+    inference:
+      regex: \b(works? at|employed by|works? for|joined|hired by|ceo of|cto of|cmo of)\b
   - name: invested_in
     inverse: investor_of
+    inference:
+      regex: \b(invested in|backed|seeded|funded|wrote a check)\b
   - name: sourced_from
   - name: derived_from
   - name: supersedes
   - name: redirects_to
+  # NOTE: v1's `attended` inference is page_type-bound to `meeting`, which
+  # v2 does not declare (lint: link_types_undeclared_page_type). Meeting
+  # pages retyped by unify-types are matched via frontmatter.legacy_type
+  # in extract-timeline-from-meetings (#2109) instead.
   - name: attended
     inverse: attended_by
   - name: authored

src/core/schema-pack/load-active.ts

@@ -91,29 +91,33 @@ export function _resetPackLocatorForTests(): void {
  * Returns null when the pack is not found. Callers handle null by
  * throwing UnknownPackError with a paste-ready install hint.
  */
+// v0.39 T8 — bundled packs registry. gbrain-base + gbrain-recommended
+// ship in src/core/schema-pack/base/. Add a new entry here to bundle
+// additional canonical packs.
+//
+// v0.41 T4 — lens packs join the bundle: creator (atoms + concepts +
+// extract_atoms/synthesize_concepts phases), investor (theses + bet
+// resolution + 3 calibration domains), engineer (gstack-learnings bridge
+// + 3 calibration domains), everything (meta-pack stacking all three
+// via extends + borrow_from). Each ships as a real YAML at base/<name>.yaml.
+//
+// #1726: exported so reporting surfaces (list_schema_packs) derive from the
+// same list the locator resolves — no more hand-copied 2-of-7 subsets.
+export const BUNDLED_PACKS: ReadonlyArray<string> = [
+  'gbrain-base',
+  'gbrain-recommended',
+  'gbrain-creator',
+  'gbrain-investor',
+  'gbrain-engineer',
+  'gbrain-everything',
+  // v0.42 type-unification: 15-type canonical successor to gbrain-base.
+  // Ships as install default (Lane E T17) + via gbrain onboard pack
+  // upgrade flow (the unify-types Minion handler).
+  'gbrain-base-v2',
+];
+
 function defaultPackLocator(name: string): string | null {
-  // v0.39 T8 — bundled packs registry. gbrain-base + gbrain-recommended
-  // ship in src/core/schema-pack/base/. Add a new entry here to bundle
-  // additional canonical packs.
-  //
-  // v0.41 T4 — lens packs join the bundle: creator (atoms + concepts +
-  // extract_atoms/synthesize_concepts phases), investor (theses + bet
-  // resolution + 3 calibration domains), engineer (gstack-learnings bridge
-  // + 3 calibration domains), everything (meta-pack stacking all three
-  // via extends + borrow_from). Each ships as a real YAML at base/<name>.yaml.
-  const BUNDLED: ReadonlyArray<string> = [
-    'gbrain-base',
-    'gbrain-recommended',
-    'gbrain-creator',
-    'gbrain-investor',
-    'gbrain-engineer',
-    'gbrain-everything',
-    // v0.42 type-unification: 15-type canonical successor to gbrain-base.
-    // Ships as install default (Lane E T17) + via gbrain onboard pack
-    // upgrade flow (the unify-types Minion handler).
-    'gbrain-base-v2',
-  ];
-  if (BUNDLED.includes(name)) {
+  if (BUNDLED_PACKS.includes(name)) {
     // Resolve bundled YAML relative to this source file. Works in both
     // direct-bun execution and bun --compile binaries.
     const here = dirname(fileURLToPath(import.meta.url));

test/calibration-profile.test.ts

@@ -32,7 +32,7 @@ interface CapturedSql {
   params: unknown[];
 }
 
-function buildMockEngine(opts: { scorecard: TakesScorecard }): {
+function buildMockEngine(opts: { scorecard: TakesScorecard; config?: Record<string, string> }): {
   engine: BrainEngine;
   captured: CapturedSql[];
 } {
@@ -42,6 +42,9 @@ function buildMockEngine(opts: { scorecard: TakesScorecard }): {
     async getScorecard() {
       return opts.scorecard;
     },
+    async getConfig(key: string) {
+      return opts.config?.[key] ?? null;
+    },
     async executeRaw<T>(sql: string, params?: unknown[]): Promise<T[]> {
       captured.push({ sql, params: params ?? [] });
       return [];
@@ -241,6 +244,36 @@ describe('runPhaseCalibrationProfile — phase integration', () => {
     expect(insert!.params[11]).toEqual(['over-confident-geography']); // active_bias_tags
   });
 
+  test('#1726: calibration.user_holder config drives the holder when no explicit opt', async () => {
+    const { engine, captured } = buildMockEngine({
+      scorecard: ENOUGH_RESOLVED_SCORECARD,
+      config: { 'calibration.user_holder': 'alice-example' },
+    });
+    await runPhaseCalibrationProfile(buildCtx(engine), {
+      patternsGenerator: async () => ['You call early-stage tactics well — 8 of 10 held up.'],
+      biasTagsGenerator: async () => [],
+      voiceGateJudge: passJudge,
+    });
+    const insert = captured.find(c => c.sql.includes('INSERT INTO calibration_profiles'));
+    expect(insert).toBeDefined();
+    expect(insert!.params[1]).toBe('alice-example'); // holder from config
+  });
+
+  test('#1726: explicit holder opt wins over calibration.user_holder config', async () => {
+    const { engine, captured } = buildMockEngine({
+      scorecard: ENOUGH_RESOLVED_SCORECARD,
+      config: { 'calibration.user_holder': 'alice-example' },
+    });
+    await runPhaseCalibrationProfile(buildCtx(engine), {
+      holder: 'charlie-example',
+      patternsGenerator: async () => ['You call early-stage tactics well — 8 of 10 held up.'],
+      biasTagsGenerator: async () => [],
+      voiceGateJudge: passJudge,
+    });
+    const insert = captured.find(c => c.sql.includes('INSERT INTO calibration_profiles'));
+    expect(insert!.params[1]).toBe('charlie-example');
+  });
+
   test('default model is a provider-prefixed id, persisted to model_id (#2451)', async () => {
     const { engine, captured } = buildMockEngine({ scorecard: ENOUGH_RESOLVED_SCORECARD });
     const patternsGenerator: PatternStatementsGenerator = async () => [

test/extract-timeline-legacy-type.test.ts

@@ -0,0 +1,106 @@
+// #2109 — gbrain-base-v2's unify-types retypes meeting pages to `note`
+// with frontmatter.legacy_type='meeting'. extract-timeline-from-meetings
+// used to hardcode type='meeting' and silently scan 0 meetings on migrated
+// brains. These tests fail without the legacy_type fallback in both SQL
+// sites (meeting walk + attended-edge join).
+
+import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'bun:test';
+import { PGLiteEngine } from '../src/core/pglite-engine.ts';
+import { resetPgliteState } from './helpers/reset-pglite.ts';
+import { extractTimelineFromMeetings } from '../src/core/extract-timeline-from-meetings.ts';
+
+let engine: PGLiteEngine;
+
+beforeAll(async () => {
+  engine = new PGLiteEngine();
+  await engine.connect({});
+  await engine.initSchema();
+});
+
+afterAll(async () => {
+  await engine.disconnect();
+});
+
+beforeEach(async () => {
+  await resetPgliteState(engine);
+});
+
+async function insertPage(opts: {
+  slug: string;
+  type: string;
+  title: string;
+  effectiveDate?: string;
+  legacyType?: string;
+}): Promise<number> {
+  const frontmatterLiteral = opts.legacyType
+    ? `'{"legacy_type": "${opts.legacyType}"}'::jsonb`
+    : `'{}'::jsonb`;
+  const rows = await engine.executeRaw<{ id: number }>(
+    `INSERT INTO pages (slug, source_id, type, title, compiled_truth, timeline, effective_date, frontmatter)
+     VALUES ($1, 'default', $2, $3, '', '', $4, ${frontmatterLiteral})
+     RETURNING id`,
+    [opts.slug, opts.type, opts.title, opts.effectiveDate ?? null],
+  );
+  return rows[0]!.id;
+}
+
+describe('extractTimelineFromMeetings — legacy_type fallback (#2109)', () => {
+  it('scans pages retyped to note with legacy_type=meeting and walks their attended edges', async () => {
+    const meetingId = await insertPage({
+      slug: 'meetings/2026-01-05',
+      type: 'note', // post-unify-types shape on a gbrain-base-v2 brain
+      legacyType: 'meeting',
+      title: 'Weekly sync',
+      effectiveDate: '2026-01-05',
+    });
+    const personId = await insertPage({
+      slug: 'people/alice-example',
+      type: 'person',
+      title: 'Alice Example',
+    });
+    await engine.executeRaw(
+      `INSERT INTO links (from_page_id, to_page_id, link_type) VALUES ($1, $2, 'attended')`,
+      [meetingId, personId],
+    );
+
+    const result = await extractTimelineFromMeetings(engine);
+    expect(result.meetings_scanned).toBe(1);
+    expect(result.entries_created).toBe(1);
+    expect(result.entities_touched).toBe(1);
+    expect(result.batch_errors).toBe(0);
+  });
+
+  it('still scans pre-unify pages with type=meeting (v1 behavior preserved)', async () => {
+    const meetingId = await insertPage({
+      slug: 'meetings/2026-02-01',
+      type: 'meeting',
+      title: 'Board prep',
+      effectiveDate: '2026-02-01',
+    });
+    const personId = await insertPage({
+      slug: 'people/charlie-example',
+      type: 'person',
+      title: 'Charlie Example',
+    });
+    await engine.executeRaw(
+      `INSERT INTO links (from_page_id, to_page_id, link_type) VALUES ($1, $2, 'attended')`,
+      [meetingId, personId],
+    );
+
+    const result = await extractTimelineFromMeetings(engine);
+    expect(result.meetings_scanned).toBe(1);
+    expect(result.entries_created).toBe(1);
+  });
+
+  it('does not scan unrelated note pages without legacy_type=meeting', async () => {
+    await insertPage({
+      slug: 'notes/random',
+      type: 'note',
+      title: 'Random note',
+      effectiveDate: '2026-03-01',
+    });
+    const result = await extractTimelineFromMeetings(engine);
+    expect(result.meetings_scanned).toBe(0);
+    expect(result.entries_created).toBe(0);
+  });
+});

test/operations-schema-pack.test.ts

@@ -152,6 +152,19 @@ describe('list_schema_packs', () => {
       expect(result.installed).toContain('mine');
     });
   });
+
+  it('reports the full bundled registry, not a hand-copied subset (#1726)', async () => {
+    await withEnv({ GBRAIN_HOME: tmpDir }, async () => {
+      const { BUNDLED_PACKS } = await import('../src/core/schema-pack/load-active.ts');
+      const result = await operationsByName.list_schema_packs!.handler(ctxOf(), {}) as { bundled: string[] };
+      expect(result.bundled.slice().sort()).toEqual([...BUNDLED_PACKS].sort());
+      // The lens packs that declare extract_atoms/synthesize_concepts phases
+      // were the ones dropped by the frozen 2-pack literal.
+      for (const name of ['gbrain-creator', 'gbrain-everything', 'gbrain-base-v2']) {
+        expect(result.bundled).toContain(name);
+      }
+    });
+  });
 });
 
 // ── schema_stats ───────────────────────────────────────────────────────

test/remediation-run-extras.serial.test.ts

@@ -1,108 +0,0 @@
-// test/remediation-run-extras.serial.test.ts
-// Regression for PR #2161 takeover: `gbrain onboard --apply --auto` dropped
-// onboard-check extraRemediations. Two distinct halves of the bug:
-//   1. runRemediation built the pre-flight plan + initial recs WITHOUT the
-//      extras, so an extras-only plan reported "Nothing to do".
-//   2. The D7 mid-run recheck rebuilt recs WITHOUT the extras after every
-//      completed step, so with 2+ plannable steps all remaining extras were
-//      dropped after step 1. The recheck must also filter out extras this
-//      run already processed — extras carry static status:'remediable', so
-//      unfiltered threading would resubmit completed extras forever.
-//
-// SERIAL: mock.module (queue + wait-for-completion stubs, R2) + GBRAIN_HOME
-// env mutation so checkpoint files land in a tmpdir, not ~/.gbrain.
-
-import { describe, expect, test, beforeAll, afterAll, mock } from 'bun:test';
-import { mkdtempSync, rmSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-import { PGLiteEngine } from '../src/core/pglite-engine.ts';
-import { makeRemediationStep } from '../src/core/remediation-step.ts';
-
-// Stub the Minion queue: every submitted job is immediately 'completed'.
-// runRemediation only calls queue.add + waitForCompletion(queue, id).
-let nextJobId = 1;
-const submittedJobs: Array<{ name: string }> = [];
-mock.module('../src/core/minions/queue.ts', () => ({
-  MinionQueue: class {
-    async add(name: string) {
-      submittedJobs.push({ name });
-      return { id: nextJobId++, status: 'completed' };
-    }
-  },
-}));
-mock.module('../src/core/minions/wait-for-completion.ts', () => ({
-  waitForCompletion: async () => ({ status: 'completed' }),
-}));
-
-let engine: PGLiteEngine;
-let home: string;
-const prevHome = process.env.GBRAIN_HOME;
-
-beforeAll(async () => {
-  home = mkdtempSync(join(tmpdir(), 'gbrain-remextras-'));
-  process.env.GBRAIN_HOME = home;
-  engine = new PGLiteEngine();
-  await engine.connect({});
-  await engine.initSchema();
-}, 120_000);
-
-afterAll(async () => {
-  await engine.disconnect();
-  if (prevHome === undefined) delete process.env.GBRAIN_HOME;
-  else process.env.GBRAIN_HOME = prevHome;
-  rmSync(home, { recursive: true, force: true });
-});
-
-function extra(id: string, job: string) {
-  return makeRemediationStep({
-    id,
-    job,
-    params: {},
-    severity: 'medium',
-    est_seconds: 5,
-    est_usd_cost: 0,
-    rationale: 'synthetic onboard-check extra',
-    status: 'remediable',
-  });
-}
-
-describe('runRemediation extraRemediations threading', () => {
-  test('extras-only plan runs BOTH extras and terminates (no Nothing-to-do, no resubmit loop)', async () => {
-    // Empty PGLite brain → zero health-derived recommendations. Without the
-    // fix, half 1 makes this run return submitted: [] via onNothingToDo.
-    // With only half 1 (the original PR #2161 diff), the mid-run recheck
-    // drops the second extra after step 1 — submitted has 1 entry, not 2.
-    const { runRemediation } = await import('../src/core/remediation/run.ts');
-    let nothingToDo = false;
-    const result = await runRemediation(
-      engine,
-      {
-        targetScore: 1,
-        extraRemediations: [
-          extra('onboard.extract_ner', 'extract-ner'),
-          extra('onboard.extract_timeline', 'extract-timeline-from-meetings'),
-        ],
-        // Safety bound: an unfiltered recheck would resubmit completed
-        // extras forever; maxJobs turns that regression into a fast fail
-        // (extra count > 1 below) instead of a hung test.
-        maxJobs: 5,
-      },
-      { onNothingToDo: () => { nothingToDo = true; } },
-    );
-
-    expect(nothingToDo).toBe(false);
-    const ids = result.submitted.map((s) => s.id);
-    expect(ids).toContain('onboard.extract_ner');
-    expect(ids).toContain('onboard.extract_timeline');
-    // Each extra ran exactly once — the recheck must not re-plan extras the
-    // run already processed.
-    expect(ids.filter((i) => i === 'onboard.extract_ner').length).toBe(1);
-    expect(ids.filter((i) => i === 'onboard.extract_timeline').length).toBe(1);
-    expect(result.submitted.every((s) => s.status === 'completed')).toBe(true);
-    expect(submittedJobs.map((j) => j.name).sort()).toEqual([
-      'extract-ner',
-      'extract-timeline-from-meetings',
-    ]);
-  });
-});

test/schema-pack-base-v2-capabilities.test.ts

@@ -0,0 +1,40 @@
+// #2117 — gbrain-base-v2 shipped with no `phases:` declaration and zero
+// link_types[].inference regexes, so extract_atoms was silently pack-gated
+// off and extract-ner returned pack_unavailable on the bundled default pack.
+// These assertions fail against the pre-fix yaml.
+
+import { describe, expect, it } from 'bun:test';
+import { join } from 'node:path';
+import { loadPackFromFile } from '../src/core/schema-pack/loader.ts';
+import { linkTypesUndeclared } from '../src/core/schema-pack/lint-rules.ts';
+
+const V2_PATH = join(import.meta.dir, '..', 'src', 'core', 'schema-pack', 'base', 'gbrain-base-v2.yaml');
+
+describe('gbrain-base-v2 capability parity (#2117)', () => {
+  const manifest = loadPackFromFile(V2_PATH);
+
+  it('declares the extract_atoms cycle phase', () => {
+    expect(manifest.phases ?? []).toContain('extract_atoms');
+  });
+
+  it('ships at least one link_type inference regex so extract-ner is not pack_unavailable', () => {
+    // Mirrors the extract-ner hasRegex predicate exactly.
+    const hasRegex = manifest.link_types.some(
+      (lt) => lt.inference && typeof lt.inference === 'object' && 'regex' in lt.inference,
+    );
+    expect(hasRegex).toBe(true);
+  });
+
+  it('ports the v1 inference verbs it declares link types for', () => {
+    const withRegex = manifest.link_types
+      .filter((lt) => lt.inference?.regex)
+      .map((lt) => lt.name)
+      .sort();
+    expect(withRegex).toEqual(['founded', 'invested_in', 'works_at']);
+  });
+
+  it('inference rules pass the undeclared-page-type lint (no meeting-bound inference)', async () => {
+    const issues = await linkTypesUndeclared(manifest);
+    expect(issues).toEqual([]);
+  });
+});