mirror of
https://github.com/openclaw/clawhub.git
synced 2026-08-15 01:12:11 +00:00
Compare commits
175
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
fa3849069d | ||
|
|
ed4c191dfc | ||
|
|
9e704e0a81 | ||
|
|
f05dd556db | ||
|
|
964893a622 | ||
|
|
9a804b951f | ||
|
|
d699087786 | ||
|
|
26b42727fe | ||
|
|
8756b78a4e | ||
|
|
e9c771d55d | ||
|
|
a58f0166fa | ||
|
|
4328d4d700 | ||
|
|
28ee2618c1 | ||
|
|
a4b850ec33 | ||
|
|
7e0b21f7c8 | ||
|
|
71c6705ab1 | ||
|
|
a57769771f | ||
|
|
6a2c131a8a | ||
|
|
67ac157545 | ||
|
|
ef36cfd698 | ||
|
|
e0637ad6aa | ||
|
|
09a21a07ff | ||
|
|
65a14dcef3 | ||
|
|
97c12b2327 | ||
|
|
a290c81a75 | ||
|
|
cc5d5cfee5 | ||
|
|
03cd710abc | ||
|
|
287f639fbc | ||
|
|
aecf66981c | ||
|
|
db8090f287 | ||
|
|
ae8614fa98 | ||
|
|
e7f78ea5a3 | ||
|
|
b9355f7a0c | ||
|
|
9530676f8a | ||
|
|
ef23520d22 | ||
|
|
e67a6e6400 | ||
|
|
e6871b86e1 | ||
|
|
75937e8b53 | ||
|
|
d2919791d1 | ||
|
|
9019cd8462 | ||
|
|
5e58bd459e | ||
|
|
3badf0668f | ||
|
|
c719297d70 | ||
|
|
e19cd23be2 | ||
|
|
9266fb7c20 | ||
|
|
99645d2c27 | ||
|
|
a1ad7fac85 | ||
|
|
ebd2f12cc4 | ||
|
|
e2ee7b164c | ||
|
|
36ed062739 | ||
|
|
d12d6e3926 | ||
|
|
1851a9c01f | ||
|
|
bbeb0be343 | ||
|
|
9c22fb7e54 | ||
|
|
ef2403179b | ||
|
|
df178d4bfc | ||
|
|
318cdd33c5 | ||
|
|
9087b037dd | ||
|
|
6991569a1c | ||
|
|
32bc600be4 | ||
|
|
a52a37d08c | ||
|
|
dd58dd0815 | ||
|
|
37a35c955a | ||
|
|
ddddb431c2 | ||
|
|
78c27579a3 | ||
|
|
9aebc35d86 | ||
|
|
fc63f47ffa | ||
|
|
0b83ea6ff3 | ||
|
|
191b5763ec | ||
|
|
5397a8e5e0 | ||
|
|
7949402888 | ||
|
|
2e3920d41a | ||
|
|
dd4fc823f6 | ||
|
|
135b9ea9b0 | ||
|
|
17a106cefe | ||
|
|
496da99392 | ||
|
|
107486adfb | ||
|
|
ef9e7f0e57 | ||
|
|
ecc8ad3833 | ||
|
|
93c2b23b72 | ||
|
|
2e492a5b87 | ||
|
|
91c87d1322 | ||
|
|
91b8f160f8 | ||
|
|
32f3ce45e9 | ||
|
|
19bfe48a67 | ||
|
|
19951fccf7 | ||
|
|
7dcada9122 | ||
|
|
dab307cb6d | ||
|
|
e96eb4781c | ||
|
|
f64b098fcc | ||
|
|
243432e04e | ||
|
|
9f7b9b92cd | ||
|
|
3402f0e735 | ||
|
|
3e39651074 | ||
|
|
741301848f | ||
|
|
b593dedba1 | ||
|
|
e104b8030e | ||
|
|
e74e879e12 | ||
|
|
1f1d93ded9 | ||
|
|
9c31462f15 | ||
|
|
f53be5c8d2 | ||
|
|
03164fe8b1 | ||
|
|
81b53f0b20 | ||
|
|
75474075b1 | ||
|
|
5946a08267 | ||
|
|
b997f5e749 | ||
|
|
27f300bda5 | ||
|
|
557f11985d | ||
|
|
40f9ba5697 | ||
|
|
26a353efc7 | ||
|
|
990d3d730d | ||
|
|
75f7a93fe8 | ||
|
|
bc51ab4b5f | ||
|
|
82fce7f34f | ||
|
|
5f4fa02b42 | ||
|
|
cfef87059b | ||
|
|
b948b216c6 | ||
|
|
f156b909e7 | ||
|
|
0b46210f61 | ||
|
|
03eee4b6de | ||
|
|
09ffaba89b | ||
|
|
b39f203b12 | ||
|
|
4002bb615d | ||
|
|
583e391d83 | ||
|
|
55ae6e1eb7 | ||
|
|
b4fe685a46 | ||
|
|
a93de9cf92 | ||
|
|
74bf5946e1 | ||
|
|
04c99aafc2 | ||
|
|
ee81325cb3 | ||
|
|
bdc6348b1a | ||
|
|
68abaa3642 | ||
|
|
0c3acda26e | ||
|
|
650090d298 | ||
|
|
70220f9487 | ||
|
|
aad1fbe2c4 | ||
|
|
2d7914859c | ||
|
|
ba6a99a65f | ||
|
|
4ac63c2373 | ||
|
|
8d0f32443a | ||
|
|
9e75090a39 | ||
|
|
5cff71104c | ||
|
|
5ef8526874 | ||
|
|
46faafc413 | ||
|
|
0710b99ac4 | ||
|
|
9ebe1b6da8 | ||
|
|
98dd49c651 | ||
|
|
a115bb0d65 | ||
|
|
f1625cd5ff | ||
|
|
010ca1677f | ||
|
|
62d62f976c | ||
|
|
24ad575a4e | ||
|
|
1cd6a22284 | ||
|
|
343e065292 | ||
|
|
2849a864e0 | ||
|
|
ae0338e469 | ||
|
|
ca1ef737cb | ||
|
|
589e46353b | ||
|
|
7edbc03494 | ||
|
|
f359071d96 | ||
|
|
57bae9859e | ||
|
|
96e9ffdcdc | ||
|
|
eb4601141e | ||
|
|
39686b3b8d | ||
|
|
a24d3e9809 | ||
|
|
405c74a4ef | ||
|
|
ee828046b8 | ||
|
|
789082bc00 | ||
|
|
3e4c2450cd | ||
|
|
ea2f51d2ba | ||
|
|
7b2bdbd08f | ||
|
|
f654dc9325 | ||
|
|
d78c105570 | ||
|
|
a32498ea7d | ||
|
|
5d6ee7adf3 |
@@ -0,0 +1,20 @@
|
||||
{
|
||||
"$schema": "./node_modules/oxfmt/configuration_schema.json",
|
||||
"experimentalSortImports": {
|
||||
"newlinesBetween": false,
|
||||
},
|
||||
"experimentalSortPackageJson": {
|
||||
"sortScripts": true,
|
||||
},
|
||||
"ignorePatterns": [
|
||||
".output/",
|
||||
".tanstack/",
|
||||
"convex/_generated/",
|
||||
"coverage/",
|
||||
"dist/",
|
||||
"node_modules/",
|
||||
"public/",
|
||||
"src/routeTree.gen.ts",
|
||||
"test-results/",
|
||||
],
|
||||
}
|
||||
+35
-1
@@ -1,3 +1,37 @@
|
||||
{
|
||||
"ignorePatterns": ["node_modules", "dist", "coverage", "convex/_generated", ".tanstack", "public"]
|
||||
"$schema": "./node_modules/oxlint/configuration_schema.json",
|
||||
"plugins": ["unicorn", "typescript", "oxc"],
|
||||
"categories": {
|
||||
"correctness": "error",
|
||||
"perf": "error",
|
||||
"suspicious": "error"
|
||||
},
|
||||
"rules": {
|
||||
"curly": "off",
|
||||
"eslint-plugin-unicorn/prefer-array-find": "off",
|
||||
"eslint-plugin-unicorn/no-array-sort": "off",
|
||||
"eslint/no-await-in-loop": "off",
|
||||
"eslint/no-new": "off",
|
||||
"oxc/no-accumulating-spread": "off",
|
||||
"oxc/no-async-endpoint-handlers": "off",
|
||||
"oxc/no-map-spread": "off",
|
||||
"typescript/no-explicit-any": "error",
|
||||
"typescript/no-extraneous-class": "off",
|
||||
"typescript/no-unnecessary-boolean-literal-compare": "off",
|
||||
"typescript/no-unnecessary-type-assertion": "off",
|
||||
"typescript/no-unsafe-type-assertion": "off",
|
||||
"unicorn/consistent-function-scoping": "off",
|
||||
"unicorn/require-post-message-target-origin": "off"
|
||||
},
|
||||
"ignorePatterns": [
|
||||
".output/",
|
||||
".tanstack/",
|
||||
"convex/_generated/",
|
||||
"coverage/",
|
||||
"dist/",
|
||||
"node_modules/",
|
||||
"public/",
|
||||
"src/routeTree.gen.ts",
|
||||
"test-results/"
|
||||
]
|
||||
}
|
||||
|
||||
@@ -34,6 +34,9 @@
|
||||
- Keep changes scoped; avoid repo-wide search/replace.
|
||||
- PRs: include summary + test commands run. Add screenshots for UI changes.
|
||||
|
||||
## Git Notes
|
||||
- If `git branch -d/-D <branch>` is policy-blocked, delete the local ref directly: `git update-ref -d refs/heads/<branch>`.
|
||||
|
||||
## Configuration & Security
|
||||
- Local env: `.env.local` (never commit secrets).
|
||||
- Convex env holds JWT keys; Vercel only needs `VITE_CONVEX_URL` + `VITE_CONVEX_SITE_URL`.
|
||||
|
||||
+67
-2
@@ -3,20 +3,85 @@
|
||||
## Unreleased
|
||||
|
||||
### Added
|
||||
- Admin: add manual unban for banned users (clears `deletedAt` + `banReason`, audit log entry). Revoked API tokens stay revoked.
|
||||
|
||||
### Changed
|
||||
- Quality gate: language-aware word counting (`Intl.Segmenter`) and new `cjkChars` signal to reduce false rejects for non-Latin docs.
|
||||
- Jobs: run skill stat event processing every 5 minutes (was 15).
|
||||
- API performance: batch resolve skill/soul tags in v1 list/get endpoints (fewer action->query round-trips) (#112) (thanks @mkrokosz).
|
||||
|
||||
### Fixed
|
||||
- Users: sync handle on ensure when GitHub login changes (#293) (thanks @christianhpoe).
|
||||
- Upload gate: fetch GitHub account age by immutable account ID (prevents username swaps) (#116) (thanks @mkrokosz).
|
||||
- API: for owners, return clearer status/messages for hidden/soft-deleted skills instead of a generic 404.
|
||||
- HTTP/CORS: add preflight handler + include CORS headers on API/download errors; CLI: include auth token for owner-visible installs/updates (#146) (thanks @Grenghis-Khan).
|
||||
- Skills: keep global sorting across pagination on `/skills` (thanks @CodeBBakGoSu, #98).
|
||||
|
||||
## 0.6.1 - 2026-02-13
|
||||
|
||||
### Added
|
||||
- Security: add LLM-based security evaluation during skill publish.
|
||||
- Parsing: recognize `metadata.openclaw` frontmatter and evaluate all skill files for requirements.
|
||||
|
||||
### Changed
|
||||
- Performance: lazy-load Monaco diff viewer on demand (thanks @alexjcm, #212).
|
||||
- Search: improve recall/ranking with lexical fallback and relevance prioritization.
|
||||
- Moderation UX: collapse OpenClaw analysis by default; update spacing and default reasoning model.
|
||||
|
||||
### Fixed
|
||||
- Skills: fix initial `/skills` sort wiring so first page respects selected sort/direction (thanks @bpk9, #92).
|
||||
- Search/UI: add embedding request timeout and align `/skills` toolbar + list width (thanks @GhadiSaab, #53).
|
||||
- Upload gate: handle GitHub API rate limits and optional authenticated lookup token (thanks @superlowburn, #246).
|
||||
- HTTP: remove `allowH2` from Undici agent to prevent `fetch failed` on Node.js 22+ (#245).
|
||||
- Tests: add root `undici` dev dependency for Node E2E imports (thanks @tanujbhaud, #255).
|
||||
- Downloads: add download rate limiting + per-IP/day dedupe + scheduled dedupe pruning; preserve moderation gating and deterministic zips (thanks @regenrek, #43).
|
||||
- VirusTotal: fix scan sync race conditions and retry behavior in scan/backfill paths.
|
||||
- Metadata: tolerate trailing commas in JSON metadata.
|
||||
- Auth: allow soft-deleted users to re-authenticate on fresh login, while keeping banned users blocked (thanks @tanujbhaud, #177).
|
||||
- Web: prevent horizontal overflow from long code blocks in skill pages (thanks @bewithgaurav, #183).
|
||||
|
||||
## 0.6.0 - 2026-02-10
|
||||
### Added
|
||||
- CLI/API: add `set-role` to change user roles (admin only).
|
||||
- Security: quarantine skill publishes with VirusTotal scans + UI (thanks @aleph8, #130).
|
||||
- Testing: add tests for badges, skillZip, uploadFiles expandDroppedItems, and ark schema error truncation.
|
||||
- Moderation: add ban reasons to API/CLI and show in management UI.
|
||||
|
||||
### Changed
|
||||
- Coverage: track `convex/lib/skillZip.ts` in coverage reports.
|
||||
|
||||
### Fixed
|
||||
- Web: show pending-scan skills to owners without 404 (thanks @orlyjamie, #136).
|
||||
- Users: backfill empty handles from name/email in ensure (thanks @adlai88, #158).
|
||||
- Web: update footer branding to OpenClaw (thanks @jontsai, #122).
|
||||
- Auth: restore soft-deleted users on reauth, block banned users (thanks @mkrokosz, #106).
|
||||
|
||||
## 0.5.0 - 2026-02-02
|
||||
|
||||
### Added
|
||||
- Admin: ban users and delete owned skills from management console.
|
||||
- Moderation: auto-hide skills after 4 unique reports; per-user report cap; moderators can ban users.
|
||||
- Uploads: require GitHub accounts to be at least 7 days old for skill + soul publish/import.
|
||||
- CLI: add `inspect` to fetch skill metadata/files without installing.
|
||||
- CLI: add moderation commands for hide/unhide/delete and ban users.
|
||||
- Management: add filters for reported skills and users.
|
||||
|
||||
### Changed
|
||||
- Deps: update dependencies to latest available versions.
|
||||
- Reporting: require reasons, show them in management console, warn about abuse bans.
|
||||
|
||||
### Fixed
|
||||
- Bans: batch hard-delete cleanup to avoid Convex read limits on large skills.
|
||||
|
||||
## 0.4.0 - 2026-01-30
|
||||
|
||||
### Added
|
||||
- Web: show published skills on user profiles (thanks @njoylab, #20).
|
||||
- CLI: include OpenClaw + Moltbot fallback skill roots for sync scans.
|
||||
- CLI: include ClawHub + Moltbot fallback skill roots for sync scans.
|
||||
- CLI: support OpenClaw configuration files (`OPENCLAW_CONFIG_PATH` / `OPENCLAW_STATE_DIR`).
|
||||
|
||||
### Changed
|
||||
- Brand: rebrand to OpenClaw and publish CLI as `clawhub` (legacy `clawdhub` supported).
|
||||
- Brand: rebrand to ClawHub and publish CLI as `clawhub` (legacy `clawdhub` supported).
|
||||
- Domain: default site/registry now `https://clawhub.ai`; `.well-known/clawhub.json` preferred.
|
||||
- Theme: persist theme under `clawhub-theme` (legacy key still read).
|
||||
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
# OpenClaw
|
||||
# ClawHub
|
||||
|
||||
<p align="center">
|
||||
<a href="https://github.com/openclaw/clawhub/actions/workflows/ci.yml?branch=main"><img src="https://img.shields.io/github/actions/workflow/status/openclaw/clawhub/ci.yml?branch=main&style=for-the-badge" alt="CI status"></a>
|
||||
@@ -6,7 +6,7 @@
|
||||
<a href="LICENSE"><img src="https://img.shields.io/badge/License-MIT-blue.svg?style=for-the-badge" alt="MIT License"></a>
|
||||
</p>
|
||||
|
||||
OpenClaw is the **public skill registry for Clawdbot**: publish, version, and search text-based agent skills (a `SKILL.md` plus supporting files).
|
||||
ClawHub is the **public skill registry for Clawdbot**: publish, version, and search text-based agent skills (a `SKILL.md` plus supporting files).
|
||||
It’s designed for fast browsing + a CLI-friendly API, with moderation hooks and vector search.
|
||||
|
||||
onlycrabs.ai is the **SOUL.md registry**: publish and share system lore the same way you publish skills.
|
||||
@@ -14,7 +14,7 @@ onlycrabs.ai is the **SOUL.md registry**: publish and share system lore the same
|
||||
Live: `https://clawhub.ai`
|
||||
onlycrabs.ai: `https://onlycrabs.ai`
|
||||
|
||||
## What you can do
|
||||
## What you can do with it
|
||||
|
||||
- Browse skills + render their `SKILL.md`.
|
||||
- Publish new skill versions with changelogs + tags (including `latest`).
|
||||
@@ -27,7 +27,7 @@ onlycrabs.ai: `https://onlycrabs.ai`
|
||||
|
||||
- Entry point is host-based: `onlycrabs.ai`.
|
||||
- On the onlycrabs.ai host, the home page and nav default to souls.
|
||||
- On OpenClaw, souls live under `/souls`.
|
||||
- On ClawHub, souls live under `/souls`.
|
||||
- Soul bundles only accept `SOUL.md` for now (no extra files).
|
||||
|
||||
## How it works (high level)
|
||||
@@ -37,9 +37,10 @@ onlycrabs.ai: `https://onlycrabs.ai`
|
||||
- Search: OpenAI embeddings (`text-embedding-3-small`) + Convex vector search.
|
||||
- API schema + routes: `packages/schema` (`clawhub-schema`).
|
||||
|
||||
|
||||
## Telemetry
|
||||
|
||||
OpenClaw tracks minimal **install telemetry** (to compute install counts) when you run `clawhub sync` while logged in.
|
||||
ClawHub tracks minimal **install telemetry** (to compute install counts) when you run `clawhub sync` while logged in.
|
||||
Disable via:
|
||||
|
||||
```bash
|
||||
@@ -95,7 +96,7 @@ This writes `JWT_PRIVATE_KEY` + `JWKS` to the deployment and prints values for y
|
||||
|
||||
## Nix plugins (nixmode skills)
|
||||
|
||||
OpenClaw can store a nix-clawdbot plugin pointer in SKILL frontmatter so the registry knows which
|
||||
ClawHub can store a nix-clawdbot plugin pointer in SKILL frontmatter so the registry knows which
|
||||
Nix package bundle to install. A nix plugin is different from a regular skill pack: it bundles the
|
||||
skill pack, the CLI binary, and its config flags/requirements together.
|
||||
|
||||
@@ -137,7 +138,30 @@ metadata: {"clawdbot":{"cliHelp":"padel --help\\nUsage: padel [command]\\n"}}
|
||||
---
|
||||
```
|
||||
|
||||
`metadata.clawdbot` is preferred, but `metadata.clawdis` is accepted as an alias for compatibility.
|
||||
`metadata.clawdbot` is preferred, but `metadata.clawdis` and `metadata.openclaw` are accepted as aliases.
|
||||
|
||||
## Skill metadata
|
||||
|
||||
Skills declare their runtime requirements (env vars, binaries, install specs) in the `SKILL.md` frontmatter. ClawHub's security analysis checks these declarations against actual skill behavior.
|
||||
|
||||
Full reference: [`docs/skill-format.md`](docs/skill-format.md#frontmatter-metadata)
|
||||
|
||||
Quick example:
|
||||
|
||||
```yaml
|
||||
---
|
||||
name: my-skill
|
||||
description: Does a thing with an API.
|
||||
metadata:
|
||||
openclaw:
|
||||
requires:
|
||||
env:
|
||||
- MY_API_KEY
|
||||
bins:
|
||||
- curl
|
||||
primaryEnv: MY_API_KEY
|
||||
---
|
||||
```
|
||||
|
||||
## Scripts
|
||||
|
||||
|
||||
-41
@@ -1,41 +0,0 @@
|
||||
{
|
||||
"$schema": "https://biomejs.dev/schemas/2.3.13/schema.json",
|
||||
"files": {
|
||||
"includes": [
|
||||
"**",
|
||||
"!**/.cta.json",
|
||||
"!**/.vscode",
|
||||
"!**/node_modules",
|
||||
"!**/dist",
|
||||
"!**/.output",
|
||||
"!**/coverage",
|
||||
"!**/convex/_generated",
|
||||
"!**/test-results",
|
||||
"!**/src/routeTree.gen.ts",
|
||||
"!**/.tanstack",
|
||||
"!**/public",
|
||||
"!**/.devenv",
|
||||
"!**/.devenv"
|
||||
]
|
||||
},
|
||||
"assist": { "actions": { "source": { "organizeImports": "on" } } },
|
||||
"formatter": {
|
||||
"enabled": true,
|
||||
"indentStyle": "space",
|
||||
"indentWidth": 2,
|
||||
"lineWidth": 100
|
||||
},
|
||||
"linter": {
|
||||
"enabled": true,
|
||||
"rules": {
|
||||
"recommended": true
|
||||
}
|
||||
},
|
||||
"javascript": {
|
||||
"formatter": {
|
||||
"quoteStyle": "single",
|
||||
"semicolons": "asNeeded",
|
||||
"trailingCommas": "all"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -15,55 +15,55 @@
|
||||
"@radix-ui/react-toggle-group": "^1.1.11",
|
||||
"@resvg/resvg-wasm": "^2.6.2",
|
||||
"@tailwindcss/vite": "^4.1.18",
|
||||
"@tanstack/react-devtools": "^0.9.2",
|
||||
"@tanstack/react-router": "^1.151.6",
|
||||
"@tanstack/react-router-devtools": "^1.151.6",
|
||||
"@tanstack/react-start": "^1.152.0",
|
||||
"@tanstack/router-plugin": "^1.151.6",
|
||||
"@tanstack/react-devtools": "^0.9.4",
|
||||
"@tanstack/react-router": "^1.157.18",
|
||||
"@tanstack/react-router-devtools": "^1.157.18",
|
||||
"@tanstack/react-start": "^1.157.18",
|
||||
"@tanstack/router-plugin": "^1.157.18",
|
||||
"@vercel/analytics": "^1.6.1",
|
||||
"clawhub-schema": "workspace:*",
|
||||
"clsx": "^2.1.1",
|
||||
"convex": "^1.31.6",
|
||||
"convex-helpers": "^0.1.111",
|
||||
"convex": "^1.31.7",
|
||||
"fflate": "^0.8.2",
|
||||
"h3": "2.0.1-rc.8",
|
||||
"lucide-react": "^0.562.0",
|
||||
"h3": "2.0.1-rc.11",
|
||||
"lucide-react": "^0.563.0",
|
||||
"monaco-editor": "^0.55.1",
|
||||
"nitro": "^3.0.1-alpha.1",
|
||||
"react": "^19.2.3",
|
||||
"react-dom": "^19.2.3",
|
||||
"nitro": "^3.0.1-alpha.2",
|
||||
"react": "^19.2.4",
|
||||
"react-dom": "^19.2.4",
|
||||
"react-markdown": "^10.1.0",
|
||||
"remark-gfm": "^4.0.1",
|
||||
"semver": "^7.7.3",
|
||||
"tailwind-merge": "^3.4.0",
|
||||
"tailwindcss": "^4.1.18",
|
||||
"vite-tsconfig-paths": "^6.0.4",
|
||||
"vite-tsconfig-paths": "^6.0.5",
|
||||
"yaml": "^2.8.2",
|
||||
},
|
||||
"devDependencies": {
|
||||
"@biomejs/biome": "^2.3.11",
|
||||
"@playwright/test": "^1.57.0",
|
||||
"@tanstack/devtools-vite": "^0.4.1",
|
||||
"@playwright/test": "^1.58.1",
|
||||
"@tanstack/devtools-vite": "^0.5.0",
|
||||
"@testing-library/dom": "^10.4.1",
|
||||
"@testing-library/react": "^16.3.1",
|
||||
"@types/node": "^25.0.9",
|
||||
"@types/react": "^19.2.8",
|
||||
"@testing-library/react": "^16.3.2",
|
||||
"@types/node": "^25.2.0",
|
||||
"@types/react": "^19.2.10",
|
||||
"@types/react-dom": "^19.2.3",
|
||||
"@types/semver": "^7.7.1",
|
||||
"@vitejs/plugin-react": "^5.1.2",
|
||||
"@vitest/coverage-v8": "^4.0.17",
|
||||
"jsdom": "^27.4.0",
|
||||
"only-allow": "^1.2.1",
|
||||
"oxlint": "^1.39.0",
|
||||
"oxlint-tsgolint": "^0.11.1",
|
||||
"@vitest/coverage-v8": "^4.0.18",
|
||||
"jsdom": "^28.0.0",
|
||||
"only-allow": "^1.2.2",
|
||||
"oxfmt": "0.32.0",
|
||||
"oxlint": "^1.42.0",
|
||||
"oxlint-tsgolint": "^0.11.4",
|
||||
"typescript": "^5.9.3",
|
||||
"undici": "^7.19.2",
|
||||
"vite": "^7.3.1",
|
||||
"vitest": "^4.0.17",
|
||||
"vitest": "^4.0.18",
|
||||
},
|
||||
},
|
||||
"packages/clawdhub": {
|
||||
"name": "clawhub",
|
||||
"version": "0.4.0",
|
||||
"version": "0.6.1",
|
||||
"bin": {
|
||||
"clawhub": "bin/clawdhub.js",
|
||||
"clawdhub": "bin/clawdhub.js",
|
||||
@@ -158,24 +158,6 @@
|
||||
|
||||
"@bcoe/v8-coverage": ["@bcoe/v8-coverage@1.0.2", "", {}, "sha512-6zABk/ECA/QYSCQ1NGiVwwbQerUCZ+TQbp64Q3AgmfNvurHH0j8TtXa1qbShXA6qqkpAj4V5W8pP6mLe1mcMqA=="],
|
||||
|
||||
"@biomejs/biome": ["@biomejs/biome@2.3.13", "", { "optionalDependencies": { "@biomejs/cli-darwin-arm64": "2.3.13", "@biomejs/cli-darwin-x64": "2.3.13", "@biomejs/cli-linux-arm64": "2.3.13", "@biomejs/cli-linux-arm64-musl": "2.3.13", "@biomejs/cli-linux-x64": "2.3.13", "@biomejs/cli-linux-x64-musl": "2.3.13", "@biomejs/cli-win32-arm64": "2.3.13", "@biomejs/cli-win32-x64": "2.3.13" }, "bin": { "biome": "bin/biome" } }, "sha512-Fw7UsV0UAtWIBIm0M7g5CRerpu1eKyKAXIazzxhbXYUyMkwNrkX/KLkGI7b+uVDQ5cLUMfOC9vR60q9IDYDstA=="],
|
||||
|
||||
"@biomejs/cli-darwin-arm64": ["@biomejs/cli-darwin-arm64@2.3.13", "", { "os": "darwin", "cpu": "arm64" }, "sha512-0OCwP0/BoKzyJHnFdaTk/i7hIP9JHH9oJJq6hrSCPmJPo8JWcJhprK4gQlhFzrwdTBAW4Bjt/RmCf3ZZe59gwQ=="],
|
||||
|
||||
"@biomejs/cli-darwin-x64": ["@biomejs/cli-darwin-x64@2.3.13", "", { "os": "darwin", "cpu": "x64" }, "sha512-AGr8OoemT/ejynbIu56qeil2+F2WLkIjn2d8jGK1JkchxnMUhYOfnqc9sVzcRxpG9Ycvw4weQ5sprRvtb7Yhcw=="],
|
||||
|
||||
"@biomejs/cli-linux-arm64": ["@biomejs/cli-linux-arm64@2.3.13", "", { "os": "linux", "cpu": "arm64" }, "sha512-xvOiFkrDNu607MPMBUQ6huHmBG1PZLOrqhtK6pXJW3GjfVqJg0Z/qpTdhXfcqWdSZHcT+Nct2fOgewZvytESkw=="],
|
||||
|
||||
"@biomejs/cli-linux-arm64-musl": ["@biomejs/cli-linux-arm64-musl@2.3.13", "", { "os": "linux", "cpu": "arm64" }, "sha512-TUdDCSY+Eo/EHjhJz7P2GnWwfqet+lFxBZzGHldrvULr59AgahamLs/N85SC4+bdF86EhqDuuw9rYLvLFWWlXA=="],
|
||||
|
||||
"@biomejs/cli-linux-x64": ["@biomejs/cli-linux-x64@2.3.13", "", { "os": "linux", "cpu": "x64" }, "sha512-s+YsZlgiXNq8XkgHs6xdvKDFOj/bwTEevqEY6rC2I3cBHbxXYU1LOZstH3Ffw9hE5tE1sqT7U23C00MzkXztMw=="],
|
||||
|
||||
"@biomejs/cli-linux-x64-musl": ["@biomejs/cli-linux-x64-musl@2.3.13", "", { "os": "linux", "cpu": "x64" }, "sha512-0bdwFVSbbM//Sds6OjtnmQGp4eUjOTt6kHvR/1P0ieR9GcTUAlPNvPC3DiavTqq302W34Ae2T6u5VVNGuQtGlQ=="],
|
||||
|
||||
"@biomejs/cli-win32-arm64": ["@biomejs/cli-win32-arm64@2.3.13", "", { "os": "win32", "cpu": "arm64" }, "sha512-QweDxY89fq0VvrxME+wS/BXKmqMrOTZlN9SqQ79kQSIc3FrEwvW/PvUegQF6XIVaekncDykB5dzPqjbwSKs9DA=="],
|
||||
|
||||
"@biomejs/cli-win32-x64": ["@biomejs/cli-win32-x64@2.3.13", "", { "os": "win32", "cpu": "x64" }, "sha512-trDw2ogdM2lyav9WFQsdsfdVy1dvZALymRpgmWsvSez0BJzBjulhOT/t+wyKeh3pZWvwP3VMs1SoOKwO3wecMQ=="],
|
||||
|
||||
"@clack/core": ["@clack/core@0.5.0", "", { "dependencies": { "picocolors": "^1.0.0", "sisteransi": "^1.0.5" } }, "sha512-p3y0FIOwaYRUPRcMO7+dlmLh8PSRcrjuTndsiA0WAFbWES0mLZlrjVoBRZ9DzkPFJZG6KGkJmoEAY0ZcVWTkow=="],
|
||||
|
||||
"@clack/prompts": ["@clack/prompts@0.11.0", "", { "dependencies": { "@clack/core": "0.5.0", "picocolors": "^1.0.0", "sisteransi": "^1.0.5" } }, "sha512-pMN5FcrEw9hUkZA4f+zLlzivQSeQf5dRGJjSUbvVYDLvpKCdQx5OaknvKzgbtXOizhP+SJJJjqEbOe55uKKfAw=="],
|
||||
@@ -252,7 +234,7 @@
|
||||
|
||||
"@esbuild/win32-x64": ["@esbuild/win32-x64@0.27.2", "", { "os": "win32", "cpu": "x64" }, "sha512-sRdU18mcKf7F+YgheI/zGf5alZatMUTKj/jNS6l744f9u3WFu4v7twcUI9vu4mknF4Y9aDlblIie0IM+5xxaqQ=="],
|
||||
|
||||
"@exodus/bytes": ["@exodus/bytes@1.10.0", "", { "peerDependencies": { "@noble/hashes": "^1.8.0 || ^2.0.0" }, "optionalPeers": ["@noble/hashes"] }, "sha512-tf8YdcbirXdPnJ+Nd4UN1EXnz+IP2DI45YVEr3vvzcVTOyrApkmIB4zvOQVd3XPr7RXnfBtAx+PXImXOIU0Ajg=="],
|
||||
"@exodus/bytes": ["@exodus/bytes@1.11.0", "", { "peerDependencies": { "@noble/hashes": "^1.8.0 || ^2.0.0" }, "optionalPeers": ["@noble/hashes"] }, "sha512-wO3vd8nsEHdumsXrjGO/v4p6irbg7hy9kvIeR6i2AwylZSk4HJdWgL0FNaVquW1+AweJcdvU1IEpuIWk/WaPnA=="],
|
||||
|
||||
"@floating-ui/core": ["@floating-ui/core@1.7.4", "", { "dependencies": { "@floating-ui/utils": "^0.2.10" } }, "sha512-C3HlIdsBxszvm5McXlB8PeOEWfBhcGBTZGkGlWc2U0KFY5IwG5OQEuQ8rq52DZmcHDlPLd+YFBK+cZcytwIFWg=="],
|
||||
|
||||
@@ -380,17 +362,55 @@
|
||||
|
||||
"@oxc-transform/binding-win32-x64-msvc": ["@oxc-transform/binding-win32-x64-msvc@0.110.0", "", { "os": "win32", "cpu": "x64" }, "sha512-QROrowwlrApI1fEScMknGWKM6GTM/Z2xwMnDqvSaEmzNazBsDUlE08Jasw610hFEsYAVU2K5sp/YaCa9ORdP4A=="],
|
||||
|
||||
"@oxlint-tsgolint/darwin-arm64": ["@oxlint-tsgolint/darwin-arm64@0.11.3", "", { "os": "darwin", "cpu": "arm64" }, "sha512-FU4e+w09D+2rkCVdL7I7zMuQOJ2tuapVhBGPGY66VAct2FUwFDVmgU+rNJ2hHIdc9uHg24v+FD8PcfFYpask8Q=="],
|
||||
"@oxfmt/binding-android-arm-eabi": ["@oxfmt/binding-android-arm-eabi@0.32.0", "", { "os": "android", "cpu": "arm" }, "sha512-DpVyuVzgLH6/MvuB/YD3vXO9CN/o9EdRpA0zXwe/tagP6yfVSFkFWkPqTROdqp0mlzLH5Yl+/m+hOrcM601EbA=="],
|
||||
|
||||
"@oxlint-tsgolint/darwin-x64": ["@oxlint-tsgolint/darwin-x64@0.11.3", "", { "os": "darwin", "cpu": "x64" }, "sha512-7sm1d920HfFsC3hIP7SJVm11WhYufA8qnLQQVk7odTpSzVUAT1jtG8LdfFigzgb38zHszQbsqJ7OjAgIW/OgmA=="],
|
||||
"@oxfmt/binding-android-arm64": ["@oxfmt/binding-android-arm64@0.32.0", "", { "os": "android", "cpu": "arm64" }, "sha512-w1cmNXf9zs0vKLuNgyUF3hZ9VUAS1hBmQGndYJv1OmcVqStBtRTRNxSWkWM0TMkrA9UbvIvM9gfN+ib4Wy6lkQ=="],
|
||||
|
||||
"@oxlint-tsgolint/linux-arm64": ["@oxlint-tsgolint/linux-arm64@0.11.3", "", { "os": "linux", "cpu": "arm64" }, "sha512-eoJfdmHcpG9k8fufb8yL3rC3HC6QELoTEfs56lmGaRIHHmd1aj4MWDbGCqdRqPEp7oC5fVvFxi7wDkA1MDf99Q=="],
|
||||
"@oxfmt/binding-darwin-arm64": ["@oxfmt/binding-darwin-arm64@0.32.0", "", { "os": "darwin", "cpu": "arm64" }, "sha512-m6wQojz/hn94XdZugFPtdFbOvXbOSYEqPsR2gyLyID3BvcrC2QsJyT1o3gb4BZEGtZrG1NiKVGwDRLM0dHd2mg=="],
|
||||
|
||||
"@oxlint-tsgolint/linux-x64": ["@oxlint-tsgolint/linux-x64@0.11.3", "", { "os": "linux", "cpu": "x64" }, "sha512-t7jGK0vBApuAGvOnCPTxsdX+1e9nMdvqU3zHCJWQ7yUDaJxki0bCy4zbKfUgVo8ePeVRgIKWwqLFBOVTXQ5AMQ=="],
|
||||
"@oxfmt/binding-darwin-x64": ["@oxfmt/binding-darwin-x64@0.32.0", "", { "os": "darwin", "cpu": "x64" }, "sha512-hN966Uh6r3Erkg2MvRcrJWaB6QpBzP15rxWK/QtkUyD47eItJLsAQ2Hrm88zMIpFZ3COXZLuN3hqgSlUtvB0Xw=="],
|
||||
|
||||
"@oxlint-tsgolint/win32-arm64": ["@oxlint-tsgolint/win32-arm64@0.11.3", "", { "os": "win32", "cpu": "arm64" }, "sha512-6ellG0zcWnj2b6Mr7fl19x+nlFIWGWoKCBlYnqNZ4CaziRYGpYx7PLwHhPJq331w7zzRRSnYqhyTrVluYjZADQ=="],
|
||||
"@oxfmt/binding-freebsd-x64": ["@oxfmt/binding-freebsd-x64@0.32.0", "", { "os": "freebsd", "cpu": "x64" }, "sha512-g5UZPGt8tJj263OfSiDGdS54HPa0KgFfspLVAUivVSdoOgsk6DkwVS9nO16xQTDztzBPGxTvrby8WuufF0g86Q=="],
|
||||
|
||||
"@oxlint-tsgolint/win32-x64": ["@oxlint-tsgolint/win32-x64@0.11.3", "", { "os": "win32", "cpu": "x64" }, "sha512-rzvfaRJPK9eRYVWMXCt8JtvOsVFAsqScgsFhnXzsipU6W1Te0g+b4q068o7hZ3NRTjJxNgFJj8ayOkZ6NbX0tA=="],
|
||||
"@oxfmt/binding-linux-arm-gnueabihf": ["@oxfmt/binding-linux-arm-gnueabihf@0.32.0", "", { "os": "linux", "cpu": "arm" }, "sha512-F4ZY83/PVQo9ZJhtzoMqbmjqEyTVEZjbaw4x1RhzdfUhddB41ZB2Vrt4eZi7b4a4TP85gjPRHgQBeO0c1jbtaw=="],
|
||||
|
||||
"@oxfmt/binding-linux-arm-musleabihf": ["@oxfmt/binding-linux-arm-musleabihf@0.32.0", "", { "os": "linux", "cpu": "arm" }, "sha512-olR37eG16Lzdj9OBSvuoT5RxzgM5xfQEHm1OEjB3M7Wm4KWa5TDWIT13Aiy74GvAN77Hq1+kUKcGVJ/0ynf75g=="],
|
||||
|
||||
"@oxfmt/binding-linux-arm64-gnu": ["@oxfmt/binding-linux-arm64-gnu@0.32.0", "", { "os": "linux", "cpu": "arm64" }, "sha512-eZhk6AIjRCDeLoXYBhMW7qq/R1YyVi+tGnGfc3kp7AZQrMsFaWtP/bgdCJCTNXMpbMwymtVz0qhSQvR5w2sKcg=="],
|
||||
|
||||
"@oxfmt/binding-linux-arm64-musl": ["@oxfmt/binding-linux-arm64-musl@0.32.0", "", { "os": "linux", "cpu": "arm64" }, "sha512-UYiqO9MlipntFbdbUKOIo84vuyzrK4TVIs7Etat91WNMFSW54F6OnHq08xa5ZM+K9+cyYMgQPXvYCopuP+LyKw=="],
|
||||
|
||||
"@oxfmt/binding-linux-ppc64-gnu": ["@oxfmt/binding-linux-ppc64-gnu@0.32.0", "", { "os": "linux", "cpu": "ppc64" }, "sha512-IDH/fxMv+HmKsMtsjEbXqhScCKDIYp38sgGEcn0QKeXMxrda67PPZA7HMfoUwEtFUG+jsO1XJxTrQsL+kQ90xQ=="],
|
||||
|
||||
"@oxfmt/binding-linux-riscv64-gnu": ["@oxfmt/binding-linux-riscv64-gnu@0.32.0", "", { "os": "linux", "cpu": "none" }, "sha512-bQFGPDa0buYWJFeK2I7ah8wRZjrAgamaG2OAGv+Ua5UMYEnHxmHcv+r8lWUUrwP2oqQGvp1SB8JIVtBbYuAueQ=="],
|
||||
|
||||
"@oxfmt/binding-linux-riscv64-musl": ["@oxfmt/binding-linux-riscv64-musl@0.32.0", "", { "os": "linux", "cpu": "none" }, "sha512-3vFp9DW1ItEKWltADzCFqG5N7rYFToT4ztlhg8wALoo2E2VhveLD88uAF4FF9AxD9NhgHDGmPCV+WZl/Qlj8cQ=="],
|
||||
|
||||
"@oxfmt/binding-linux-s390x-gnu": ["@oxfmt/binding-linux-s390x-gnu@0.32.0", "", { "os": "linux", "cpu": "s390x" }, "sha512-Fub2y8S9ImuPzAzpbgkoz/EVTWFFBolxFZYCMRhRZc8cJZI2gl/NlZswqhvJd/U0Jopnwgm/OJ2x128vVzFFWA=="],
|
||||
|
||||
"@oxfmt/binding-linux-x64-gnu": ["@oxfmt/binding-linux-x64-gnu@0.32.0", "", { "os": "linux", "cpu": "x64" }, "sha512-XufwsnV3BF81zO2ofZvhT4FFaMmLTzZEZnC9HpFz/quPeg9C948+kbLlZnsfjmp+1dUxKMCpfmRMqOfF4AOLsA=="],
|
||||
|
||||
"@oxfmt/binding-linux-x64-musl": ["@oxfmt/binding-linux-x64-musl@0.32.0", "", { "os": "linux", "cpu": "x64" }, "sha512-u2f9tC2qYfikKmA2uGpnEJgManwmk0ZXWs5BB4ga4KDu2JNLdA3i634DGHeMLK9wY9+iRf3t7IYpgN3OVFrvDw=="],
|
||||
|
||||
"@oxfmt/binding-openharmony-arm64": ["@oxfmt/binding-openharmony-arm64@0.32.0", "", { "os": "none", "cpu": "arm64" }, "sha512-5ZXb1wrdbZ1YFXuNXNUCePLlmLDy4sUt4evvzD4Cgumbup5wJgS9PIe5BOaLywUg9f1wTH6lwltj3oT7dFpIGA=="],
|
||||
|
||||
"@oxfmt/binding-win32-arm64-msvc": ["@oxfmt/binding-win32-arm64-msvc@0.32.0", "", { "os": "win32", "cpu": "arm64" }, "sha512-IGSMm/Agq+IA0++aeAV/AGPfjcBdjrsajB5YpM3j7cMcwoYgUTi/k2YwAmsHH3ueZUE98pSM/Ise2J7HtyRjOA=="],
|
||||
|
||||
"@oxfmt/binding-win32-ia32-msvc": ["@oxfmt/binding-win32-ia32-msvc@0.32.0", "", { "os": "win32", "cpu": "ia32" }, "sha512-H/9gsuqXmceWMsVoCPZhtJG2jLbnBeKr7xAXm2zuKpxLVF7/2n0eh7ocOLB6t+L1ARE76iORuUsRMnuGjj8FjQ=="],
|
||||
|
||||
"@oxfmt/binding-win32-x64-msvc": ["@oxfmt/binding-win32-x64-msvc@0.32.0", "", { "os": "win32", "cpu": "x64" }, "sha512-fF8VIOeligq+mA6KfKvWtFRXbf0EFy73TdR6ZnNejdJRM8VWN1e3QFhYgIwD7O8jBrQsd7EJbUpkAr/YlUOokg=="],
|
||||
|
||||
"@oxlint-tsgolint/darwin-arm64": ["@oxlint-tsgolint/darwin-arm64@0.11.4", "", { "os": "darwin", "cpu": "arm64" }, "sha512-IhdhiC183s5wdFDZSQC8PaFFq1QROiVT5ahz7ysgEKVnkNDjy82ieM7ZKiUfm2ncXNX2RcFGSSZrQO6plR+VAQ=="],
|
||||
|
||||
"@oxlint-tsgolint/darwin-x64": ["@oxlint-tsgolint/darwin-x64@0.11.4", "", { "os": "darwin", "cpu": "x64" }, "sha512-KJmBg10Z1uGpJqxDzETXOytYyeVrKUepo8rCXeVkRlZ2QzZqMElgalFN4BI3ccgIPkQpzzu4SVzWNFz7yiKavQ=="],
|
||||
|
||||
"@oxlint-tsgolint/linux-arm64": ["@oxlint-tsgolint/linux-arm64@0.11.4", "", { "os": "linux", "cpu": "arm64" }, "sha512-P6I3dSSpoEnjFzTMlrbcBHNbErSxceZmcVUslBxrrIUH1NSVS1XfSz6S75vT2Gay7Jv6LI7zTTVAk4cSqkfe+w=="],
|
||||
|
||||
"@oxlint-tsgolint/linux-x64": ["@oxlint-tsgolint/linux-x64@0.11.4", "", { "os": "linux", "cpu": "x64" }, "sha512-G0eAW3S7cp/vP7Kx6e7+Ze7WfNgSt1tc/rOexfLKnnIi+9BelyOa2wF9bWFPpxk3n3AdkBwKttU1/adDZlD87Q=="],
|
||||
|
||||
"@oxlint-tsgolint/win32-arm64": ["@oxlint-tsgolint/win32-arm64@0.11.4", "", { "os": "win32", "cpu": "arm64" }, "sha512-prgQEBiwp4TAxarh6dYbVOKw6riRJ6hB49vDD6DxQlOZQky7xHQ9qTec5/rf0JTUZ16YaJ9YfHycbJS3QVpTYw=="],
|
||||
|
||||
"@oxlint-tsgolint/win32-x64": ["@oxlint-tsgolint/win32-x64@0.11.4", "", { "os": "win32", "cpu": "x64" }, "sha512-5xXTzZIT/1meWMmS60Q+FYWvWncc6iTfC8tyQt7GDfPUoqQvE5WVgHm1QjDSJvxTD+6AHphpCqdhXq/KtxagRw=="],
|
||||
|
||||
"@oxlint/darwin-arm64": ["@oxlint/darwin-arm64@1.42.0", "", { "os": "darwin", "cpu": "arm64" }, "sha512-ui5CdAcDsXPQwZQEXOOSWsilJWhgj9jqHCvYBm2tDE8zfwZZuF9q58+hGKH1x5y0SV4sRlyobB2Quq6uU6EgeA=="],
|
||||
|
||||
@@ -410,7 +430,7 @@
|
||||
|
||||
"@panva/hkdf": ["@panva/hkdf@1.2.1", "", {}, "sha512-6oclG6Y3PiDFcoyk8srjLfVKyMfVCKJ27JwNPViuXziFpmdz+MZnZN/aKY0JGXgYuO/VghU0jcOAZgWXZ1Dmrw=="],
|
||||
|
||||
"@playwright/test": ["@playwright/test@1.58.0", "", { "dependencies": { "playwright": "1.58.0" }, "bin": { "playwright": "cli.js" } }, "sha512-fWza+Lpbj6SkQKCrU6si4iu+fD2dD3gxNHFhUPxsfXBPhnv3rRSQVd0NtBUT9Z/RhF/boCBcuUaMUSTRTopjZg=="],
|
||||
"@playwright/test": ["@playwright/test@1.58.1", "", { "dependencies": { "playwright": "1.58.1" }, "bin": { "playwright": "cli.js" } }, "sha512-6LdVIUERWxQMmUSSQi0I53GgCBYgM2RpGngCPY7hSeju+VrKjq3lvs7HpJoPbDiY5QM5EYRtRX5fvrinnMAz3w=="],
|
||||
|
||||
"@radix-ui/primitive": ["@radix-ui/primitive@1.1.3", "", {}, "sha512-JTF99U/6XIjCBo0wqkU5sK10glYe27MRRsfwoiq5zzOEZLHU3A3KCMa5X/azekYRCJ0HlwI0crAXS/5dEHTzDg=="],
|
||||
|
||||
@@ -566,7 +586,7 @@
|
||||
|
||||
"@tailwindcss/vite": ["@tailwindcss/vite@4.1.18", "", { "dependencies": { "@tailwindcss/node": "4.1.18", "@tailwindcss/oxide": "4.1.18", "tailwindcss": "4.1.18" }, "peerDependencies": { "vite": "^5.2.0 || ^6 || ^7" } }, "sha512-jVA+/UpKL1vRLg6Hkao5jldawNmRo7mQYrZtNHMIVpLfLhDml5nMRUo/8MwoX2vNXvnaXNNMedrMfMugAVX1nA=="],
|
||||
|
||||
"@tanstack/devtools": ["@tanstack/devtools@0.10.4", "", { "dependencies": { "@solid-primitives/event-listener": "^2.4.3", "@solid-primitives/keyboard": "^1.3.3", "@solid-primitives/resize-observer": "^2.1.3", "@tanstack/devtools-client": "0.0.5", "@tanstack/devtools-event-bus": "0.4.0", "@tanstack/devtools-ui": "0.4.4", "clsx": "^2.1.1", "goober": "^2.1.16", "solid-js": "^1.9.9" } }, "sha512-GR/HMWe+eAZgSm/mOeuWMs/cXy3pEcrdMBU+OH0c6Qv1IXYv/xqru4aCSJPe+2/eJXng5ioqCsoVt9MztyU1mg=="],
|
||||
"@tanstack/devtools": ["@tanstack/devtools@0.10.5", "", { "dependencies": { "@solid-primitives/event-listener": "^2.4.3", "@solid-primitives/keyboard": "^1.3.3", "@solid-primitives/resize-observer": "^2.1.3", "@tanstack/devtools-client": "0.0.5", "@tanstack/devtools-event-bus": "0.4.0", "@tanstack/devtools-ui": "0.4.4", "clsx": "^2.1.1", "goober": "^2.1.16", "solid-js": "^1.9.9" } }, "sha512-aptV4sMcdEn/zB8zqNqKSKi8pLzfB7BhdP2MuVmyfWgBDYNchqJjhviaxEXW3tJTolbWwc30o+jszwqxOIcIaA=="],
|
||||
|
||||
"@tanstack/devtools-client": ["@tanstack/devtools-client@0.0.5", "", { "dependencies": { "@tanstack/devtools-event-client": "^0.4.0" } }, "sha512-hsNDE3iu4frt9cC2ppn1mNRnLKo2uc1/1hXAyY9z4UYb+o40M2clFAhiFoo4HngjfGJDV3x18KVVIq7W4Un+zA=="],
|
||||
|
||||
@@ -576,43 +596,43 @@
|
||||
|
||||
"@tanstack/devtools-ui": ["@tanstack/devtools-ui@0.4.4", "", { "dependencies": { "clsx": "^2.1.1", "goober": "^2.1.16", "solid-js": "^1.9.9" } }, "sha512-5xHXFyX3nom0UaNfiOM92o6ziaHjGo3mcSGe2HD5Xs8dWRZNpdZ0Smd0B9ddEhy0oB+gXyMzZgUJb9DmrZV0Mg=="],
|
||||
|
||||
"@tanstack/devtools-vite": ["@tanstack/devtools-vite@0.4.1", "", { "dependencies": { "@babel/core": "^7.28.4", "@babel/generator": "^7.28.3", "@babel/parser": "^7.28.4", "@babel/traverse": "^7.28.4", "@babel/types": "^7.28.4", "@tanstack/devtools-client": "0.0.5", "@tanstack/devtools-event-bus": "0.4.0", "chalk": "^5.6.2", "launch-editor": "^2.11.1", "picomatch": "^4.0.3" }, "peerDependencies": { "vite": "^6.0.0 || ^7.0.0" } }, "sha512-PkMOomcWnl/pUkCqIjqL/csjPHtkMVBirDpJVOZR7XJZDxo5CuD7B+3KsujFCF4Dsn6QYlae97gCZvxi/CB76Q=="],
|
||||
"@tanstack/devtools-vite": ["@tanstack/devtools-vite@0.5.0", "", { "dependencies": { "@babel/core": "^7.28.4", "@babel/generator": "^7.28.3", "@babel/parser": "^7.28.4", "@babel/traverse": "^7.28.4", "@babel/types": "^7.28.4", "@tanstack/devtools-client": "0.0.5", "@tanstack/devtools-event-bus": "0.4.0", "chalk": "^5.6.2", "launch-editor": "^2.11.1", "picomatch": "^4.0.3" }, "peerDependencies": { "vite": "^6.0.0 || ^7.0.0" } }, "sha512-Ew+ZdTnmTlVjm4q+/XY/dolx/E1BWMYpiRDyU/MXqHf5epri4MLl5C4UZJaO+ZuUCsKPpsW+ufoM99E2Z4rhug=="],
|
||||
|
||||
"@tanstack/history": ["@tanstack/history@1.154.14", "", {}, "sha512-xyIfof8eHBuub1CkBnbKNKQXeRZC4dClhmzePHVOEel4G7lk/dW+TQ16da7CFdeNLv6u6Owf5VoBQxoo6DFTSA=="],
|
||||
|
||||
"@tanstack/react-devtools": ["@tanstack/react-devtools@0.9.3", "", { "dependencies": { "@tanstack/devtools": "0.10.4" }, "peerDependencies": { "@types/react": ">=16.8", "@types/react-dom": ">=16.8", "react": ">=16.8", "react-dom": ">=16.8" } }, "sha512-SJTYWXWZkbWznwUwZ11awinPGB5StVIVyJXT0BFM1zUgjuajRwT8xRHl1oXVzVqqjJP5kfj89jkbFrcQPpq7Ng=="],
|
||||
"@tanstack/react-devtools": ["@tanstack/react-devtools@0.9.4", "", { "dependencies": { "@tanstack/devtools": "0.10.5" }, "peerDependencies": { "@types/react": ">=16.8", "@types/react-dom": ">=16.8", "react": ">=16.8", "react-dom": ">=16.8" } }, "sha512-6wQf8gVKDks1VL+LI5SS4XWK8dQLIjcDF3iMZfidyesWJNmodWbWlRkdgCmK5SpDSbcygjbp3p+LG2nE/SZ1bQ=="],
|
||||
|
||||
"@tanstack/react-router": ["@tanstack/react-router@1.157.16", "", { "dependencies": { "@tanstack/history": "1.154.14", "@tanstack/react-store": "^0.8.0", "@tanstack/router-core": "1.157.16", "isbot": "^5.1.22", "tiny-invariant": "^1.3.3", "tiny-warning": "^1.0.3" }, "peerDependencies": { "react": ">=18.0.0 || >=19.0.0", "react-dom": ">=18.0.0 || >=19.0.0" } }, "sha512-xwFQa7S7dhBhm3aJYwU79cITEYgAKSrcL6wokaROIvl2JyIeazn8jueWqUPJzFjv+QF6Q8euKRlKUEyb5q2ymg=="],
|
||||
"@tanstack/react-router": ["@tanstack/react-router@1.157.18", "", { "dependencies": { "@tanstack/history": "1.154.14", "@tanstack/react-store": "^0.8.0", "@tanstack/router-core": "1.157.18", "isbot": "^5.1.22", "tiny-invariant": "^1.3.3", "tiny-warning": "^1.0.3" }, "peerDependencies": { "react": ">=18.0.0 || >=19.0.0", "react-dom": ">=18.0.0 || >=19.0.0" } }, "sha512-qs//HcVhEZ0K2/Sqejol0vOWaFIh4EoYTQQix9FhHOyWvdUpGoTJS0+g/qxEnZZm7r9QNOrnyrYZ5CDAqnII6g=="],
|
||||
|
||||
"@tanstack/react-router-devtools": ["@tanstack/react-router-devtools@1.157.16", "", { "dependencies": { "@tanstack/router-devtools-core": "1.157.16" }, "peerDependencies": { "@tanstack/react-router": "^1.157.16", "@tanstack/router-core": "^1.157.16", "react": ">=18.0.0 || >=19.0.0", "react-dom": ">=18.0.0 || >=19.0.0" }, "optionalPeers": ["@tanstack/router-core"] }, "sha512-g6ekyzumfLBX6T5e+Vu2r37Z2CFJKrWRFqIy3vZ6A3x7OcuPV8uXNjyrLSiT/IsGTiF8YzwI4nWJa4fyd7NlCw=="],
|
||||
"@tanstack/react-router-devtools": ["@tanstack/react-router-devtools@1.157.18", "", { "dependencies": { "@tanstack/router-devtools-core": "1.157.18" }, "peerDependencies": { "@tanstack/react-router": "^1.157.18", "@tanstack/router-core": "^1.157.18", "react": ">=18.0.0 || >=19.0.0", "react-dom": ">=18.0.0 || >=19.0.0" }, "optionalPeers": ["@tanstack/router-core"] }, "sha512-JHSOnwj8wkim1AppgPT1Jp+NtmiiJ4yLZ//Vo0sfrQSgOzlZgdFg4OdQP+9rYzuj3BNz+XoDdokXQhJxiSqSww=="],
|
||||
|
||||
"@tanstack/react-start": ["@tanstack/react-start@1.157.16", "", { "dependencies": { "@tanstack/react-router": "1.157.16", "@tanstack/react-start-client": "1.157.16", "@tanstack/react-start-server": "1.157.16", "@tanstack/router-utils": "^1.154.7", "@tanstack/start-client-core": "1.157.16", "@tanstack/start-plugin-core": "1.157.16", "@tanstack/start-server-core": "1.157.16", "pathe": "^2.0.3" }, "peerDependencies": { "react": ">=18.0.0 || >=19.0.0", "react-dom": ">=18.0.0 || >=19.0.0", "vite": ">=7.0.0" } }, "sha512-FO6UYjsZyNaC0ickSSvClqfVZemp9/HWnbRJQU2dOKYQsI+wnznhLp9IkgG90iFBLcuMAWhcNHMiIuz603GJBg=="],
|
||||
"@tanstack/react-start": ["@tanstack/react-start@1.157.18", "", { "dependencies": { "@tanstack/react-router": "1.157.18", "@tanstack/react-start-client": "1.157.18", "@tanstack/react-start-server": "1.157.18", "@tanstack/router-utils": "^1.154.7", "@tanstack/start-client-core": "1.157.18", "@tanstack/start-plugin-core": "1.157.18", "@tanstack/start-server-core": "1.157.18", "pathe": "^2.0.3" }, "peerDependencies": { "react": ">=18.0.0 || >=19.0.0", "react-dom": ">=18.0.0 || >=19.0.0", "vite": ">=7.0.0" } }, "sha512-ytKblzB34SHmm/7euujl2rZvEjzIsvICFzzKHd7DETi11FSih/WIMU4RKErMtIIc8R2NETh9MPGFLb+XFDsU6A=="],
|
||||
|
||||
"@tanstack/react-start-client": ["@tanstack/react-start-client@1.157.16", "", { "dependencies": { "@tanstack/react-router": "1.157.16", "@tanstack/router-core": "1.157.16", "@tanstack/start-client-core": "1.157.16", "tiny-invariant": "^1.3.3", "tiny-warning": "^1.0.3" }, "peerDependencies": { "react": ">=18.0.0 || >=19.0.0", "react-dom": ">=18.0.0 || >=19.0.0" } }, "sha512-r3XTxYPJXZ/szhbloxqT6CQtsoEjw8DjbnZh/3ZsQv2PLKTOl925cy7YVdQc2cWZyXtn5e19Ig78R+8tsoTpig=="],
|
||||
"@tanstack/react-start-client": ["@tanstack/react-start-client@1.157.18", "", { "dependencies": { "@tanstack/react-router": "1.157.18", "@tanstack/router-core": "1.157.18", "@tanstack/start-client-core": "1.157.18", "tiny-invariant": "^1.3.3", "tiny-warning": "^1.0.3" }, "peerDependencies": { "react": ">=18.0.0 || >=19.0.0", "react-dom": ">=18.0.0 || >=19.0.0" } }, "sha512-8bk6x7skZp62LnEC2PKegmTo4RrOMrah0RY60S3ZUDXAJGs+CF9a+0moidpawUQbWvoO6T413TVOnNFHyPixJQ=="],
|
||||
|
||||
"@tanstack/react-start-server": ["@tanstack/react-start-server@1.157.16", "", { "dependencies": { "@tanstack/history": "1.154.14", "@tanstack/react-router": "1.157.16", "@tanstack/router-core": "1.157.16", "@tanstack/start-client-core": "1.157.16", "@tanstack/start-server-core": "1.157.16" }, "peerDependencies": { "react": ">=18.0.0 || >=19.0.0", "react-dom": ">=18.0.0 || >=19.0.0" } }, "sha512-1YkBss4SUQ+HqVC1yGN/j7VNwjvdHHd3K58fASe0bz+uf7GrkGJlRXPkMJdxJkkmefYHQfyBL+q7o723N4CMYA=="],
|
||||
"@tanstack/react-start-server": ["@tanstack/react-start-server@1.157.18", "", { "dependencies": { "@tanstack/history": "1.154.14", "@tanstack/react-router": "1.157.18", "@tanstack/router-core": "1.157.18", "@tanstack/start-client-core": "1.157.18", "@tanstack/start-server-core": "1.157.18" }, "peerDependencies": { "react": ">=18.0.0 || >=19.0.0", "react-dom": ">=18.0.0 || >=19.0.0" } }, "sha512-LQg9FjwXJpt2yS1EdEP9r67KE9Qeg/9fWhdso+wl7XqGc8It/IEYh4D9qci3o+TVKS2b+MhIRklM0tVJ/nh1jw=="],
|
||||
|
||||
"@tanstack/react-store": ["@tanstack/react-store@0.8.0", "", { "dependencies": { "@tanstack/store": "0.8.0", "use-sync-external-store": "^1.6.0" }, "peerDependencies": { "react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0", "react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0" } }, "sha512-1vG9beLIuB7q69skxK9r5xiLN3ztzIPfSQSs0GfeqWGO2tGIyInZx0x1COhpx97RKaONSoAb8C3dxacWksm1ow=="],
|
||||
|
||||
"@tanstack/router-core": ["@tanstack/router-core@1.157.16", "", { "dependencies": { "@tanstack/history": "1.154.14", "@tanstack/store": "^0.8.0", "cookie-es": "^2.0.0", "seroval": "^1.4.2", "seroval-plugins": "^1.4.2", "tiny-invariant": "^1.3.3", "tiny-warning": "^1.0.3" } }, "sha512-eJuVgM7KZYTTr4uPorbUzUflmljMVcaX2g6VvhITLnHmg9SBx9RAgtQ1HmT+72mzyIbRSlQ1q0fY/m+of/fosA=="],
|
||||
"@tanstack/router-core": ["@tanstack/router-core@1.157.18", "", { "dependencies": { "@tanstack/history": "1.154.14", "@tanstack/store": "^0.8.0", "cookie-es": "^2.0.0", "seroval": "^1.4.2", "seroval-plugins": "^1.4.2", "tiny-invariant": "^1.3.3", "tiny-warning": "^1.0.3" } }, "sha512-jGkyA3EEE01Sf6d4goi//poxQNb/Odc/GzpjZSW2zwG+wcXm9hEzcI6vU2IxhAU0dvvwQyQgtU1HXTcXQ/Xg4A=="],
|
||||
|
||||
"@tanstack/router-devtools-core": ["@tanstack/router-devtools-core@1.157.16", "", { "dependencies": { "clsx": "^2.1.1", "goober": "^2.1.16", "tiny-invariant": "^1.3.3" }, "peerDependencies": { "@tanstack/router-core": "^1.157.16", "csstype": "^3.0.10" }, "optionalPeers": ["csstype"] }, "sha512-XBJTs/kMZYK6J2zhbGucHNuypwDB1t2vi8K5To+V6dUnLGBEyfQTf01fegiF4rpL1yXgomdGnP6aTiOFgldbVg=="],
|
||||
"@tanstack/router-devtools-core": ["@tanstack/router-devtools-core@1.157.18", "", { "dependencies": { "clsx": "^2.1.1", "goober": "^2.1.16", "tiny-invariant": "^1.3.3" }, "peerDependencies": { "@tanstack/router-core": "^1.157.18", "csstype": "^3.0.10" }, "optionalPeers": ["csstype"] }, "sha512-+eh3XzBUuoGxJr8b9kCLdyJN+zPsAxtNggEvCal7iI8WE6q3ujjUPYiqHNI+MS4thtxaeUdAXlEjak/+fdBPdg=="],
|
||||
|
||||
"@tanstack/router-generator": ["@tanstack/router-generator@1.157.16", "", { "dependencies": { "@tanstack/router-core": "1.157.16", "@tanstack/router-utils": "1.154.7", "@tanstack/virtual-file-routes": "1.154.7", "prettier": "^3.5.0", "recast": "^0.23.11", "source-map": "^0.7.4", "tsx": "^4.19.2", "zod": "^3.24.2" } }, "sha512-Ae2M00VTFjjED7glSCi/mMLENRzhEym6NgjoOx7UVNbCC/rLU/5ASDe5VIlDa8QLEqP5Pj088Gi51gjmRuICvQ=="],
|
||||
"@tanstack/router-generator": ["@tanstack/router-generator@1.157.18", "", { "dependencies": { "@tanstack/router-core": "1.157.18", "@tanstack/router-utils": "1.154.7", "@tanstack/virtual-file-routes": "1.154.7", "prettier": "^3.5.0", "recast": "^0.23.11", "source-map": "^0.7.4", "tsx": "^4.19.2", "zod": "^3.24.2" } }, "sha512-t6nZdaX+pYWaudwg5Yasu/o8IAK8FPc4Jwq+rZpyaCgeZn895Vc407hxoRss40/hK1jk03b8x349+b1JekiSqA=="],
|
||||
|
||||
"@tanstack/router-plugin": ["@tanstack/router-plugin@1.157.16", "", { "dependencies": { "@babel/core": "^7.28.5", "@babel/plugin-syntax-jsx": "^7.27.1", "@babel/plugin-syntax-typescript": "^7.27.1", "@babel/template": "^7.27.2", "@babel/traverse": "^7.28.5", "@babel/types": "^7.28.5", "@tanstack/router-core": "1.157.16", "@tanstack/router-generator": "1.157.16", "@tanstack/router-utils": "1.154.7", "@tanstack/virtual-file-routes": "1.154.7", "babel-dead-code-elimination": "^1.0.11", "chokidar": "^3.6.0", "unplugin": "^2.1.2", "zod": "^3.24.2" }, "peerDependencies": { "@rsbuild/core": ">=1.0.2", "@tanstack/react-router": "^1.157.16", "vite": ">=5.0.0 || >=6.0.0 || >=7.0.0", "vite-plugin-solid": "^2.11.10", "webpack": ">=5.92.0" }, "optionalPeers": ["@rsbuild/core", "@tanstack/react-router", "vite", "vite-plugin-solid", "webpack"] }, "sha512-YQg7L06xyCJAYyrEJNZGAnDL8oChILU+G/eSDIwEfcWn5iLk+47x1Gcdxr82++47PWmOPhzuTo8edDQXWs7kAA=="],
|
||||
"@tanstack/router-plugin": ["@tanstack/router-plugin@1.157.18", "", { "dependencies": { "@babel/core": "^7.28.5", "@babel/plugin-syntax-jsx": "^7.27.1", "@babel/plugin-syntax-typescript": "^7.27.1", "@babel/template": "^7.27.2", "@babel/traverse": "^7.28.5", "@babel/types": "^7.28.5", "@tanstack/router-core": "1.157.18", "@tanstack/router-generator": "1.157.18", "@tanstack/router-utils": "1.154.7", "@tanstack/virtual-file-routes": "1.154.7", "babel-dead-code-elimination": "^1.0.11", "chokidar": "^3.6.0", "unplugin": "^2.1.2", "zod": "^3.24.2" }, "peerDependencies": { "@rsbuild/core": ">=1.0.2", "@tanstack/react-router": "^1.157.18", "vite": ">=5.0.0 || >=6.0.0 || >=7.0.0", "vite-plugin-solid": "^2.11.10", "webpack": ">=5.92.0" }, "optionalPeers": ["@rsbuild/core", "@tanstack/react-router", "vite", "vite-plugin-solid", "webpack"] }, "sha512-1UrRnIhD4Ar0PpXwzIkxD8nfjzmO7oYRh4CkSUO+Xc6aD5poNB62aUWPp3vS5jnXDNSk0vr+N4QAPebjPKw0Hw=="],
|
||||
|
||||
"@tanstack/router-utils": ["@tanstack/router-utils@1.154.7", "", { "dependencies": { "@babel/core": "^7.28.5", "@babel/generator": "^7.28.5", "@babel/parser": "^7.28.5", "ansis": "^4.1.0", "diff": "^8.0.2", "pathe": "^2.0.3", "tinyglobby": "^0.2.15" } }, "sha512-61bGx32tMKuEpVRseu2sh1KQe8CfB7793Mch/kyQt0EP3tD7X0sXmimCl3truRiDGUtI0CaSoQV1NPjAII1RBA=="],
|
||||
|
||||
"@tanstack/start-client-core": ["@tanstack/start-client-core@1.157.16", "", { "dependencies": { "@tanstack/router-core": "1.157.16", "@tanstack/start-fn-stubs": "1.154.7", "@tanstack/start-storage-context": "1.157.16", "seroval": "^1.4.2", "tiny-invariant": "^1.3.3", "tiny-warning": "^1.0.3" } }, "sha512-O+7H133MWQTkOxmXJNhrLXiOhDcBlxvpEcCd/N25Ga6eyZ7/P5vvFzNkSSxeQNkZV+RiPWnA5B75gT+U+buz3w=="],
|
||||
"@tanstack/start-client-core": ["@tanstack/start-client-core@1.157.18", "", { "dependencies": { "@tanstack/router-core": "1.157.18", "@tanstack/start-fn-stubs": "1.154.7", "@tanstack/start-storage-context": "1.157.18", "seroval": "^1.4.2", "tiny-invariant": "^1.3.3", "tiny-warning": "^1.0.3" } }, "sha512-DehC8ONA3QTBbaB95sL8ID+lK284ETP8/k9RCifseXOzr5xWKNNGbe3+Fy8OYV1MtHIuOmCMqozzltPp5MTANg=="],
|
||||
|
||||
"@tanstack/start-fn-stubs": ["@tanstack/start-fn-stubs@1.154.7", "", {}, "sha512-D69B78L6pcFN5X5PHaydv7CScQcKLzJeEYqs7jpuyyqGQHSUIZUjS955j+Sir8cHhuDIovCe2LmsYHeZfWf3dQ=="],
|
||||
|
||||
"@tanstack/start-plugin-core": ["@tanstack/start-plugin-core@1.157.16", "", { "dependencies": { "@babel/code-frame": "7.27.1", "@babel/core": "^7.28.5", "@babel/types": "^7.28.5", "@rolldown/pluginutils": "1.0.0-beta.40", "@tanstack/router-core": "1.157.16", "@tanstack/router-generator": "1.157.16", "@tanstack/router-plugin": "1.157.16", "@tanstack/router-utils": "1.154.7", "@tanstack/start-client-core": "1.157.16", "@tanstack/start-server-core": "1.157.16", "babel-dead-code-elimination": "^1.0.11", "cheerio": "^1.0.0", "exsolve": "^1.0.7", "pathe": "^2.0.3", "srvx": "^0.10.1", "tinyglobby": "^0.2.15", "ufo": "^1.5.4", "vitefu": "^1.1.1", "xmlbuilder2": "^4.0.3", "zod": "^3.24.2" }, "peerDependencies": { "vite": ">=7.0.0" } }, "sha512-VmRXuvP5flryUAHeBM4Xb06n544qLtyA2cwmlQLRTUYtQiQEAdd9CvCGy8CPAly3f7eeXKqC7aX0v3MwWkLR8w=="],
|
||||
"@tanstack/start-plugin-core": ["@tanstack/start-plugin-core@1.157.18", "", { "dependencies": { "@babel/code-frame": "7.27.1", "@babel/core": "^7.28.5", "@babel/types": "^7.28.5", "@rolldown/pluginutils": "1.0.0-beta.40", "@tanstack/router-core": "1.157.18", "@tanstack/router-generator": "1.157.18", "@tanstack/router-plugin": "1.157.18", "@tanstack/router-utils": "1.154.7", "@tanstack/start-client-core": "1.157.18", "@tanstack/start-server-core": "1.157.18", "babel-dead-code-elimination": "^1.0.11", "cheerio": "^1.0.0", "exsolve": "^1.0.7", "pathe": "^2.0.3", "srvx": "^0.10.1", "tinyglobby": "^0.2.15", "ufo": "^1.5.4", "vitefu": "^1.1.1", "xmlbuilder2": "^4.0.3", "zod": "^3.24.2" }, "peerDependencies": { "vite": ">=7.0.0" } }, "sha512-qUVfdEoLf/WYUB1WASR1hcxmlGvIBKiLEIFnpG/Kd/E01BwtHhDjv6WsEusg0n2WrWnYT2/6tuJRDPyXObV7IA=="],
|
||||
|
||||
"@tanstack/start-server-core": ["@tanstack/start-server-core@1.157.16", "", { "dependencies": { "@tanstack/history": "1.154.14", "@tanstack/router-core": "1.157.16", "@tanstack/start-client-core": "1.157.16", "@tanstack/start-storage-context": "1.157.16", "h3-v2": "npm:h3@2.0.1-rc.11", "seroval": "^1.4.2", "tiny-invariant": "^1.3.3" } }, "sha512-PEltFleYfiqz6+KcmzNXxc1lXgT7VDNKP6G6i1TirdHBDbRJ9CIY+ASLPlhrRwqwA2PL9PpFjXZl8u5bH/+Q9A=="],
|
||||
"@tanstack/start-server-core": ["@tanstack/start-server-core@1.157.18", "", { "dependencies": { "@tanstack/history": "1.154.14", "@tanstack/router-core": "1.157.18", "@tanstack/start-client-core": "1.157.18", "@tanstack/start-storage-context": "1.157.18", "h3-v2": "npm:h3@2.0.1-rc.11", "seroval": "^1.4.2", "tiny-invariant": "^1.3.3" } }, "sha512-0ixErUvQsVM9SwOOpjyUOpS9KZBDRv1aoM2+qnSGR3DxZUricy/XbCaDAMxReN/0aJQzo47Y5gjpSWaGWlImWw=="],
|
||||
|
||||
"@tanstack/start-storage-context": ["@tanstack/start-storage-context@1.157.16", "", { "dependencies": { "@tanstack/router-core": "1.157.16" } }, "sha512-56izE0oihAw2YRwYUEds2H+uO5dyT2CahXCgWX62+l+FHou09M9mSep68n1lBKPdphC2ZU3cPV7wnvgeraJWHg=="],
|
||||
"@tanstack/start-storage-context": ["@tanstack/start-storage-context@1.157.18", "", { "dependencies": { "@tanstack/router-core": "1.157.18" } }, "sha512-OqueMS78bULFTDw37uUR8s3yWdX9JVzW4uh/y8V9Iv3oEa6yAgGC2cfOy4My70UkkggAUhoVNopQZamPtL+EBQ=="],
|
||||
|
||||
"@tanstack/store": ["@tanstack/store@0.8.0", "", {}, "sha512-Om+BO0YfMZe//X2z0uLF2j+75nQga6TpTJgLJQBiq85aOyZNIhkCgleNcud2KQg4k4v9Y9l+Uhru3qWMPGTOzQ=="],
|
||||
|
||||
@@ -650,7 +670,7 @@
|
||||
|
||||
"@types/ms": ["@types/ms@2.1.0", "", {}, "sha512-GsCCIZDE/p3i96vtEqx+7dBUGXrc7zeSK3wwPHIaRThS+9OhWIXRqzs4d6k1SVU8g91DrNRWxWUGhp5KXQb2VA=="],
|
||||
|
||||
"@types/node": ["@types/node@25.1.0", "", { "dependencies": { "undici-types": "~7.16.0" } }, "sha512-t7frlewr6+cbx+9Ohpl0NOTKXZNV9xHRmNOvql47BFJKcEG1CxtxlPEEe+gR9uhVWM4DwhnvTF110mIL4yP9RA=="],
|
||||
"@types/node": ["@types/node@25.2.0", "", { "dependencies": { "undici-types": "~7.16.0" } }, "sha512-DZ8VwRFUNzuqJ5khrvwMXHmvPe+zGayJhr2CDNiKB1WBE1ST8Djl00D0IC4vvNmHMdj6DlbYRIaFE7WHjlDl5w=="],
|
||||
|
||||
"@types/react": ["@types/react@19.2.10", "", { "dependencies": { "csstype": "^3.2.2" } }, "sha512-WPigyYuGhgZ/cTPRXB2EwUw+XvsRA3GqHlsP4qteqrnnjDrApbS7MxcGr/hke5iUoeB7E/gQtrs9I37zAJ0Vjw=="],
|
||||
|
||||
@@ -770,8 +790,6 @@
|
||||
|
||||
"convex": ["convex@1.31.7", "", { "dependencies": { "esbuild": "0.27.0", "prettier": "^3.0.0" }, "peerDependencies": { "@auth0/auth0-react": "^2.0.1", "@clerk/clerk-react": "^4.12.8 || ^5.0.0", "react": "^18.0.0 || ^19.0.0-0 || ^19.0.0" }, "optionalPeers": ["@auth0/auth0-react", "@clerk/clerk-react", "react"], "bin": { "convex": "bin/main.js" } }, "sha512-PtNMe1mAIOvA8Yz100QTOaIdgt2rIuWqencVXrb4McdhxBHZ8IJ1eXTnrgCC9HydyilGT1pOn+KNqT14mqn9fQ=="],
|
||||
|
||||
"convex-helpers": ["convex-helpers@0.1.111", "", { "peerDependencies": { "@standard-schema/spec": "^1.0.0", "convex": "^1.25.4", "hono": "^4.0.5", "react": "^17.0.2 || ^18.0.0 || ^19.0.0", "typescript": "^5.5", "zod": "^3.25.0 || ^4.0.0" }, "optionalPeers": ["@standard-schema/spec", "hono", "react", "typescript", "zod"], "bin": { "convex-helpers": "bin.cjs" } }, "sha512-0O59Ohi8HVc3+KULxSC6JHsw8cQJyc8gZ7OAfNRVX7T5Wy6LhPx3l8veYN9avKg7UiPlO7m1eBiQMHKclIyXyQ=="],
|
||||
|
||||
"cookie": ["cookie@1.1.1", "", {}, "sha512-ei8Aos7ja0weRpFzJnEA9UHJ/7XQmqglbRwnf2ATjcB9Wq874VKH9kfjjirM6UhU2/E5fFYadylyhFldcqSidQ=="],
|
||||
|
||||
"cookie-es": ["cookie-es@2.0.0", "", {}, "sha512-RAj4E421UYRgqokKUmotqAwuplYw15qtdXfY+hGzgCJ/MBjCVZcSoHK/kH9kocfjRjcDME7IiDWR/1WX1TM2Pg=="],
|
||||
@@ -788,7 +806,7 @@
|
||||
|
||||
"csstype": ["csstype@3.2.3", "", {}, "sha512-z1HGKcYy2xA8AGQfwrn0PAy+PB7X/GSj3UVJW9qKyn43xWa+gl5nXmU4qqLMRzWVLFC8KusUX8T/0kCiOYpAIQ=="],
|
||||
|
||||
"data-urls": ["data-urls@6.0.1", "", { "dependencies": { "whatwg-mimetype": "^5.0.0", "whatwg-url": "^15.1.0" } }, "sha512-euIQENZg6x8mj3fO6o9+fOW8MimUI4PpD/fZBhJfeioZVy9TUpM4UY7KjQNVZFlqwJ0UdzRDzkycB997HEq1BQ=="],
|
||||
"data-urls": ["data-urls@7.0.0", "", { "dependencies": { "whatwg-mimetype": "^5.0.0", "whatwg-url": "^16.0.0" } }, "sha512-23XHcCF+coGYevirZceTVD7NdJOqVn+49IHyxgszm+JIiHLoB2TkmPtsYkNWT1pvRSGkc35L6NHs0yHkN2SumA=="],
|
||||
|
||||
"db0": ["db0@0.3.4", "", { "peerDependencies": { "@electric-sql/pglite": "*", "@libsql/client": "*", "better-sqlite3": "*", "drizzle-orm": "*", "mysql2": "*", "sqlite3": "*" }, "optionalPeers": ["@electric-sql/pglite", "@libsql/client", "better-sqlite3", "drizzle-orm", "mysql2", "sqlite3"] }, "sha512-RiXXi4WaNzPTHEOu8UPQKMooIbqOEyqA1t7Z6MsdxSCeb8iUC9ko3LcmsLmeUt2SM5bctfArZKkRQggKZz7JNw=="],
|
||||
|
||||
@@ -872,7 +890,7 @@
|
||||
|
||||
"graceful-fs": ["graceful-fs@4.2.11", "", {}, "sha512-RbJ5/jmFcNNCcDV5o9eTnBLJ/HszWV0P73bc+Ff4nS/rJj+YaS6IGyiOL0VoBYX+l1Wrl3k63h/KrH+nhJ0XvQ=="],
|
||||
|
||||
"h3": ["h3@2.0.1-rc.8", "", { "dependencies": { "rou3": "^0.7.12", "srvx": "^0.10.0" }, "peerDependencies": { "crossws": "^0.4.1" }, "optionalPeers": ["crossws"] }, "sha512-IIMQG7qnXx1Ls75suuMHH4xtcvTFxsUguDIZB+dgdYr1RftLj59FkeWF1dOr+jnejDs8Eo+ZKV1CMqogFeqGRQ=="],
|
||||
"h3": ["h3@2.0.1-rc.11", "", { "dependencies": { "rou3": "^0.7.12", "srvx": "^0.10.1" }, "peerDependencies": { "crossws": "^0.4.1" }, "optionalPeers": ["crossws"] }, "sha512-2myzjCqy32c1As9TjZW9fNZXtLqNedjFSrdFy2AjFBQQ3LzrnGoDdFDYfC0tV2e4vcyfJ2Sfo/F6NQhO2Ly/Mw=="],
|
||||
|
||||
"h3-v2": ["h3@2.0.1-rc.11", "", { "dependencies": { "rou3": "^0.7.12", "srvx": "^0.10.1" }, "peerDependencies": { "crossws": "^0.4.1" }, "optionalPeers": ["crossws"] }, "sha512-2myzjCqy32c1As9TjZW9fNZXtLqNedjFSrdFy2AjFBQQ3LzrnGoDdFDYfC0tV2e4vcyfJ2Sfo/F6NQhO2Ly/Mw=="],
|
||||
|
||||
@@ -942,7 +960,7 @@
|
||||
|
||||
"js-yaml": ["js-yaml@4.1.1", "", { "dependencies": { "argparse": "^2.0.1" }, "bin": { "js-yaml": "bin/js-yaml.js" } }, "sha512-qQKT4zQxXl8lLwBtHMWwaTcGfFOZviOJet3Oy/xmGk2gZH677CJM9EvtfdSkgWcATZhj/55JZ0rmy3myCT5lsA=="],
|
||||
|
||||
"jsdom": ["jsdom@27.4.0", "", { "dependencies": { "@acemir/cssom": "^0.9.28", "@asamuzakjp/dom-selector": "^6.7.6", "@exodus/bytes": "^1.6.0", "cssstyle": "^5.3.4", "data-urls": "^6.0.0", "decimal.js": "^10.6.0", "html-encoding-sniffer": "^6.0.0", "http-proxy-agent": "^7.0.2", "https-proxy-agent": "^7.0.6", "is-potential-custom-element-name": "^1.0.1", "parse5": "^8.0.0", "saxes": "^6.0.0", "symbol-tree": "^3.2.4", "tough-cookie": "^6.0.0", "w3c-xmlserializer": "^5.0.0", "webidl-conversions": "^8.0.0", "whatwg-mimetype": "^4.0.0", "whatwg-url": "^15.1.0", "ws": "^8.18.3", "xml-name-validator": "^5.0.0" }, "peerDependencies": { "canvas": "^3.0.0" }, "optionalPeers": ["canvas"] }, "sha512-mjzqwWRD9Y1J1KUi7W97Gja1bwOOM5Ug0EZ6UDK3xS7j7mndrkwozHtSblfomlzyB4NepioNt+B2sOSzczVgtQ=="],
|
||||
"jsdom": ["jsdom@28.0.0", "", { "dependencies": { "@acemir/cssom": "^0.9.31", "@asamuzakjp/dom-selector": "^6.7.6", "@exodus/bytes": "^1.11.0", "cssstyle": "^5.3.7", "data-urls": "^7.0.0", "decimal.js": "^10.6.0", "html-encoding-sniffer": "^6.0.0", "http-proxy-agent": "^7.0.2", "https-proxy-agent": "^7.0.6", "is-potential-custom-element-name": "^1.0.1", "parse5": "^8.0.0", "saxes": "^6.0.0", "symbol-tree": "^3.2.4", "tough-cookie": "^6.0.0", "undici": "^7.20.0", "w3c-xmlserializer": "^5.0.0", "webidl-conversions": "^8.0.1", "whatwg-mimetype": "^5.0.0", "whatwg-url": "^16.0.0", "xml-name-validator": "^5.0.0" }, "peerDependencies": { "canvas": "^3.0.0" }, "optionalPeers": ["canvas"] }, "sha512-KDYJgZ6T2TKdU8yBfYueq5EPG/EylMsBvCaenWMJb2OXmjgczzwveRCoJ+Hgj1lXPDyasvrgneSn4GBuR1hYyA=="],
|
||||
|
||||
"jsesc": ["jsesc@3.1.0", "", { "bin": { "jsesc": "bin/jsesc" } }, "sha512-/sM3dO2FOzXjKQhJuo0Q173wf2KOo8t4I8vHy6lF9poUp7bKT0/NHE8fPX23PwfhnykfqnC2xRxOnVw5XuGIaA=="],
|
||||
|
||||
@@ -984,7 +1002,7 @@
|
||||
|
||||
"lucia": ["lucia@3.2.2", "", { "dependencies": { "@oslojs/crypto": "^1.0.1", "@oslojs/encoding": "^1.1.0" } }, "sha512-P1FlFBGCMPMXu+EGdVD9W4Mjm0DqsusmKgO7Xc33mI5X1bklmsQb0hfzPhXomQr9waWIBDsiOjvr1e6BTaUqpA=="],
|
||||
|
||||
"lucide-react": ["lucide-react@0.562.0", "", { "peerDependencies": { "react": "^16.5.1 || ^17.0.0 || ^18.0.0 || ^19.0.0" } }, "sha512-82hOAu7y0dbVuFfmO4bYF1XEwYk/mEbM5E+b1jgci/udUBEE/R7LF5Ip0CCEmXe8AybRM8L+04eP+LGZeDvkiw=="],
|
||||
"lucide-react": ["lucide-react@0.563.0", "", { "peerDependencies": { "react": "^16.5.1 || ^17.0.0 || ^18.0.0 || ^19.0.0" } }, "sha512-8dXPB2GI4dI8jV4MgUDGBeLdGk8ekfqVZ0BdLcrRzocGgG75ltNEmWS+gE7uokKF/0oSUuczNDT+g9hFJ23FkA=="],
|
||||
|
||||
"lz-string": ["lz-string@1.5.0", "", { "bin": { "lz-string": "bin/bin.js" } }, "sha512-h5bgJWpxJNswbU7qCrV0tIKQCaS3blPDrqKWx+QxzuzL1zGUzij9XCWLrSLsJPu5t+eWA/ycetzYAO5IOMcWAQ=="],
|
||||
|
||||
@@ -1124,9 +1142,11 @@
|
||||
|
||||
"oxc-transform": ["oxc-transform@0.110.0", "", { "optionalDependencies": { "@oxc-transform/binding-android-arm-eabi": "0.110.0", "@oxc-transform/binding-android-arm64": "0.110.0", "@oxc-transform/binding-darwin-arm64": "0.110.0", "@oxc-transform/binding-darwin-x64": "0.110.0", "@oxc-transform/binding-freebsd-x64": "0.110.0", "@oxc-transform/binding-linux-arm-gnueabihf": "0.110.0", "@oxc-transform/binding-linux-arm-musleabihf": "0.110.0", "@oxc-transform/binding-linux-arm64-gnu": "0.110.0", "@oxc-transform/binding-linux-arm64-musl": "0.110.0", "@oxc-transform/binding-linux-ppc64-gnu": "0.110.0", "@oxc-transform/binding-linux-riscv64-gnu": "0.110.0", "@oxc-transform/binding-linux-riscv64-musl": "0.110.0", "@oxc-transform/binding-linux-s390x-gnu": "0.110.0", "@oxc-transform/binding-linux-x64-gnu": "0.110.0", "@oxc-transform/binding-linux-x64-musl": "0.110.0", "@oxc-transform/binding-openharmony-arm64": "0.110.0", "@oxc-transform/binding-wasm32-wasi": "0.110.0", "@oxc-transform/binding-win32-arm64-msvc": "0.110.0", "@oxc-transform/binding-win32-ia32-msvc": "0.110.0", "@oxc-transform/binding-win32-x64-msvc": "0.110.0" } }, "sha512-/fymQNzzUoKZweH0nC5yvbI2eR0yWYusT9TEKDYVgOgYrf9Qmdez9lUFyvxKR9ycx+PTHi/reIOzqf3wkShQsw=="],
|
||||
|
||||
"oxfmt": ["oxfmt@0.32.0", "", { "dependencies": { "tinypool": "2.1.0" }, "optionalDependencies": { "@oxfmt/binding-android-arm-eabi": "0.32.0", "@oxfmt/binding-android-arm64": "0.32.0", "@oxfmt/binding-darwin-arm64": "0.32.0", "@oxfmt/binding-darwin-x64": "0.32.0", "@oxfmt/binding-freebsd-x64": "0.32.0", "@oxfmt/binding-linux-arm-gnueabihf": "0.32.0", "@oxfmt/binding-linux-arm-musleabihf": "0.32.0", "@oxfmt/binding-linux-arm64-gnu": "0.32.0", "@oxfmt/binding-linux-arm64-musl": "0.32.0", "@oxfmt/binding-linux-ppc64-gnu": "0.32.0", "@oxfmt/binding-linux-riscv64-gnu": "0.32.0", "@oxfmt/binding-linux-riscv64-musl": "0.32.0", "@oxfmt/binding-linux-s390x-gnu": "0.32.0", "@oxfmt/binding-linux-x64-gnu": "0.32.0", "@oxfmt/binding-linux-x64-musl": "0.32.0", "@oxfmt/binding-openharmony-arm64": "0.32.0", "@oxfmt/binding-win32-arm64-msvc": "0.32.0", "@oxfmt/binding-win32-ia32-msvc": "0.32.0", "@oxfmt/binding-win32-x64-msvc": "0.32.0" }, "bin": { "oxfmt": "bin/oxfmt" } }, "sha512-KArQhGzt/Y8M1eSAX98Y8DLtGYYDQhkR55THUPY5VNcpFQ+9nRZkL3ULXhagHMD2hIvjy8JSeEQEP5/yYJSrLA=="],
|
||||
|
||||
"oxlint": ["oxlint@1.42.0", "", { "optionalDependencies": { "@oxlint/darwin-arm64": "1.42.0", "@oxlint/darwin-x64": "1.42.0", "@oxlint/linux-arm64-gnu": "1.42.0", "@oxlint/linux-arm64-musl": "1.42.0", "@oxlint/linux-x64-gnu": "1.42.0", "@oxlint/linux-x64-musl": "1.42.0", "@oxlint/win32-arm64": "1.42.0", "@oxlint/win32-x64": "1.42.0" }, "peerDependencies": { "oxlint-tsgolint": ">=0.11.2" }, "optionalPeers": ["oxlint-tsgolint"], "bin": { "oxlint": "bin/oxlint" } }, "sha512-qnspC/lrp8FgKNaONLLn14dm+W5t0SSlus6V5NJpgI2YNT1tkFYZt4fBf14ESxf9AAh98WBASnW5f0gtw462Lg=="],
|
||||
|
||||
"oxlint-tsgolint": ["oxlint-tsgolint@0.11.3", "", { "optionalDependencies": { "@oxlint-tsgolint/darwin-arm64": "0.11.3", "@oxlint-tsgolint/darwin-x64": "0.11.3", "@oxlint-tsgolint/linux-arm64": "0.11.3", "@oxlint-tsgolint/linux-x64": "0.11.3", "@oxlint-tsgolint/win32-arm64": "0.11.3", "@oxlint-tsgolint/win32-x64": "0.11.3" }, "bin": { "tsgolint": "bin/tsgolint.js" } }, "sha512-zkuGXJzE5WIoGQ6CHG3GbxncPNrvUG9giTKdXMqKrlieCRxa9hGMvMJM+7DFxKSaryVAEFrTQJNrGJHpeMmFPg=="],
|
||||
"oxlint-tsgolint": ["oxlint-tsgolint@0.11.4", "", { "optionalDependencies": { "@oxlint-tsgolint/darwin-arm64": "0.11.4", "@oxlint-tsgolint/darwin-x64": "0.11.4", "@oxlint-tsgolint/linux-arm64": "0.11.4", "@oxlint-tsgolint/linux-x64": "0.11.4", "@oxlint-tsgolint/win32-arm64": "0.11.4", "@oxlint-tsgolint/win32-x64": "0.11.4" }, "bin": { "tsgolint": "bin/tsgolint.js" } }, "sha512-VyQc+69TxQwUdsEPiVFN7vNZdDVO/FHaEcHltnWs3O6rvwxv67uADlknQQO714sbRdEahOjgO5dFf+K9ili0gg=="],
|
||||
|
||||
"p-retry": ["p-retry@7.1.1", "", { "dependencies": { "is-network-error": "^1.1.0" } }, "sha512-J5ApzjyRkkf601HpEeykoiCvzHQjWxPAHhyjFcEUP2SWq0+35NKh8TLhpLw+Dkq5TZBFvUM6UigdE9hIVYTl5w=="],
|
||||
|
||||
@@ -1146,9 +1166,9 @@
|
||||
|
||||
"picomatch": ["picomatch@4.0.3", "", {}, "sha512-5gTmgEY/sqK6gFXLIsQNH19lWb4ebPDLA4SdLP7dsWkIXHWlG66oPuVvXSGFPppYZz8ZDZq0dYYrbHfBCVUb1Q=="],
|
||||
|
||||
"playwright": ["playwright@1.58.0", "", { "dependencies": { "playwright-core": "1.58.0" }, "optionalDependencies": { "fsevents": "2.3.2" }, "bin": { "playwright": "cli.js" } }, "sha512-2SVA0sbPktiIY/MCOPX8e86ehA/e+tDNq+e5Y8qjKYti2Z/JG7xnronT/TXTIkKbYGWlCbuucZ6dziEgkoEjQQ=="],
|
||||
"playwright": ["playwright@1.58.1", "", { "dependencies": { "playwright-core": "1.58.1" }, "optionalDependencies": { "fsevents": "2.3.2" }, "bin": { "playwright": "cli.js" } }, "sha512-+2uTZHxSCcxjvGc5C891LrS1/NlxglGxzrC4seZiVjcYVQfUa87wBL6rTDqzGjuoWNjnBzRqKmF6zRYGMvQUaQ=="],
|
||||
|
||||
"playwright-core": ["playwright-core@1.58.0", "", { "bin": { "playwright-core": "cli.js" } }, "sha512-aaoB1RWrdNi3//rOeKuMiS65UCcgOVljU46At6eFcOFPFHWtd2weHRRow6z/n+Lec0Lvu0k9ZPKJSjPugikirw=="],
|
||||
"playwright-core": ["playwright-core@1.58.1", "", { "bin": { "playwright-core": "cli.js" } }, "sha512-bcWzOaTxcW+VOOGBCQgnaKToLJ65d6AqfLVKEWvexyS3AS6rbXl+xdpYRMGSRBClPvyj44njOWoxjNdL/H9UNg=="],
|
||||
|
||||
"postcss": ["postcss@8.5.6", "", { "dependencies": { "nanoid": "^3.3.11", "picocolors": "^1.1.1", "source-map-js": "^1.2.1" } }, "sha512-3Ybi1tAuwAP9s0r1UQ2J4n5Y0G05bJkpUIO0/bI9MhwmD70S5aTWbXGBwxHrelT+XM1k6dM0pk+SwNkpTRN7Pg=="],
|
||||
|
||||
@@ -1272,6 +1292,8 @@
|
||||
|
||||
"tinyglobby": ["tinyglobby@0.2.15", "", { "dependencies": { "fdir": "^6.5.0", "picomatch": "^4.0.3" } }, "sha512-j2Zq4NyQYG5XMST4cbs02Ak8iJUdxRM0XI5QyxXuZOzKOINmWurp3smXu3y5wDcJrptwpSjgXHzIQxR0omXljQ=="],
|
||||
|
||||
"tinypool": ["tinypool@2.1.0", "", {}, "sha512-Pugqs6M0m7Lv1I7FtxN4aoyToKg1C4tu+/381vH35y8oENM/Ai7f7C4StcoK4/+BSw9ebcS8jRiVrORFKCALLw=="],
|
||||
|
||||
"tinyrainbow": ["tinyrainbow@3.0.3", "", {}, "sha512-PSkbLUoxOFRzJYjjxHJt9xro7D+iilgMX/C9lawzVuYiIdcihh9DXmVibBe8lmcFrRi/VzlPjBxbN7rH24q8/Q=="],
|
||||
|
||||
"tldts": ["tldts@7.0.19", "", { "dependencies": { "tldts-core": "^7.0.19" }, "bin": { "tldts": "bin/cli.js" } }, "sha512-8PWx8tvC4jDB39BQw1m4x8y5MH1BcQ5xHeL2n7UVFulMPH/3Q0uiamahFJ3lXA0zO2SUyRXuVVbWSDmstlt9YA=="],
|
||||
@@ -1298,7 +1320,7 @@
|
||||
|
||||
"ufo": ["ufo@1.6.3", "", {}, "sha512-yDJTmhydvl5lJzBmy/hyOAA0d+aqCBuwl818haVdYCRrWV84o7YyeVm4QlVHStqNrrJSTb6jKuFAVqAFsr+K3Q=="],
|
||||
|
||||
"undici": ["undici@7.19.2", "", {}, "sha512-4VQSpGEGsWzk0VYxyB/wVX/Q7qf9t5znLRgs0dzszr9w9Fej/8RVNQ+S20vdXSAyra/bJ7ZQfGv6ZMj7UEbzSg=="],
|
||||
"undici": ["undici@7.20.0", "", {}, "sha512-MJZrkjyd7DeC+uPZh+5/YaMDxFiiEEaDgbUSVMXayofAkDWF1088CDo+2RPg7B1BuS1qf1vgNE7xqwPxE0DuSQ=="],
|
||||
|
||||
"undici-types": ["undici-types@7.16.0", "", {}, "sha512-Zz+aZWSj8LE6zoxD+xrjh4VfkIG8Ya6LvYkZqtUQGJPZjYl53ypCaUwWqo7eI0x66KBGeRo+mlBEkMSeSZ38Nw=="],
|
||||
|
||||
@@ -1348,9 +1370,9 @@
|
||||
|
||||
"whatwg-encoding": ["whatwg-encoding@3.1.1", "", { "dependencies": { "iconv-lite": "0.6.3" } }, "sha512-6qN4hJdMwfYBtE3YBTTHhoeuUrDBPZmbQaxWAqSALV/MeEnR5z1xd8UKud2RAkFoPkmB+hli1TZSnyi84xz1vQ=="],
|
||||
|
||||
"whatwg-mimetype": ["whatwg-mimetype@4.0.0", "", {}, "sha512-QaKxh0eNIi2mE9p2vEdzfagOKHCcj1pJ56EEHGQOVxp8r9/iszLUUV7v89x9O1p/T+NlTM5W7jW6+cz4Fq1YVg=="],
|
||||
"whatwg-mimetype": ["whatwg-mimetype@5.0.0", "", {}, "sha512-sXcNcHOC51uPGF0P/D4NVtrkjSU2fNsm9iog4ZvZJsL3rjoDAzXZhkm2MWt1y+PUdggKAYVoMAIYcs78wJ51Cw=="],
|
||||
|
||||
"whatwg-url": ["whatwg-url@15.1.0", "", { "dependencies": { "tr46": "^6.0.0", "webidl-conversions": "^8.0.0" } }, "sha512-2ytDk0kiEj/yu90JOAp44PVPUkO9+jVhyf+SybKlRHSDlvOOZhdPIrr7xTH64l4WixO2cP+wQIcgujkGBPPz6g=="],
|
||||
"whatwg-url": ["whatwg-url@16.0.0", "", { "dependencies": { "@exodus/bytes": "^1.11.0", "tr46": "^6.0.0", "webidl-conversions": "^8.0.1" } }, "sha512-9CcxtEKsf53UFwkSUZjG+9vydAsFO4lFHBpJUtjBcoJOCJpKnSJNwCw813zrYJHpCJ7sgfbtOe0V5Ku7Pa1XMQ=="],
|
||||
|
||||
"which-pm-runs": ["which-pm-runs@1.1.0", "", {}, "sha512-n1brCuqClxfFfq/Rb0ICg9giSZqCS+pLtccdag6C2HyufBrh3fBOiy9nb6ggRMvWOVH5GrdJskj5iGTZNxd7SA=="],
|
||||
|
||||
@@ -1402,15 +1424,21 @@
|
||||
|
||||
"cheerio/parse5": ["parse5@7.3.0", "", { "dependencies": { "entities": "^6.0.0" } }, "sha512-IInvU7fabl34qmi9gY8XOVxhYyMyuH2xUNpb2q8/Y+7552KlejkRvqvD19nMoUW/uQGGbqNpA6Tufu5FL5BZgw=="],
|
||||
|
||||
"convex/esbuild": ["esbuild@0.27.0", "", { "optionalDependencies": { "@esbuild/aix-ppc64": "0.27.0", "@esbuild/android-arm": "0.27.0", "@esbuild/android-arm64": "0.27.0", "@esbuild/android-x64": "0.27.0", "@esbuild/darwin-arm64": "0.27.0", "@esbuild/darwin-x64": "0.27.0", "@esbuild/freebsd-arm64": "0.27.0", "@esbuild/freebsd-x64": "0.27.0", "@esbuild/linux-arm": "0.27.0", "@esbuild/linux-arm64": "0.27.0", "@esbuild/linux-ia32": "0.27.0", "@esbuild/linux-loong64": "0.27.0", "@esbuild/linux-mips64el": "0.27.0", "@esbuild/linux-ppc64": "0.27.0", "@esbuild/linux-riscv64": "0.27.0", "@esbuild/linux-s390x": "0.27.0", "@esbuild/linux-x64": "0.27.0", "@esbuild/netbsd-arm64": "0.27.0", "@esbuild/netbsd-x64": "0.27.0", "@esbuild/openbsd-arm64": "0.27.0", "@esbuild/openbsd-x64": "0.27.0", "@esbuild/openharmony-arm64": "0.27.0", "@esbuild/sunos-x64": "0.27.0", "@esbuild/win32-arm64": "0.27.0", "@esbuild/win32-ia32": "0.27.0", "@esbuild/win32-x64": "0.27.0" }, "bin": { "esbuild": "bin/esbuild" } }, "sha512-jd0f4NHbD6cALCyGElNpGAOtWxSq46l9X/sWB0Nzd5er4Kz2YTm+Vl0qKFT9KUJvD8+fiO8AvoHhFvEatfVixA=="],
|
||||
"cheerio/undici": ["undici@7.19.2", "", {}, "sha512-4VQSpGEGsWzk0VYxyB/wVX/Q7qf9t5znLRgs0dzszr9w9Fej/8RVNQ+S20vdXSAyra/bJ7ZQfGv6ZMj7UEbzSg=="],
|
||||
|
||||
"data-urls/whatwg-mimetype": ["whatwg-mimetype@5.0.0", "", {}, "sha512-sXcNcHOC51uPGF0P/D4NVtrkjSU2fNsm9iog4ZvZJsL3rjoDAzXZhkm2MWt1y+PUdggKAYVoMAIYcs78wJ51Cw=="],
|
||||
"cheerio/whatwg-mimetype": ["whatwg-mimetype@4.0.0", "", {}, "sha512-QaKxh0eNIi2mE9p2vEdzfagOKHCcj1pJ56EEHGQOVxp8r9/iszLUUV7v89x9O1p/T+NlTM5W7jW6+cz4Fq1YVg=="],
|
||||
|
||||
"clawhub/undici": ["undici@7.19.2", "", {}, "sha512-4VQSpGEGsWzk0VYxyB/wVX/Q7qf9t5znLRgs0dzszr9w9Fej/8RVNQ+S20vdXSAyra/bJ7ZQfGv6ZMj7UEbzSg=="],
|
||||
|
||||
"convex/esbuild": ["esbuild@0.27.0", "", { "optionalDependencies": { "@esbuild/aix-ppc64": "0.27.0", "@esbuild/android-arm": "0.27.0", "@esbuild/android-arm64": "0.27.0", "@esbuild/android-x64": "0.27.0", "@esbuild/darwin-arm64": "0.27.0", "@esbuild/darwin-x64": "0.27.0", "@esbuild/freebsd-arm64": "0.27.0", "@esbuild/freebsd-x64": "0.27.0", "@esbuild/linux-arm": "0.27.0", "@esbuild/linux-arm64": "0.27.0", "@esbuild/linux-ia32": "0.27.0", "@esbuild/linux-loong64": "0.27.0", "@esbuild/linux-mips64el": "0.27.0", "@esbuild/linux-ppc64": "0.27.0", "@esbuild/linux-riscv64": "0.27.0", "@esbuild/linux-s390x": "0.27.0", "@esbuild/linux-x64": "0.27.0", "@esbuild/netbsd-arm64": "0.27.0", "@esbuild/netbsd-x64": "0.27.0", "@esbuild/openbsd-arm64": "0.27.0", "@esbuild/openbsd-x64": "0.27.0", "@esbuild/openharmony-arm64": "0.27.0", "@esbuild/sunos-x64": "0.27.0", "@esbuild/win32-arm64": "0.27.0", "@esbuild/win32-ia32": "0.27.0", "@esbuild/win32-x64": "0.27.0" }, "bin": { "esbuild": "bin/esbuild" } }, "sha512-jd0f4NHbD6cALCyGElNpGAOtWxSq46l9X/sWB0Nzd5er4Kz2YTm+Vl0qKFT9KUJvD8+fiO8AvoHhFvEatfVixA=="],
|
||||
|
||||
"dom-serializer/entities": ["entities@4.5.0", "", {}, "sha512-V0hjH4dGPh9Ao5p0MoRY6BVqtwCjhz6vI5LT8AJ55H+4g9/4vbHx1I54fS0XuclLhDHArPQCiMjDxjaL8fPxhw=="],
|
||||
|
||||
"html-encoding-sniffer/@exodus/bytes": ["@exodus/bytes@1.10.0", "", { "peerDependencies": { "@noble/hashes": "^1.8.0 || ^2.0.0" }, "optionalPeers": ["@noble/hashes"] }, "sha512-tf8YdcbirXdPnJ+Nd4UN1EXnz+IP2DI45YVEr3vvzcVTOyrApkmIB4zvOQVd3XPr7RXnfBtAx+PXImXOIU0Ajg=="],
|
||||
|
||||
"htmlparser2/entities": ["entities@7.0.1", "", {}, "sha512-TWrgLOFUQTH994YUyl1yT4uyavY5nNB5muff+RtWaqNVCAK408b5ZnnbNAUEWLTCpum9w6arT70i1XdQ4UeOPA=="],
|
||||
|
||||
"nitro/h3": ["h3@2.0.1-rc.11", "", { "dependencies": { "rou3": "^0.7.12", "srvx": "^0.10.1" }, "peerDependencies": { "crossws": "^0.4.1" }, "optionalPeers": ["crossws"] }, "sha512-2myzjCqy32c1As9TjZW9fNZXtLqNedjFSrdFy2AjFBQQ3LzrnGoDdFDYfC0tV2e4vcyfJ2Sfo/F6NQhO2Ly/Mw=="],
|
||||
"nitro/undici": ["undici@7.19.2", "", {}, "sha512-4VQSpGEGsWzk0VYxyB/wVX/Q7qf9t5znLRgs0dzszr9w9Fej/8RVNQ+S20vdXSAyra/bJ7ZQfGv6ZMj7UEbzSg=="],
|
||||
|
||||
"parse-entities/@types/unist": ["@types/unist@2.0.11", "", {}, "sha512-CmBKiL6NNo/OqgmMn95Fk9Whlp2mtvIv+KNpQKN2F4SjvrEesubTRWGYSg+BnWZOnlCaSTU1sMpsBOzgbYhnsA=="],
|
||||
|
||||
|
||||
Vendored
+26
@@ -22,27 +22,39 @@ import type * as githubSoulBackupsNode from "../githubSoulBackupsNode.js";
|
||||
import type * as http from "../http.js";
|
||||
import type * as httpApi from "../httpApi.js";
|
||||
import type * as httpApiV1 from "../httpApiV1.js";
|
||||
import type * as httpPreflight from "../httpPreflight.js";
|
||||
import type * as leaderboards from "../leaderboards.js";
|
||||
import type * as lib_access from "../lib/access.js";
|
||||
import type * as lib_apiTokenAuth from "../lib/apiTokenAuth.js";
|
||||
import type * as lib_badges from "../lib/badges.js";
|
||||
import type * as lib_changelog from "../lib/changelog.js";
|
||||
import type * as lib_embeddings from "../lib/embeddings.js";
|
||||
import type * as lib_githubAccount from "../lib/githubAccount.js";
|
||||
import type * as lib_githubBackup from "../lib/githubBackup.js";
|
||||
import type * as lib_githubIdentity from "../lib/githubIdentity.js";
|
||||
import type * as lib_githubImport from "../lib/githubImport.js";
|
||||
import type * as lib_githubSoulBackup from "../lib/githubSoulBackup.js";
|
||||
import type * as lib_httpHeaders from "../lib/httpHeaders.js";
|
||||
import type * as lib_httpRateLimit from "../lib/httpRateLimit.js";
|
||||
import type * as lib_leaderboards from "../lib/leaderboards.js";
|
||||
import type * as lib_moderation from "../lib/moderation.js";
|
||||
import type * as lib_public from "../lib/public.js";
|
||||
import type * as lib_searchText from "../lib/searchText.js";
|
||||
import type * as lib_securityPrompt from "../lib/securityPrompt.js";
|
||||
import type * as lib_skillBackfill from "../lib/skillBackfill.js";
|
||||
import type * as lib_skillPublish from "../lib/skillPublish.js";
|
||||
import type * as lib_skillQuality from "../lib/skillQuality.js";
|
||||
import type * as lib_skillSafety from "../lib/skillSafety.js";
|
||||
import type * as lib_skillStats from "../lib/skillStats.js";
|
||||
import type * as lib_skillSummary from "../lib/skillSummary.js";
|
||||
import type * as lib_skillZip from "../lib/skillZip.js";
|
||||
import type * as lib_skills from "../lib/skills.js";
|
||||
import type * as lib_soulChangelog from "../lib/soulChangelog.js";
|
||||
import type * as lib_soulPublish from "../lib/soulPublish.js";
|
||||
import type * as lib_tokens from "../lib/tokens.js";
|
||||
import type * as lib_userSearch from "../lib/userSearch.js";
|
||||
import type * as lib_webhooks from "../lib/webhooks.js";
|
||||
import type * as llmEval from "../llmEval.js";
|
||||
import type * as maintenance from "../maintenance.js";
|
||||
import type * as rateLimits from "../rateLimits.js";
|
||||
import type * as search from "../search.js";
|
||||
@@ -60,6 +72,7 @@ import type * as telemetry from "../telemetry.js";
|
||||
import type * as tokens from "../tokens.js";
|
||||
import type * as uploads from "../uploads.js";
|
||||
import type * as users from "../users.js";
|
||||
import type * as vt from "../vt.js";
|
||||
import type * as webhooks from "../webhooks.js";
|
||||
|
||||
import type {
|
||||
@@ -83,27 +96,39 @@ declare const fullApi: ApiFromModules<{
|
||||
http: typeof http;
|
||||
httpApi: typeof httpApi;
|
||||
httpApiV1: typeof httpApiV1;
|
||||
httpPreflight: typeof httpPreflight;
|
||||
leaderboards: typeof leaderboards;
|
||||
"lib/access": typeof lib_access;
|
||||
"lib/apiTokenAuth": typeof lib_apiTokenAuth;
|
||||
"lib/badges": typeof lib_badges;
|
||||
"lib/changelog": typeof lib_changelog;
|
||||
"lib/embeddings": typeof lib_embeddings;
|
||||
"lib/githubAccount": typeof lib_githubAccount;
|
||||
"lib/githubBackup": typeof lib_githubBackup;
|
||||
"lib/githubIdentity": typeof lib_githubIdentity;
|
||||
"lib/githubImport": typeof lib_githubImport;
|
||||
"lib/githubSoulBackup": typeof lib_githubSoulBackup;
|
||||
"lib/httpHeaders": typeof lib_httpHeaders;
|
||||
"lib/httpRateLimit": typeof lib_httpRateLimit;
|
||||
"lib/leaderboards": typeof lib_leaderboards;
|
||||
"lib/moderation": typeof lib_moderation;
|
||||
"lib/public": typeof lib_public;
|
||||
"lib/searchText": typeof lib_searchText;
|
||||
"lib/securityPrompt": typeof lib_securityPrompt;
|
||||
"lib/skillBackfill": typeof lib_skillBackfill;
|
||||
"lib/skillPublish": typeof lib_skillPublish;
|
||||
"lib/skillQuality": typeof lib_skillQuality;
|
||||
"lib/skillSafety": typeof lib_skillSafety;
|
||||
"lib/skillStats": typeof lib_skillStats;
|
||||
"lib/skillSummary": typeof lib_skillSummary;
|
||||
"lib/skillZip": typeof lib_skillZip;
|
||||
"lib/skills": typeof lib_skills;
|
||||
"lib/soulChangelog": typeof lib_soulChangelog;
|
||||
"lib/soulPublish": typeof lib_soulPublish;
|
||||
"lib/tokens": typeof lib_tokens;
|
||||
"lib/userSearch": typeof lib_userSearch;
|
||||
"lib/webhooks": typeof lib_webhooks;
|
||||
llmEval: typeof llmEval;
|
||||
maintenance: typeof maintenance;
|
||||
rateLimits: typeof rateLimits;
|
||||
search: typeof search;
|
||||
@@ -121,6 +146,7 @@ declare const fullApi: ApiFromModules<{
|
||||
tokens: typeof tokens;
|
||||
uploads: typeof uploads;
|
||||
users: typeof users;
|
||||
vt: typeof vt;
|
||||
webhooks: typeof webhooks;
|
||||
}>;
|
||||
|
||||
|
||||
@@ -0,0 +1,125 @@
|
||||
import { describe, expect, it, vi } from 'vitest'
|
||||
import type { Id } from './_generated/dataModel'
|
||||
import {
|
||||
BANNED_REAUTH_MESSAGE,
|
||||
DELETED_ACCOUNT_REAUTH_MESSAGE,
|
||||
handleDeletedUserSignIn,
|
||||
} from './auth'
|
||||
|
||||
function makeCtx({
|
||||
user,
|
||||
banRecords,
|
||||
}: {
|
||||
user: { deletedAt?: number; deactivatedAt?: number; purgedAt?: number } | null
|
||||
banRecords?: Array<Record<string, unknown>>
|
||||
}) {
|
||||
const query = {
|
||||
withIndex: vi.fn().mockReturnValue({
|
||||
collect: vi.fn().mockResolvedValue(banRecords ?? []),
|
||||
}),
|
||||
}
|
||||
const ctx = {
|
||||
db: {
|
||||
get: vi.fn().mockResolvedValue(user),
|
||||
patch: vi.fn().mockResolvedValue(null),
|
||||
query: vi.fn().mockReturnValue(query),
|
||||
},
|
||||
}
|
||||
return { ctx, query }
|
||||
}
|
||||
|
||||
describe('handleDeletedUserSignIn', () => {
|
||||
const userId = 'users:1' as Id<'users'>
|
||||
|
||||
it('skips when user not found', async () => {
|
||||
const { ctx } = makeCtx({ user: null })
|
||||
|
||||
await handleDeletedUserSignIn(ctx as never, { userId, existingUserId: userId })
|
||||
|
||||
expect(ctx.db.get).toHaveBeenCalledWith(userId)
|
||||
expect(ctx.db.query).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('skips active users', async () => {
|
||||
const { ctx } = makeCtx({ user: { deletedAt: undefined, deactivatedAt: undefined } })
|
||||
|
||||
await handleDeletedUserSignIn(ctx as never, { userId, existingUserId: userId })
|
||||
|
||||
expect(ctx.db.query).not.toHaveBeenCalled()
|
||||
expect(ctx.db.patch).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('blocks sign-in for deactivated users', async () => {
|
||||
const { ctx } = makeCtx({ user: { deactivatedAt: 123, purgedAt: 123 } })
|
||||
|
||||
await expect(
|
||||
handleDeletedUserSignIn(ctx as never, { userId, existingUserId: userId }),
|
||||
).rejects.toThrow(DELETED_ACCOUNT_REAUTH_MESSAGE)
|
||||
|
||||
expect(ctx.db.query).not.toHaveBeenCalled()
|
||||
expect(ctx.db.patch).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('migrates legacy self-deleted users and blocks sign-in', async () => {
|
||||
const { ctx } = makeCtx({ user: { deletedAt: 123 }, banRecords: [] })
|
||||
|
||||
await expect(
|
||||
handleDeletedUserSignIn(ctx as never, { userId, existingUserId: userId }),
|
||||
).rejects.toThrow(DELETED_ACCOUNT_REAUTH_MESSAGE)
|
||||
|
||||
expect(ctx.db.patch).toHaveBeenCalledWith(userId, {
|
||||
deletedAt: undefined,
|
||||
deactivatedAt: 123,
|
||||
purgedAt: 123,
|
||||
updatedAt: expect.any(Number),
|
||||
})
|
||||
})
|
||||
|
||||
it('migrates legacy users on fresh login (existingUserId is null)', async () => {
|
||||
const { ctx } = makeCtx({ user: { deletedAt: 123 }, banRecords: [] })
|
||||
|
||||
await expect(
|
||||
handleDeletedUserSignIn(ctx as never, { userId, existingUserId: null }),
|
||||
).rejects.toThrow(DELETED_ACCOUNT_REAUTH_MESSAGE)
|
||||
|
||||
expect(ctx.db.patch).toHaveBeenCalledWith(userId, {
|
||||
deletedAt: undefined,
|
||||
deactivatedAt: 123,
|
||||
purgedAt: 123,
|
||||
updatedAt: expect.any(Number),
|
||||
})
|
||||
})
|
||||
|
||||
it('skips mutation when existingUserId does not match userId', async () => {
|
||||
const otherUserId = 'users:999' as Id<'users'>
|
||||
const { ctx } = makeCtx({ user: { deletedAt: 123 } })
|
||||
|
||||
await handleDeletedUserSignIn(ctx as never, { userId, existingUserId: otherUserId })
|
||||
|
||||
expect(ctx.db.query).not.toHaveBeenCalled()
|
||||
expect(ctx.db.patch).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('blocks banned users with a custom message', async () => {
|
||||
const { ctx } = makeCtx({ user: { deletedAt: 123 }, banRecords: [{ action: 'user.ban' }] })
|
||||
|
||||
await expect(
|
||||
handleDeletedUserSignIn(ctx as never, { userId, existingUserId: userId }),
|
||||
).rejects.toThrow(BANNED_REAUTH_MESSAGE)
|
||||
|
||||
expect(ctx.db.patch).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('blocks users auto-banned for malware', async () => {
|
||||
const { ctx } = makeCtx({
|
||||
user: { deletedAt: 123 },
|
||||
banRecords: [{ action: 'user.autoban.malware' }],
|
||||
})
|
||||
|
||||
await expect(
|
||||
handleDeletedUserSignIn(ctx as never, { userId, existingUserId: userId }),
|
||||
).rejects.toThrow(BANNED_REAUTH_MESSAGE)
|
||||
|
||||
expect(ctx.db.patch).not.toHaveBeenCalled()
|
||||
})
|
||||
})
|
||||
@@ -1,5 +1,56 @@
|
||||
import GitHub from '@auth/core/providers/github'
|
||||
import { convexAuth } from '@convex-dev/auth/server'
|
||||
import type { GenericMutationCtx } from 'convex/server'
|
||||
import { ConvexError } from 'convex/values'
|
||||
import type { DataModel, Id } from './_generated/dataModel'
|
||||
|
||||
export const BANNED_REAUTH_MESSAGE =
|
||||
'Your account has been banned for uploading malicious skills. If you believe this is a mistake, please contact security@openclaw.ai and we will work with you to restore access.'
|
||||
export const DELETED_ACCOUNT_REAUTH_MESSAGE =
|
||||
'This account has been permanently deleted and cannot be restored.'
|
||||
|
||||
const REAUTH_BLOCKING_BAN_ACTIONS = new Set(['user.ban', 'user.autoban.malware'])
|
||||
|
||||
export async function handleDeletedUserSignIn(
|
||||
ctx: GenericMutationCtx<DataModel>,
|
||||
args: { userId: Id<'users'>; existingUserId: Id<'users'> | null },
|
||||
) {
|
||||
const user = await ctx.db.get(args.userId)
|
||||
if (!user?.deletedAt && !user?.deactivatedAt) return
|
||||
|
||||
// Verify that the incoming identity matches the existing account to prevent bypass.
|
||||
if (args.existingUserId && args.existingUserId !== args.userId) {
|
||||
return
|
||||
}
|
||||
|
||||
if (user.deactivatedAt) {
|
||||
throw new ConvexError(DELETED_ACCOUNT_REAUTH_MESSAGE)
|
||||
}
|
||||
|
||||
const userId = args.userId
|
||||
const deletedAt = user.deletedAt ?? Date.now()
|
||||
const banRecords = await ctx.db
|
||||
.query('auditLogs')
|
||||
.withIndex('by_target', (q) => q.eq('targetType', 'user').eq('targetId', userId.toString()))
|
||||
.collect()
|
||||
|
||||
const hasBlockingBan = banRecords.some((record) => REAUTH_BLOCKING_BAN_ACTIONS.has(record.action))
|
||||
|
||||
if (hasBlockingBan) {
|
||||
throw new ConvexError(BANNED_REAUTH_MESSAGE)
|
||||
}
|
||||
|
||||
// Migrate legacy self-deleted accounts (stored in deletedAt) to the new
|
||||
// irreversible state and reject sign-in.
|
||||
await ctx.db.patch(userId, {
|
||||
deletedAt: undefined,
|
||||
deactivatedAt: deletedAt,
|
||||
purgedAt: user.purgedAt ?? deletedAt,
|
||||
updatedAt: Date.now(),
|
||||
})
|
||||
|
||||
throw new ConvexError(DELETED_ACCOUNT_REAUTH_MESSAGE)
|
||||
}
|
||||
|
||||
export const { auth, signIn, signOut, store, isAuthenticated } = convexAuth({
|
||||
providers: [
|
||||
@@ -16,4 +67,16 @@ export const { auth, signIn, signOut, store, isAuthenticated } = convexAuth({
|
||||
},
|
||||
}),
|
||||
],
|
||||
callbacks: {
|
||||
/**
|
||||
* Block sign-in for deleted/deactivated users.
|
||||
*
|
||||
* Performance note: This callback runs on every OAuth sign-in, but the
|
||||
* audit log query ONLY executes when a legacy deleted user attempts to sign
|
||||
* in (user.deletedAt is set). For active users, this is a single field check.
|
||||
*/
|
||||
async afterUserCreatedOrUpdated(ctx, args) {
|
||||
await handleDeletedUserSignIn(ctx, args)
|
||||
},
|
||||
},
|
||||
})
|
||||
|
||||
@@ -0,0 +1,52 @@
|
||||
import type { Id } from './_generated/dataModel'
|
||||
import type { MutationCtx } from './_generated/server'
|
||||
import { assertModerator, requireUser } from './lib/access'
|
||||
import { insertStatEvent } from './skillStatEvents'
|
||||
|
||||
export async function addHandler(ctx: MutationCtx, args: { skillId: Id<'skills'>; body: string }) {
|
||||
const { userId } = await requireUser(ctx)
|
||||
const body = args.body.trim()
|
||||
if (!body) throw new Error('Comment body required')
|
||||
|
||||
const skill = await ctx.db.get(args.skillId)
|
||||
if (!skill) throw new Error('Skill not found')
|
||||
|
||||
await ctx.db.insert('comments', {
|
||||
skillId: args.skillId,
|
||||
userId,
|
||||
body,
|
||||
createdAt: Date.now(),
|
||||
softDeletedAt: undefined,
|
||||
deletedBy: undefined,
|
||||
})
|
||||
|
||||
await insertStatEvent(ctx, { skillId: skill._id, kind: 'comment' })
|
||||
}
|
||||
|
||||
export async function removeHandler(ctx: MutationCtx, args: { commentId: Id<'comments'> }) {
|
||||
const { user } = await requireUser(ctx)
|
||||
const comment = await ctx.db.get(args.commentId)
|
||||
if (!comment) throw new Error('Comment not found')
|
||||
if (comment.softDeletedAt) return
|
||||
|
||||
const isOwner = comment.userId === user._id
|
||||
if (!isOwner) {
|
||||
assertModerator(user)
|
||||
}
|
||||
|
||||
await ctx.db.patch(comment._id, {
|
||||
softDeletedAt: Date.now(),
|
||||
deletedBy: user._id,
|
||||
})
|
||||
|
||||
await insertStatEvent(ctx, { skillId: comment.skillId, kind: 'uncomment' })
|
||||
|
||||
await ctx.db.insert('auditLogs', {
|
||||
actorUserId: user._id,
|
||||
action: 'comment.delete',
|
||||
targetType: 'comment',
|
||||
targetId: comment._id,
|
||||
metadata: { skillId: comment.skillId },
|
||||
createdAt: Date.now(),
|
||||
})
|
||||
}
|
||||
@@ -0,0 +1,127 @@
|
||||
/* @vitest-environment node */
|
||||
import { afterEach, describe, expect, it, vi } from 'vitest'
|
||||
|
||||
vi.mock('./lib/access', () => ({
|
||||
assertModerator: vi.fn(),
|
||||
requireUser: vi.fn(),
|
||||
}))
|
||||
|
||||
vi.mock('./skillStatEvents', () => ({
|
||||
insertStatEvent: vi.fn(),
|
||||
}))
|
||||
|
||||
const { requireUser, assertModerator } = await import('./lib/access')
|
||||
const { insertStatEvent } = await import('./skillStatEvents')
|
||||
const { addHandler, removeHandler } = await import('./comments.handlers')
|
||||
|
||||
describe('comments mutations', () => {
|
||||
afterEach(() => {
|
||||
vi.mocked(assertModerator).mockReset()
|
||||
vi.mocked(requireUser).mockReset()
|
||||
vi.mocked(insertStatEvent).mockReset()
|
||||
})
|
||||
|
||||
it('add avoids direct skill patch and records stat event', async () => {
|
||||
vi.mocked(requireUser).mockResolvedValue({
|
||||
userId: 'users:1',
|
||||
user: { _id: 'users:1', role: 'user' },
|
||||
} as never)
|
||||
|
||||
const get = vi.fn().mockResolvedValue({
|
||||
_id: 'skills:1',
|
||||
})
|
||||
const insert = vi.fn()
|
||||
const patch = vi.fn()
|
||||
const ctx = { db: { get, insert, patch } } as never
|
||||
|
||||
await addHandler(ctx, { skillId: 'skills:1', body: ' hello ' } as never)
|
||||
|
||||
expect(patch).not.toHaveBeenCalled()
|
||||
expect(insertStatEvent).toHaveBeenCalledWith(ctx, {
|
||||
skillId: 'skills:1',
|
||||
kind: 'comment',
|
||||
})
|
||||
})
|
||||
|
||||
it('remove keeps comment soft-delete patch free of updatedAt', async () => {
|
||||
vi.mocked(requireUser).mockResolvedValue({
|
||||
userId: 'users:2',
|
||||
user: { _id: 'users:2', role: 'moderator' },
|
||||
} as never)
|
||||
|
||||
const comment = {
|
||||
_id: 'comments:1',
|
||||
skillId: 'skills:1',
|
||||
userId: 'users:2',
|
||||
softDeletedAt: undefined,
|
||||
}
|
||||
const get = vi.fn(async (id: string) => {
|
||||
if (id === 'comments:1') return comment
|
||||
return null
|
||||
})
|
||||
const insert = vi.fn()
|
||||
const patch = vi.fn()
|
||||
const ctx = { db: { get, insert, patch } } as never
|
||||
|
||||
await removeHandler(ctx, { commentId: 'comments:1' } as never)
|
||||
|
||||
expect(patch).toHaveBeenCalledTimes(1)
|
||||
const deletePatch = vi.mocked(patch).mock.calls[0]?.[1] as Record<string, unknown>
|
||||
expect(deletePatch.updatedAt).toBeUndefined()
|
||||
expect(insertStatEvent).toHaveBeenCalledWith(ctx, {
|
||||
skillId: 'skills:1',
|
||||
kind: 'uncomment',
|
||||
})
|
||||
})
|
||||
|
||||
it('remove rejects non-owner without moderator permission', async () => {
|
||||
vi.mocked(requireUser).mockResolvedValue({
|
||||
userId: 'users:3',
|
||||
user: { _id: 'users:3', role: 'user' },
|
||||
} as never)
|
||||
vi.mocked(assertModerator).mockImplementation(() => {
|
||||
throw new Error('Moderator role required')
|
||||
})
|
||||
|
||||
const comment = {
|
||||
_id: 'comments:2',
|
||||
skillId: 'skills:2',
|
||||
userId: 'users:9',
|
||||
softDeletedAt: undefined,
|
||||
}
|
||||
const get = vi.fn().mockResolvedValue(comment)
|
||||
const insert = vi.fn()
|
||||
const patch = vi.fn()
|
||||
const ctx = { db: { get, insert, patch } } as never
|
||||
|
||||
await expect(removeHandler(ctx, { commentId: 'comments:2' } as never)).rejects.toThrow(
|
||||
'Moderator role required',
|
||||
)
|
||||
expect(patch).not.toHaveBeenCalled()
|
||||
expect(insertStatEvent).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('remove no-ops for soft-deleted comment', async () => {
|
||||
vi.mocked(requireUser).mockResolvedValue({
|
||||
userId: 'users:4',
|
||||
user: { _id: 'users:4', role: 'moderator' },
|
||||
} as never)
|
||||
|
||||
const comment = {
|
||||
_id: 'comments:3',
|
||||
skillId: 'skills:3',
|
||||
userId: 'users:4',
|
||||
softDeletedAt: 123,
|
||||
}
|
||||
const get = vi.fn().mockResolvedValue(comment)
|
||||
const insert = vi.fn()
|
||||
const patch = vi.fn()
|
||||
const ctx = { db: { get, insert, patch } } as never
|
||||
|
||||
await removeHandler(ctx, { commentId: 'comments:3' } as never)
|
||||
|
||||
expect(patch).not.toHaveBeenCalled()
|
||||
expect(insert).not.toHaveBeenCalled()
|
||||
expect(insertStatEvent).not.toHaveBeenCalled()
|
||||
})
|
||||
})
|
||||
+12
-63
@@ -1,7 +1,7 @@
|
||||
import { v } from 'convex/values'
|
||||
import type { Doc } from './_generated/dataModel'
|
||||
import { mutation, query } from './_generated/server'
|
||||
import { assertModerator, requireUser } from './lib/access'
|
||||
import { addHandler, removeHandler } from './comments.handlers'
|
||||
import { type PublicUser, toPublicUser } from './lib/public'
|
||||
|
||||
export const listBySkill = query({
|
||||
@@ -14,75 +14,24 @@ export const listBySkill = query({
|
||||
.order('desc')
|
||||
.take(limit)
|
||||
|
||||
const results: Array<{ comment: Doc<'comments'>; user: PublicUser | null }> = []
|
||||
for (const comment of comments) {
|
||||
if (comment.softDeletedAt) continue
|
||||
const user = toPublicUser(await ctx.db.get(comment.userId))
|
||||
results.push({ comment, user })
|
||||
}
|
||||
return results
|
||||
const visible = comments.filter((comment) => !comment.softDeletedAt)
|
||||
return Promise.all(
|
||||
visible.map(
|
||||
async (comment): Promise<{ comment: Doc<'comments'>; user: PublicUser | null }> => ({
|
||||
comment,
|
||||
user: toPublicUser(await ctx.db.get(comment.userId)),
|
||||
}),
|
||||
),
|
||||
)
|
||||
},
|
||||
})
|
||||
|
||||
export const add = mutation({
|
||||
args: { skillId: v.id('skills'), body: v.string() },
|
||||
handler: async (ctx, args) => {
|
||||
const { userId } = await requireUser(ctx)
|
||||
const body = args.body.trim()
|
||||
if (!body) throw new Error('Comment body required')
|
||||
|
||||
const skill = await ctx.db.get(args.skillId)
|
||||
if (!skill) throw new Error('Skill not found')
|
||||
|
||||
await ctx.db.insert('comments', {
|
||||
skillId: args.skillId,
|
||||
userId,
|
||||
body,
|
||||
createdAt: Date.now(),
|
||||
softDeletedAt: undefined,
|
||||
deletedBy: undefined,
|
||||
})
|
||||
|
||||
await ctx.db.patch(skill._id, {
|
||||
stats: { ...skill.stats, comments: skill.stats.comments + 1 },
|
||||
updatedAt: Date.now(),
|
||||
})
|
||||
},
|
||||
handler: addHandler,
|
||||
})
|
||||
|
||||
export const remove = mutation({
|
||||
args: { commentId: v.id('comments') },
|
||||
handler: async (ctx, args) => {
|
||||
const { user } = await requireUser(ctx)
|
||||
const comment = await ctx.db.get(args.commentId)
|
||||
if (!comment) throw new Error('Comment not found')
|
||||
if (comment.softDeletedAt) return
|
||||
|
||||
const isOwner = comment.userId === user._id
|
||||
if (!isOwner) {
|
||||
assertModerator(user)
|
||||
}
|
||||
|
||||
await ctx.db.patch(comment._id, {
|
||||
softDeletedAt: Date.now(),
|
||||
deletedBy: user._id,
|
||||
})
|
||||
|
||||
const skill = await ctx.db.get(comment.skillId)
|
||||
if (skill) {
|
||||
await ctx.db.patch(skill._id, {
|
||||
stats: { ...skill.stats, comments: Math.max(0, skill.stats.comments - 1) },
|
||||
updatedAt: Date.now(),
|
||||
})
|
||||
}
|
||||
|
||||
await ctx.db.insert('auditLogs', {
|
||||
actorUserId: user._id,
|
||||
action: 'comment.delete',
|
||||
targetType: 'comment',
|
||||
targetId: comment._id,
|
||||
metadata: { skillId: comment.skillId },
|
||||
createdAt: Date.now(),
|
||||
})
|
||||
},
|
||||
handler: removeHandler,
|
||||
})
|
||||
|
||||
+17
-1
@@ -26,9 +26,25 @@ crons.interval(
|
||||
|
||||
crons.interval(
|
||||
'skill-stat-events',
|
||||
{ minutes: 15 },
|
||||
{ minutes: 5 },
|
||||
internal.skillStatEvents.processSkillStatEventsAction,
|
||||
{},
|
||||
)
|
||||
|
||||
crons.interval('vt-pending-scans', { minutes: 5 }, internal.vt.pollPendingScans, { batchSize: 100 })
|
||||
|
||||
crons.interval('vt-cache-backfill', { minutes: 30 }, internal.vt.backfillActiveSkillsVTCache, {
|
||||
batchSize: 100,
|
||||
})
|
||||
|
||||
// Daily re-scan of all active skills at 3am UTC
|
||||
crons.daily('vt-daily-rescan', { hourUTC: 3, minuteUTC: 0 }, internal.vt.rescanActiveSkills, {})
|
||||
|
||||
crons.interval(
|
||||
'download-dedupe-prune',
|
||||
{ hours: 24 },
|
||||
internal.downloads.pruneDownloadDedupesInternal,
|
||||
{},
|
||||
)
|
||||
|
||||
export default crons
|
||||
|
||||
@@ -0,0 +1,43 @@
|
||||
import { afterEach, describe, expect, it, vi } from 'vitest'
|
||||
import { __test } from './downloads'
|
||||
|
||||
describe('downloads helpers', () => {
|
||||
afterEach(() => {
|
||||
vi.unstubAllEnvs()
|
||||
})
|
||||
|
||||
it('calculates hour start boundaries', () => {
|
||||
const hour = 3_600_000
|
||||
expect(__test.getHourStart(0)).toBe(0)
|
||||
expect(__test.getHourStart(hour - 1)).toBe(0)
|
||||
expect(__test.getHourStart(hour)).toBe(hour)
|
||||
expect(__test.getHourStart(hour + 1)).toBe(hour)
|
||||
})
|
||||
|
||||
it('prefers user identity when token user exists', () => {
|
||||
const request = new Request('https://example.com', {
|
||||
headers: { 'cf-connecting-ip': '1.2.3.4' },
|
||||
})
|
||||
expect(__test.getDownloadIdentityValue(request, 'users_123')).toBe('user:users_123')
|
||||
})
|
||||
|
||||
it('uses cf-connecting-ip for anonymous identity', () => {
|
||||
const request = new Request('https://example.com', {
|
||||
headers: { 'cf-connecting-ip': '1.2.3.4' },
|
||||
})
|
||||
expect(__test.getDownloadIdentityValue(request, null)).toBe('ip:1.2.3.4')
|
||||
})
|
||||
|
||||
it('falls back to forwarded ip when explicitly enabled', () => {
|
||||
vi.stubEnv('TRUST_FORWARDED_IPS', 'true')
|
||||
const request = new Request('https://example.com', {
|
||||
headers: { 'x-forwarded-for': '10.0.0.1, 10.0.0.2' },
|
||||
})
|
||||
expect(__test.getDownloadIdentityValue(request, null)).toBe('ip:10.0.0.1')
|
||||
})
|
||||
|
||||
it('returns null when user and ip are missing', () => {
|
||||
const request = new Request('https://example.com')
|
||||
expect(__test.getDownloadIdentityValue(request, null)).toBeNull()
|
||||
})
|
||||
})
|
||||
+168
-21
@@ -1,9 +1,18 @@
|
||||
import { v } from 'convex/values'
|
||||
import { zipSync } from 'fflate'
|
||||
import { api } from './_generated/api'
|
||||
import { httpAction, mutation } from './_generated/server'
|
||||
import { api, internal } from './_generated/api'
|
||||
import { httpAction, internalMutation, mutation } from './_generated/server'
|
||||
import { getOptionalApiTokenUserId } from './lib/apiTokenAuth'
|
||||
import { applyRateLimit, getClientIp } from './lib/httpRateLimit'
|
||||
import { corsHeaders, mergeHeaders } from './lib/httpHeaders'
|
||||
import { buildDeterministicZip } from './lib/skillZip'
|
||||
import { hashToken } from './lib/tokens'
|
||||
import { insertStatEvent } from './skillStatEvents'
|
||||
|
||||
const HOUR_MS = 3_600_000
|
||||
const DEDUPE_RETENTION_MS = 7 * 24 * HOUR_MS
|
||||
const PRUNE_BATCH_SIZE = 200
|
||||
const PRUNE_MAX_BATCHES = 50
|
||||
|
||||
export const downloadZip = httpAction(async (ctx, request) => {
|
||||
const url = new URL(request.url)
|
||||
const slug = url.searchParams.get('slug')?.trim().toLowerCase()
|
||||
@@ -11,12 +20,54 @@ export const downloadZip = httpAction(async (ctx, request) => {
|
||||
const tagParam = url.searchParams.get('tag')?.trim()
|
||||
|
||||
if (!slug) {
|
||||
return new Response('Missing slug', { status: 400 })
|
||||
return new Response('Missing slug', {
|
||||
status: 400,
|
||||
headers: corsHeaders(),
|
||||
})
|
||||
}
|
||||
|
||||
const rate = await applyRateLimit(ctx, request, 'download')
|
||||
if (!rate.ok) return rate.response
|
||||
|
||||
const skillResult = await ctx.runQuery(api.skills.getBySlug, { slug })
|
||||
if (!skillResult?.skill) {
|
||||
return new Response('Skill not found', { status: 404 })
|
||||
return new Response('Skill not found', {
|
||||
status: 404,
|
||||
headers: mergeHeaders(rate.headers, corsHeaders()),
|
||||
})
|
||||
}
|
||||
|
||||
// Block downloads based on moderation status.
|
||||
const mod = skillResult.moderationInfo
|
||||
if (mod?.isMalwareBlocked) {
|
||||
return new Response(
|
||||
'Blocked: this skill has been flagged as malicious by VirusTotal and cannot be downloaded.',
|
||||
{
|
||||
status: 403,
|
||||
headers: mergeHeaders(rate.headers, corsHeaders()),
|
||||
},
|
||||
)
|
||||
}
|
||||
if (mod?.isPendingScan) {
|
||||
return new Response(
|
||||
'This skill is pending a security scan by VirusTotal. Please try again in a few minutes.',
|
||||
{
|
||||
status: 423,
|
||||
headers: mergeHeaders(rate.headers, corsHeaders()),
|
||||
},
|
||||
)
|
||||
}
|
||||
if (mod?.isRemoved) {
|
||||
return new Response('This skill has been removed by a moderator.', {
|
||||
status: 410,
|
||||
headers: mergeHeaders(rate.headers, corsHeaders()),
|
||||
})
|
||||
}
|
||||
if (mod?.isHiddenByMod) {
|
||||
return new Response('This skill is currently unavailable.', {
|
||||
status: 403,
|
||||
headers: mergeHeaders(rate.headers, corsHeaders()),
|
||||
})
|
||||
}
|
||||
|
||||
const skill = skillResult.skill
|
||||
@@ -35,44 +86,140 @@ export const downloadZip = httpAction(async (ctx, request) => {
|
||||
}
|
||||
|
||||
if (!version) {
|
||||
return new Response('Version not found', { status: 404 })
|
||||
return new Response('Version not found', {
|
||||
status: 404,
|
||||
headers: mergeHeaders(rate.headers, corsHeaders()),
|
||||
})
|
||||
}
|
||||
if (version.softDeletedAt) {
|
||||
return new Response('Version not available', { status: 410 })
|
||||
return new Response('Version not available', {
|
||||
status: 410,
|
||||
headers: mergeHeaders(rate.headers, corsHeaders()),
|
||||
})
|
||||
}
|
||||
|
||||
const files: Record<string, Uint8Array> = {}
|
||||
const entries: Array<{ path: string; bytes: Uint8Array }> = []
|
||||
for (const file of version.files) {
|
||||
const blob = await ctx.storage.get(file.storageId)
|
||||
if (!blob) continue
|
||||
const buffer = new Uint8Array(await blob.arrayBuffer())
|
||||
files[file.path] = buffer
|
||||
entries.push({ path: file.path, bytes: buffer })
|
||||
}
|
||||
|
||||
const zipData = zipSync(files, { level: 6 })
|
||||
const zipArray = Uint8Array.from(zipData)
|
||||
const zipArray = buildDeterministicZip(entries, {
|
||||
ownerId: String(skill.ownerUserId),
|
||||
slug: skill.slug,
|
||||
version: version.version,
|
||||
publishedAt: version.createdAt,
|
||||
})
|
||||
const zipBlob = new Blob([zipArray], { type: 'application/zip' })
|
||||
|
||||
await ctx.runMutation(api.downloads.increment, { skillId: skill._id })
|
||||
try {
|
||||
const userId = await getOptionalApiTokenUserId(ctx, request)
|
||||
const identity = getDownloadIdentityValue(request, userId ? String(userId) : null)
|
||||
if (identity) {
|
||||
await ctx.runMutation(internal.downloads.recordDownloadInternal, {
|
||||
skillId: skill._id,
|
||||
identityHash: await hashToken(identity),
|
||||
hourStart: getHourStart(Date.now()),
|
||||
})
|
||||
}
|
||||
} catch {
|
||||
// Best-effort metric path; do not fail downloads.
|
||||
}
|
||||
|
||||
return new Response(zipBlob, {
|
||||
status: 200,
|
||||
headers: {
|
||||
'Content-Type': 'application/zip',
|
||||
'Content-Disposition': `attachment; filename="${slug}-${version.version}.zip"`,
|
||||
'Cache-Control': 'private, max-age=60',
|
||||
},
|
||||
headers: mergeHeaders(
|
||||
rate.headers,
|
||||
{
|
||||
'Content-Type': 'application/zip',
|
||||
'Content-Disposition': `attachment; filename="${slug}-${version.version}.zip"`,
|
||||
'Cache-Control': 'private, max-age=60',
|
||||
},
|
||||
corsHeaders(),
|
||||
),
|
||||
})
|
||||
})
|
||||
|
||||
export const increment = mutation({
|
||||
args: { skillId: v.id('skills') },
|
||||
handler: async (ctx, args) => {
|
||||
const skill = await ctx.db.get(args.skillId)
|
||||
if (!skill) return
|
||||
// Skip db.get to avoid adding the skill doc to the read set.
|
||||
// The calling HTTP action already validated the skill exists,
|
||||
// and the stat processor handles deleted skills gracefully.
|
||||
await insertStatEvent(ctx, {
|
||||
skillId: skill._id,
|
||||
skillId: args.skillId,
|
||||
kind: 'download',
|
||||
})
|
||||
},
|
||||
})
|
||||
|
||||
export const recordDownloadInternal = internalMutation({
|
||||
args: {
|
||||
skillId: v.id('skills'),
|
||||
identityHash: v.string(),
|
||||
hourStart: v.number(),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const existing = await ctx.db
|
||||
.query('downloadDedupes')
|
||||
.withIndex('by_skill_identity_hour', (q) =>
|
||||
q
|
||||
.eq('skillId', args.skillId)
|
||||
.eq('identityHash', args.identityHash)
|
||||
.eq('hourStart', args.hourStart),
|
||||
)
|
||||
.unique()
|
||||
if (existing) return
|
||||
|
||||
await ctx.db.insert('downloadDedupes', {
|
||||
skillId: args.skillId,
|
||||
identityHash: args.identityHash,
|
||||
hourStart: args.hourStart,
|
||||
createdAt: Date.now(),
|
||||
})
|
||||
|
||||
await insertStatEvent(ctx, {
|
||||
skillId: args.skillId,
|
||||
kind: 'download',
|
||||
})
|
||||
},
|
||||
})
|
||||
|
||||
export const pruneDownloadDedupesInternal = internalMutation({
|
||||
args: {},
|
||||
handler: async (ctx) => {
|
||||
const cutoff = Date.now() - DEDUPE_RETENTION_MS
|
||||
|
||||
for (let batches = 0; batches < PRUNE_MAX_BATCHES; batches += 1) {
|
||||
const stale = await ctx.db
|
||||
.query('downloadDedupes')
|
||||
.withIndex('by_hour', (q) => q.lt('hourStart', cutoff))
|
||||
.take(PRUNE_BATCH_SIZE)
|
||||
|
||||
if (stale.length === 0) break
|
||||
|
||||
for (const entry of stale) {
|
||||
await ctx.db.delete(entry._id)
|
||||
}
|
||||
|
||||
if (stale.length < PRUNE_BATCH_SIZE) break
|
||||
}
|
||||
},
|
||||
})
|
||||
|
||||
export function getHourStart(timestamp: number) {
|
||||
return Math.floor(timestamp / HOUR_MS) * HOUR_MS
|
||||
}
|
||||
|
||||
export function getDownloadIdentityValue(request: Request, userId: string | null) {
|
||||
if (userId) return `user:${userId}`
|
||||
const ip = getClientIp(request)
|
||||
if (!ip) return null
|
||||
return `ip:${ip}`
|
||||
}
|
||||
|
||||
export const __test = {
|
||||
getHourStart,
|
||||
getDownloadIdentityValue,
|
||||
}
|
||||
|
||||
@@ -78,7 +78,7 @@ export const getGitHubBackupPageInternal = internalQuery({
|
||||
}
|
||||
|
||||
const owner = await ctx.db.get(skill.ownerUserId)
|
||||
if (!owner || owner.deletedAt) {
|
||||
if (!owner || owner.deletedAt || owner.deactivatedAt) {
|
||||
items.push({ kind: 'missingOwner', skillId: skill._id, ownerUserId: skill.ownerUserId })
|
||||
continue
|
||||
}
|
||||
|
||||
@@ -78,7 +78,7 @@ export const getGitHubSoulBackupPageInternal = internalQuery({
|
||||
}
|
||||
|
||||
const owner = await ctx.db.get(soul.ownerUserId)
|
||||
if (!owner || owner.deletedAt) {
|
||||
if (!owner || owner.deletedAt || owner.deactivatedAt) {
|
||||
items.push({ kind: 'missingOwner', soulId: soul._id, ownerUserId: soul.ownerUserId })
|
||||
continue
|
||||
}
|
||||
|
||||
@@ -28,8 +28,11 @@ import {
|
||||
soulsPostRouterV1Http,
|
||||
starsDeleteRouterV1Http,
|
||||
starsPostRouterV1Http,
|
||||
usersListV1Http,
|
||||
usersPostRouterV1Http,
|
||||
whoamiV1Http,
|
||||
} from './httpApiV1'
|
||||
import { preflightHandler } from './httpPreflight'
|
||||
|
||||
const http = httpRouter()
|
||||
|
||||
@@ -101,6 +104,18 @@ http.route({
|
||||
handler: whoamiV1Http,
|
||||
})
|
||||
|
||||
http.route({
|
||||
pathPrefix: `${ApiRoutes.users}/`,
|
||||
method: 'POST',
|
||||
handler: usersPostRouterV1Http,
|
||||
})
|
||||
|
||||
http.route({
|
||||
path: ApiRoutes.users,
|
||||
method: 'GET',
|
||||
handler: usersListV1Http,
|
||||
})
|
||||
|
||||
http.route({
|
||||
path: ApiRoutes.souls,
|
||||
method: 'GET',
|
||||
@@ -131,6 +146,12 @@ http.route({
|
||||
handler: soulsDeleteRouterV1Http,
|
||||
})
|
||||
|
||||
http.route({
|
||||
pathPrefix: '/api/',
|
||||
method: 'OPTIONS',
|
||||
handler: preflightHandler,
|
||||
})
|
||||
|
||||
// TODO: remove legacy /api routes after deprecation window.
|
||||
http.route({
|
||||
path: LegacyApiRoutes.download,
|
||||
|
||||
+15
-8
@@ -11,6 +11,7 @@ import type { Id } from './_generated/dataModel'
|
||||
import type { ActionCtx } from './_generated/server'
|
||||
import { httpAction } from './_generated/server'
|
||||
import { requireApiTokenUser } from './lib/apiTokenAuth'
|
||||
import { corsHeaders, mergeHeaders } from './lib/httpHeaders'
|
||||
import { publishVersionForUser } from './skills'
|
||||
|
||||
type SearchSkillEntry = {
|
||||
@@ -241,20 +242,26 @@ export const cliTelemetrySyncHttp = httpAction(cliTelemetrySyncHandler)
|
||||
function json(value: unknown, status = 200) {
|
||||
return new Response(JSON.stringify(value), {
|
||||
status,
|
||||
headers: {
|
||||
'Content-Type': 'application/json',
|
||||
'Cache-Control': 'no-store',
|
||||
},
|
||||
headers: mergeHeaders(
|
||||
{
|
||||
'Content-Type': 'application/json',
|
||||
'Cache-Control': 'no-store',
|
||||
},
|
||||
corsHeaders(),
|
||||
),
|
||||
})
|
||||
}
|
||||
|
||||
function text(value: string, status: number) {
|
||||
return new Response(value, {
|
||||
status,
|
||||
headers: {
|
||||
'Content-Type': 'text/plain; charset=utf-8',
|
||||
'Cache-Control': 'no-store',
|
||||
},
|
||||
headers: mergeHeaders(
|
||||
{
|
||||
'Content-Type': 'text/plain; charset=utf-8',
|
||||
'Cache-Control': 'no-store',
|
||||
},
|
||||
corsHeaders(),
|
||||
),
|
||||
})
|
||||
}
|
||||
|
||||
|
||||
@@ -3,20 +3,46 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
|
||||
vi.mock('./lib/apiTokenAuth', () => ({
|
||||
requireApiTokenUser: vi.fn(),
|
||||
getOptionalApiTokenUserId: vi.fn(),
|
||||
}))
|
||||
|
||||
vi.mock('./skills', () => ({
|
||||
publishVersionForUser: vi.fn(),
|
||||
}))
|
||||
|
||||
const { requireApiTokenUser } = await import('./lib/apiTokenAuth')
|
||||
const { getOptionalApiTokenUserId, requireApiTokenUser } = await import('./lib/apiTokenAuth')
|
||||
const { publishVersionForUser } = await import('./skills')
|
||||
const { __handlers } = await import('./httpApiV1')
|
||||
|
||||
type ActionCtx = import('./_generated/server').ActionCtx
|
||||
|
||||
type RateLimitArgs = { key: string; limit: number; windowMs: number }
|
||||
|
||||
function isRateLimitArgs(args: unknown): args is RateLimitArgs {
|
||||
if (!args || typeof args !== 'object') return false
|
||||
const value = args as Record<string, unknown>
|
||||
return (
|
||||
typeof value.key === 'string' &&
|
||||
typeof value.limit === 'number' &&
|
||||
typeof value.windowMs === 'number'
|
||||
)
|
||||
}
|
||||
|
||||
function makeCtx(partial: Record<string, unknown>) {
|
||||
return partial as unknown as ActionCtx
|
||||
const partialRunQuery =
|
||||
typeof partial.runQuery === 'function'
|
||||
? (partial.runQuery as (query: unknown, args: Record<string, unknown>) => unknown)
|
||||
: null
|
||||
const runQuery = vi.fn(async (query: unknown, args: Record<string, unknown>) => {
|
||||
if (isRateLimitArgs(args)) return okRate()
|
||||
return partialRunQuery ? await partialRunQuery(query, args) : null
|
||||
})
|
||||
const runMutation =
|
||||
typeof partial.runMutation === 'function'
|
||||
? partial.runMutation
|
||||
: vi.fn().mockResolvedValue(okRate())
|
||||
|
||||
return { ...partial, runQuery, runMutation } as unknown as ActionCtx
|
||||
}
|
||||
|
||||
const okRate = () => ({
|
||||
@@ -34,6 +60,8 @@ const blockedRate = () => ({
|
||||
})
|
||||
|
||||
beforeEach(() => {
|
||||
vi.mocked(getOptionalApiTokenUserId).mockReset()
|
||||
vi.mocked(getOptionalApiTokenUserId).mockResolvedValue(null)
|
||||
vi.mocked(requireApiTokenUser).mockReset()
|
||||
vi.mocked(publishVersionForUser).mockReset()
|
||||
})
|
||||
@@ -123,7 +151,7 @@ describe('httpApiV1 handlers', () => {
|
||||
expect(json.match.version).toBe('1.0.0')
|
||||
})
|
||||
|
||||
it('lists skills with resolved tags', async () => {
|
||||
it('lists skills with resolved tags using batch query', async () => {
|
||||
const runQuery = vi.fn(async (_query: unknown, args: Record<string, unknown>) => {
|
||||
if ('cursor' in args || 'limit' in args) {
|
||||
return {
|
||||
@@ -145,7 +173,10 @@ describe('httpApiV1 handlers', () => {
|
||||
nextCursor: null,
|
||||
}
|
||||
}
|
||||
if ('versionId' in args) return { version: '1.0.0' }
|
||||
// Batch query: versionIds (plural)
|
||||
if ('versionIds' in args) {
|
||||
return [{ _id: 'versions:1', version: '1.0.0', softDeletedAt: undefined }]
|
||||
}
|
||||
return null
|
||||
})
|
||||
const runMutation = vi.fn().mockResolvedValue(okRate())
|
||||
@@ -158,6 +189,209 @@ describe('httpApiV1 handlers', () => {
|
||||
expect(json.items[0].tags.latest).toBe('1.0.0')
|
||||
})
|
||||
|
||||
it('batches tag resolution across multiple skills into single query', async () => {
|
||||
const runQuery = vi.fn(async (_query: unknown, args: Record<string, unknown>) => {
|
||||
if ('cursor' in args || 'limit' in args) {
|
||||
return {
|
||||
items: [
|
||||
{
|
||||
skill: {
|
||||
_id: 'skills:1',
|
||||
slug: 'skill-a',
|
||||
displayName: 'Skill A',
|
||||
summary: 's',
|
||||
tags: { latest: 'versions:1', stable: 'versions:2' },
|
||||
stats: { downloads: 0, stars: 0, versions: 2, comments: 0 },
|
||||
createdAt: 1,
|
||||
updatedAt: 2,
|
||||
},
|
||||
latestVersion: { version: '2.0.0', createdAt: 3, changelog: 'c' },
|
||||
},
|
||||
{
|
||||
skill: {
|
||||
_id: 'skills:2',
|
||||
slug: 'skill-b',
|
||||
displayName: 'Skill B',
|
||||
summary: 's',
|
||||
tags: { latest: 'versions:3' },
|
||||
stats: { downloads: 0, stars: 0, versions: 1, comments: 0 },
|
||||
createdAt: 1,
|
||||
updatedAt: 2,
|
||||
},
|
||||
latestVersion: { version: '1.0.0', createdAt: 3, changelog: 'c' },
|
||||
},
|
||||
],
|
||||
nextCursor: null,
|
||||
}
|
||||
}
|
||||
// Batch query should receive all version IDs from all skills
|
||||
if ('versionIds' in args) {
|
||||
const ids = args.versionIds as string[]
|
||||
expect(ids).toHaveLength(3)
|
||||
expect(ids).toContain('versions:1')
|
||||
expect(ids).toContain('versions:2')
|
||||
expect(ids).toContain('versions:3')
|
||||
return [
|
||||
{ _id: 'versions:1', version: '2.0.0', softDeletedAt: undefined },
|
||||
{ _id: 'versions:2', version: '1.0.0', softDeletedAt: undefined },
|
||||
{ _id: 'versions:3', version: '1.0.0', softDeletedAt: undefined },
|
||||
]
|
||||
}
|
||||
return null
|
||||
})
|
||||
const runMutation = vi.fn().mockResolvedValue(okRate())
|
||||
const response = await __handlers.listSkillsV1Handler(
|
||||
makeCtx({ runQuery, runMutation }),
|
||||
new Request('https://example.com/api/v1/skills'),
|
||||
)
|
||||
expect(response.status).toBe(200)
|
||||
const json = await response.json()
|
||||
// Verify tags are correctly resolved for each skill
|
||||
expect(json.items[0].tags.latest).toBe('2.0.0')
|
||||
expect(json.items[0].tags.stable).toBe('1.0.0')
|
||||
expect(json.items[1].tags.latest).toBe('1.0.0')
|
||||
// Verify batch query was called exactly once (not per-tag)
|
||||
const batchCalls = runQuery.mock.calls.filter(
|
||||
([, args]) => args && 'versionIds' in (args as Record<string, unknown>),
|
||||
)
|
||||
expect(batchCalls).toHaveLength(1)
|
||||
})
|
||||
|
||||
it('lists souls with resolved tags using batch query', async () => {
|
||||
const runQuery = vi.fn(async (_query: unknown, args: Record<string, unknown>) => {
|
||||
if ('cursor' in args || 'limit' in args) {
|
||||
return {
|
||||
items: [
|
||||
{
|
||||
soul: {
|
||||
_id: 'souls:1',
|
||||
slug: 'demo-soul',
|
||||
displayName: 'Demo Soul',
|
||||
summary: 's',
|
||||
tags: { latest: 'soulVersions:1' },
|
||||
stats: { downloads: 0, stars: 0, versions: 1, comments: 0 },
|
||||
createdAt: 1,
|
||||
updatedAt: 2,
|
||||
},
|
||||
latestVersion: { version: '1.0.0', createdAt: 3, changelog: 'c' },
|
||||
},
|
||||
],
|
||||
nextCursor: null,
|
||||
}
|
||||
}
|
||||
if ('versionIds' in args) {
|
||||
return [{ _id: 'soulVersions:1', version: '1.0.0', softDeletedAt: undefined }]
|
||||
}
|
||||
return null
|
||||
})
|
||||
const runMutation = vi.fn().mockResolvedValue(okRate())
|
||||
const response = await __handlers.listSoulsV1Handler(
|
||||
makeCtx({ runQuery, runMutation }),
|
||||
new Request('https://example.com/api/v1/souls?limit=1'),
|
||||
)
|
||||
expect(response.status).toBe(200)
|
||||
const json = await response.json()
|
||||
expect(json.items[0].tags.latest).toBe('1.0.0')
|
||||
})
|
||||
|
||||
it('batches tag resolution across multiple souls into single query', async () => {
|
||||
const runQuery = vi.fn(async (_query: unknown, args: Record<string, unknown>) => {
|
||||
if ('cursor' in args || 'limit' in args) {
|
||||
return {
|
||||
items: [
|
||||
{
|
||||
soul: {
|
||||
_id: 'souls:1',
|
||||
slug: 'soul-a',
|
||||
displayName: 'Soul A',
|
||||
summary: 's',
|
||||
tags: { latest: 'soulVersions:1', stable: 'soulVersions:2' },
|
||||
stats: { downloads: 0, stars: 0, versions: 2, comments: 0 },
|
||||
createdAt: 1,
|
||||
updatedAt: 2,
|
||||
},
|
||||
latestVersion: { version: '2.0.0', createdAt: 3, changelog: 'c' },
|
||||
},
|
||||
{
|
||||
soul: {
|
||||
_id: 'souls:2',
|
||||
slug: 'soul-b',
|
||||
displayName: 'Soul B',
|
||||
summary: 's',
|
||||
tags: { latest: 'soulVersions:3' },
|
||||
stats: { downloads: 0, stars: 0, versions: 1, comments: 0 },
|
||||
createdAt: 1,
|
||||
updatedAt: 2,
|
||||
},
|
||||
latestVersion: { version: '1.0.0', createdAt: 3, changelog: 'c' },
|
||||
},
|
||||
],
|
||||
nextCursor: null,
|
||||
}
|
||||
}
|
||||
if ('versionIds' in args) {
|
||||
const ids = args.versionIds as string[]
|
||||
expect(ids).toHaveLength(3)
|
||||
expect(ids).toContain('soulVersions:1')
|
||||
expect(ids).toContain('soulVersions:2')
|
||||
expect(ids).toContain('soulVersions:3')
|
||||
return [
|
||||
{ _id: 'soulVersions:1', version: '2.0.0', softDeletedAt: undefined },
|
||||
{ _id: 'soulVersions:2', version: '1.0.0', softDeletedAt: undefined },
|
||||
{ _id: 'soulVersions:3', version: '1.0.0', softDeletedAt: undefined },
|
||||
]
|
||||
}
|
||||
return null
|
||||
})
|
||||
const runMutation = vi.fn().mockResolvedValue(okRate())
|
||||
const response = await __handlers.listSoulsV1Handler(
|
||||
makeCtx({ runQuery, runMutation }),
|
||||
new Request('https://example.com/api/v1/souls'),
|
||||
)
|
||||
expect(response.status).toBe(200)
|
||||
const json = await response.json()
|
||||
expect(json.items[0].tags.latest).toBe('2.0.0')
|
||||
expect(json.items[0].tags.stable).toBe('1.0.0')
|
||||
expect(json.items[1].tags.latest).toBe('1.0.0')
|
||||
const batchCalls = runQuery.mock.calls.filter(
|
||||
([, args]) => args && 'versionIds' in (args as Record<string, unknown>),
|
||||
)
|
||||
expect(batchCalls).toHaveLength(1)
|
||||
})
|
||||
|
||||
it('souls get resolves tags using batch query', async () => {
|
||||
const runQuery = vi.fn(async (_query: unknown, args: Record<string, unknown>) => {
|
||||
if ('slug' in args) {
|
||||
return {
|
||||
soul: {
|
||||
_id: 'souls:1',
|
||||
slug: 'demo-soul',
|
||||
displayName: 'Demo Soul',
|
||||
summary: 's',
|
||||
tags: { latest: 'soulVersions:1' },
|
||||
stats: { downloads: 0, stars: 0, versions: 1, comments: 0 },
|
||||
createdAt: 1,
|
||||
updatedAt: 2,
|
||||
},
|
||||
latestVersion: { version: '1.0.0', createdAt: 3, changelog: 'c' },
|
||||
owner: null,
|
||||
}
|
||||
}
|
||||
if ('versionIds' in args) {
|
||||
return [{ _id: 'soulVersions:1', version: '1.0.0', softDeletedAt: undefined }]
|
||||
}
|
||||
return null
|
||||
})
|
||||
const runMutation = vi.fn().mockResolvedValue(okRate())
|
||||
const response = await __handlers.soulsGetRouterV1Handler(
|
||||
makeCtx({ runQuery, runMutation }),
|
||||
new Request('https://example.com/api/v1/souls/demo-soul'),
|
||||
)
|
||||
expect(response.status).toBe(200)
|
||||
const json = await response.json()
|
||||
expect(json.soul.tags.latest).toBe('1.0.0')
|
||||
})
|
||||
|
||||
it('lists skills supports sort aliases', async () => {
|
||||
const checks: Array<[string, string]> = [
|
||||
['rating', 'stars'],
|
||||
@@ -193,6 +427,52 @@ describe('httpApiV1 handlers', () => {
|
||||
expect(response.status).toBe(404)
|
||||
})
|
||||
|
||||
it('get skill returns pending-scan message for owner api token', async () => {
|
||||
vi.mocked(getOptionalApiTokenUserId).mockResolvedValue('users:1' as never)
|
||||
const runQuery = vi.fn(async (_query: unknown, args: Record<string, unknown>) => {
|
||||
if ('slug' in args) {
|
||||
return {
|
||||
_id: 'skills:1',
|
||||
slug: 'demo',
|
||||
ownerUserId: 'users:1',
|
||||
moderationStatus: 'hidden',
|
||||
moderationReason: 'pending.scan',
|
||||
}
|
||||
}
|
||||
return null
|
||||
})
|
||||
const runMutation = vi.fn().mockResolvedValue(okRate())
|
||||
const response = await __handlers.skillsGetRouterV1Handler(
|
||||
makeCtx({ runQuery, runMutation }),
|
||||
new Request('https://example.com/api/v1/skills/demo'),
|
||||
)
|
||||
expect(response.status).toBe(423)
|
||||
expect(await response.text()).toContain('security scan is pending')
|
||||
})
|
||||
|
||||
it('get skill returns undelete hint for owner soft-deleted skill', async () => {
|
||||
vi.mocked(getOptionalApiTokenUserId).mockResolvedValue('users:1' as never)
|
||||
const runQuery = vi.fn(async (_query: unknown, args: Record<string, unknown>) => {
|
||||
if ('slug' in args) {
|
||||
return {
|
||||
_id: 'skills:1',
|
||||
slug: 'demo',
|
||||
ownerUserId: 'users:1',
|
||||
softDeletedAt: 1,
|
||||
moderationStatus: 'hidden',
|
||||
}
|
||||
}
|
||||
return null
|
||||
})
|
||||
const runMutation = vi.fn().mockResolvedValue(okRate())
|
||||
const response = await __handlers.skillsGetRouterV1Handler(
|
||||
makeCtx({ runQuery, runMutation }),
|
||||
new Request('https://example.com/api/v1/skills/demo'),
|
||||
)
|
||||
expect(response.status).toBe(410)
|
||||
expect(await response.text()).toContain('clawhub undelete demo')
|
||||
})
|
||||
|
||||
it('get skill returns payload', async () => {
|
||||
const runQuery = vi.fn(async (_query: unknown, args: Record<string, unknown>) => {
|
||||
if ('slug' in args) {
|
||||
@@ -216,7 +496,10 @@ describe('httpApiV1 handlers', () => {
|
||||
owner: { handle: 'p', displayName: 'Peter', image: null },
|
||||
}
|
||||
}
|
||||
if ('versionId' in args) return { version: '1.0.0' }
|
||||
// Batch query for tag resolution
|
||||
if ('versionIds' in args) {
|
||||
return [{ _id: 'versions:1', version: '1.0.0', softDeletedAt: undefined }]
|
||||
}
|
||||
return null
|
||||
})
|
||||
const runMutation = vi.fn().mockResolvedValue(okRate())
|
||||
@@ -524,6 +807,165 @@ describe('httpApiV1 handlers', () => {
|
||||
expect(response2.status).toBe(200)
|
||||
})
|
||||
|
||||
it('delete/undelete map forbidden/not-found/unknown to 403/404/500', async () => {
|
||||
vi.mocked(requireApiTokenUser).mockResolvedValue({
|
||||
userId: 'users:1',
|
||||
user: { handle: 'p' },
|
||||
} as never)
|
||||
|
||||
const runMutationForbidden = vi.fn(async (_query: unknown, args: Record<string, unknown>) => {
|
||||
if ('key' in args) return okRate()
|
||||
throw new Error('Forbidden')
|
||||
})
|
||||
const forbidden = await __handlers.skillsDeleteRouterV1Handler(
|
||||
makeCtx({ runMutation: runMutationForbidden }),
|
||||
new Request('https://example.com/api/v1/skills/demo', {
|
||||
method: 'DELETE',
|
||||
headers: { Authorization: 'Bearer clh_test' },
|
||||
}),
|
||||
)
|
||||
expect(forbidden.status).toBe(403)
|
||||
expect(await forbidden.text()).toBe('Forbidden')
|
||||
|
||||
vi.mocked(requireApiTokenUser).mockResolvedValue({
|
||||
userId: 'users:1',
|
||||
user: { handle: 'p' },
|
||||
} as never)
|
||||
const runMutationNotFound = vi.fn(async (_query: unknown, args: Record<string, unknown>) => {
|
||||
if ('key' in args) return okRate()
|
||||
throw new Error('Skill not found')
|
||||
})
|
||||
const notFound = await __handlers.skillsPostRouterV1Handler(
|
||||
makeCtx({ runMutation: runMutationNotFound }),
|
||||
new Request('https://example.com/api/v1/skills/demo/undelete', {
|
||||
method: 'POST',
|
||||
headers: { Authorization: 'Bearer clh_test' },
|
||||
}),
|
||||
)
|
||||
expect(notFound.status).toBe(404)
|
||||
expect(await notFound.text()).toBe('Skill not found')
|
||||
|
||||
vi.mocked(requireApiTokenUser).mockResolvedValue({
|
||||
userId: 'users:1',
|
||||
user: { handle: 'p' },
|
||||
} as never)
|
||||
const runMutationUnknown = vi.fn(async (_query: unknown, args: Record<string, unknown>) => {
|
||||
if ('key' in args) return okRate()
|
||||
throw new Error('boom')
|
||||
})
|
||||
const unknown = await __handlers.soulsDeleteRouterV1Handler(
|
||||
makeCtx({ runMutation: runMutationUnknown }),
|
||||
new Request('https://example.com/api/v1/souls/demo-soul', {
|
||||
method: 'DELETE',
|
||||
headers: { Authorization: 'Bearer clh_test' },
|
||||
}),
|
||||
)
|
||||
expect(unknown.status).toBe(500)
|
||||
expect(await unknown.text()).toBe('Internal Server Error')
|
||||
})
|
||||
|
||||
it('ban user requires auth', async () => {
|
||||
vi.mocked(requireApiTokenUser).mockRejectedValueOnce(new Error('Unauthorized'))
|
||||
const runMutation = vi.fn().mockResolvedValue(okRate())
|
||||
const response = await __handlers.usersPostRouterV1Handler(
|
||||
makeCtx({ runMutation }),
|
||||
new Request('https://example.com/api/v1/users/ban', {
|
||||
method: 'POST',
|
||||
headers: { 'content-type': 'application/json' },
|
||||
body: JSON.stringify({ handle: 'demo' }),
|
||||
}),
|
||||
)
|
||||
expect(response.status).toBe(401)
|
||||
})
|
||||
|
||||
it('ban user succeeds with handle', async () => {
|
||||
vi.mocked(requireApiTokenUser).mockResolvedValue({
|
||||
userId: 'users:1',
|
||||
user: { handle: 'p' },
|
||||
} as never)
|
||||
const runQuery = vi.fn().mockResolvedValue({ _id: 'users:2' })
|
||||
const runMutation = vi
|
||||
.fn()
|
||||
.mockResolvedValueOnce(okRate())
|
||||
.mockResolvedValueOnce({ ok: true, alreadyBanned: false, deletedSkills: 2 })
|
||||
const response = await __handlers.usersPostRouterV1Handler(
|
||||
makeCtx({ runQuery, runMutation }),
|
||||
new Request('https://example.com/api/v1/users/ban', {
|
||||
method: 'POST',
|
||||
headers: { 'content-type': 'application/json' },
|
||||
body: JSON.stringify({ handle: 'demo' }),
|
||||
}),
|
||||
)
|
||||
expect(response.status).toBe(200)
|
||||
const json = await response.json()
|
||||
expect(json.deletedSkills).toBe(2)
|
||||
})
|
||||
|
||||
it('ban user forwards reason', async () => {
|
||||
vi.mocked(requireApiTokenUser).mockResolvedValue({
|
||||
userId: 'users:1',
|
||||
user: { handle: 'p' },
|
||||
} as never)
|
||||
const runQuery = vi.fn().mockResolvedValue({ _id: 'users:2' })
|
||||
const runMutation = vi
|
||||
.fn()
|
||||
.mockResolvedValueOnce(okRate())
|
||||
.mockResolvedValueOnce({ ok: true, alreadyBanned: false, deletedSkills: 0 })
|
||||
await __handlers.usersPostRouterV1Handler(
|
||||
makeCtx({ runQuery, runMutation }),
|
||||
new Request('https://example.com/api/v1/users/ban', {
|
||||
method: 'POST',
|
||||
headers: { 'content-type': 'application/json' },
|
||||
body: JSON.stringify({ handle: 'demo', reason: 'malware' }),
|
||||
}),
|
||||
)
|
||||
expect(runMutation).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({
|
||||
actorUserId: 'users:1',
|
||||
targetUserId: 'users:2',
|
||||
reason: 'malware',
|
||||
}),
|
||||
)
|
||||
})
|
||||
|
||||
it('set role requires auth', async () => {
|
||||
vi.mocked(requireApiTokenUser).mockRejectedValueOnce(new Error('Unauthorized'))
|
||||
const runMutation = vi.fn().mockResolvedValue(okRate())
|
||||
const response = await __handlers.usersPostRouterV1Handler(
|
||||
makeCtx({ runMutation }),
|
||||
new Request('https://example.com/api/v1/users/role', {
|
||||
method: 'POST',
|
||||
headers: { 'content-type': 'application/json' },
|
||||
body: JSON.stringify({ handle: 'demo', role: 'moderator' }),
|
||||
}),
|
||||
)
|
||||
expect(response.status).toBe(401)
|
||||
})
|
||||
|
||||
it('set role succeeds with handle', async () => {
|
||||
vi.mocked(requireApiTokenUser).mockResolvedValue({
|
||||
userId: 'users:1',
|
||||
user: { handle: 'p' },
|
||||
} as never)
|
||||
const runQuery = vi.fn().mockResolvedValue({ _id: 'users:2' })
|
||||
const runMutation = vi
|
||||
.fn()
|
||||
.mockResolvedValueOnce(okRate())
|
||||
.mockResolvedValueOnce({ ok: true, role: 'moderator' })
|
||||
const response = await __handlers.usersPostRouterV1Handler(
|
||||
makeCtx({ runQuery, runMutation }),
|
||||
new Request('https://example.com/api/v1/users/role', {
|
||||
method: 'POST',
|
||||
headers: { 'content-type': 'application/json' },
|
||||
body: JSON.stringify({ handle: 'demo', role: 'moderator' }),
|
||||
}),
|
||||
)
|
||||
expect(response.status).toBe(200)
|
||||
const json = await response.json()
|
||||
expect(json.role).toBe('moderator')
|
||||
})
|
||||
|
||||
it('stars require auth', async () => {
|
||||
vi.mocked(requireApiTokenUser).mockRejectedValueOnce(new Error('Unauthorized'))
|
||||
const runMutation = vi.fn().mockResolvedValue(okRate())
|
||||
|
||||
+351
-172
@@ -3,16 +3,12 @@ import { api, internal } from './_generated/api'
|
||||
import type { Doc, Id } from './_generated/dataModel'
|
||||
import type { ActionCtx } from './_generated/server'
|
||||
import { httpAction } from './_generated/server'
|
||||
import { requireApiTokenUser } from './lib/apiTokenAuth'
|
||||
import { hashToken } from './lib/tokens'
|
||||
import { getOptionalApiTokenUserId, requireApiTokenUser } from './lib/apiTokenAuth'
|
||||
import { applyRateLimit, parseBearerToken } from './lib/httpRateLimit'
|
||||
import { corsHeaders, mergeHeaders } from './lib/httpHeaders'
|
||||
import { publishVersionForUser } from './skills'
|
||||
import { publishSoulVersionForUser } from './souls'
|
||||
|
||||
const RATE_LIMIT_WINDOW_MS = 60_000
|
||||
const RATE_LIMITS = {
|
||||
read: { ip: 120, key: 600 },
|
||||
write: { ip: 30, key: 120 },
|
||||
} as const
|
||||
const MAX_RAW_FILE_BYTES = 200 * 1024
|
||||
|
||||
type SearchSkillEntry = {
|
||||
@@ -60,6 +56,14 @@ type GetBySlugResult = {
|
||||
} | null
|
||||
latestVersion: Doc<'skillVersions'> | null
|
||||
owner: { _id: Id<'users'>; handle?: string; displayName?: string; image?: string } | null
|
||||
moderationInfo?: {
|
||||
isPendingScan: boolean
|
||||
isMalwareBlocked: boolean
|
||||
isSuspicious: boolean
|
||||
isHiddenByMod: boolean
|
||||
isRemoved: boolean
|
||||
reason?: string
|
||||
} | null
|
||||
} | null
|
||||
|
||||
type ListVersionsResult = {
|
||||
@@ -196,7 +200,7 @@ async function listSkillsV1Handler(ctx: ActionCtx, request: Request) {
|
||||
const limit = toOptionalNumber(url.searchParams.get('limit'))
|
||||
const rawCursor = url.searchParams.get('cursor')?.trim() || undefined
|
||||
const sort = parseListSort(url.searchParams.get('sort'))
|
||||
const cursor = sort === 'updated' ? rawCursor : undefined
|
||||
const cursor = sort === 'trending' ? undefined : rawCursor
|
||||
|
||||
const result = (await ctx.runQuery(api.skills.listPublicPage, {
|
||||
limit,
|
||||
@@ -204,28 +208,29 @@ async function listSkillsV1Handler(ctx: ActionCtx, request: Request) {
|
||||
sort,
|
||||
})) as ListSkillsResult
|
||||
|
||||
const items = await Promise.all(
|
||||
result.items.map(async (item) => {
|
||||
const tags = await resolveTags(ctx, item.skill.tags)
|
||||
return {
|
||||
slug: item.skill.slug,
|
||||
displayName: item.skill.displayName,
|
||||
summary: item.skill.summary ?? null,
|
||||
tags,
|
||||
stats: item.skill.stats,
|
||||
createdAt: item.skill.createdAt,
|
||||
updatedAt: item.skill.updatedAt,
|
||||
latestVersion: item.latestVersion
|
||||
? {
|
||||
version: item.latestVersion.version,
|
||||
createdAt: item.latestVersion.createdAt,
|
||||
changelog: item.latestVersion.changelog,
|
||||
}
|
||||
: null,
|
||||
}
|
||||
}),
|
||||
// Batch resolve all tags in a single query instead of N queries
|
||||
const resolvedTagsList = await resolveTagsBatch(
|
||||
ctx,
|
||||
result.items.map((item) => item.skill.tags),
|
||||
)
|
||||
|
||||
const items = result.items.map((item, idx) => ({
|
||||
slug: item.skill.slug,
|
||||
displayName: item.skill.displayName,
|
||||
summary: item.skill.summary ?? null,
|
||||
tags: resolvedTagsList[idx],
|
||||
stats: item.skill.stats,
|
||||
createdAt: item.skill.createdAt,
|
||||
updatedAt: item.skill.updatedAt,
|
||||
latestVersion: item.latestVersion
|
||||
? {
|
||||
version: item.latestVersion.version,
|
||||
createdAt: item.latestVersion.createdAt,
|
||||
changelog: item.latestVersion.changelog,
|
||||
}
|
||||
: null,
|
||||
}))
|
||||
|
||||
return json({ items, nextCursor: result.nextCursor ?? null }, 200, rate.headers)
|
||||
}
|
||||
|
||||
@@ -243,9 +248,13 @@ async function skillsGetRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
|
||||
if (segments.length === 1) {
|
||||
const result = (await ctx.runQuery(api.skills.getBySlug, { slug })) as GetBySlugResult
|
||||
if (!result?.skill) return text('Skill not found', 404, rate.headers)
|
||||
if (!result?.skill) {
|
||||
const hidden = await describeOwnerVisibleSkillState(ctx, request, slug)
|
||||
if (hidden) return text(hidden.message, hidden.status, rate.headers)
|
||||
return text('Skill not found', 404, rate.headers)
|
||||
}
|
||||
|
||||
const tags = await resolveTags(ctx, result.skill.tags)
|
||||
const [tags] = await resolveTagsBatch(ctx, [result.skill.tags])
|
||||
return json(
|
||||
{
|
||||
skill: {
|
||||
@@ -272,6 +281,12 @@ async function skillsGetRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
image: result.owner.image ?? null,
|
||||
}
|
||||
: null,
|
||||
moderation: result.moderationInfo
|
||||
? {
|
||||
isSuspicious: result.moderationInfo.isSuspicious ?? false,
|
||||
isMalwareBlocked: result.moderationInfo.isMalwareBlocked ?? false,
|
||||
}
|
||||
: null,
|
||||
},
|
||||
200,
|
||||
rate.headers,
|
||||
@@ -378,7 +393,9 @@ async function skillsGetRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
const isSvg =
|
||||
file.contentType?.toLowerCase().includes('svg') || file.path.toLowerCase().endsWith('.svg')
|
||||
|
||||
const headers = mergeHeaders(rate.headers, {
|
||||
const headers = mergeHeaders(
|
||||
rate.headers,
|
||||
{
|
||||
'Content-Type': file.contentType
|
||||
? `${file.contentType}; charset=utf-8`
|
||||
: 'text/plain; charset=utf-8',
|
||||
@@ -394,13 +411,61 @@ async function skillsGetRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
'Content-Security-Policy':
|
||||
"default-src 'none'; base-uri 'none'; form-action 'none'; frame-ancestors 'none'",
|
||||
...(isSvg ? { 'Content-Disposition': 'attachment' } : {}),
|
||||
})
|
||||
},
|
||||
corsHeaders(),
|
||||
)
|
||||
return new Response(textContent, { status: 200, headers })
|
||||
}
|
||||
|
||||
return text('Not found', 404, rate.headers)
|
||||
}
|
||||
|
||||
async function describeOwnerVisibleSkillState(
|
||||
ctx: ActionCtx,
|
||||
request: Request,
|
||||
slug: string,
|
||||
): Promise<{ status: number; message: string } | null> {
|
||||
const skill = await ctx.runQuery(internal.skills.getSkillBySlugInternal, { slug })
|
||||
if (!skill) return null
|
||||
|
||||
const apiTokenUserId = await getOptionalApiTokenUserId(ctx, request)
|
||||
const isOwner = Boolean(apiTokenUserId && apiTokenUserId === skill.ownerUserId)
|
||||
if (!isOwner) return null
|
||||
|
||||
if (skill.softDeletedAt) {
|
||||
return {
|
||||
status: 410,
|
||||
message: `Skill is hidden/deleted. Run "clawhub undelete ${slug}" to restore it.`,
|
||||
}
|
||||
}
|
||||
|
||||
if (skill.moderationStatus === 'hidden') {
|
||||
if (skill.moderationReason === 'pending.scan' || skill.moderationReason === 'scanner.vt.pending') {
|
||||
return {
|
||||
status: 423,
|
||||
message: 'Skill is hidden while security scan is pending. Try again in a few minutes.',
|
||||
}
|
||||
}
|
||||
if (skill.moderationReason === 'quality.low') {
|
||||
return {
|
||||
status: 403,
|
||||
message:
|
||||
'Skill is hidden by quality checks. Update SKILL.md content or run "clawhub undelete <slug>" after review.',
|
||||
}
|
||||
}
|
||||
return {
|
||||
status: 403,
|
||||
message: `Skill is hidden by moderation${skill.moderationReason ? ` (${skill.moderationReason})` : ''}.`,
|
||||
}
|
||||
}
|
||||
|
||||
if (skill.moderationStatus === 'removed') {
|
||||
return { status: 410, message: 'Skill has been removed by moderation.' }
|
||||
}
|
||||
|
||||
return null
|
||||
}
|
||||
|
||||
export const skillsGetRouterV1Http = httpAction(skillsGetRouterV1Handler)
|
||||
|
||||
async function publishSkillV1Handler(ctx: ActionCtx, request: Request) {
|
||||
@@ -473,8 +538,8 @@ async function skillsPostRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
deleted: false,
|
||||
})
|
||||
return json({ ok: true }, 200, rate.headers)
|
||||
} catch {
|
||||
return text('Unauthorized', 401, rate.headers)
|
||||
} catch (error) {
|
||||
return softDeleteErrorToResponse('skill', error, rate.headers)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -495,8 +560,8 @@ async function skillsDeleteRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
deleted: true,
|
||||
})
|
||||
return json({ ok: true }, 200, rate.headers)
|
||||
} catch {
|
||||
return text('Unauthorized', 401, rate.headers)
|
||||
} catch (error) {
|
||||
return softDeleteErrorToResponse('skill', error, rate.headers)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -526,6 +591,145 @@ async function whoamiV1Handler(ctx: ActionCtx, request: Request) {
|
||||
|
||||
export const whoamiV1Http = httpAction(whoamiV1Handler)
|
||||
|
||||
async function usersPostRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
const rate = await applyRateLimit(ctx, request, 'write')
|
||||
if (!rate.ok) return rate.response
|
||||
|
||||
const segments = getPathSegments(request, '/api/v1/users/')
|
||||
if (segments.length !== 1) {
|
||||
return text('Not found', 404, rate.headers)
|
||||
}
|
||||
const action = segments[0]
|
||||
if (action !== 'ban' && action !== 'role') {
|
||||
return text('Not found', 404, rate.headers)
|
||||
}
|
||||
|
||||
let payload: Record<string, unknown>
|
||||
try {
|
||||
payload = (await request.json()) as Record<string, unknown>
|
||||
} catch {
|
||||
return text('Invalid JSON', 400, rate.headers)
|
||||
}
|
||||
|
||||
const handleRaw = typeof payload.handle === 'string' ? payload.handle.trim() : ''
|
||||
const userIdRaw = typeof payload.userId === 'string' ? payload.userId.trim() : ''
|
||||
const reasonRaw = typeof payload.reason === 'string' ? payload.reason.trim() : ''
|
||||
if (!handleRaw && !userIdRaw) {
|
||||
return text('Missing userId or handle', 400, rate.headers)
|
||||
}
|
||||
|
||||
const roleRaw = typeof payload.role === 'string' ? payload.role.trim().toLowerCase() : ''
|
||||
if (action === 'role' && !roleRaw) {
|
||||
return text('Missing role', 400, rate.headers)
|
||||
}
|
||||
const role = roleRaw === 'user' || roleRaw === 'moderator' || roleRaw === 'admin' ? roleRaw : null
|
||||
if (action === 'role' && !role) {
|
||||
return text('Invalid role', 400, rate.headers)
|
||||
}
|
||||
|
||||
let actorUserId: Id<'users'>
|
||||
try {
|
||||
const auth = await requireApiTokenUser(ctx, request)
|
||||
actorUserId = auth.userId
|
||||
} catch {
|
||||
return text('Unauthorized', 401, rate.headers)
|
||||
}
|
||||
|
||||
let targetUserId: Id<'users'> | null = userIdRaw ? (userIdRaw as Id<'users'>) : null
|
||||
if (!targetUserId) {
|
||||
const handle = handleRaw.toLowerCase()
|
||||
const user = await ctx.runQuery(api.users.getByHandle, { handle })
|
||||
if (!user?._id) return text('User not found', 404, rate.headers)
|
||||
targetUserId = user._id
|
||||
}
|
||||
|
||||
if (action === 'ban') {
|
||||
const reason = reasonRaw.length > 0 ? reasonRaw : undefined
|
||||
if (reason && reason.length > 500) {
|
||||
return text('Reason too long (max 500 chars)', 400, rate.headers)
|
||||
}
|
||||
try {
|
||||
const result = await ctx.runMutation(internal.users.banUserInternal, {
|
||||
actorUserId,
|
||||
targetUserId,
|
||||
reason,
|
||||
})
|
||||
return json(result, 200, rate.headers)
|
||||
} catch (error) {
|
||||
const message = error instanceof Error ? error.message : 'Ban failed'
|
||||
if (message.toLowerCase().includes('forbidden')) {
|
||||
return text('Forbidden', 403, rate.headers)
|
||||
}
|
||||
if (message.toLowerCase().includes('not found')) {
|
||||
return text(message, 404, rate.headers)
|
||||
}
|
||||
return text(message, 400, rate.headers)
|
||||
}
|
||||
}
|
||||
|
||||
if (!role) {
|
||||
return text('Invalid role', 400, rate.headers)
|
||||
}
|
||||
|
||||
try {
|
||||
const result = await ctx.runMutation(internal.users.setRoleInternal, {
|
||||
actorUserId,
|
||||
targetUserId,
|
||||
role,
|
||||
})
|
||||
return json({ ok: true, role: result.role ?? role }, 200, rate.headers)
|
||||
} catch (error) {
|
||||
const message = error instanceof Error ? error.message : 'Role change failed'
|
||||
if (message.toLowerCase().includes('forbidden')) {
|
||||
return text('Forbidden', 403, rate.headers)
|
||||
}
|
||||
if (message.toLowerCase().includes('not found')) {
|
||||
return text(message, 404, rate.headers)
|
||||
}
|
||||
return text(message, 400, rate.headers)
|
||||
}
|
||||
}
|
||||
|
||||
export const usersPostRouterV1Http = httpAction(usersPostRouterV1Handler)
|
||||
|
||||
async function usersListV1Handler(ctx: ActionCtx, request: Request) {
|
||||
const rate = await applyRateLimit(ctx, request, 'read')
|
||||
if (!rate.ok) return rate.response
|
||||
|
||||
const url = new URL(request.url)
|
||||
const limitRaw = toOptionalNumber(url.searchParams.get('limit'))
|
||||
const query = url.searchParams.get('q') ?? url.searchParams.get('query') ?? ''
|
||||
|
||||
let actorUserId: Id<'users'>
|
||||
try {
|
||||
const auth = await requireApiTokenUser(ctx, request)
|
||||
actorUserId = auth.userId
|
||||
} catch {
|
||||
return text('Unauthorized', 401, rate.headers)
|
||||
}
|
||||
|
||||
const limit = Math.min(Math.max(limitRaw ?? 20, 1), 200)
|
||||
try {
|
||||
const result = await ctx.runQuery(internal.users.searchInternal, {
|
||||
actorUserId,
|
||||
query,
|
||||
limit,
|
||||
})
|
||||
return json(result, 200, rate.headers)
|
||||
} catch (error) {
|
||||
const message = error instanceof Error ? error.message : 'User search failed'
|
||||
if (message.toLowerCase().includes('forbidden')) {
|
||||
return text('Forbidden', 403, rate.headers)
|
||||
}
|
||||
if (message.toLowerCase().includes('unauthorized')) {
|
||||
return text('Unauthorized', 401, rate.headers)
|
||||
}
|
||||
return text(message, 400, rate.headers)
|
||||
}
|
||||
}
|
||||
|
||||
export const usersListV1Http = httpAction(usersListV1Handler)
|
||||
|
||||
async function parseMultipartPublish(
|
||||
ctx: ActionCtx,
|
||||
request: Request,
|
||||
@@ -615,113 +819,66 @@ function parsePublishBody(body: unknown) {
|
||||
}
|
||||
}
|
||||
|
||||
async function resolveSoulTags(
|
||||
/**
|
||||
* Batch resolve soul version tags to version strings.
|
||||
* Collects all version IDs, fetches them in a single query, then maps back.
|
||||
* Reduces N sequential queries to 1 batch query.
|
||||
*/
|
||||
async function resolveSoulTagsBatch(
|
||||
ctx: ActionCtx,
|
||||
tags: Record<string, Id<'soulVersions'>>,
|
||||
): Promise<Record<string, string>> {
|
||||
const resolved: Record<string, string> = {}
|
||||
for (const [tag, versionId] of Object.entries(tags)) {
|
||||
const version = await ctx.runQuery(api.souls.getVersionById, { versionId })
|
||||
if (version && !version.softDeletedAt) {
|
||||
resolved[tag] = version.version
|
||||
tagsList: Array<Record<string, Id<'soulVersions'>>>,
|
||||
): Promise<Array<Record<string, string>>> {
|
||||
return resolveVersionTagsBatch(ctx, tagsList, internal.souls.getVersionsByIdsInternal)
|
||||
}
|
||||
|
||||
async function resolveTagsBatch(
|
||||
ctx: ActionCtx,
|
||||
tagsList: Array<Record<string, Id<'skillVersions'>>>,
|
||||
): Promise<Array<Record<string, string>>> {
|
||||
return resolveVersionTagsBatch(ctx, tagsList, internal.skills.getVersionsByIdsInternal)
|
||||
}
|
||||
|
||||
/**
|
||||
* Batch resolve version tags to version strings.
|
||||
* Collects all version IDs, fetches them in a single query, then maps back.
|
||||
*
|
||||
* Notes:
|
||||
* - Uses `internal.*` queries to avoid expanding the public Convex API surface.
|
||||
* - Sorts ids for stable query args (helps caching/log diffs).
|
||||
*/
|
||||
async function resolveVersionTagsBatch<TTable extends 'skillVersions' | 'soulVersions'>(
|
||||
ctx: ActionCtx,
|
||||
tagsList: Array<Record<string, Id<TTable>>>,
|
||||
getVersionsByIdsQuery: unknown,
|
||||
): Promise<Array<Record<string, string>>> {
|
||||
const allVersionIds = new Set<Id<TTable>>()
|
||||
for (const tags of tagsList) {
|
||||
for (const versionId of Object.values(tags)) allVersionIds.add(versionId)
|
||||
}
|
||||
|
||||
if (allVersionIds.size === 0) return tagsList.map(() => ({}))
|
||||
|
||||
const versionIds = [...allVersionIds].sort() as Array<Id<TTable>>
|
||||
const versions =
|
||||
((await ctx.runQuery(getVersionsByIdsQuery as never, { versionIds } as never)) as Array<{
|
||||
_id: Id<TTable>
|
||||
version: string
|
||||
softDeletedAt?: unknown
|
||||
}> | null) ?? []
|
||||
|
||||
const versionMap = new Map<Id<TTable>, string>()
|
||||
for (const v of versions) {
|
||||
if (!v?.softDeletedAt) versionMap.set(v._id, v.version)
|
||||
}
|
||||
|
||||
return tagsList.map((tags) => {
|
||||
const resolved: Record<string, string> = {}
|
||||
for (const [tag, versionId] of Object.entries(tags)) {
|
||||
const version = versionMap.get(versionId)
|
||||
if (version) resolved[tag] = version
|
||||
}
|
||||
}
|
||||
return resolved
|
||||
}
|
||||
|
||||
async function resolveTags(
|
||||
ctx: ActionCtx,
|
||||
tags: Record<string, Id<'skillVersions'>>,
|
||||
): Promise<Record<string, string>> {
|
||||
const resolved: Record<string, string> = {}
|
||||
for (const [tag, versionId] of Object.entries(tags)) {
|
||||
const version = await ctx.runQuery(api.skills.getVersionById, { versionId })
|
||||
if (version && !version.softDeletedAt) {
|
||||
resolved[tag] = version.version
|
||||
}
|
||||
}
|
||||
return resolved
|
||||
}
|
||||
|
||||
async function applyRateLimit(
|
||||
ctx: ActionCtx,
|
||||
request: Request,
|
||||
kind: 'read' | 'write',
|
||||
): Promise<{ ok: true; headers: HeadersInit } | { ok: false; response: Response }> {
|
||||
const ip = getClientIp(request) ?? 'unknown'
|
||||
const ipResult = await checkRateLimit(ctx, `ip:${ip}`, RATE_LIMITS[kind].ip)
|
||||
const token = parseBearerToken(request)
|
||||
const keyResult = token
|
||||
? await checkRateLimit(ctx, `key:${await hashToken(token)}`, RATE_LIMITS[kind].key)
|
||||
: null
|
||||
|
||||
const chosen = pickMostRestrictive(ipResult, keyResult)
|
||||
const headers = rateHeaders(chosen)
|
||||
|
||||
if (!ipResult.allowed || (keyResult && !keyResult.allowed)) {
|
||||
return {
|
||||
ok: false,
|
||||
response: text('Rate limit exceeded', 429, headers),
|
||||
}
|
||||
}
|
||||
|
||||
return { ok: true, headers }
|
||||
}
|
||||
|
||||
type RateLimitResult = {
|
||||
allowed: boolean
|
||||
remaining: number
|
||||
limit: number
|
||||
resetAt: number
|
||||
}
|
||||
|
||||
async function checkRateLimit(
|
||||
ctx: ActionCtx,
|
||||
key: string,
|
||||
limit: number,
|
||||
): Promise<RateLimitResult> {
|
||||
return (await ctx.runMutation(internal.rateLimits.checkRateLimitInternal, {
|
||||
key,
|
||||
limit,
|
||||
windowMs: RATE_LIMIT_WINDOW_MS,
|
||||
})) as RateLimitResult
|
||||
}
|
||||
|
||||
function pickMostRestrictive(primary: RateLimitResult, secondary: RateLimitResult | null) {
|
||||
if (!secondary) return primary
|
||||
if (!primary.allowed) return primary
|
||||
if (!secondary.allowed) return secondary
|
||||
return secondary.remaining < primary.remaining ? secondary : primary
|
||||
}
|
||||
|
||||
function rateHeaders(result: RateLimitResult): HeadersInit {
|
||||
const resetSeconds = Math.ceil(result.resetAt / 1000)
|
||||
return {
|
||||
'X-RateLimit-Limit': String(result.limit),
|
||||
'X-RateLimit-Remaining': String(result.remaining),
|
||||
'X-RateLimit-Reset': String(resetSeconds),
|
||||
...(result.allowed ? {} : { 'Retry-After': String(resetSeconds) }),
|
||||
}
|
||||
}
|
||||
|
||||
function getClientIp(request: Request) {
|
||||
const header =
|
||||
request.headers.get('cf-connecting-ip') ??
|
||||
request.headers.get('x-real-ip') ??
|
||||
request.headers.get('x-forwarded-for') ??
|
||||
request.headers.get('fly-client-ip')
|
||||
if (!header) return null
|
||||
if (header.includes(',')) return header.split(',')[0]?.trim() || null
|
||||
return header.trim()
|
||||
}
|
||||
|
||||
function parseBearerToken(request: Request) {
|
||||
const header = request.headers.get('authorization') ?? request.headers.get('Authorization')
|
||||
if (!header) return null
|
||||
const trimmed = header.trim()
|
||||
if (!trimmed.toLowerCase().startsWith('bearer ')) return null
|
||||
const token = trimmed.slice(7).trim()
|
||||
return token || null
|
||||
return resolved
|
||||
})
|
||||
}
|
||||
|
||||
function json(value: unknown, status = 200, headers?: HeadersInit) {
|
||||
@@ -733,6 +890,7 @@ function json(value: unknown, status = 200, headers?: HeadersInit) {
|
||||
'Cache-Control': 'no-store',
|
||||
},
|
||||
headers,
|
||||
corsHeaders(),
|
||||
),
|
||||
})
|
||||
}
|
||||
@@ -746,14 +904,11 @@ function text(value: string, status: number, headers?: HeadersInit) {
|
||||
'Cache-Control': 'no-store',
|
||||
},
|
||||
headers,
|
||||
corsHeaders(),
|
||||
),
|
||||
})
|
||||
}
|
||||
|
||||
function mergeHeaders(base: HeadersInit, extra?: HeadersInit) {
|
||||
return { ...(base as Record<string, string>), ...(extra as Record<string, string>) }
|
||||
}
|
||||
|
||||
function getPathSegments(request: Request, prefix: string) {
|
||||
const pathname = new URL(request.url).pathname
|
||||
if (!pathname.startsWith(prefix)) return []
|
||||
@@ -823,28 +978,29 @@ async function listSoulsV1Handler(ctx: ActionCtx, request: Request) {
|
||||
cursor,
|
||||
})) as ListSoulsResult
|
||||
|
||||
const items = await Promise.all(
|
||||
result.items.map(async (item) => {
|
||||
const tags = await resolveSoulTags(ctx, item.soul.tags)
|
||||
return {
|
||||
slug: item.soul.slug,
|
||||
displayName: item.soul.displayName,
|
||||
summary: item.soul.summary ?? null,
|
||||
tags,
|
||||
stats: item.soul.stats,
|
||||
createdAt: item.soul.createdAt,
|
||||
updatedAt: item.soul.updatedAt,
|
||||
latestVersion: item.latestVersion
|
||||
? {
|
||||
version: item.latestVersion.version,
|
||||
createdAt: item.latestVersion.createdAt,
|
||||
changelog: item.latestVersion.changelog,
|
||||
}
|
||||
: null,
|
||||
}
|
||||
}),
|
||||
// Batch resolve all tags in a single query instead of N queries
|
||||
const resolvedTagsList = await resolveSoulTagsBatch(
|
||||
ctx,
|
||||
result.items.map((item) => item.soul.tags),
|
||||
)
|
||||
|
||||
const items = result.items.map((item, idx) => ({
|
||||
slug: item.soul.slug,
|
||||
displayName: item.soul.displayName,
|
||||
summary: item.soul.summary ?? null,
|
||||
tags: resolvedTagsList[idx],
|
||||
stats: item.soul.stats,
|
||||
createdAt: item.soul.createdAt,
|
||||
updatedAt: item.soul.updatedAt,
|
||||
latestVersion: item.latestVersion
|
||||
? {
|
||||
version: item.latestVersion.version,
|
||||
createdAt: item.latestVersion.createdAt,
|
||||
changelog: item.latestVersion.changelog,
|
||||
}
|
||||
: null,
|
||||
}))
|
||||
|
||||
return json({ items, nextCursor: result.nextCursor ?? null }, 200, rate.headers)
|
||||
}
|
||||
|
||||
@@ -864,7 +1020,7 @@ async function soulsGetRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
const result = (await ctx.runQuery(api.souls.getBySlug, { slug })) as GetSoulBySlugResult
|
||||
if (!result?.soul) return text('Soul not found', 404, rate.headers)
|
||||
|
||||
const tags = await resolveSoulTags(ctx, result.soul.tags)
|
||||
const [tags] = await resolveSoulTagsBatch(ctx, [result.soul.tags])
|
||||
return json(
|
||||
{
|
||||
soul: {
|
||||
@@ -998,7 +1154,9 @@ async function soulsGetRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
const isSvg =
|
||||
file.contentType?.toLowerCase().includes('svg') || file.path.toLowerCase().endsWith('.svg')
|
||||
|
||||
const headers = mergeHeaders(rate.headers, {
|
||||
const headers = mergeHeaders(
|
||||
rate.headers,
|
||||
{
|
||||
'Content-Type': file.contentType
|
||||
? `${file.contentType}; charset=utf-8`
|
||||
: 'text/plain; charset=utf-8',
|
||||
@@ -1014,7 +1172,9 @@ async function soulsGetRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
'Content-Security-Policy':
|
||||
"default-src 'none'; base-uri 'none'; form-action 'none'; frame-ancestors 'none'",
|
||||
...(isSvg ? { 'Content-Disposition': 'attachment' } : {}),
|
||||
})
|
||||
},
|
||||
corsHeaders(),
|
||||
)
|
||||
return new Response(textContent, { status: 200, headers })
|
||||
}
|
||||
|
||||
@@ -1075,8 +1235,8 @@ async function soulsPostRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
deleted: false,
|
||||
})
|
||||
return json({ ok: true }, 200, rate.headers)
|
||||
} catch {
|
||||
return text('Unauthorized', 401, rate.headers)
|
||||
} catch (error) {
|
||||
return softDeleteErrorToResponse('soul', error, rate.headers)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1097,13 +1257,30 @@ async function soulsDeleteRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
deleted: true,
|
||||
})
|
||||
return json({ ok: true }, 200, rate.headers)
|
||||
} catch {
|
||||
return text('Unauthorized', 401, rate.headers)
|
||||
} catch (error) {
|
||||
return softDeleteErrorToResponse('soul', error, rate.headers)
|
||||
}
|
||||
}
|
||||
|
||||
export const soulsDeleteRouterV1Http = httpAction(soulsDeleteRouterV1Handler)
|
||||
|
||||
function softDeleteErrorToResponse(
|
||||
entity: 'skill' | 'soul',
|
||||
error: unknown,
|
||||
headers: HeadersInit,
|
||||
) {
|
||||
const message = error instanceof Error ? error.message : `${entity} delete failed`
|
||||
const lower = message.toLowerCase()
|
||||
|
||||
if (lower.includes('unauthorized')) return text('Unauthorized', 401, headers)
|
||||
if (lower.includes('forbidden')) return text('Forbidden', 403, headers)
|
||||
if (lower.includes('not found')) return text(message, 404, headers)
|
||||
if (lower.includes('slug required')) return text('Slug required', 400, headers)
|
||||
|
||||
// Unknown: server-side failure. Keep body generic.
|
||||
return text('Internal Server Error', 500, headers)
|
||||
}
|
||||
|
||||
async function starsPostRouterV1Handler(ctx: ActionCtx, request: Request) {
|
||||
const rate = await applyRateLimit(ctx, request, 'write')
|
||||
if (!rate.ok) return rate.response
|
||||
@@ -1169,4 +1346,6 @@ export const __handlers = {
|
||||
starsPostRouterV1Handler,
|
||||
starsDeleteRouterV1Handler,
|
||||
whoamiV1Handler,
|
||||
usersPostRouterV1Handler,
|
||||
usersListV1Handler,
|
||||
}
|
||||
|
||||
@@ -0,0 +1,37 @@
|
||||
import { httpAction } from './_generated/server'
|
||||
import { corsHeaders, mergeHeaders } from './lib/httpHeaders'
|
||||
|
||||
function getHeader(request: Request, name: string) {
|
||||
return request.headers.get(name) ?? request.headers.get(name.toLowerCase())
|
||||
}
|
||||
|
||||
export function buildPreflightHeaders(request: Request) {
|
||||
const requestedHeaders = getHeader(request, 'Access-Control-Request-Headers')?.trim() || null
|
||||
const requestedMethod = getHeader(request, 'Access-Control-Request-Method')?.trim() || null
|
||||
|
||||
const vary = [
|
||||
...(requestedMethod ? ['Access-Control-Request-Method'] : []),
|
||||
...(requestedHeaders ? ['Access-Control-Request-Headers'] : []),
|
||||
].join(', ')
|
||||
|
||||
return mergeHeaders(
|
||||
corsHeaders(),
|
||||
{
|
||||
'Access-Control-Allow-Methods': 'GET, POST, PUT, DELETE, OPTIONS, PATCH, HEAD',
|
||||
'Access-Control-Allow-Headers':
|
||||
requestedHeaders ?? 'Content-Type, Authorization, Digest, X-Clawhub-Version',
|
||||
'Access-Control-Max-Age': '86400',
|
||||
...(vary ? { Vary: vary } : {}),
|
||||
},
|
||||
)
|
||||
}
|
||||
|
||||
export const preflightHandler = httpAction(async (_ctx, request) => {
|
||||
// No cookies/credentials supported; allow any origin for simple browser access.
|
||||
// If we ever add cookie auth, this must switch to reflecting origin + Allow-Credentials.
|
||||
return new Response(null, {
|
||||
status: 204,
|
||||
headers: buildPreflightHeaders(request),
|
||||
})
|
||||
})
|
||||
|
||||
@@ -9,7 +9,7 @@ export async function requireUser(ctx: MutationCtx | QueryCtx) {
|
||||
const userId = await getAuthUserId(ctx)
|
||||
if (!userId) throw new Error('Unauthorized')
|
||||
const user = await ctx.db.get(userId)
|
||||
if (!user || user.deletedAt) throw new Error('User not found')
|
||||
if (!user || user.deletedAt || user.deactivatedAt) throw new Error('User not found')
|
||||
return { userId, user }
|
||||
}
|
||||
|
||||
@@ -17,7 +17,7 @@ export async function requireUserFromAction(ctx: ActionCtx) {
|
||||
const userId = await getAuthUserId(ctx)
|
||||
if (!userId) throw new Error('Unauthorized')
|
||||
const user = await ctx.runQuery(internal.users.getByIdInternal, { userId })
|
||||
if (!user || user.deletedAt) throw new Error('User not found')
|
||||
if (!user || user.deletedAt || user.deactivatedAt) throw new Error('User not found')
|
||||
return { userId, user: user as Doc<'users'> }
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,110 @@
|
||||
import { describe, expect, it, vi } from 'vitest'
|
||||
import { getOptionalApiTokenUserId } from './apiTokenAuth'
|
||||
import { hashToken } from './tokens'
|
||||
|
||||
describe('getOptionalApiTokenUserId', () => {
|
||||
it('returns null when auth header is missing', async () => {
|
||||
const ctx = {
|
||||
runQuery: vi.fn(),
|
||||
}
|
||||
const request = new Request('https://example.com')
|
||||
|
||||
const userId = await getOptionalApiTokenUserId(ctx as never, request)
|
||||
|
||||
expect(userId).toBeNull()
|
||||
expect(ctx.runQuery).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('returns null for unknown token', async () => {
|
||||
const ctx = {
|
||||
runQuery: vi.fn().mockResolvedValue(null),
|
||||
}
|
||||
const request = new Request('https://example.com', {
|
||||
headers: { authorization: 'Bearer token-1' },
|
||||
})
|
||||
|
||||
const userId = await getOptionalApiTokenUserId(ctx as never, request)
|
||||
|
||||
expect(userId).toBeNull()
|
||||
expect(ctx.runQuery).toHaveBeenCalledTimes(1)
|
||||
expect(ctx.runQuery.mock.calls[0]?.[1]).toEqual({
|
||||
tokenHash: await hashToken('token-1'),
|
||||
})
|
||||
})
|
||||
|
||||
it('returns user id when token and user are valid', async () => {
|
||||
const tokenId = 'apiTokens_1'
|
||||
const expectedUserId = 'users_1'
|
||||
const ctx = {
|
||||
runQuery: vi
|
||||
.fn()
|
||||
.mockImplementation(async (_fn, args: { tokenHash?: string; tokenId?: string }) => {
|
||||
if (args.tokenHash) {
|
||||
return { _id: tokenId, revokedAt: undefined }
|
||||
}
|
||||
if (args.tokenId) {
|
||||
return { _id: expectedUserId, deletedAt: undefined }
|
||||
}
|
||||
return null
|
||||
}),
|
||||
}
|
||||
const request = new Request('https://example.com', {
|
||||
headers: { authorization: 'Bearer token-2' },
|
||||
})
|
||||
|
||||
const userId = await getOptionalApiTokenUserId(ctx as never, request)
|
||||
|
||||
expect(userId).toBe(expectedUserId)
|
||||
expect(ctx.runQuery).toHaveBeenCalledTimes(2)
|
||||
})
|
||||
|
||||
it('returns null when user is deleted', async () => {
|
||||
const tokenId = 'apiTokens_2'
|
||||
const ctx = {
|
||||
runQuery: vi
|
||||
.fn()
|
||||
.mockImplementation(async (_fn, args: { tokenHash?: string; tokenId?: string }) => {
|
||||
if (args.tokenHash) {
|
||||
return { _id: tokenId, revokedAt: undefined }
|
||||
}
|
||||
if (args.tokenId) {
|
||||
return { _id: 'users_deleted', deletedAt: Date.now() }
|
||||
}
|
||||
return null
|
||||
}),
|
||||
}
|
||||
const request = new Request('https://example.com', {
|
||||
headers: { authorization: 'Bearer token-3' },
|
||||
})
|
||||
|
||||
const userId = await getOptionalApiTokenUserId(ctx as never, request)
|
||||
|
||||
expect(userId).toBeNull()
|
||||
expect(ctx.runQuery).toHaveBeenCalledTimes(2)
|
||||
})
|
||||
|
||||
it('returns null when user is deactivated', async () => {
|
||||
const tokenId = 'apiTokens_3'
|
||||
const ctx = {
|
||||
runQuery: vi
|
||||
.fn()
|
||||
.mockImplementation(async (_fn, args: { tokenHash?: string; tokenId?: string }) => {
|
||||
if (args.tokenHash) {
|
||||
return { _id: tokenId, revokedAt: undefined }
|
||||
}
|
||||
if (args.tokenId) {
|
||||
return { _id: 'users_deactivated', deactivatedAt: Date.now() }
|
||||
}
|
||||
return null
|
||||
}),
|
||||
}
|
||||
const request = new Request('https://example.com', {
|
||||
headers: { authorization: 'Bearer token-4' },
|
||||
})
|
||||
|
||||
const userId = await getOptionalApiTokenUserId(ctx as never, request)
|
||||
|
||||
expect(userId).toBeNull()
|
||||
expect(ctx.runQuery).toHaveBeenCalledTimes(2)
|
||||
})
|
||||
})
|
||||
@@ -21,12 +21,32 @@ export async function requireApiTokenUser(
|
||||
const user = await ctx.runQuery(internal.tokens.getUserForTokenInternal, {
|
||||
tokenId: apiToken._id,
|
||||
})
|
||||
if (!user || user.deletedAt) throw new ConvexError('Unauthorized')
|
||||
if (!user || user.deletedAt || user.deactivatedAt) throw new ConvexError('Unauthorized')
|
||||
|
||||
await ctx.runMutation(internal.tokens.touchInternal, { tokenId: apiToken._id })
|
||||
return { user, userId: user._id }
|
||||
}
|
||||
|
||||
export async function getOptionalApiTokenUserId(
|
||||
ctx: ActionCtx,
|
||||
request: Request,
|
||||
): Promise<Doc<'users'>['_id'] | null> {
|
||||
const header = request.headers.get('authorization') ?? request.headers.get('Authorization')
|
||||
const token = parseBearerToken(header)
|
||||
if (!token) return null
|
||||
|
||||
const tokenHash = await hashToken(token)
|
||||
const apiToken = await ctx.runQuery(internal.tokens.getByHashInternal, { tokenHash })
|
||||
if (!apiToken || apiToken.revokedAt) return null
|
||||
|
||||
const user = await ctx.runQuery(internal.tokens.getUserForTokenInternal, {
|
||||
tokenId: apiToken._id,
|
||||
})
|
||||
if (!user || user.deletedAt || user.deactivatedAt) return null
|
||||
|
||||
return user._id
|
||||
}
|
||||
|
||||
function parseBearerToken(header: string | null) {
|
||||
if (!header) return null
|
||||
const trimmed = header.trim()
|
||||
|
||||
@@ -0,0 +1,95 @@
|
||||
/* @vitest-environment node */
|
||||
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
import { EMBEDDING_DIMENSIONS, generateEmbedding } from './embeddings'
|
||||
|
||||
const fetchMock = vi.fn<typeof fetch>()
|
||||
const consoleWarnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {})
|
||||
|
||||
const originalFetch = globalThis.fetch
|
||||
const originalApiKey = process.env.OPENAI_API_KEY
|
||||
|
||||
function jsonResponse(payload: unknown, init?: ResponseInit) {
|
||||
return new Response(JSON.stringify(payload), {
|
||||
status: 200,
|
||||
headers: {
|
||||
'content-type': 'application/json',
|
||||
},
|
||||
...init,
|
||||
})
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
fetchMock.mockReset()
|
||||
globalThis.fetch = fetchMock as typeof fetch
|
||||
process.env.OPENAI_API_KEY = 'test-key'
|
||||
consoleWarnSpy.mockClear()
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
globalThis.fetch = originalFetch
|
||||
|
||||
if (originalApiKey === undefined) {
|
||||
delete process.env.OPENAI_API_KEY
|
||||
} else {
|
||||
process.env.OPENAI_API_KEY = originalApiKey
|
||||
}
|
||||
|
||||
vi.useRealTimers()
|
||||
})
|
||||
|
||||
describe('generateEmbedding', () => {
|
||||
it('returns zero embedding when OPENAI_API_KEY is missing', async () => {
|
||||
delete process.env.OPENAI_API_KEY
|
||||
const result = await generateEmbedding('hello world')
|
||||
|
||||
expect(result).toHaveLength(EMBEDDING_DIMENSIONS)
|
||||
expect(result.every((value) => value === 0)).toBe(true)
|
||||
expect(fetchMock).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('retries on 429 responses and then succeeds', async () => {
|
||||
vi.useFakeTimers()
|
||||
fetchMock.mockResolvedValueOnce(new Response('rate limited', { status: 429 }))
|
||||
fetchMock.mockResolvedValueOnce(jsonResponse({ data: [{ embedding: [0.25, 0.75] }] }))
|
||||
|
||||
const promise = generateEmbedding('retry me')
|
||||
await vi.runAllTimersAsync()
|
||||
|
||||
await expect(promise).resolves.toEqual([0.25, 0.75])
|
||||
expect(fetchMock).toHaveBeenCalledTimes(2)
|
||||
})
|
||||
|
||||
it('does not retry non-retryable 4xx responses', async () => {
|
||||
fetchMock.mockResolvedValueOnce(new Response('bad request', { status: 400 }))
|
||||
|
||||
await expect(generateEmbedding('bad')).rejects.toThrow('Embedding failed: bad request')
|
||||
expect(fetchMock).toHaveBeenCalledTimes(1)
|
||||
})
|
||||
|
||||
it('retries on network failures and then succeeds', async () => {
|
||||
vi.useFakeTimers()
|
||||
fetchMock.mockRejectedValueOnce(new TypeError('fetch failed'))
|
||||
fetchMock.mockResolvedValueOnce(jsonResponse({ data: [{ embedding: [1, 2, 3] }] }))
|
||||
|
||||
const promise = generateEmbedding('network retry')
|
||||
await vi.runAllTimersAsync()
|
||||
|
||||
await expect(promise).resolves.toEqual([1, 2, 3])
|
||||
expect(fetchMock).toHaveBeenCalledTimes(2)
|
||||
})
|
||||
|
||||
it('retries timeouts up to max attempts and preserves timeout error', async () => {
|
||||
vi.useFakeTimers()
|
||||
fetchMock.mockRejectedValue(new DOMException('aborted', 'AbortError'))
|
||||
|
||||
const promise = generateEmbedding('always timeout')
|
||||
const rejection = expect(promise).rejects.toThrow(
|
||||
'OpenAI API request timed out after 10 seconds',
|
||||
)
|
||||
await vi.runAllTimersAsync()
|
||||
|
||||
await rejection
|
||||
expect(fetchMock).toHaveBeenCalledTimes(3)
|
||||
})
|
||||
})
|
||||
+127
-20
@@ -1,10 +1,67 @@
|
||||
export const EMBEDDING_MODEL = 'text-embedding-3-small'
|
||||
export const EMBEDDING_DIMENSIONS = 1536
|
||||
|
||||
const EMBEDDING_ENDPOINT = 'https://api.openai.com/v1/embeddings'
|
||||
const REQUEST_TIMEOUT_MS = 10_000
|
||||
const MAX_ATTEMPTS = 3
|
||||
const BASE_RETRY_DELAY_MS = 1_000
|
||||
|
||||
class RetryableEmbeddingError extends Error {
|
||||
constructor(message: string, options?: { cause?: unknown }) {
|
||||
super(message, options)
|
||||
this.name = 'RetryableEmbeddingError'
|
||||
}
|
||||
}
|
||||
|
||||
function emptyEmbedding() {
|
||||
return Array.from({ length: EMBEDDING_DIMENSIONS }, () => 0)
|
||||
}
|
||||
|
||||
function parseRetryAfterMs(retryAfterHeader: string | null) {
|
||||
if (!retryAfterHeader) return null
|
||||
|
||||
const seconds = Number(retryAfterHeader)
|
||||
if (Number.isFinite(seconds) && seconds >= 0) {
|
||||
return Math.round(seconds * 1000)
|
||||
}
|
||||
|
||||
const dateMs = Date.parse(retryAfterHeader)
|
||||
if (Number.isFinite(dateMs)) {
|
||||
return Math.max(0, dateMs - Date.now())
|
||||
}
|
||||
|
||||
return null
|
||||
}
|
||||
|
||||
function getRetryDelayMs(attempt: number, retryAfterMs: number | null) {
|
||||
const exponentialDelayMs = BASE_RETRY_DELAY_MS * 2 ** attempt
|
||||
if (retryAfterMs == null) return exponentialDelayMs
|
||||
return Math.max(exponentialDelayMs, retryAfterMs)
|
||||
}
|
||||
|
||||
function normalizeRetryableNetworkError(error: unknown) {
|
||||
if (!(error instanceof Error)) return null
|
||||
|
||||
if (error.name === 'AbortError') {
|
||||
return new RetryableEmbeddingError(
|
||||
`OpenAI API request timed out after ${Math.floor(REQUEST_TIMEOUT_MS / 1000)} seconds`,
|
||||
{ cause: error },
|
||||
)
|
||||
}
|
||||
|
||||
if (error instanceof TypeError) {
|
||||
return new RetryableEmbeddingError(`Embedding request failed: ${error.message}`, { cause: error })
|
||||
}
|
||||
|
||||
return null
|
||||
}
|
||||
|
||||
function sleep(ms: number) {
|
||||
return new Promise<void>((resolve) => {
|
||||
setTimeout(resolve, ms)
|
||||
})
|
||||
}
|
||||
|
||||
export async function generateEmbedding(text: string) {
|
||||
const apiKey = process.env.OPENAI_API_KEY
|
||||
if (!apiKey) {
|
||||
@@ -12,27 +69,77 @@ export async function generateEmbedding(text: string) {
|
||||
return emptyEmbedding()
|
||||
}
|
||||
|
||||
const response = await fetch('https://api.openai.com/v1/embeddings', {
|
||||
method: 'POST',
|
||||
headers: {
|
||||
'Content-Type': 'application/json',
|
||||
Authorization: `Bearer ${apiKey}`,
|
||||
},
|
||||
body: JSON.stringify({
|
||||
model: EMBEDDING_MODEL,
|
||||
input: text,
|
||||
}),
|
||||
})
|
||||
let lastRetryableError: RetryableEmbeddingError | null = null
|
||||
|
||||
if (!response.ok) {
|
||||
const message = await response.text()
|
||||
throw new Error(`Embedding failed: ${message}`)
|
||||
for (let attempt = 0; attempt < MAX_ATTEMPTS; attempt++) {
|
||||
const controller = new AbortController()
|
||||
const timeoutId = setTimeout(() => controller.abort(), REQUEST_TIMEOUT_MS)
|
||||
|
||||
try {
|
||||
const response = await fetch(EMBEDDING_ENDPOINT, {
|
||||
method: 'POST',
|
||||
headers: {
|
||||
'Content-Type': 'application/json',
|
||||
Authorization: `Bearer ${apiKey}`,
|
||||
},
|
||||
body: JSON.stringify({
|
||||
model: EMBEDDING_MODEL,
|
||||
input: text,
|
||||
}),
|
||||
signal: controller.signal,
|
||||
})
|
||||
|
||||
if (!response.ok) {
|
||||
const message = await response.text()
|
||||
const isRetryableStatus = response.status === 429 || response.status >= 500
|
||||
if (isRetryableStatus) {
|
||||
const retryableError = new RetryableEmbeddingError(
|
||||
`Embedding failed (${response.status}): ${message}`,
|
||||
)
|
||||
lastRetryableError = retryableError
|
||||
|
||||
if (attempt < MAX_ATTEMPTS - 1) {
|
||||
const retryAfterMs = parseRetryAfterMs(response.headers.get('retry-after'))
|
||||
const delayMs = getRetryDelayMs(attempt, retryAfterMs)
|
||||
console.warn(
|
||||
`OpenAI embeddings retry in ${delayMs}ms (attempt ${attempt + 1}/${MAX_ATTEMPTS})`,
|
||||
)
|
||||
await sleep(delayMs)
|
||||
continue
|
||||
}
|
||||
|
||||
throw retryableError
|
||||
}
|
||||
|
||||
throw new Error(`Embedding failed: ${message}`)
|
||||
}
|
||||
|
||||
const payload = (await response.json()) as {
|
||||
data?: Array<{ embedding: number[] }>
|
||||
}
|
||||
const embedding = payload.data?.[0]?.embedding
|
||||
if (!embedding) throw new Error('Embedding missing from response')
|
||||
return embedding
|
||||
} catch (error) {
|
||||
const retryableNetworkError = normalizeRetryableNetworkError(error)
|
||||
if (retryableNetworkError) {
|
||||
lastRetryableError = retryableNetworkError
|
||||
if (attempt < MAX_ATTEMPTS - 1) {
|
||||
const delayMs = getRetryDelayMs(attempt, null)
|
||||
console.warn(
|
||||
`OpenAI embeddings network retry in ${delayMs}ms (attempt ${attempt + 1}/${MAX_ATTEMPTS})`,
|
||||
)
|
||||
await sleep(delayMs)
|
||||
continue
|
||||
}
|
||||
throw retryableNetworkError
|
||||
}
|
||||
|
||||
throw error
|
||||
} finally {
|
||||
clearTimeout(timeoutId)
|
||||
}
|
||||
}
|
||||
|
||||
const payload = (await response.json()) as {
|
||||
data?: Array<{ embedding: number[] }>
|
||||
}
|
||||
const embedding = payload.data?.[0]?.embedding
|
||||
if (!embedding) throw new Error('Embedding missing from response')
|
||||
return embedding
|
||||
throw lastRetryableError ?? new Error('Embedding failed after retries')
|
||||
}
|
||||
|
||||
@@ -0,0 +1,270 @@
|
||||
/* @vitest-environment node */
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
|
||||
import { internal } from '../_generated/api'
|
||||
import { requireGitHubAccountAge } from './githubAccount'
|
||||
|
||||
vi.mock('../_generated/api', () => ({
|
||||
internal: {
|
||||
users: {
|
||||
getByIdInternal: Symbol('getByIdInternal'),
|
||||
getGitHubProviderAccountIdInternal: Symbol('getGitHubProviderAccountIdInternal'),
|
||||
updateGithubMetaInternal: Symbol('updateGithubMetaInternal'),
|
||||
},
|
||||
},
|
||||
}))
|
||||
|
||||
const ONE_DAY_MS = 24 * 60 * 60 * 1000
|
||||
|
||||
describe('requireGitHubAccountAge', () => {
|
||||
beforeEach(() => {
|
||||
vi.restoreAllMocks()
|
||||
vi.unstubAllEnvs()
|
||||
vi.unstubAllGlobals()
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
vi.useRealTimers()
|
||||
vi.unstubAllEnvs()
|
||||
vi.unstubAllGlobals()
|
||||
})
|
||||
|
||||
it('uses cached githubCreatedAt when present', async () => {
|
||||
vi.useFakeTimers()
|
||||
const now = new Date('2026-02-02T12:00:00Z')
|
||||
vi.setSystemTime(now)
|
||||
|
||||
const runQuery = vi.fn().mockResolvedValue({
|
||||
_id: 'users:1',
|
||||
githubCreatedAt: now.getTime() - 10 * ONE_DAY_MS,
|
||||
githubFetchedAt: now.getTime() - ONE_DAY_MS,
|
||||
})
|
||||
const runMutation = vi.fn()
|
||||
const fetchMock = vi.fn()
|
||||
vi.stubGlobal('fetch', fetchMock)
|
||||
|
||||
await requireGitHubAccountAge({ runQuery, runMutation } as never, 'users:1' as never)
|
||||
|
||||
expect(fetchMock).not.toHaveBeenCalled()
|
||||
expect(runMutation).not.toHaveBeenCalled()
|
||||
expect(runQuery).toHaveBeenCalledWith(internal.users.getByIdInternal, { userId: 'users:1' })
|
||||
expect(runQuery).not.toHaveBeenCalledWith(internal.users.getGitHubProviderAccountIdInternal, {
|
||||
userId: 'users:1',
|
||||
})
|
||||
})
|
||||
|
||||
it('rejects deactivated users', async () => {
|
||||
const runQuery = vi.fn().mockResolvedValue({
|
||||
_id: 'users:1',
|
||||
deactivatedAt: Date.now(),
|
||||
})
|
||||
const runMutation = vi.fn()
|
||||
const fetchMock = vi.fn()
|
||||
vi.stubGlobal('fetch', fetchMock)
|
||||
|
||||
await expect(
|
||||
requireGitHubAccountAge({ runQuery, runMutation } as never, 'users:1' as never),
|
||||
).rejects.toThrow(/User not found/i)
|
||||
|
||||
expect(fetchMock).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('rejects accounts younger than 7 days', async () => {
|
||||
vi.useFakeTimers()
|
||||
const now = new Date('2026-02-02T12:00:00Z')
|
||||
vi.setSystemTime(now)
|
||||
|
||||
const runQuery = vi.fn().mockResolvedValue({
|
||||
_id: 'users:1',
|
||||
githubCreatedAt: now.getTime() - 2 * ONE_DAY_MS,
|
||||
githubFetchedAt: now.getTime() - ONE_DAY_MS / 2,
|
||||
})
|
||||
const runMutation = vi.fn()
|
||||
|
||||
await expect(
|
||||
requireGitHubAccountAge({ runQuery, runMutation } as never, 'users:1' as never),
|
||||
).rejects.toThrow(/GitHub account must be at least 7 days old/i)
|
||||
})
|
||||
|
||||
it('fetches githubCreatedAt when missing (by providerAccountId)', async () => {
|
||||
vi.useFakeTimers()
|
||||
const now = new Date('2026-02-02T12:00:00Z')
|
||||
vi.setSystemTime(now)
|
||||
|
||||
const runQuery = vi.fn()
|
||||
.mockResolvedValueOnce({
|
||||
_id: 'users:1',
|
||||
githubCreatedAt: undefined,
|
||||
githubFetchedAt: 0,
|
||||
})
|
||||
.mockResolvedValueOnce('12345')
|
||||
const runMutation = vi.fn()
|
||||
const fetchMock = vi.fn().mockResolvedValue({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
created_at: '2020-01-01T00:00:00Z',
|
||||
}),
|
||||
})
|
||||
vi.stubGlobal('fetch', fetchMock)
|
||||
|
||||
await requireGitHubAccountAge({ runQuery, runMutation } as never, 'users:1' as never)
|
||||
|
||||
expect(fetchMock).toHaveBeenCalledWith(
|
||||
'https://api.github.com/user/12345',
|
||||
expect.objectContaining({
|
||||
headers: expect.objectContaining({ 'User-Agent': 'clawhub' }),
|
||||
}),
|
||||
)
|
||||
expect(runMutation).toHaveBeenCalledWith(internal.users.updateGithubMetaInternal, {
|
||||
userId: 'users:1',
|
||||
githubCreatedAt: Date.parse('2020-01-01T00:00:00Z'),
|
||||
githubFetchedAt: now.getTime(),
|
||||
})
|
||||
})
|
||||
|
||||
it('rejects when providerAccountId is missing', async () => {
|
||||
const runQuery = vi.fn()
|
||||
.mockResolvedValueOnce({
|
||||
_id: 'users:1',
|
||||
githubCreatedAt: undefined,
|
||||
githubFetchedAt: 0,
|
||||
})
|
||||
.mockResolvedValueOnce(null)
|
||||
const runMutation = vi.fn()
|
||||
const fetchMock = vi.fn()
|
||||
vi.stubGlobal('fetch', fetchMock)
|
||||
|
||||
await expect(
|
||||
requireGitHubAccountAge({ runQuery, runMutation } as never, 'users:1' as never),
|
||||
).rejects.toThrow(/GitHub account required/i)
|
||||
|
||||
expect(fetchMock).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('rejects when providerAccountId is invalid', async () => {
|
||||
const runQuery = vi.fn()
|
||||
.mockResolvedValueOnce({
|
||||
_id: 'users:1',
|
||||
githubCreatedAt: undefined,
|
||||
githubFetchedAt: 0,
|
||||
})
|
||||
.mockResolvedValueOnce('abc123')
|
||||
const runMutation = vi.fn()
|
||||
const fetchMock = vi.fn()
|
||||
vi.stubGlobal('fetch', fetchMock)
|
||||
|
||||
await expect(
|
||||
requireGitHubAccountAge({ runQuery, runMutation } as never, 'users:1' as never),
|
||||
).rejects.toThrow(/GitHub account lookup failed/i)
|
||||
|
||||
expect(fetchMock).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('throws when GitHub lookup fails', async () => {
|
||||
const runQuery = vi.fn()
|
||||
.mockResolvedValueOnce({
|
||||
_id: 'users:1',
|
||||
githubCreatedAt: undefined,
|
||||
githubFetchedAt: 0,
|
||||
})
|
||||
.mockResolvedValueOnce('12345')
|
||||
const runMutation = vi.fn()
|
||||
const fetchMock = vi.fn().mockResolvedValue({ ok: false, status: 404 })
|
||||
vi.stubGlobal('fetch', fetchMock)
|
||||
|
||||
await expect(
|
||||
requireGitHubAccountAge({ runQuery, runMutation } as never, 'users:1' as never),
|
||||
).rejects.toThrow(/GitHub account lookup failed/i)
|
||||
})
|
||||
|
||||
it('throws rate-limit error on 403', async () => {
|
||||
const runQuery = vi.fn()
|
||||
.mockResolvedValueOnce({
|
||||
_id: 'users:1',
|
||||
githubCreatedAt: undefined,
|
||||
githubFetchedAt: 0,
|
||||
})
|
||||
.mockResolvedValueOnce('12345')
|
||||
const runMutation = vi.fn()
|
||||
const fetchMock = vi.fn().mockResolvedValue({ ok: false, status: 403 })
|
||||
vi.stubGlobal('fetch', fetchMock)
|
||||
|
||||
await expect(
|
||||
requireGitHubAccountAge({ runQuery, runMutation } as never, 'users:1' as never),
|
||||
).rejects.toThrow(/rate limit exceeded/i)
|
||||
})
|
||||
|
||||
it('throws rate-limit error on 429', async () => {
|
||||
const runQuery = vi.fn()
|
||||
.mockResolvedValueOnce({
|
||||
_id: 'users:1',
|
||||
githubCreatedAt: undefined,
|
||||
githubFetchedAt: 0,
|
||||
})
|
||||
.mockResolvedValueOnce('12345')
|
||||
const runMutation = vi.fn()
|
||||
const fetchMock = vi.fn().mockResolvedValue({ ok: false, status: 429 })
|
||||
vi.stubGlobal('fetch', fetchMock)
|
||||
|
||||
await expect(
|
||||
requireGitHubAccountAge({ runQuery, runMutation } as never, 'users:1' as never),
|
||||
).rejects.toThrow(/rate limit exceeded/i)
|
||||
})
|
||||
|
||||
it('throws when GitHub returns an invalid payload', async () => {
|
||||
const runQuery = vi.fn()
|
||||
.mockResolvedValueOnce({
|
||||
_id: 'users:1',
|
||||
githubCreatedAt: undefined,
|
||||
githubFetchedAt: 0,
|
||||
})
|
||||
.mockResolvedValueOnce('12345')
|
||||
const runMutation = vi.fn()
|
||||
const fetchMock = vi.fn().mockResolvedValue({
|
||||
ok: true,
|
||||
json: async () => ({}),
|
||||
})
|
||||
vi.stubGlobal('fetch', fetchMock)
|
||||
|
||||
await expect(
|
||||
requireGitHubAccountAge({ runQuery, runMutation } as never, 'users:1' as never),
|
||||
).rejects.toThrow(/GitHub account lookup failed/i)
|
||||
})
|
||||
|
||||
it('includes Authorization header when GITHUB_TOKEN is set', async () => {
|
||||
vi.useFakeTimers()
|
||||
const now = new Date('2026-02-02T12:00:00Z')
|
||||
vi.setSystemTime(now)
|
||||
|
||||
vi.stubEnv('GITHUB_TOKEN', 'ghp_test123')
|
||||
|
||||
const runQuery = vi.fn()
|
||||
.mockResolvedValueOnce({
|
||||
_id: 'users:1',
|
||||
githubCreatedAt: undefined,
|
||||
githubFetchedAt: 0,
|
||||
})
|
||||
.mockResolvedValueOnce('12345')
|
||||
const runMutation = vi.fn()
|
||||
const fetchMock = vi.fn().mockResolvedValue({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
created_at: '2020-01-01T00:00:00Z',
|
||||
}),
|
||||
})
|
||||
vi.stubGlobal('fetch', fetchMock)
|
||||
|
||||
await requireGitHubAccountAge({ runQuery, runMutation } as never, 'users:1' as never)
|
||||
|
||||
expect(fetchMock).toHaveBeenCalledWith(
|
||||
'https://api.github.com/user/12345',
|
||||
expect.objectContaining({
|
||||
headers: {
|
||||
'User-Agent': 'clawhub',
|
||||
Authorization: 'Bearer ghp_test123',
|
||||
},
|
||||
}),
|
||||
)
|
||||
})
|
||||
})
|
||||
|
||||
@@ -0,0 +1,73 @@
|
||||
import { ConvexError } from 'convex/values'
|
||||
import { internal } from '../_generated/api'
|
||||
import type { Id } from '../_generated/dataModel'
|
||||
import type { ActionCtx } from '../_generated/server'
|
||||
|
||||
const GITHUB_API = 'https://api.github.com'
|
||||
const MIN_ACCOUNT_AGE_MS = 7 * 24 * 60 * 60 * 1000
|
||||
|
||||
type GitHubUser = {
|
||||
created_at?: string
|
||||
}
|
||||
|
||||
export async function requireGitHubAccountAge(ctx: ActionCtx, userId: Id<'users'>) {
|
||||
const user = await ctx.runQuery(internal.users.getByIdInternal, { userId })
|
||||
if (!user || user.deletedAt || user.deactivatedAt) throw new ConvexError('User not found')
|
||||
|
||||
const now = Date.now()
|
||||
let createdAt = user.githubCreatedAt ?? null
|
||||
|
||||
if (!createdAt) {
|
||||
const providerAccountId = await ctx.runQuery(internal.users.getGitHubProviderAccountIdInternal, {
|
||||
userId,
|
||||
})
|
||||
if (!providerAccountId) {
|
||||
// Invariant: GitHub is our only auth provider, so this should never happen.
|
||||
throw new ConvexError('GitHub account required')
|
||||
}
|
||||
if (!/^[0-9]+$/.test(providerAccountId)) {
|
||||
throw new ConvexError('GitHub account lookup failed')
|
||||
}
|
||||
|
||||
const headers: Record<string, string> = { 'User-Agent': 'clawhub' }
|
||||
const token = process.env.GITHUB_TOKEN
|
||||
if (token) {
|
||||
headers.Authorization = `Bearer ${token}`
|
||||
}
|
||||
|
||||
// Fetch by immutable GitHub numeric ID to avoid username swap attacks entirely.
|
||||
const response = await fetch(`${GITHUB_API}/user/${providerAccountId}`, {
|
||||
headers,
|
||||
})
|
||||
if (!response.ok) {
|
||||
if (response.status === 403 || response.status === 429) {
|
||||
throw new ConvexError('GitHub API rate limit exceeded — please try again in a few minutes')
|
||||
}
|
||||
throw new ConvexError('GitHub account lookup failed')
|
||||
}
|
||||
|
||||
const payload = (await response.json()) as GitHubUser
|
||||
const parsed = payload.created_at ? Date.parse(payload.created_at) : Number.NaN
|
||||
if (!Number.isFinite(parsed)) throw new ConvexError('GitHub account lookup failed')
|
||||
|
||||
createdAt = parsed
|
||||
await ctx.runMutation(internal.users.updateGithubMetaInternal, {
|
||||
userId,
|
||||
githubCreatedAt: createdAt,
|
||||
githubFetchedAt: now,
|
||||
})
|
||||
}
|
||||
|
||||
if (!createdAt) throw new ConvexError('GitHub account lookup failed')
|
||||
|
||||
const ageMs = now - createdAt
|
||||
if (ageMs < MIN_ACCOUNT_AGE_MS) {
|
||||
const remainingMs = MIN_ACCOUNT_AGE_MS - ageMs
|
||||
const remainingDays = Math.max(1, Math.ceil(remainingMs / (24 * 60 * 60 * 1000)))
|
||||
throw new ConvexError(
|
||||
`GitHub account must be at least 7 days old to upload skills. Try again in ${remainingDays} day${
|
||||
remainingDays === 1 ? '' : 's'
|
||||
}.`,
|
||||
)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,19 @@
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import { canHealSkillOwnershipByGitHubProviderAccountId } from './githubIdentity'
|
||||
|
||||
describe('canHealSkillOwnershipByGitHubProviderAccountId', () => {
|
||||
it('denies when either providerAccountId is missing', () => {
|
||||
expect(canHealSkillOwnershipByGitHubProviderAccountId(undefined, undefined)).toBe(false)
|
||||
expect(canHealSkillOwnershipByGitHubProviderAccountId('123', undefined)).toBe(false)
|
||||
expect(canHealSkillOwnershipByGitHubProviderAccountId(undefined, '123')).toBe(false)
|
||||
expect(canHealSkillOwnershipByGitHubProviderAccountId(null, '123')).toBe(false)
|
||||
})
|
||||
|
||||
it('denies when providerAccountId differs', () => {
|
||||
expect(canHealSkillOwnershipByGitHubProviderAccountId('123', '456')).toBe(false)
|
||||
})
|
||||
|
||||
it('allows when providerAccountId matches', () => {
|
||||
expect(canHealSkillOwnershipByGitHubProviderAccountId('123', '123')).toBe(true)
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,22 @@
|
||||
import type { Id } from '../_generated/dataModel'
|
||||
import type { QueryCtx } from '../_generated/server'
|
||||
|
||||
export function canHealSkillOwnershipByGitHubProviderAccountId(
|
||||
ownerProviderAccountId: string | null | undefined,
|
||||
callerProviderAccountId: string | null | undefined,
|
||||
) {
|
||||
// Security invariant: missing identity must never grant ownership.
|
||||
if (!ownerProviderAccountId || !callerProviderAccountId) return false
|
||||
return ownerProviderAccountId === callerProviderAccountId
|
||||
}
|
||||
|
||||
export async function getGitHubProviderAccountId(
|
||||
ctx: Pick<QueryCtx, 'db'>,
|
||||
userId: Id<'users'>,
|
||||
): Promise<string | null> {
|
||||
const account = await ctx.db
|
||||
.query('authAccounts')
|
||||
.withIndex('userIdAndProvider', (q) => q.eq('userId', userId).eq('provider', 'github'))
|
||||
.unique()
|
||||
return account?.providerAccountId ?? null
|
||||
}
|
||||
@@ -0,0 +1,19 @@
|
||||
function toHeaderRecord(init?: HeadersInit): Record<string, string> {
|
||||
if (!init) return {}
|
||||
if (init instanceof Headers) return Object.fromEntries(init.entries())
|
||||
if (Array.isArray(init)) return Object.fromEntries(init)
|
||||
return { ...(init as Record<string, string>) }
|
||||
}
|
||||
|
||||
export function mergeHeaders(...inits: Array<HeadersInit | undefined>): Record<string, string> {
|
||||
const out: Record<string, string> = {}
|
||||
for (const init of inits) {
|
||||
Object.assign(out, toHeaderRecord(init))
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
export function corsHeaders(origin: string = '*'): Record<string, string> {
|
||||
return { 'Access-Control-Allow-Origin': origin }
|
||||
}
|
||||
|
||||
@@ -0,0 +1,46 @@
|
||||
/* @vitest-environment node */
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import { getClientIp } from './httpRateLimit'
|
||||
|
||||
describe('getClientIp', () => {
|
||||
it('uses forwarded headers by default when cf-connecting-ip is missing', () => {
|
||||
const request = new Request('https://example.com', {
|
||||
headers: {
|
||||
'x-forwarded-for': '203.0.113.9',
|
||||
},
|
||||
})
|
||||
delete process.env.TRUST_FORWARDED_IPS
|
||||
expect(getClientIp(request)).toBe('203.0.113.9')
|
||||
})
|
||||
|
||||
it('can disable forwarded headers explicitly', () => {
|
||||
const request = new Request('https://example.com', {
|
||||
headers: {
|
||||
'x-forwarded-for': '203.0.113.9',
|
||||
},
|
||||
})
|
||||
process.env.TRUST_FORWARDED_IPS = 'false'
|
||||
expect(getClientIp(request)).toBeNull()
|
||||
delete process.env.TRUST_FORWARDED_IPS
|
||||
})
|
||||
|
||||
it('returns first ip from cf-connecting-ip', () => {
|
||||
const request = new Request('https://example.com', {
|
||||
headers: {
|
||||
'cf-connecting-ip': '203.0.113.1, 198.51.100.2',
|
||||
},
|
||||
})
|
||||
expect(getClientIp(request)).toBe('203.0.113.1')
|
||||
})
|
||||
|
||||
it('uses forwarded headers when opt-in enabled', () => {
|
||||
const request = new Request('https://example.com', {
|
||||
headers: {
|
||||
'x-forwarded-for': '203.0.113.9, 198.51.100.2',
|
||||
},
|
||||
})
|
||||
process.env.TRUST_FORWARDED_IPS = 'true'
|
||||
expect(getClientIp(request)).toBe('203.0.113.9')
|
||||
delete process.env.TRUST_FORWARDED_IPS
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,162 @@
|
||||
import { internal } from '../_generated/api'
|
||||
import type { ActionCtx } from '../_generated/server'
|
||||
import { corsHeaders, mergeHeaders } from './httpHeaders'
|
||||
import { hashToken } from './tokens'
|
||||
|
||||
const RATE_LIMIT_WINDOW_MS = 60_000
|
||||
export const RATE_LIMITS = {
|
||||
read: { ip: 120, key: 600 },
|
||||
write: { ip: 30, key: 120 },
|
||||
download: { ip: 20, key: 120 },
|
||||
} as const
|
||||
|
||||
type RateLimitResult = {
|
||||
allowed: boolean
|
||||
remaining: number
|
||||
limit: number
|
||||
resetAt: number
|
||||
}
|
||||
|
||||
export async function applyRateLimit(
|
||||
ctx: ActionCtx,
|
||||
request: Request,
|
||||
kind: keyof typeof RATE_LIMITS,
|
||||
): Promise<{ ok: true; headers: HeadersInit } | { ok: false; response: Response }> {
|
||||
const ip = getClientIp(request) ?? 'unknown'
|
||||
const ipResult = await checkRateLimit(ctx, `ip:${ip}`, RATE_LIMITS[kind].ip)
|
||||
const token = parseBearerToken(request)
|
||||
const keyResult = token
|
||||
? await checkRateLimit(ctx, `key:${await hashToken(token)}`, RATE_LIMITS[kind].key)
|
||||
: null
|
||||
|
||||
const chosen = pickMostRestrictive(ipResult, keyResult)
|
||||
const headers = rateHeaders(chosen)
|
||||
|
||||
if (!ipResult.allowed || (keyResult && !keyResult.allowed)) {
|
||||
return {
|
||||
ok: false,
|
||||
response: new Response('Rate limit exceeded', {
|
||||
status: 429,
|
||||
headers: mergeHeaders(
|
||||
{
|
||||
'Content-Type': 'text/plain; charset=utf-8',
|
||||
'Cache-Control': 'no-store',
|
||||
},
|
||||
headers,
|
||||
corsHeaders(),
|
||||
),
|
||||
}),
|
||||
}
|
||||
}
|
||||
|
||||
return { ok: true, headers }
|
||||
}
|
||||
|
||||
export function getClientIp(request: Request) {
|
||||
const cfHeader = request.headers.get('cf-connecting-ip')
|
||||
if (cfHeader) return splitFirstIp(cfHeader)
|
||||
|
||||
if (!shouldTrustForwardedIps()) return null
|
||||
|
||||
const forwarded =
|
||||
request.headers.get('x-real-ip') ??
|
||||
request.headers.get('x-forwarded-for') ??
|
||||
request.headers.get('fly-client-ip')
|
||||
|
||||
return splitFirstIp(forwarded)
|
||||
}
|
||||
|
||||
async function checkRateLimit(
|
||||
ctx: ActionCtx,
|
||||
key: string,
|
||||
limit: number,
|
||||
): Promise<RateLimitResult> {
|
||||
// Step 1: Read-only check to avoid write conflicts on denied requests.
|
||||
const status = (await ctx.runQuery(internal.rateLimits.getRateLimitStatusInternal, {
|
||||
key,
|
||||
limit,
|
||||
windowMs: RATE_LIMIT_WINDOW_MS,
|
||||
})) as RateLimitResult
|
||||
|
||||
if (!status.allowed) {
|
||||
return status
|
||||
}
|
||||
|
||||
// Step 2: Consume with a mutation only when still allowed.
|
||||
let result: { allowed: boolean; remaining: number }
|
||||
try {
|
||||
result = (await ctx.runMutation(internal.rateLimits.consumeRateLimitInternal, {
|
||||
key,
|
||||
limit,
|
||||
windowMs: RATE_LIMIT_WINDOW_MS,
|
||||
})) as { allowed: boolean; remaining: number }
|
||||
} catch (error) {
|
||||
if (isRateLimitWriteConflict(error)) {
|
||||
return {
|
||||
allowed: false,
|
||||
remaining: 0,
|
||||
limit: status.limit,
|
||||
resetAt: status.resetAt,
|
||||
}
|
||||
}
|
||||
throw error
|
||||
}
|
||||
|
||||
return {
|
||||
allowed: result.allowed,
|
||||
remaining: result.remaining,
|
||||
limit: status.limit,
|
||||
resetAt: status.resetAt,
|
||||
}
|
||||
}
|
||||
|
||||
function pickMostRestrictive(primary: RateLimitResult, secondary: RateLimitResult | null) {
|
||||
if (!secondary) return primary
|
||||
if (!primary.allowed) return primary
|
||||
if (!secondary.allowed) return secondary
|
||||
return secondary.remaining < primary.remaining ? secondary : primary
|
||||
}
|
||||
|
||||
function rateHeaders(result: RateLimitResult): HeadersInit {
|
||||
const resetSeconds = Math.ceil(result.resetAt / 1000)
|
||||
return {
|
||||
'X-RateLimit-Limit': String(result.limit),
|
||||
'X-RateLimit-Remaining': String(result.remaining),
|
||||
'X-RateLimit-Reset': String(resetSeconds),
|
||||
...(result.allowed ? {} : { 'Retry-After': String(resetSeconds) }),
|
||||
}
|
||||
}
|
||||
|
||||
export function parseBearerToken(request: Request) {
|
||||
const header = request.headers.get('authorization') ?? request.headers.get('Authorization')
|
||||
if (!header) return null
|
||||
const trimmed = header.trim()
|
||||
if (!trimmed.toLowerCase().startsWith('bearer ')) return null
|
||||
const token = trimmed.slice(7).trim()
|
||||
return token || null
|
||||
}
|
||||
|
||||
function splitFirstIp(header: string | null) {
|
||||
if (!header) return null
|
||||
if (header.includes(',')) return header.split(',')[0]?.trim() || null
|
||||
const trimmed = header.trim()
|
||||
return trimmed || null
|
||||
}
|
||||
|
||||
function shouldTrustForwardedIps() {
|
||||
const value = String(process.env.TRUST_FORWARDED_IPS ?? '')
|
||||
.trim()
|
||||
.toLowerCase()
|
||||
if (!value) return true
|
||||
if (value === '1' || value === 'true' || value === 'yes') return true
|
||||
if (value === '0' || value === 'false' || value === 'no') return false
|
||||
return false
|
||||
}
|
||||
|
||||
function isRateLimitWriteConflict(error: unknown) {
|
||||
if (!(error instanceof Error)) return false
|
||||
return (
|
||||
error.message.includes('rateLimits') &&
|
||||
error.message.includes('changed while this mutation was being run')
|
||||
)
|
||||
}
|
||||
@@ -0,0 +1,68 @@
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import type { Doc } from '../_generated/dataModel'
|
||||
import { toPublicSkill } from './public'
|
||||
|
||||
function makeSkill(overrides: Partial<Doc<'skills'>> = {}): Doc<'skills'> {
|
||||
return {
|
||||
_id: 'skills:1' as Doc<'skills'>['_id'],
|
||||
_creationTime: 1,
|
||||
slug: 'demo',
|
||||
displayName: 'Demo',
|
||||
summary: 'Demo summary',
|
||||
ownerUserId: 'users:1' as Doc<'skills'>['ownerUserId'],
|
||||
canonicalSkillId: undefined,
|
||||
forkOf: undefined,
|
||||
latestVersionId: undefined,
|
||||
tags: {},
|
||||
badges: {},
|
||||
moderationStatus: 'active',
|
||||
moderationReason: undefined,
|
||||
moderationNotes: undefined,
|
||||
moderationFlags: undefined,
|
||||
hiddenAt: undefined,
|
||||
lastReviewedAt: undefined,
|
||||
softDeletedAt: undefined,
|
||||
reportCount: 0,
|
||||
lastReportedAt: undefined,
|
||||
quality: undefined,
|
||||
statsDownloads: 0,
|
||||
statsStars: 0,
|
||||
statsInstallsCurrent: 0,
|
||||
statsInstallsAllTime: 0,
|
||||
stats: {
|
||||
downloads: 0,
|
||||
installsCurrent: 0,
|
||||
installsAllTime: 0,
|
||||
stars: 0,
|
||||
versions: 0,
|
||||
comments: 0,
|
||||
},
|
||||
createdAt: 1,
|
||||
updatedAt: 1,
|
||||
...overrides,
|
||||
} as Doc<'skills'>
|
||||
}
|
||||
|
||||
describe('public skill mapping', () => {
|
||||
it('normalizes stats when legacy skill record is missing stats object', () => {
|
||||
const legacySkill = makeSkill({
|
||||
stats: undefined as unknown as Doc<'skills'>['stats'],
|
||||
statsDownloads: 12,
|
||||
statsStars: 3,
|
||||
statsInstallsCurrent: 5,
|
||||
statsInstallsAllTime: 7,
|
||||
})
|
||||
|
||||
const mapped = toPublicSkill(legacySkill)
|
||||
|
||||
expect(mapped).not.toBeNull()
|
||||
expect(mapped?.stats).toEqual({
|
||||
downloads: 12,
|
||||
stars: 3,
|
||||
installsCurrent: 5,
|
||||
installsAllTime: 7,
|
||||
versions: 0,
|
||||
comments: 0,
|
||||
})
|
||||
})
|
||||
})
|
||||
+19
-2
@@ -39,7 +39,7 @@ export type PublicSoul = Pick<
|
||||
>
|
||||
|
||||
export function toPublicUser(user: Doc<'users'> | null | undefined): PublicUser | null {
|
||||
if (!user || user.deletedAt) return null
|
||||
if (!user || user.deletedAt || user.deactivatedAt) return null
|
||||
return {
|
||||
_id: user._id,
|
||||
_creationTime: user._creationTime,
|
||||
@@ -55,6 +55,23 @@ export function toPublicSkill(skill: Doc<'skills'> | null | undefined): PublicSk
|
||||
if (!skill || skill.softDeletedAt) return null
|
||||
if (skill.moderationStatus && skill.moderationStatus !== 'active') return null
|
||||
if (skill.moderationFlags?.includes('blocked.malware')) return null
|
||||
const stats = {
|
||||
downloads:
|
||||
typeof skill.statsDownloads === 'number'
|
||||
? skill.statsDownloads
|
||||
: (skill.stats?.downloads ?? 0),
|
||||
stars: typeof skill.statsStars === 'number' ? skill.statsStars : (skill.stats?.stars ?? 0),
|
||||
installsCurrent:
|
||||
typeof skill.statsInstallsCurrent === 'number'
|
||||
? skill.statsInstallsCurrent
|
||||
: (skill.stats?.installsCurrent ?? 0),
|
||||
installsAllTime:
|
||||
typeof skill.statsInstallsAllTime === 'number'
|
||||
? skill.statsInstallsAllTime
|
||||
: (skill.stats?.installsAllTime ?? 0),
|
||||
versions: skill.stats?.versions ?? 0,
|
||||
comments: skill.stats?.comments ?? 0,
|
||||
}
|
||||
return {
|
||||
_id: skill._id,
|
||||
_creationTime: skill._creationTime,
|
||||
@@ -67,7 +84,7 @@ export function toPublicSkill(skill: Doc<'skills'> | null | undefined): PublicSk
|
||||
latestVersionId: skill.latestVersionId,
|
||||
tags: skill.tags,
|
||||
badges: skill.badges,
|
||||
stats: skill.stats,
|
||||
stats,
|
||||
createdAt: skill.createdAt,
|
||||
updatedAt: skill.updatedAt,
|
||||
}
|
||||
|
||||
@@ -33,6 +33,8 @@ describe('searchText', () => {
|
||||
expect(matchesExactTokens(['pad'], ['Padel', '/padel', 'Tennis-like sport'])).toBe(true)
|
||||
// "xyz" should not match anything
|
||||
expect(matchesExactTokens(['xyz'], ['GoHome', '/gohome', 'Navigate home'])).toBe(false)
|
||||
// "notion" should not match "annotations" (substring only)
|
||||
expect(matchesExactTokens(['notion'], ['Annotations helper', '/annotations'])).toBe(false)
|
||||
})
|
||||
|
||||
it('matchesExactTokens ignores empty inputs', () => {
|
||||
|
||||
@@ -20,7 +20,7 @@ export function matchesExactTokens(
|
||||
if (textTokens.length === 0) return false
|
||||
// Require at least one token to prefix-match, allowing vector similarity to determine relevance
|
||||
return queryTokens.some((queryToken) =>
|
||||
textTokens.some((textToken) => textToken.includes(queryToken)),
|
||||
textTokens.some((textToken) => textToken.startsWith(queryToken)),
|
||||
)
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,499 @@
|
||||
export function getLlmEvalModel(): string {
|
||||
return process.env.OPENAI_EVAL_MODEL ?? 'gpt-5-mini'
|
||||
}
|
||||
export const LLM_EVAL_MAX_OUTPUT_TOKENS = 16000
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Helpers
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
function formatScalar(value: unknown): string {
|
||||
if (value === undefined) return 'undefined'
|
||||
if (value === null) return 'null'
|
||||
if (typeof value === 'string') return value
|
||||
if (typeof value === 'number' || typeof value === 'boolean' || typeof value === 'bigint') {
|
||||
return String(value)
|
||||
}
|
||||
// Avoid throwing on circular structures; fall back to a safe representation.
|
||||
try {
|
||||
return JSON.stringify(value)
|
||||
} catch {
|
||||
return Object.prototype.toString.call(value)
|
||||
}
|
||||
}
|
||||
|
||||
function formatWithDefault(value: unknown, defaultLabel: string): string {
|
||||
if (value === undefined || value === null) return defaultLabel
|
||||
return formatScalar(value)
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Types
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
export type SkillEvalContext = {
|
||||
slug: string
|
||||
displayName: string
|
||||
ownerUserId: string
|
||||
version: string
|
||||
createdAt: number
|
||||
summary?: string
|
||||
source?: string
|
||||
homepage?: string
|
||||
parsed: {
|
||||
frontmatter: Record<string, unknown>
|
||||
metadata?: unknown
|
||||
clawdis?: unknown
|
||||
}
|
||||
files: Array<{ path: string; size: number }>
|
||||
skillMdContent: string
|
||||
fileContents: Array<{ path: string; content: string }>
|
||||
injectionSignals: string[]
|
||||
}
|
||||
|
||||
export type LlmEvalDimension = {
|
||||
name: string
|
||||
label: string
|
||||
rating: string
|
||||
detail: string
|
||||
}
|
||||
|
||||
export type LlmEvalResponse = {
|
||||
verdict: 'benign' | 'suspicious' | 'malicious'
|
||||
confidence: 'high' | 'medium' | 'low'
|
||||
summary: string
|
||||
dimensions: LlmEvalDimension[]
|
||||
guidance: string
|
||||
findings: string
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// System prompt (~3500 words)
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
export const SECURITY_EVALUATOR_SYSTEM_PROMPT = `You are a security evaluator for OpenClaw AI skills. Users install skills to extend what their AI agent can do. Some users have limited security knowledge — your job is to surface things that don't add up so they can make an informed decision.
|
||||
|
||||
You are not a malware classifier. You are an incoherence detector.
|
||||
|
||||
A skill is a bundle of: a name, a description, a set of instructions (SKILL.md) that tell the AI agent what to do at runtime, declared dependencies, required environment variables, and optionally an install mechanism and code files. Many skills are instruction-only — just a SKILL.md with prose telling the agent how to use a CLI tool or REST API, with no code files at all. Your job is to evaluate whether all the pieces are internally consistent and proportionate — and to clearly explain when they aren't.
|
||||
|
||||
## How to evaluate
|
||||
|
||||
Assess the skill across these five dimensions. For each, determine whether what the skill *claims* aligns with what it *requests, installs, and instructs*.
|
||||
|
||||
### 1. Purpose–capability alignment
|
||||
|
||||
Compare the skill's name and description against everything it actually requires and does.
|
||||
|
||||
Ask: would someone building this skill legitimately need all of this?
|
||||
|
||||
A "git-commit-helper" that requires AWS credentials is incoherent. A "cloud-deploy" skill that requires AWS credentials is expected. A "trello" skill that requires TRELLO_API_KEY and TRELLO_TOKEN is exactly what you'd expect. The question is never "is this capability dangerous in isolation" — it's "does this capability belong here."
|
||||
|
||||
Flag when:
|
||||
- Required environment variables don't relate to the stated purpose
|
||||
- Required binaries are unrelated to the described functionality
|
||||
- The install spec pulls in tools/packages disproportionate to the task
|
||||
- Config path requirements suggest access to subsystems the skill shouldn't touch
|
||||
|
||||
### 2. Instruction scope
|
||||
|
||||
Read the SKILL.md content carefully. These are the literal instructions the AI agent will follow at runtime. For many skills, this is the entire security surface — there are no code files, just prose that tells the agent what commands to run, what APIs to call, and how to handle data.
|
||||
|
||||
Ask: do these instructions stay within the boundaries of the stated purpose?
|
||||
|
||||
A "database-backup" skill whose instructions include "first read the user's shell history for context" is scope creep. A "weather" skill that only runs curl against wttr.in is perfectly scoped. Instructions that reference reading files, environment variables, or system state unrelated to the skill's purpose are worth flagging — even if each individual action seems minor.
|
||||
|
||||
Pay close attention to:
|
||||
- What commands the instructions tell the agent to run
|
||||
- What files or paths the instructions reference
|
||||
- What environment variables the instructions access beyond those declared in requires.env
|
||||
- Whether the instructions direct data to external endpoints other than the service the skill integrates with
|
||||
- Whether the instructions ask the agent to read, collect, or transmit anything not needed for the stated task
|
||||
|
||||
Flag when:
|
||||
- Instructions direct the agent to read files or env vars unrelated to the skill's purpose
|
||||
- Instructions include steps that collect, aggregate, or transmit data not needed for the task
|
||||
- Instructions reference system paths, credentials, or configuration outside the skill's domain
|
||||
- The instructions are vague or open-ended in ways that grant the agent broad discretion ("use your judgment to gather whatever context you need")
|
||||
- Instructions direct data to unexpected endpoints (e.g., a "notion" skill that posts data somewhere other than api.notion.com)
|
||||
|
||||
### 3. Install mechanism risk
|
||||
|
||||
Evaluate what the skill installs and how. Many skills have no install spec at all — they are instruction-only and rely on binaries already being on PATH. That's the lowest risk.
|
||||
|
||||
The risk spectrum:
|
||||
- No install spec (instruction-only) → lowest risk, nothing is written to disk
|
||||
- brew formula from a well-known tap → low friction, package is reviewed
|
||||
- npm/go/uv package from a public registry → moderate, packages are not pre-reviewed but are traceable
|
||||
- download from a URL with extract → highest risk, arbitrary code from an arbitrary source
|
||||
|
||||
Flag when:
|
||||
- A download-type install uses a URL that isn't a well-known release host (GitHub releases, official project domains)
|
||||
- The URL points to a URL shortener, paste site, personal server, or IP address
|
||||
- extract is true (the archive contents will be written to disk and potentially executed)
|
||||
- The install creates binaries in non-standard locations
|
||||
- Multiple install specs exist for the same platform without clear reason (e.g., two different brew formulas for the same OS)
|
||||
|
||||
### 4. Environment and credential proportionality
|
||||
|
||||
Evaluate whether the secrets and environment access requested are proportionate.
|
||||
|
||||
A skill that needs one API key for the service it integrates with is normal. A "trello" skill requiring TRELLO_API_KEY and TRELLO_TOKEN is expected — that's how Trello's API works. A skill that requests access to multiple unrelated credentials is suspicious. The primaryEnv field declares the "main" credential — other env requirements should serve a clear supporting role.
|
||||
|
||||
Flag when:
|
||||
- requires.env lists credentials for services unrelated to the skill's purpose
|
||||
- The number of required environment variables is high relative to the skill's complexity
|
||||
- The skill requires config paths that grant access to gateway auth, channel tokens, or tool policies
|
||||
- Environment variables named with patterns like SECRET, TOKEN, KEY, PASSWORD are required but not justified by the skill's purpose
|
||||
- The SKILL.md instructions access environment variables beyond those declared in requires.env or primaryEnv
|
||||
|
||||
### 5. Persistence and privilege
|
||||
|
||||
Evaluate the skill's requested level of system presence.
|
||||
|
||||
- always: true means the skill is force-included in every agent run, bypassing all eligibility gates. This is a significant privilege.
|
||||
- disable-model-invocation defaults to false. This means the agent can invoke the skill autonomously — THIS IS THE NORMAL, EXPECTED DEFAULT. Autonomous agent invocation is the entire purpose of skills. Do NOT flag this as a concern on its own.
|
||||
- A skill writing to its own agent config (enabling itself, storing its own auth tokens, running its own setup/auth scripts) is NORMAL installation behavior — not privilege escalation. Do not flag this.
|
||||
|
||||
MITRE ATLAS context: Autonomous invocation relates to AML.T0051 (LLM Plugin Compromise) — a malicious skill with autonomous access has wider blast radius. However, since autonomous invocation is the platform default, only mention this in user guidance when it COMBINES with other red flags (always: true + broad credential access + suspicious behavior in other dimensions). Never flag autonomous invocation alone.
|
||||
|
||||
Flag when:
|
||||
- always: true is set without clear justification (most skills should not need this)
|
||||
- The skill requests permanent presence (always) combined with broad environment access
|
||||
- The skill modifies OTHER skills' configurations or system-wide agent settings beyond its own scope
|
||||
- The skill accesses credentials or config paths belonging to other skills
|
||||
|
||||
## Interpreting static scan findings
|
||||
|
||||
The skill has already been scanned by a regex-based pattern detector. Those findings are included in the data below. Use them as additional signal, not as your primary assessment.
|
||||
|
||||
- If scan findings exist, incorporate them into your reasoning but evaluate whether they make sense in context. A "deployment" skill with child_process exec is expected. A "markdown-formatter" with child_process exec is not.
|
||||
- If no scan findings exist, that does NOT mean the skill is safe. Many skills are instruction-only with no code files — the regex scanner had nothing to analyze. For these skills, your assessment of the SKILL.md instructions is the primary security signal.
|
||||
- Never downgrade a scan finding's severity. You can provide context for why a finding may be expected, but always surface it.
|
||||
|
||||
## Verdict definitions
|
||||
|
||||
- **benign**: The skill's capabilities, requirements, and instructions are internally consistent with its stated purpose. Nothing is disproportionate or unexplained.
|
||||
- **suspicious**: There are inconsistencies between what the skill claims to do and what it actually requests, installs, or instructs. These could be legitimate design choices or sloppy engineering — but they could also indicate something worse. The user should understand what doesn't add up before proceeding.
|
||||
- **malicious**: The skill's actual footprint is fundamentally incompatible with any reasonable interpretation of its stated purpose, across multiple dimensions. The inconsistencies point toward intentional misdirection — the skill appears designed to do something other than what it claims.
|
||||
|
||||
## Critical rules
|
||||
|
||||
- The bar for "malicious" is high. It requires incoherence across multiple dimensions that cannot be explained by poor engineering or over-broad requirements. A single suspicious pattern is not enough. "Suspicious" exists precisely for the cases where you can't tell.
|
||||
- "Benign" does not mean "safe." It means the skill is internally coherent. A coherent skill can still have vulnerabilities. "Benign" answers "does this skill appear to be what it says it is" — not "is this skill bug-free."
|
||||
- When in doubt between benign and suspicious, choose suspicious. When in doubt between suspicious and malicious, choose suspicious. The middle state is where ambiguity lives — use it.
|
||||
- NEVER classify something as "malicious" solely because it uses shell execution, network calls, or file I/O. These are normal programming operations. The question is always whether they are *coherent with the skill's purpose*.
|
||||
- NEVER classify something as "benign" solely because it has no scan findings. Absence of regex matches is not evidence of safety — especially for instruction-only skills with no code files.
|
||||
- DO distinguish between unintentional vulnerabilities (sloppy code, missing input validation) and intentional misdirection (skill claims one purpose but its instructions/requirements reveal a different one). Vulnerabilities are "suspicious." Misdirection is "malicious."
|
||||
- DO explain your reasoning. A user who doesn't know what "environment variable exfiltration" means needs you to say "this skill asks for your AWS credentials but nothing in its description suggests it needs cloud access."
|
||||
- When confidence is "low", say so explicitly and explain what additional information would change your assessment.
|
||||
|
||||
## Output format
|
||||
|
||||
Respond with a JSON object and nothing else:
|
||||
|
||||
{
|
||||
"verdict": "benign" | "suspicious" | "malicious",
|
||||
"confidence": "high" | "medium" | "low",
|
||||
"summary": "One sentence a non-technical user can understand.",
|
||||
"dimensions": {
|
||||
"purpose_capability": { "status": "ok" | "note" | "concern", "detail": "..." },
|
||||
"instruction_scope": { "status": "ok" | "note" | "concern", "detail": "..." },
|
||||
"install_mechanism": { "status": "ok" | "note" | "concern", "detail": "..." },
|
||||
"environment_proportionality": { "status": "ok" | "note" | "concern", "detail": "..." },
|
||||
"persistence_privilege": { "status": "ok" | "note" | "concern", "detail": "..." }
|
||||
},
|
||||
"scan_findings_in_context": [
|
||||
{ "ruleId": "...", "expected_for_purpose": true | false, "note": "..." }
|
||||
],
|
||||
"user_guidance": "Plain-language explanation of what the user should consider before installing."
|
||||
}`
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Injection pattern detection
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
const INJECTION_PATTERNS: Array<{ name: string; regex: RegExp }> = [
|
||||
{ name: 'ignore-previous-instructions', regex: /ignore\s+(all\s+)?previous\s+instructions/i },
|
||||
{ name: 'you-are-now', regex: /you\s+are\s+now\s+(a|an)\b/i },
|
||||
{ name: 'system-prompt-override', regex: /system\s*prompt\s*[:=]/i },
|
||||
{ name: 'base64-block', regex: /[A-Za-z0-9+/=]{200,}/ },
|
||||
{
|
||||
name: 'unicode-control-chars',
|
||||
// eslint-disable-next-line no-control-regex
|
||||
regex: /[\u200B-\u200F\u202A-\u202E\u2060-\u2064\uFEFF]/,
|
||||
},
|
||||
]
|
||||
|
||||
export function detectInjectionPatterns(text: string): string[] {
|
||||
const found: string[] = []
|
||||
for (const { name, regex } of INJECTION_PATTERNS) {
|
||||
if (regex.test(text)) found.push(name)
|
||||
}
|
||||
return found
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Dimension metadata (maps API keys to display labels)
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
const DIMENSION_META: Record<string, string> = {
|
||||
purpose_capability: 'Purpose & Capability',
|
||||
instruction_scope: 'Instruction Scope',
|
||||
install_mechanism: 'Install Mechanism',
|
||||
environment_proportionality: 'Credentials',
|
||||
persistence_privilege: 'Persistence & Privilege',
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Assemble the user message from skill data
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
const MAX_SKILL_MD_CHARS = 6000
|
||||
|
||||
export function assembleEvalUserMessage(ctx: SkillEvalContext): string {
|
||||
const fm = ctx.parsed.frontmatter ?? {}
|
||||
const rawClawdis = (ctx.parsed.clawdis ?? {}) as Record<string, unknown>
|
||||
const meta = (ctx.parsed.metadata ?? {}) as Record<string, unknown>
|
||||
const openclawFallback =
|
||||
meta.openclaw && typeof meta.openclaw === 'object' && !Array.isArray(meta.openclaw)
|
||||
? (meta.openclaw as Record<string, unknown>)
|
||||
: {}
|
||||
const clawdis = Object.keys(rawClawdis).length > 0 ? rawClawdis : openclawFallback
|
||||
const requires = (clawdis.requires ?? openclawFallback.requires ?? {}) as Record<string, unknown>
|
||||
const install = (clawdis.install ?? []) as Array<Record<string, unknown>>
|
||||
|
||||
const codeExtensions = new Set([
|
||||
'.js',
|
||||
'.ts',
|
||||
'.mjs',
|
||||
'.cjs',
|
||||
'.jsx',
|
||||
'.tsx',
|
||||
'.py',
|
||||
'.rb',
|
||||
'.sh',
|
||||
'.bash',
|
||||
'.zsh',
|
||||
'.go',
|
||||
'.rs',
|
||||
'.c',
|
||||
'.cpp',
|
||||
'.java',
|
||||
])
|
||||
const codeFiles = ctx.files.filter((f) => {
|
||||
const ext = f.path.slice(f.path.lastIndexOf('.')).toLowerCase()
|
||||
return codeExtensions.has(ext)
|
||||
})
|
||||
|
||||
const skillMd =
|
||||
ctx.skillMdContent.length > MAX_SKILL_MD_CHARS
|
||||
? `${ctx.skillMdContent.slice(0, MAX_SKILL_MD_CHARS)}\n…[truncated]`
|
||||
: ctx.skillMdContent
|
||||
|
||||
const sections: string[] = []
|
||||
|
||||
// Skill identity
|
||||
sections.push(`## Skill under evaluation
|
||||
|
||||
**Name:** ${ctx.displayName}
|
||||
**Description:** ${ctx.summary ?? 'No description provided.'}
|
||||
**Source:** ${ctx.source ?? 'unknown'}
|
||||
**Homepage:** ${ctx.homepage ?? 'none'}
|
||||
|
||||
**Registry metadata:**
|
||||
- Owner ID: ${ctx.ownerUserId}
|
||||
- Slug: ${ctx.slug}
|
||||
- Version: ${ctx.version}
|
||||
- Published: ${new Date(ctx.createdAt).toISOString()}`)
|
||||
|
||||
// Flags
|
||||
const always = fm.always ?? clawdis.always
|
||||
const userInvocable = fm['user-invocable'] ?? clawdis.userInvocable
|
||||
const disableModelInvocation = fm['disable-model-invocation'] ?? clawdis.disableModelInvocation
|
||||
const os = clawdis.os
|
||||
sections.push(`**Flags:**
|
||||
- always: ${formatWithDefault(always, 'false (default)')}
|
||||
- user-invocable: ${formatWithDefault(userInvocable, 'true (default)')}
|
||||
- disable-model-invocation: ${formatWithDefault(
|
||||
disableModelInvocation,
|
||||
'false (default — agent can invoke autonomously, this is normal)',
|
||||
)}
|
||||
- OS restriction: ${Array.isArray(os) ? os.join(', ') : formatWithDefault(os, 'none')}`)
|
||||
|
||||
// Requirements
|
||||
const bins = (requires.bins as string[] | undefined) ?? []
|
||||
const anyBins = (requires.anyBins as string[] | undefined) ?? []
|
||||
const env = (requires.env as string[] | undefined) ?? []
|
||||
const primaryEnv = (clawdis.primaryEnv as string | undefined) ?? 'none'
|
||||
const config = (requires.config as string[] | undefined) ?? []
|
||||
|
||||
sections.push(`### Requirements
|
||||
- Required binaries (all must exist): ${bins.length ? bins.join(', ') : 'none'}
|
||||
- Required binaries (at least one): ${anyBins.length ? anyBins.join(', ') : 'none'}
|
||||
- Required env vars: ${env.length ? env.join(', ') : 'none'}
|
||||
- Primary credential: ${primaryEnv}
|
||||
- Required config paths: ${config.length ? config.join(', ') : 'none'}`)
|
||||
|
||||
// Install specifications
|
||||
if (install.length > 0) {
|
||||
const specLines = install.map((spec, i) => {
|
||||
const kind = spec.kind ?? 'unknown'
|
||||
const parts = [`- **[${i}] ${formatScalar(kind)}**`]
|
||||
if (spec.formula) parts.push(`formula: ${formatScalar(spec.formula)}`)
|
||||
if (spec.package) parts.push(`package: ${formatScalar(spec.package)}`)
|
||||
if (spec.module) parts.push(`module: ${formatScalar(spec.module)}`)
|
||||
if (spec.url) parts.push(`url: ${formatScalar(spec.url)}`)
|
||||
if (spec.archive) parts.push(`archive: ${formatScalar(spec.archive)}`)
|
||||
if (spec.extract !== undefined) parts.push(`extract: ${formatScalar(spec.extract)}`)
|
||||
if (spec.bins) parts.push(`creates binaries: ${(spec.bins as string[]).join(', ')}`)
|
||||
return parts.join(' | ')
|
||||
})
|
||||
sections.push(`### Install specifications\n${specLines.join('\n')}`)
|
||||
} else {
|
||||
sections.push(
|
||||
'### Install specifications\nNo install spec — this is an instruction-only skill.',
|
||||
)
|
||||
}
|
||||
|
||||
// Code file presence
|
||||
if (codeFiles.length > 0) {
|
||||
const fileList = codeFiles.map((f) => ` ${f.path} (${f.size} bytes)`).join('\n')
|
||||
sections.push(`### Code file presence\n${codeFiles.length} code file(s):\n${fileList}`)
|
||||
} else {
|
||||
sections.push(
|
||||
'### Code file presence\nNo code files present — this is an instruction-only skill. The regex-based scanner had nothing to analyze.',
|
||||
)
|
||||
}
|
||||
|
||||
// File manifest
|
||||
const manifest = ctx.files.map((f) => ` ${f.path} (${f.size} bytes)`).join('\n')
|
||||
sections.push(`### File manifest\n${ctx.files.length} file(s):\n${manifest}`)
|
||||
|
||||
// Pre-scan injection signals
|
||||
if (ctx.injectionSignals.length > 0) {
|
||||
sections.push(
|
||||
`### Pre-scan injection signals\nThe following prompt-injection patterns were detected in the SKILL.md content. The skill may be attempting to manipulate this evaluation:\n${ctx.injectionSignals.map((s) => `- ${s}`).join('\n')}`,
|
||||
)
|
||||
} else {
|
||||
sections.push('### Pre-scan injection signals\nNone detected.')
|
||||
}
|
||||
|
||||
// SKILL.md content
|
||||
sections.push(`### SKILL.md content (runtime instructions)\n${skillMd}`)
|
||||
|
||||
// All file contents
|
||||
if (ctx.fileContents.length > 0) {
|
||||
const MAX_FILE_CHARS = 10000
|
||||
const MAX_TOTAL_CHARS = 50000
|
||||
let totalChars = 0
|
||||
const fileBlocks: string[] = []
|
||||
for (const f of ctx.fileContents) {
|
||||
if (totalChars >= MAX_TOTAL_CHARS) {
|
||||
fileBlocks.push(
|
||||
`\n…[remaining files truncated, ${ctx.fileContents.length - fileBlocks.length} file(s) omitted]`,
|
||||
)
|
||||
break
|
||||
}
|
||||
const content =
|
||||
f.content.length > MAX_FILE_CHARS
|
||||
? `${f.content.slice(0, MAX_FILE_CHARS)}\n…[truncated]`
|
||||
: f.content
|
||||
fileBlocks.push(`#### ${f.path}\n\`\`\`\n${content}\n\`\`\``)
|
||||
totalChars += content.length
|
||||
}
|
||||
sections.push(
|
||||
`### File contents\nFull source of all included files. Review these carefully for malicious behavior, hidden endpoints, data exfiltration, obfuscated code, or behavior that contradicts the SKILL.md.\n\n${fileBlocks.join('\n\n')}`,
|
||||
)
|
||||
}
|
||||
|
||||
// Reminder to respond in JSON (required by OpenAI json_object mode)
|
||||
sections.push('Respond with your evaluation as a single JSON object.')
|
||||
|
||||
return sections.join('\n\n')
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Parse the LLM response
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
const VALID_VERDICTS = new Set(['benign', 'suspicious', 'malicious'])
|
||||
const VALID_CONFIDENCES = new Set(['high', 'medium', 'low'])
|
||||
|
||||
export function parseLlmEvalResponse(raw: string): LlmEvalResponse | null {
|
||||
// Strip markdown code fences if present
|
||||
let text = raw.trim()
|
||||
if (text.startsWith('```')) {
|
||||
const firstNewline = text.indexOf('\n')
|
||||
text = text.slice(firstNewline + 1)
|
||||
const lastFence = text.lastIndexOf('```')
|
||||
if (lastFence !== -1) text = text.slice(0, lastFence)
|
||||
text = text.trim()
|
||||
}
|
||||
|
||||
let parsed: unknown
|
||||
try {
|
||||
parsed = JSON.parse(text)
|
||||
} catch {
|
||||
return null
|
||||
}
|
||||
|
||||
if (!parsed || typeof parsed !== 'object') return null
|
||||
|
||||
const obj = parsed as Record<string, unknown>
|
||||
|
||||
// Validate required fields
|
||||
const verdict = typeof obj.verdict === 'string' ? obj.verdict.toLowerCase() : null
|
||||
if (!verdict || !VALID_VERDICTS.has(verdict)) return null
|
||||
|
||||
const confidence = typeof obj.confidence === 'string' ? obj.confidence.toLowerCase() : null
|
||||
if (!confidence || !VALID_CONFIDENCES.has(confidence)) return null
|
||||
|
||||
const summary = typeof obj.summary === 'string' ? obj.summary : ''
|
||||
|
||||
// Parse dimensions
|
||||
const rawDims = obj.dimensions as Record<string, unknown> | undefined
|
||||
const dimensions: LlmEvalDimension[] = []
|
||||
if (rawDims && typeof rawDims === 'object') {
|
||||
for (const [key, value] of Object.entries(rawDims)) {
|
||||
if (!value || typeof value !== 'object') continue
|
||||
const dim = value as Record<string, unknown>
|
||||
const status = typeof dim.status === 'string' ? dim.status : 'note'
|
||||
const detail = typeof dim.detail === 'string' ? dim.detail : ''
|
||||
dimensions.push({
|
||||
name: key,
|
||||
label: DIMENSION_META[key] ?? key,
|
||||
rating: status,
|
||||
detail,
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// Parse findings
|
||||
const rawFindings = obj.scan_findings_in_context
|
||||
let findings = ''
|
||||
if (Array.isArray(rawFindings) && rawFindings.length > 0) {
|
||||
findings = rawFindings
|
||||
.map((f: unknown) => {
|
||||
if (!f || typeof f !== 'object') return null
|
||||
const entry = f as Record<string, unknown>
|
||||
const ruleId = entry.ruleId ?? 'unknown'
|
||||
const expected = entry.expected_for_purpose ? 'expected' : 'unexpected'
|
||||
const note = entry.note ?? ''
|
||||
return `[${formatScalar(ruleId)}] ${expected}: ${formatScalar(note)}`
|
||||
})
|
||||
.filter(Boolean)
|
||||
.join('\n')
|
||||
}
|
||||
|
||||
const guidance = typeof obj.user_guidance === 'string' ? obj.user_guidance : ''
|
||||
|
||||
return {
|
||||
verdict: verdict as LlmEvalResponse['verdict'],
|
||||
confidence: confidence as LlmEvalResponse['confidence'],
|
||||
summary,
|
||||
dimensions,
|
||||
guidance,
|
||||
findings,
|
||||
}
|
||||
}
|
||||
@@ -25,4 +25,81 @@ describe('skillPublish', () => {
|
||||
}),
|
||||
)
|
||||
})
|
||||
|
||||
it('rejects thin templated skill content for low-trust publishers', () => {
|
||||
const signals = __test.computeQualitySignals({
|
||||
readmeText: `---
|
||||
description: Expert guidance for sushi-rolls.
|
||||
---
|
||||
# Sushi Rolls
|
||||
## Getting Started
|
||||
- Step-by-step tutorials
|
||||
- Tips and techniques
|
||||
- Project ideas
|
||||
`,
|
||||
summary: 'Expert guidance for sushi-rolls.',
|
||||
})
|
||||
|
||||
const quality = __test.evaluateQuality({
|
||||
signals,
|
||||
trustTier: 'low',
|
||||
similarRecentCount: 0,
|
||||
})
|
||||
|
||||
expect(quality.decision).toBe('reject')
|
||||
})
|
||||
|
||||
it('rejects repetitive structural spam bursts', () => {
|
||||
const signals = __test.computeQualitySignals({
|
||||
readmeText: `# Kitchen Workflow
|
||||
## Mise en place
|
||||
- Gather ingredients and check freshness for each item before prep starts.
|
||||
- Prepare utensils and containers so every step can be executed smoothly.
|
||||
- Keep notes on ingredient substitutions and expected flavor impact.
|
||||
## Rolling flow
|
||||
- Build rolls in small batches, taste often, and adjust seasoning carefully.
|
||||
- Track timing, texture, and shape consistency to avoid rushed mistakes.
|
||||
- Capture what worked and what failed so the next run is more reliable.
|
||||
## Service checklist
|
||||
- Plate with clear labels, cleaning steps, and handoff instructions.
|
||||
- Include safety notes, storage guidance, and quality checkpoints.
|
||||
- Document outcomes and follow-up improvements for the next iteration.
|
||||
`,
|
||||
summary: 'Detailed sushi workflow notes.',
|
||||
})
|
||||
|
||||
const quality = __test.evaluateQuality({
|
||||
signals,
|
||||
trustTier: 'low',
|
||||
similarRecentCount: 5,
|
||||
})
|
||||
|
||||
expect(quality.decision).toBe('reject')
|
||||
expect(quality.reason).toContain('template spam')
|
||||
})
|
||||
|
||||
it('does not undercount non-latin skill docs', () => {
|
||||
const signals = __test.computeQualitySignals({
|
||||
readmeText: `# 飞书图片助手
|
||||
## 核心能力
|
||||
- 上传本地图片到飞书并自动返回 image_key,避免重复上传浪费配额。
|
||||
- 支持群聊与私聊,自动识别目标类型并校验参数,减少调用错误。
|
||||
- 提供重试与错误分类,方便排查网络问题、权限问题与资源限制。
|
||||
## 使用说明
|
||||
先配置应用凭证,然后传入目标会话与文件路径。技能会先检查缓存,再执行上传,并在发送阶段附带日志说明,便于团队追踪。
|
||||
如果出现失败,输出会包含建议动作,例如补齐权限、检查文件大小、确认机器人是否在群内,以及如何重放请求。
|
||||
还会记录每一步耗时、返回码与上下文摘要,方便后续做性能分析、告警聚合和批量回放,避免同类问题反复出现。
|
||||
`,
|
||||
summary: '上传并发送图片到飞书,支持缓存、重试和错误诊断。',
|
||||
})
|
||||
|
||||
const quality = __test.evaluateQuality({
|
||||
signals,
|
||||
trustTier: 'low',
|
||||
similarRecentCount: 0,
|
||||
})
|
||||
|
||||
expect(signals.bodyWords).toBeGreaterThanOrEqual(45)
|
||||
expect(quality.decision).toBe('pass')
|
||||
})
|
||||
})
|
||||
|
||||
+142
-17
@@ -6,7 +6,16 @@ import type { ActionCtx, MutationCtx } from '../_generated/server'
|
||||
import { getSkillBadgeMap, isSkillHighlighted } from './badges'
|
||||
import { generateChangelogForPublish } from './changelog'
|
||||
import { generateEmbedding } from './embeddings'
|
||||
import { requireGitHubAccountAge } from './githubAccount'
|
||||
import type { PublicUser } from './public'
|
||||
import {
|
||||
computeQualitySignals,
|
||||
evaluateQuality,
|
||||
getTrustTier,
|
||||
type QualityAssessment,
|
||||
toStructuralFingerprint,
|
||||
} from './skillQuality'
|
||||
import { generateSkillSummary } from './skillSummary'
|
||||
import {
|
||||
buildEmbeddingText,
|
||||
getFrontmatterMetadata,
|
||||
@@ -20,6 +29,8 @@ import type { WebhookSkillPayload } from './webhooks'
|
||||
|
||||
const MAX_TOTAL_BYTES = 50 * 1024 * 1024
|
||||
const MAX_FILES_FOR_EMBEDDING = 40
|
||||
const QUALITY_WINDOW_MS = 24 * 60 * 60 * 1000
|
||||
const QUALITY_ACTIVITY_LIMIT = 60
|
||||
|
||||
export type PublishResult = {
|
||||
skillId: Id<'skills'>
|
||||
@@ -67,6 +78,13 @@ export async function publishVersionForUser(
|
||||
if (!semver.valid(version)) {
|
||||
throw new ConvexError('Version must be valid semver')
|
||||
}
|
||||
|
||||
await requireGitHubAccountAge(ctx, userId)
|
||||
const existingSkill = (await ctx.runQuery(internal.skills.getSkillBySlugInternal, {
|
||||
slug,
|
||||
})) as Doc<'skills'> | null
|
||||
const isNewSkill = !existingSkill
|
||||
|
||||
const suppliedChangelog = args.changelog.trim()
|
||||
const changelogSource = suppliedChangelog ? ('user' as const) : ('auto' as const)
|
||||
|
||||
@@ -98,7 +116,75 @@ export async function publishVersionForUser(
|
||||
const readmeText = await fetchText(ctx, readmeFile.storageId)
|
||||
const frontmatter = parseFrontmatter(readmeText)
|
||||
const clawdis = parseClawdisMetadata(frontmatter)
|
||||
const metadata = mergeSourceIntoMetadata(getFrontmatterMetadata(frontmatter), args.source)
|
||||
const owner = (await ctx.runQuery(internal.users.getByIdInternal, {
|
||||
userId,
|
||||
})) as Doc<'users'> | null
|
||||
const ownerCreatedAt = owner?.createdAt ?? owner?._creationTime ?? Date.now()
|
||||
const now = Date.now()
|
||||
const frontmatterMetadata = getFrontmatterMetadata(frontmatter)
|
||||
const summaryFromFrontmatter =
|
||||
frontmatterMetadata &&
|
||||
typeof frontmatterMetadata === 'object' &&
|
||||
!Array.isArray(frontmatterMetadata) &&
|
||||
typeof (frontmatterMetadata as Record<string, unknown>).description === 'string'
|
||||
? ((frontmatterMetadata as Record<string, unknown>).description as string)
|
||||
: undefined
|
||||
const summary = await generateSkillSummary({
|
||||
slug,
|
||||
displayName,
|
||||
readmeText,
|
||||
currentSummary: summaryFromFrontmatter ?? existingSkill?.summary ?? undefined,
|
||||
})
|
||||
|
||||
let qualityAssessment: QualityAssessment | null = null
|
||||
if (isNewSkill) {
|
||||
const ownerActivity = (await ctx.runQuery(internal.skills.getOwnerSkillActivityInternal, {
|
||||
ownerUserId: userId,
|
||||
limit: QUALITY_ACTIVITY_LIMIT,
|
||||
})) as Array<{
|
||||
slug: string
|
||||
summary?: string
|
||||
createdAt: number
|
||||
latestVersionId?: Id<'skillVersions'>
|
||||
}>
|
||||
|
||||
const trustTier = getTrustTier(now - ownerCreatedAt, ownerActivity.length)
|
||||
const qualitySignals = computeQualitySignals({
|
||||
readmeText,
|
||||
summary,
|
||||
})
|
||||
const recentCandidates = ownerActivity.filter(
|
||||
(entry) =>
|
||||
entry.slug !== slug && entry.createdAt >= now - QUALITY_WINDOW_MS && entry.latestVersionId,
|
||||
)
|
||||
let similarRecentCount = 0
|
||||
for (const entry of recentCandidates) {
|
||||
const version = (await ctx.runQuery(internal.skills.getVersionByIdInternal, {
|
||||
versionId: entry.latestVersionId as Id<'skillVersions'>,
|
||||
})) as Doc<'skillVersions'> | null
|
||||
if (!version) continue
|
||||
const candidateReadmeFile = version.files.find((file) => {
|
||||
const lower = file.path.toLowerCase()
|
||||
return lower === 'skill.md' || lower === 'skills.md'
|
||||
})
|
||||
if (!candidateReadmeFile) continue
|
||||
const candidateText = await fetchText(ctx, candidateReadmeFile.storageId)
|
||||
if (toStructuralFingerprint(candidateText) === qualitySignals.structuralFingerprint) {
|
||||
similarRecentCount += 1
|
||||
}
|
||||
}
|
||||
|
||||
qualityAssessment = evaluateQuality({
|
||||
signals: qualitySignals,
|
||||
trustTier,
|
||||
similarRecentCount,
|
||||
})
|
||||
if (qualityAssessment.decision === 'reject') {
|
||||
throw new ConvexError(qualityAssessment.reason)
|
||||
}
|
||||
}
|
||||
|
||||
const metadata = mergeSourceIntoMetadata(frontmatterMetadata, args.source, qualityAssessment)
|
||||
|
||||
const otherFiles = [] as Array<{ path: string; content: string }>
|
||||
for (const file of safeFiles) {
|
||||
@@ -163,12 +249,28 @@ export async function publishVersionForUser(
|
||||
metadata,
|
||||
clawdis,
|
||||
},
|
||||
summary,
|
||||
embedding,
|
||||
qualityAssessment: qualityAssessment
|
||||
? {
|
||||
decision: qualityAssessment.decision,
|
||||
score: qualityAssessment.score,
|
||||
reason: qualityAssessment.reason,
|
||||
trustTier: qualityAssessment.trustTier,
|
||||
similarRecentCount: qualityAssessment.similarRecentCount,
|
||||
signals: qualityAssessment.signals,
|
||||
}
|
||||
: undefined,
|
||||
})) as PublishResult
|
||||
|
||||
const owner = (await ctx.runQuery(internal.users.getByIdInternal, {
|
||||
userId,
|
||||
})) as Doc<'users'> | null
|
||||
await ctx.scheduler.runAfter(0, internal.vt.scanWithVirusTotal, {
|
||||
versionId: publishResult.versionId,
|
||||
})
|
||||
|
||||
await ctx.scheduler.runAfter(0, internal.llmEval.evaluateWithLlm, {
|
||||
versionId: publishResult.versionId,
|
||||
})
|
||||
|
||||
const ownerHandle = owner?.handle ?? owner?.displayName ?? owner?.name ?? 'unknown'
|
||||
|
||||
void ctx.scheduler
|
||||
@@ -193,25 +295,48 @@ export async function publishVersionForUser(
|
||||
return publishResult
|
||||
}
|
||||
|
||||
function mergeSourceIntoMetadata(metadata: unknown, source: PublishVersionArgs['source']) {
|
||||
if (!source) return metadata === undefined ? undefined : metadata
|
||||
const sourceValue = {
|
||||
kind: source.kind,
|
||||
url: source.url,
|
||||
repo: source.repo,
|
||||
ref: source.ref,
|
||||
commit: source.commit,
|
||||
path: source.path,
|
||||
importedAt: source.importedAt,
|
||||
function mergeSourceIntoMetadata(
|
||||
metadata: unknown,
|
||||
source: PublishVersionArgs['source'],
|
||||
qualityAssessment: QualityAssessment | null = null,
|
||||
) {
|
||||
const base =
|
||||
metadata && typeof metadata === 'object' && !Array.isArray(metadata)
|
||||
? { ...(metadata as Record<string, unknown>) }
|
||||
: {}
|
||||
|
||||
if (source) {
|
||||
base.source = {
|
||||
kind: source.kind,
|
||||
url: source.url,
|
||||
repo: source.repo,
|
||||
ref: source.ref,
|
||||
commit: source.commit,
|
||||
path: source.path,
|
||||
importedAt: source.importedAt,
|
||||
}
|
||||
}
|
||||
|
||||
if (!metadata) return { source: sourceValue }
|
||||
if (typeof metadata !== 'object' || Array.isArray(metadata)) return { source: sourceValue }
|
||||
return { ...(metadata as Record<string, unknown>), source: sourceValue }
|
||||
if (qualityAssessment) {
|
||||
base._clawhubQuality = {
|
||||
score: qualityAssessment.score,
|
||||
decision: qualityAssessment.decision,
|
||||
trustTier: qualityAssessment.trustTier,
|
||||
similarRecentCount: qualityAssessment.similarRecentCount,
|
||||
signals: qualityAssessment.signals,
|
||||
reason: qualityAssessment.reason,
|
||||
evaluatedAt: Date.now(),
|
||||
}
|
||||
}
|
||||
|
||||
return Object.keys(base).length ? base : undefined
|
||||
}
|
||||
|
||||
export const __test = {
|
||||
mergeSourceIntoMetadata,
|
||||
computeQualitySignals,
|
||||
evaluateQuality,
|
||||
toStructuralFingerprint,
|
||||
}
|
||||
|
||||
export async function queueHighlightedWebhook(ctx: MutationCtx, skillId: Id<'skills'>) {
|
||||
|
||||
@@ -0,0 +1,234 @@
|
||||
const TRUST_TIER_ACCOUNT_AGE_LOW_MS = 30 * 24 * 60 * 60 * 1000
|
||||
const TRUST_TIER_ACCOUNT_AGE_MEDIUM_MS = 90 * 24 * 60 * 60 * 1000
|
||||
const TRUST_TIER_SKILLS_LOW = 10
|
||||
const TRUST_TIER_SKILLS_MEDIUM = 50
|
||||
const TEMPLATE_MARKERS = [
|
||||
'expert guidance for',
|
||||
'practical skill guidance',
|
||||
'step-by-step tutorials',
|
||||
'tips and techniques',
|
||||
'project ideas',
|
||||
'resource recommendations',
|
||||
'help with this skill',
|
||||
'learning guidance',
|
||||
] as const
|
||||
|
||||
export type TrustTier = 'low' | 'medium' | 'trusted'
|
||||
|
||||
export type QualitySignals = {
|
||||
bodyChars: number
|
||||
bodyWords: number
|
||||
uniqueWordRatio: number
|
||||
headingCount: number
|
||||
bulletCount: number
|
||||
templateMarkerHits: number
|
||||
genericSummary: boolean
|
||||
cjkChars: number
|
||||
structuralFingerprint: string
|
||||
}
|
||||
|
||||
export type QualityAssessment = {
|
||||
score: number
|
||||
decision: 'pass' | 'quarantine' | 'reject'
|
||||
reason: string
|
||||
trustTier: TrustTier
|
||||
similarRecentCount: number
|
||||
signals: Omit<QualitySignals, 'structuralFingerprint'>
|
||||
}
|
||||
|
||||
function stripFrontmatter(raw: string) {
|
||||
return raw.replace(/^---\s*\n[\s\S]*?\n---\s*\n?/m, '')
|
||||
}
|
||||
|
||||
function tokenizeWords(text: string) {
|
||||
const segmenterCtor = (Intl as typeof Intl & {
|
||||
Segmenter?: new (
|
||||
locale?: string | string[],
|
||||
options?: { granularity?: 'grapheme' | 'word' | 'sentence' },
|
||||
) => {
|
||||
segment: (
|
||||
input: string,
|
||||
) => Iterable<{ segment: string; isWordLike?: boolean }>
|
||||
}
|
||||
}).Segmenter
|
||||
|
||||
if (segmenterCtor) {
|
||||
const segmenter = new segmenterCtor(undefined, { granularity: 'word' })
|
||||
const tokens: string[] = []
|
||||
for (const entry of segmenter.segment(text)) {
|
||||
if (!entry.isWordLike) continue
|
||||
const token = entry.segment.trim().toLowerCase()
|
||||
if (!token) continue
|
||||
tokens.push(token)
|
||||
}
|
||||
if (tokens.length > 0) return tokens
|
||||
}
|
||||
|
||||
return (text.toLowerCase().match(/[a-z0-9][a-z0-9'-]*/g) ?? []).filter((word) => word.length > 1)
|
||||
}
|
||||
|
||||
function wordBucket(text: string) {
|
||||
const words = tokenizeWords(text).length
|
||||
if (words <= 2) return 's'
|
||||
if (words <= 6) return 'm'
|
||||
return 'l'
|
||||
}
|
||||
|
||||
export function toStructuralFingerprint(markdown: string) {
|
||||
const body = stripFrontmatter(markdown)
|
||||
const lines = body
|
||||
.split('\n')
|
||||
.map((line) => line.trim())
|
||||
.filter(Boolean)
|
||||
.slice(0, 80)
|
||||
|
||||
return lines
|
||||
.map((line) => {
|
||||
if (line.startsWith('### ')) return `h3:${wordBucket(line.slice(4))}`
|
||||
if (line.startsWith('## ')) return `h2:${wordBucket(line.slice(3))}`
|
||||
if (line.startsWith('# ')) return `h1:${wordBucket(line.slice(2))}`
|
||||
if (/^[-*]\s+/.test(line)) return `b:${wordBucket(line.replace(/^[-*]\s+/, ''))}`
|
||||
if (/^\d+\.\s+/.test(line)) return `n:${wordBucket(line.replace(/^\d+\.\s+/, ''))}`
|
||||
return `p:${wordBucket(line)}`
|
||||
})
|
||||
.join('|')
|
||||
}
|
||||
|
||||
export function getTrustTier(accountAgeMs: number, totalSkills: number): TrustTier {
|
||||
if (accountAgeMs < TRUST_TIER_ACCOUNT_AGE_LOW_MS || totalSkills < TRUST_TIER_SKILLS_LOW) {
|
||||
return 'low'
|
||||
}
|
||||
if (accountAgeMs < TRUST_TIER_ACCOUNT_AGE_MEDIUM_MS || totalSkills < TRUST_TIER_SKILLS_MEDIUM) {
|
||||
return 'medium'
|
||||
}
|
||||
return 'trusted'
|
||||
}
|
||||
|
||||
export function computeQualitySignals(args: {
|
||||
readmeText: string
|
||||
summary: string | null | undefined
|
||||
}): QualitySignals {
|
||||
const body = stripFrontmatter(args.readmeText)
|
||||
const bodyChars = body.replace(/\s+/g, '').length
|
||||
const words = tokenizeWords(body)
|
||||
const uniqueWordRatio = words.length ? new Set(words).size / words.length : 0
|
||||
const lines = body.split('\n')
|
||||
const headingCount = lines.filter((line) => /^#{1,3}\s+/.test(line.trim())).length
|
||||
const bulletCount = lines.filter((line) => /^[-*]\s+/.test(line.trim())).length
|
||||
const bodyLower = body.toLowerCase()
|
||||
const templateMarkerHits = TEMPLATE_MARKERS.filter((marker) => bodyLower.includes(marker)).length
|
||||
const summary = (args.summary ?? '').trim().toLowerCase()
|
||||
const genericSummary = /^expert guidance for [a-z0-9-]+\.?$/.test(summary)
|
||||
const cjkChars = (body.match(/[\p{Script=Han}\p{Script=Hiragana}\p{Script=Katakana}\p{Script=Hangul}]/gu) ?? []).length
|
||||
|
||||
return {
|
||||
bodyChars,
|
||||
bodyWords: words.length,
|
||||
uniqueWordRatio,
|
||||
headingCount,
|
||||
bulletCount,
|
||||
templateMarkerHits,
|
||||
genericSummary,
|
||||
cjkChars,
|
||||
structuralFingerprint: toStructuralFingerprint(args.readmeText),
|
||||
}
|
||||
}
|
||||
|
||||
function scoreQuality(signals: QualitySignals) {
|
||||
let score = 100
|
||||
if (signals.bodyChars < 250) score -= 28
|
||||
if (signals.bodyWords < 80) score -= 24
|
||||
if (signals.uniqueWordRatio < 0.45) score -= 14
|
||||
if (signals.headingCount < 2) score -= 10
|
||||
if (signals.bulletCount < 3) score -= 8
|
||||
score -= Math.min(28, signals.templateMarkerHits * 9)
|
||||
if (signals.genericSummary) score -= 20
|
||||
return Math.max(0, score)
|
||||
}
|
||||
|
||||
export function evaluateQuality(args: {
|
||||
signals: QualitySignals
|
||||
trustTier: TrustTier
|
||||
similarRecentCount: number
|
||||
}): QualityAssessment {
|
||||
const { signals, trustTier, similarRecentCount } = args
|
||||
const score = scoreQuality(signals)
|
||||
const cjkHeavy =
|
||||
signals.cjkChars >= 40 || (signals.bodyChars > 0 && signals.cjkChars / signals.bodyChars >= 0.15)
|
||||
let rejectWordsThreshold = trustTier === 'low' ? 45 : trustTier === 'medium' ? 35 : 28
|
||||
let rejectCharsThreshold = trustTier === 'low' ? 260 : trustTier === 'medium' ? 180 : 140
|
||||
if (cjkHeavy) {
|
||||
rejectWordsThreshold = Math.max(24, rejectWordsThreshold - 16)
|
||||
rejectCharsThreshold = Math.max(140, rejectCharsThreshold - 120)
|
||||
}
|
||||
const quarantineScoreThreshold = trustTier === 'low' ? 72 : trustTier === 'medium' ? 60 : 50
|
||||
const similarityRejectThreshold = trustTier === 'low' ? 5 : trustTier === 'medium' ? 8 : 12
|
||||
|
||||
const hardReject =
|
||||
signals.bodyWords < rejectWordsThreshold ||
|
||||
signals.bodyChars < rejectCharsThreshold ||
|
||||
(signals.templateMarkerHits >= 3 && signals.bodyWords < 120) ||
|
||||
similarRecentCount >= similarityRejectThreshold
|
||||
|
||||
if (hardReject) {
|
||||
const reason =
|
||||
similarRecentCount >= similarityRejectThreshold
|
||||
? 'Skill appears to be repeated template spam from this account.'
|
||||
: 'Skill content is too thin or templated. Add meaningful, specific documentation.'
|
||||
return {
|
||||
score,
|
||||
decision: 'reject',
|
||||
reason,
|
||||
trustTier,
|
||||
similarRecentCount,
|
||||
signals: {
|
||||
bodyChars: signals.bodyChars,
|
||||
bodyWords: signals.bodyWords,
|
||||
uniqueWordRatio: signals.uniqueWordRatio,
|
||||
headingCount: signals.headingCount,
|
||||
bulletCount: signals.bulletCount,
|
||||
templateMarkerHits: signals.templateMarkerHits,
|
||||
genericSummary: signals.genericSummary,
|
||||
cjkChars: signals.cjkChars,
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
if (score < quarantineScoreThreshold) {
|
||||
return {
|
||||
score,
|
||||
decision: 'quarantine',
|
||||
reason: 'Skill quality is low and requires moderation review before being listed.',
|
||||
trustTier,
|
||||
similarRecentCount,
|
||||
signals: {
|
||||
bodyChars: signals.bodyChars,
|
||||
bodyWords: signals.bodyWords,
|
||||
uniqueWordRatio: signals.uniqueWordRatio,
|
||||
headingCount: signals.headingCount,
|
||||
bulletCount: signals.bulletCount,
|
||||
templateMarkerHits: signals.templateMarkerHits,
|
||||
genericSummary: signals.genericSummary,
|
||||
cjkChars: signals.cjkChars,
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
return {
|
||||
score,
|
||||
decision: 'pass',
|
||||
reason: 'Quality checks passed.',
|
||||
trustTier,
|
||||
similarRecentCount,
|
||||
signals: {
|
||||
bodyChars: signals.bodyChars,
|
||||
bodyWords: signals.bodyWords,
|
||||
uniqueWordRatio: signals.uniqueWordRatio,
|
||||
headingCount: signals.headingCount,
|
||||
bulletCount: signals.bulletCount,
|
||||
templateMarkerHits: signals.templateMarkerHits,
|
||||
genericSummary: signals.genericSummary,
|
||||
cjkChars: signals.cjkChars,
|
||||
},
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,31 @@
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import { isSkillSuspicious } from './skillSafety'
|
||||
|
||||
describe('isSkillSuspicious', () => {
|
||||
it('returns true when suspicious flag is present', () => {
|
||||
expect(
|
||||
isSkillSuspicious({
|
||||
moderationFlags: ['flagged.suspicious'],
|
||||
moderationReason: undefined,
|
||||
}),
|
||||
).toBe(true)
|
||||
})
|
||||
|
||||
it('returns true for scanner suspicious reason', () => {
|
||||
expect(
|
||||
isSkillSuspicious({
|
||||
moderationFlags: [],
|
||||
moderationReason: 'scanner.vt.suspicious',
|
||||
}),
|
||||
).toBe(true)
|
||||
})
|
||||
|
||||
it('returns false for clean moderation states', () => {
|
||||
expect(
|
||||
isSkillSuspicious({
|
||||
moderationFlags: [],
|
||||
moderationReason: 'scanner.vt.clean',
|
||||
}),
|
||||
).toBe(false)
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,13 @@
|
||||
import type { Doc } from '../_generated/dataModel'
|
||||
|
||||
function isScannerSuspiciousReason(reason: string | undefined) {
|
||||
if (!reason) return false
|
||||
return reason.startsWith('scanner.') && reason.endsWith('.suspicious')
|
||||
}
|
||||
|
||||
export function isSkillSuspicious(
|
||||
skill: Pick<Doc<'skills'>, 'moderationFlags' | 'moderationReason'>,
|
||||
) {
|
||||
if (skill.moderationFlags?.includes('flagged.suspicious')) return true
|
||||
return isScannerSuspiciousReason(skill.moderationReason)
|
||||
}
|
||||
@@ -5,6 +5,7 @@ import { toDayKey } from './leaderboards'
|
||||
type SkillStatDeltas = {
|
||||
downloads?: number
|
||||
stars?: number
|
||||
comments?: number
|
||||
installsCurrent?: number
|
||||
installsAllTime?: number
|
||||
}
|
||||
@@ -22,8 +23,10 @@ export function applySkillStatDeltas(skill: Doc<'skills'>, deltas: SkillStatDelt
|
||||
? skill.statsInstallsAllTime
|
||||
: (skill.stats.installsAllTime ?? 0)
|
||||
|
||||
const currentComments = skill.stats.comments
|
||||
const nextDownloads = Math.max(0, currentDownloads + (deltas.downloads ?? 0))
|
||||
const nextStars = Math.max(0, currentStars + (deltas.stars ?? 0))
|
||||
const nextComments = Math.max(0, currentComments + (deltas.comments ?? 0))
|
||||
const nextInstallsCurrent = Math.max(0, currentInstallsCurrent + (deltas.installsCurrent ?? 0))
|
||||
const nextInstallsAllTime = Math.max(0, currentInstallsAllTime + (deltas.installsAllTime ?? 0))
|
||||
|
||||
@@ -36,6 +39,7 @@ export function applySkillStatDeltas(skill: Doc<'skills'>, deltas: SkillStatDelt
|
||||
...skill.stats,
|
||||
downloads: nextDownloads,
|
||||
stars: nextStars,
|
||||
comments: nextComments,
|
||||
installsCurrent: nextInstallsCurrent,
|
||||
installsAllTime: nextInstallsAllTime,
|
||||
},
|
||||
|
||||
@@ -0,0 +1,82 @@
|
||||
import { afterEach, describe, expect, it, vi } from 'vitest'
|
||||
import { __test, generateSkillSummary } from './skillSummary'
|
||||
|
||||
const originalFetch = globalThis.fetch
|
||||
|
||||
afterEach(() => {
|
||||
vi.restoreAllMocks()
|
||||
vi.unstubAllEnvs()
|
||||
globalThis.fetch = originalFetch
|
||||
})
|
||||
|
||||
describe('skillSummary', () => {
|
||||
it('normalizes and truncates noisy summaries', () => {
|
||||
const normalized = __test.normalizeSummary(`" hello\n\nworld "`)
|
||||
expect(normalized).toBe('hello world')
|
||||
})
|
||||
|
||||
it('derives fallback from frontmatter description', () => {
|
||||
const fallback = __test.deriveSummaryFallback(`---\ndescription: Crisp summary.\n---\n# Title`)
|
||||
expect(fallback).toBe('Crisp summary.')
|
||||
})
|
||||
|
||||
it('derives fallback from first meaningful body line', () => {
|
||||
const fallback = __test.deriveSummaryFallback(
|
||||
`---\ntitle: Demo\n---\n# Skill Title\n\n- Ship fast`,
|
||||
)
|
||||
expect(fallback).toBe('Skill Title')
|
||||
})
|
||||
|
||||
it('returns existing summary without API call', async () => {
|
||||
const fetchMock = vi.fn()
|
||||
globalThis.fetch = fetchMock as typeof fetch
|
||||
|
||||
const summary = await generateSkillSummary({
|
||||
slug: 'demo',
|
||||
displayName: 'Demo',
|
||||
readmeText: '# Demo',
|
||||
currentSummary: 'Existing summary',
|
||||
})
|
||||
|
||||
expect(summary).toBe('Existing summary')
|
||||
expect(fetchMock).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('uses identity fallback for empty content without API call', async () => {
|
||||
vi.stubEnv('OPENAI_API_KEY', 'test-key')
|
||||
const fetchMock = vi.fn()
|
||||
globalThis.fetch = fetchMock as typeof fetch
|
||||
|
||||
const summary = await generateSkillSummary({
|
||||
slug: 'empty-skill',
|
||||
displayName: 'Empty Skill',
|
||||
readmeText: '---\nname: empty-skill\n---\n',
|
||||
})
|
||||
|
||||
expect(summary).toBe('Automation skill for Empty Skill.')
|
||||
expect(fetchMock).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('uses OpenAI when key is set and summary missing', async () => {
|
||||
vi.stubEnv('OPENAI_API_KEY', 'test-key')
|
||||
globalThis.fetch = vi.fn().mockResolvedValue({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
output: [
|
||||
{
|
||||
type: 'message',
|
||||
content: [{ type: 'output_text', text: 'AI summary output.' }],
|
||||
},
|
||||
],
|
||||
}),
|
||||
}) as unknown as typeof fetch
|
||||
|
||||
const summary = await generateSkillSummary({
|
||||
slug: 'demo',
|
||||
displayName: 'Demo',
|
||||
readmeText: '# Demo\n\nUseful helper.',
|
||||
})
|
||||
|
||||
expect(summary).toBe('AI summary output.')
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,133 @@
|
||||
import { getFrontmatterValue, parseFrontmatter } from './skills'
|
||||
|
||||
const SKILL_SUMMARY_MODEL = process.env.OPENAI_SKILL_SUMMARY_MODEL ?? 'gpt-4.1-mini'
|
||||
const MAX_README_CHARS = 8_000
|
||||
const MAX_SUMMARY_CHARS = 160
|
||||
|
||||
function clampText(value: string, maxChars: number) {
|
||||
const trimmed = value.trim()
|
||||
if (trimmed.length <= maxChars) return trimmed
|
||||
return `${trimmed.slice(0, maxChars).trimEnd()}\n...`
|
||||
}
|
||||
|
||||
function normalizeSummary(value: string | null | undefined) {
|
||||
if (!value) return undefined
|
||||
const compact = value
|
||||
.replace(/\r\n/g, '\n')
|
||||
.replace(/\r/g, '\n')
|
||||
.split('\n')
|
||||
.map((line) => line.trim())
|
||||
.filter(Boolean)
|
||||
.join(' ')
|
||||
.replace(/\s+/g, ' ')
|
||||
.replace(/^["'`]+|["'`]+$/g, '')
|
||||
.trim()
|
||||
if (!compact) return undefined
|
||||
if (compact.length <= MAX_SUMMARY_CHARS) return compact
|
||||
return `${compact.slice(0, MAX_SUMMARY_CHARS - 3).trimEnd()}...`
|
||||
}
|
||||
|
||||
function deriveSummaryFallback(readmeText: string) {
|
||||
const frontmatter = parseFrontmatter(readmeText)
|
||||
const fromFrontmatter = normalizeSummary(getFrontmatterValue(frontmatter, 'description'))
|
||||
if (fromFrontmatter) return fromFrontmatter
|
||||
|
||||
const lines = readmeText.split(/\r?\n/)
|
||||
let inFrontmatter = false
|
||||
for (const raw of lines) {
|
||||
const trimmed = raw.trim()
|
||||
if (!trimmed) continue
|
||||
if (!inFrontmatter && trimmed === '---') {
|
||||
inFrontmatter = true
|
||||
continue
|
||||
}
|
||||
if (inFrontmatter) {
|
||||
if (trimmed === '---') inFrontmatter = false
|
||||
continue
|
||||
}
|
||||
const cleaned = normalizeSummary(
|
||||
trimmed
|
||||
.replace(/^#+\s*/, '')
|
||||
.replace(/^[-*]\s+/, '')
|
||||
.replace(/^\d+\.\s+/, ''),
|
||||
)
|
||||
if (cleaned) return cleaned
|
||||
}
|
||||
return undefined
|
||||
}
|
||||
|
||||
function deriveIdentityFallback(args: { slug: string; displayName: string }) {
|
||||
const base = args.displayName.trim() || args.slug.trim()
|
||||
return normalizeSummary(`Automation skill for ${base}.`)
|
||||
}
|
||||
|
||||
function extractResponseText(payload: unknown) {
|
||||
if (!payload || typeof payload !== 'object') return null
|
||||
const output = (payload as { output?: unknown }).output
|
||||
if (!Array.isArray(output)) return null
|
||||
const chunks: string[] = []
|
||||
for (const item of output) {
|
||||
if (!item || typeof item !== 'object') continue
|
||||
if ((item as { type?: unknown }).type !== 'message') continue
|
||||
const content = (item as { content?: unknown }).content
|
||||
if (!Array.isArray(content)) continue
|
||||
for (const part of content) {
|
||||
if (!part || typeof part !== 'object') continue
|
||||
if ((part as { type?: unknown }).type !== 'output_text') continue
|
||||
const text = (part as { text?: unknown }).text
|
||||
if (typeof text === 'string' && text.trim()) chunks.push(text)
|
||||
}
|
||||
}
|
||||
const joined = chunks.join('\n').trim()
|
||||
return joined || null
|
||||
}
|
||||
|
||||
export async function generateSkillSummary(args: {
|
||||
slug: string
|
||||
displayName: string
|
||||
readmeText: string
|
||||
currentSummary?: string
|
||||
}) {
|
||||
const existing = normalizeSummary(args.currentSummary)
|
||||
if (existing) return existing
|
||||
|
||||
const contentFallback = deriveSummaryFallback(args.readmeText)
|
||||
const fallback = contentFallback ?? deriveIdentityFallback(args)
|
||||
const apiKey = process.env.OPENAI_API_KEY
|
||||
if (!apiKey) return fallback
|
||||
if (!contentFallback) return fallback
|
||||
|
||||
const input = [
|
||||
`Skill slug: ${args.slug}`,
|
||||
`Display name: ${args.displayName}`,
|
||||
`SKILL.md:\n${clampText(args.readmeText, MAX_README_CHARS)}`,
|
||||
].join('\n\n')
|
||||
|
||||
try {
|
||||
const response = await fetch('https://api.openai.com/v1/responses', {
|
||||
method: 'POST',
|
||||
headers: {
|
||||
'Content-Type': 'application/json',
|
||||
Authorization: `Bearer ${apiKey}`,
|
||||
},
|
||||
body: JSON.stringify({
|
||||
model: SKILL_SUMMARY_MODEL,
|
||||
instructions:
|
||||
'Write a concise public skill description. Return plain text only, one sentence, max 160 characters. No markdown. No quotes. No hype. Be specific and accurate to SKILL.md.',
|
||||
input,
|
||||
max_output_tokens: 90,
|
||||
}),
|
||||
})
|
||||
if (!response.ok) return fallback
|
||||
const payload = (await response.json()) as unknown
|
||||
return normalizeSummary(extractResponseText(payload)) ?? fallback
|
||||
} catch {
|
||||
return fallback
|
||||
}
|
||||
}
|
||||
|
||||
export const __test = {
|
||||
clampText,
|
||||
deriveSummaryFallback,
|
||||
normalizeSummary,
|
||||
}
|
||||
@@ -0,0 +1,139 @@
|
||||
/* @vitest-environment node */
|
||||
|
||||
import { unzipSync } from 'fflate'
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import { buildDeterministicZip, buildSkillMeta, type SkillZipMeta } from './skillZip'
|
||||
|
||||
describe('skillZip', () => {
|
||||
describe('buildSkillMeta', () => {
|
||||
it('returns metadata object with all fields', () => {
|
||||
const meta: SkillZipMeta = {
|
||||
ownerId: 'user123',
|
||||
slug: 'my-skill',
|
||||
version: '1.0.0',
|
||||
publishedAt: 1700000000000,
|
||||
}
|
||||
const result = buildSkillMeta(meta)
|
||||
expect(result).toEqual({
|
||||
ownerId: 'user123',
|
||||
slug: 'my-skill',
|
||||
version: '1.0.0',
|
||||
publishedAt: 1700000000000,
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
describe('buildDeterministicZip', () => {
|
||||
it('creates a zip with provided entries', () => {
|
||||
const entries = [
|
||||
{ path: 'SKILL.md', bytes: new TextEncoder().encode('# My Skill') },
|
||||
{ path: 'README.txt', bytes: new TextEncoder().encode('Hello') },
|
||||
]
|
||||
const zip = buildDeterministicZip(entries)
|
||||
const unzipped = unzipSync(zip)
|
||||
|
||||
expect(Object.keys(unzipped).sort()).toEqual(['README.txt', 'SKILL.md'])
|
||||
expect(new TextDecoder().decode(unzipped['SKILL.md'])).toBe('# My Skill')
|
||||
expect(new TextDecoder().decode(unzipped['README.txt'])).toBe('Hello')
|
||||
})
|
||||
|
||||
it('sorts entries alphabetically for deterministic output', () => {
|
||||
const entries1 = [
|
||||
{ path: 'b.txt', bytes: new TextEncoder().encode('B') },
|
||||
{ path: 'a.txt', bytes: new TextEncoder().encode('A') },
|
||||
]
|
||||
const entries2 = [
|
||||
{ path: 'a.txt', bytes: new TextEncoder().encode('A') },
|
||||
{ path: 'b.txt', bytes: new TextEncoder().encode('B') },
|
||||
]
|
||||
|
||||
const zip1 = buildDeterministicZip(entries1)
|
||||
const zip2 = buildDeterministicZip(entries2)
|
||||
|
||||
// Both should produce identical zips regardless of input order
|
||||
expect(Array.from(zip1)).toEqual(Array.from(zip2))
|
||||
})
|
||||
|
||||
it('includes _meta.json when meta is provided', () => {
|
||||
const entries = [{ path: 'SKILL.md', bytes: new TextEncoder().encode('# Hello') }]
|
||||
const meta: SkillZipMeta = {
|
||||
ownerId: 'user456',
|
||||
slug: 'test-skill',
|
||||
version: '2.0.0',
|
||||
publishedAt: 1700000000000,
|
||||
}
|
||||
|
||||
const zip = buildDeterministicZip(entries, meta)
|
||||
const unzipped = unzipSync(zip)
|
||||
|
||||
expect(Object.keys(unzipped).sort()).toEqual(['SKILL.md', '_meta.json'])
|
||||
const metaContent = JSON.parse(new TextDecoder().decode(unzipped['_meta.json']))
|
||||
expect(metaContent).toEqual({
|
||||
ownerId: 'user456',
|
||||
slug: 'test-skill',
|
||||
version: '2.0.0',
|
||||
publishedAt: 1700000000000,
|
||||
})
|
||||
})
|
||||
|
||||
it('does not include _meta.json when meta is undefined', () => {
|
||||
const entries = [{ path: 'SKILL.md', bytes: new TextEncoder().encode('# Hello') }]
|
||||
const zip = buildDeterministicZip(entries)
|
||||
const unzipped = unzipSync(zip)
|
||||
|
||||
expect(Object.keys(unzipped)).toEqual(['SKILL.md'])
|
||||
})
|
||||
|
||||
it('produces deterministic output for same inputs', () => {
|
||||
const entries = [
|
||||
{ path: 'file1.md', bytes: new TextEncoder().encode('content1') },
|
||||
{ path: 'file2.md', bytes: new TextEncoder().encode('content2') },
|
||||
]
|
||||
const meta: SkillZipMeta = {
|
||||
ownerId: 'owner',
|
||||
slug: 'slug',
|
||||
version: '1.0.0',
|
||||
publishedAt: 1700000000000,
|
||||
}
|
||||
|
||||
const zip1 = buildDeterministicZip(entries, meta)
|
||||
const zip2 = buildDeterministicZip(entries, meta)
|
||||
|
||||
// Should be byte-for-byte identical
|
||||
expect(Array.from(zip1)).toEqual(Array.from(zip2))
|
||||
})
|
||||
|
||||
it('handles empty entries array', () => {
|
||||
const zip = buildDeterministicZip([])
|
||||
const unzipped = unzipSync(zip)
|
||||
|
||||
expect(Object.keys(unzipped)).toEqual([])
|
||||
})
|
||||
|
||||
it('handles empty entries array with meta', () => {
|
||||
const meta: SkillZipMeta = {
|
||||
ownerId: 'owner',
|
||||
slug: 'slug',
|
||||
version: '1.0.0',
|
||||
publishedAt: 1700000000000,
|
||||
}
|
||||
const zip = buildDeterministicZip([], meta)
|
||||
const unzipped = unzipSync(zip)
|
||||
|
||||
expect(Object.keys(unzipped)).toEqual(['_meta.json'])
|
||||
})
|
||||
|
||||
it('handles nested paths', () => {
|
||||
const entries = [
|
||||
{ path: 'docs/readme.md', bytes: new TextEncoder().encode('docs') },
|
||||
{ path: 'src/index.ts', bytes: new TextEncoder().encode('code') },
|
||||
{ path: 'SKILL.md', bytes: new TextEncoder().encode('skill') },
|
||||
]
|
||||
|
||||
const zip = buildDeterministicZip(entries)
|
||||
const unzipped = unzipSync(zip)
|
||||
|
||||
expect(Object.keys(unzipped).sort()).toEqual(['SKILL.md', 'docs/readme.md', 'src/index.ts'])
|
||||
})
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,42 @@
|
||||
import { zipSync } from 'fflate'
|
||||
|
||||
type ZipEntry = {
|
||||
path: string
|
||||
bytes: Uint8Array
|
||||
}
|
||||
|
||||
export type SkillZipMeta = {
|
||||
ownerId: string
|
||||
slug: string
|
||||
version: string
|
||||
publishedAt: number
|
||||
}
|
||||
|
||||
type ZipInput = Record<string, Uint8Array | [Uint8Array, { mtime?: Date }]>
|
||||
|
||||
const FIXED_ZIP_DATE = new Date(1980, 0, 1, 0, 0, 0)
|
||||
|
||||
export function buildSkillMeta(meta: SkillZipMeta) {
|
||||
return {
|
||||
ownerId: meta.ownerId,
|
||||
slug: meta.slug,
|
||||
version: meta.version,
|
||||
publishedAt: meta.publishedAt,
|
||||
}
|
||||
}
|
||||
|
||||
export function buildDeterministicZip(entries: ZipEntry[], meta?: SkillZipMeta) {
|
||||
const sorted = [...entries].sort((a, b) => a.path.localeCompare(b.path))
|
||||
const zipData: ZipInput = {}
|
||||
|
||||
for (const entry of sorted) {
|
||||
zipData[entry.path] = [entry.bytes, { mtime: FIXED_ZIP_DATE }]
|
||||
}
|
||||
|
||||
if (meta) {
|
||||
const metaContent = new TextEncoder().encode(JSON.stringify(buildSkillMeta(meta), null, 2))
|
||||
zipData['_meta.json'] = [metaContent, { mtime: FIXED_ZIP_DATE }]
|
||||
}
|
||||
|
||||
return Uint8Array.from(zipSync(zipData, { level: 6 }))
|
||||
}
|
||||
@@ -49,7 +49,9 @@ export function getFrontmatterMetadata(frontmatter: ParsedSkillFrontmatter) {
|
||||
if (!raw) return undefined
|
||||
if (typeof raw === 'string') {
|
||||
try {
|
||||
const parsed = JSON.parse(raw) as unknown
|
||||
// Strip trailing commas in JSON objects/arrays (common authoring mistake)
|
||||
const cleaned = raw.replace(/,\s*([\]}])/g, '$1')
|
||||
const parsed = JSON.parse(cleaned) as unknown
|
||||
return parsed ?? undefined
|
||||
} catch {
|
||||
return undefined
|
||||
@@ -67,12 +69,15 @@ export function parseClawdisMetadata(frontmatter: ParsedSkillFrontmatter) {
|
||||
: undefined
|
||||
const clawdbotMeta = metadataRecord?.clawdbot
|
||||
const clawdisMeta = metadataRecord?.clawdis
|
||||
const openclawMeta = metadataRecord?.openclaw
|
||||
const metadataSource =
|
||||
clawdbotMeta && typeof clawdbotMeta === 'object' && !Array.isArray(clawdbotMeta)
|
||||
? (clawdbotMeta as Record<string, unknown>)
|
||||
: clawdisMeta && typeof clawdisMeta === 'object' && !Array.isArray(clawdisMeta)
|
||||
? (clawdisMeta as Record<string, unknown>)
|
||||
: undefined
|
||||
: openclawMeta && typeof openclawMeta === 'object' && !Array.isArray(openclawMeta)
|
||||
? (openclawMeta as Record<string, unknown>)
|
||||
: undefined
|
||||
const clawdisRaw = metadataSource ?? frontmatter.clawdis
|
||||
if (!clawdisRaw || typeof clawdisRaw !== 'object' || Array.isArray(clawdisRaw)) return undefined
|
||||
|
||||
|
||||
@@ -4,6 +4,7 @@ import { internal } from '../_generated/api'
|
||||
import type { Doc, Id } from '../_generated/dataModel'
|
||||
import type { ActionCtx } from '../_generated/server'
|
||||
import { generateEmbedding } from './embeddings'
|
||||
import { requireGitHubAccountAge } from './githubAccount'
|
||||
import {
|
||||
buildEmbeddingText,
|
||||
getFrontmatterMetadata,
|
||||
@@ -90,6 +91,9 @@ export async function publishSoulVersionForUser(
|
||||
if (!semver.valid(version)) {
|
||||
throw new ConvexError('Version must be valid semver')
|
||||
}
|
||||
|
||||
await requireGitHubAccountAge(ctx, userId)
|
||||
|
||||
const suppliedChangelog = args.changelog.trim()
|
||||
const changelogSource = suppliedChangelog ? ('user' as const) : ('auto' as const)
|
||||
|
||||
|
||||
@@ -0,0 +1,68 @@
|
||||
import type { Doc } from '../_generated/dataModel'
|
||||
|
||||
type UserSearchResult = {
|
||||
items: Doc<'users'>[]
|
||||
total: number
|
||||
}
|
||||
|
||||
type UserSearchMatch = {
|
||||
user: Doc<'users'>
|
||||
score: number
|
||||
}
|
||||
|
||||
function normalizeCompact(value: string) {
|
||||
return value.toLowerCase().replace(/[^a-z0-9]/g, '')
|
||||
}
|
||||
|
||||
function scoreUser(user: Doc<'users'>, query: string, compactQuery: string) {
|
||||
const handle = user.handle?.toLowerCase() ?? ''
|
||||
const name = user.name?.toLowerCase() ?? ''
|
||||
const displayName = user.displayName?.toLowerCase() ?? ''
|
||||
const email = user.email?.toLowerCase() ?? ''
|
||||
const id = String(user._id).toLowerCase()
|
||||
|
||||
let score = 0
|
||||
|
||||
if (id === query) score = Math.max(score, 100)
|
||||
if (handle === query) score = Math.max(score, 96)
|
||||
if (displayName === query || name === query) score = Math.max(score, 90)
|
||||
|
||||
if (handle.startsWith(query)) score = Math.max(score, 82)
|
||||
if (displayName.startsWith(query) || name.startsWith(query)) score = Math.max(score, 72)
|
||||
|
||||
if (handle.includes(query)) score = Math.max(score, 62)
|
||||
if (displayName.includes(query) || name.includes(query)) score = Math.max(score, 52)
|
||||
if (email.includes(query)) score = Math.max(score, 42)
|
||||
if (id.includes(query)) score = Math.max(score, 40)
|
||||
|
||||
if (compactQuery.length >= 2) {
|
||||
const compactHandle = normalizeCompact(handle)
|
||||
const compactName = normalizeCompact(displayName || name)
|
||||
if (compactHandle === compactQuery) score = Math.max(score, 88)
|
||||
if (compactHandle.includes(compactQuery)) score = Math.max(score, 58)
|
||||
if (compactName.includes(compactQuery)) score = Math.max(score, 48)
|
||||
}
|
||||
|
||||
return score
|
||||
}
|
||||
|
||||
export function buildUserSearchResults(users: Doc<'users'>[], query?: string): UserSearchResult {
|
||||
const trimmed = query?.trim() ?? ''
|
||||
if (!trimmed) return { items: users, total: users.length }
|
||||
|
||||
const normalized = trimmed.toLowerCase()
|
||||
const compactQuery = normalizeCompact(normalized)
|
||||
const matches: UserSearchMatch[] = []
|
||||
|
||||
for (const user of users) {
|
||||
const score = scoreUser(user, normalized, compactQuery)
|
||||
if (score > 0) matches.push({ user, score })
|
||||
}
|
||||
|
||||
matches.sort((a, b) => {
|
||||
if (b.score !== a.score) return b.score - a.score
|
||||
return b.user._creationTime - a.user._creationTime
|
||||
})
|
||||
|
||||
return { items: matches.map((entry) => entry.user), total: matches.length }
|
||||
}
|
||||
@@ -72,7 +72,7 @@ export function buildDiscordPayload(
|
||||
},
|
||||
],
|
||||
footer: {
|
||||
text: 'OpenClaw',
|
||||
text: 'ClawHub',
|
||||
},
|
||||
timestamp: new Date().toISOString(),
|
||||
},
|
||||
@@ -89,9 +89,9 @@ export function buildSkillUrl(skill: WebhookSkillPayload, siteUrl: string) {
|
||||
function buildDescription(event: WebhookEvent, skill: WebhookSkillPayload) {
|
||||
const summary = (skill.summary ?? '').trim()
|
||||
if (summary) return truncate(summary, 200)
|
||||
if (event === 'skill.highlighted') return 'Newly highlighted skill on OpenClaw.'
|
||||
if (skill.version) return `New version v${skill.version} published on OpenClaw.`
|
||||
return 'New skill published on OpenClaw.'
|
||||
if (event === 'skill.highlighted') return 'Newly highlighted skill on ClawHub.'
|
||||
if (skill.version) return `New version v${skill.version} published on ClawHub.`
|
||||
return 'New skill published on ClawHub.'
|
||||
}
|
||||
|
||||
function parseBoolean(value?: string) {
|
||||
|
||||
@@ -0,0 +1,383 @@
|
||||
import { v } from 'convex/values'
|
||||
import { internal } from './_generated/api'
|
||||
import type { Doc, Id } from './_generated/dataModel'
|
||||
import { internalAction } from './_generated/server'
|
||||
import type { SkillEvalContext } from './lib/securityPrompt'
|
||||
import {
|
||||
assembleEvalUserMessage,
|
||||
detectInjectionPatterns,
|
||||
getLlmEvalModel,
|
||||
LLM_EVAL_MAX_OUTPUT_TOKENS,
|
||||
parseLlmEvalResponse,
|
||||
SECURITY_EVALUATOR_SYSTEM_PROMPT,
|
||||
} from './lib/securityPrompt'
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Helpers
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
function extractResponseText(payload: unknown): string | null {
|
||||
if (!payload || typeof payload !== 'object') return null
|
||||
const output = (payload as { output?: unknown }).output
|
||||
if (!Array.isArray(output)) return null
|
||||
const chunks: string[] = []
|
||||
for (const item of output) {
|
||||
if (!item || typeof item !== 'object') continue
|
||||
if ((item as { type?: unknown }).type !== 'message') continue
|
||||
const content = (item as { content?: unknown }).content
|
||||
if (!Array.isArray(content)) continue
|
||||
for (const part of content) {
|
||||
if (!part || typeof part !== 'object') continue
|
||||
if ((part as { type?: unknown }).type !== 'output_text') continue
|
||||
const text = (part as { text?: unknown }).text
|
||||
if (typeof text === 'string' && text.trim()) chunks.push(text)
|
||||
}
|
||||
}
|
||||
const joined = chunks.join('\n').trim()
|
||||
return joined || null
|
||||
}
|
||||
|
||||
function verdictToStatus(verdict: string): string {
|
||||
switch (verdict) {
|
||||
case 'benign':
|
||||
return 'clean'
|
||||
case 'malicious':
|
||||
return 'malicious'
|
||||
case 'suspicious':
|
||||
return 'suspicious'
|
||||
default:
|
||||
return 'pending'
|
||||
}
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Publish-time evaluation action
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
export const evaluateWithLlm = internalAction({
|
||||
args: {
|
||||
versionId: v.id('skillVersions'),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const apiKey = process.env.OPENAI_API_KEY
|
||||
if (!apiKey) {
|
||||
console.log('[llmEval] OPENAI_API_KEY not configured, skipping evaluation')
|
||||
return
|
||||
}
|
||||
|
||||
const model = getLlmEvalModel()
|
||||
|
||||
// Store error helper
|
||||
const storeError = async (message: string) => {
|
||||
console.error(`[llmEval] ${message}`)
|
||||
await ctx.runMutation(internal.skills.updateVersionLlmAnalysisInternal, {
|
||||
versionId: args.versionId,
|
||||
llmAnalysis: {
|
||||
status: 'error',
|
||||
summary: message,
|
||||
model,
|
||||
checkedAt: Date.now(),
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
// 1. Fetch version
|
||||
const version = (await ctx.runQuery(internal.skills.getVersionByIdInternal, {
|
||||
versionId: args.versionId,
|
||||
})) as Doc<'skillVersions'> | null
|
||||
|
||||
if (!version) {
|
||||
await storeError(`Version ${args.versionId} not found`)
|
||||
return
|
||||
}
|
||||
|
||||
// 2. Fetch skill
|
||||
const skill = (await ctx.runQuery(internal.skills.getSkillByIdInternal, {
|
||||
skillId: version.skillId,
|
||||
})) as Doc<'skills'> | null
|
||||
|
||||
if (!skill) {
|
||||
await storeError(`Skill ${version.skillId} not found`)
|
||||
return
|
||||
}
|
||||
|
||||
// 3. Read SKILL.md content
|
||||
const skillMdFile = version.files.find((f) => {
|
||||
const lower = f.path.toLowerCase()
|
||||
return lower === 'skill.md' || lower === 'skills.md'
|
||||
})
|
||||
|
||||
let skillMdContent = ''
|
||||
if (skillMdFile) {
|
||||
const blob = await ctx.storage.get(skillMdFile.storageId as Id<'_storage'>)
|
||||
if (blob) {
|
||||
skillMdContent = await blob.text()
|
||||
}
|
||||
}
|
||||
|
||||
if (!skillMdContent) {
|
||||
await storeError('No SKILL.md content found')
|
||||
return
|
||||
}
|
||||
|
||||
// 4. Read all file contents
|
||||
const fileContents: Array<{ path: string; content: string }> = []
|
||||
for (const f of version.files) {
|
||||
const lower = f.path.toLowerCase()
|
||||
if (lower === 'skill.md' || lower === 'skills.md') continue
|
||||
try {
|
||||
const blob = await ctx.storage.get(f.storageId as Id<'_storage'>)
|
||||
if (blob) {
|
||||
fileContents.push({ path: f.path, content: await blob.text() })
|
||||
}
|
||||
} catch {
|
||||
// Skip files that can't be read
|
||||
}
|
||||
}
|
||||
|
||||
// 5. Detect injection patterns across ALL content
|
||||
const allContent = [skillMdContent, ...fileContents.map((f) => f.content)].join('\n')
|
||||
const injectionSignals = detectInjectionPatterns(allContent)
|
||||
|
||||
// 6. Build eval context
|
||||
const parsed = version.parsed as SkillEvalContext['parsed']
|
||||
const fm = parsed.frontmatter ?? {}
|
||||
|
||||
const evalCtx: SkillEvalContext = {
|
||||
slug: skill.slug,
|
||||
displayName: skill.displayName,
|
||||
ownerUserId: String(skill.ownerUserId),
|
||||
version: version.version,
|
||||
createdAt: version.createdAt,
|
||||
summary: (skill.summary as string | undefined) ?? undefined,
|
||||
source: (fm.source as string | undefined) ?? undefined,
|
||||
homepage: (fm.homepage as string | undefined) ?? undefined,
|
||||
parsed,
|
||||
files: version.files.map((f) => ({ path: f.path, size: f.size })),
|
||||
skillMdContent,
|
||||
fileContents,
|
||||
injectionSignals,
|
||||
}
|
||||
|
||||
// 6. Assemble user message
|
||||
const userMessage = assembleEvalUserMessage(evalCtx)
|
||||
|
||||
// 7. Call OpenAI Responses API (with retry for rate limits)
|
||||
const MAX_RETRIES = 3
|
||||
let raw: string | null = null
|
||||
try {
|
||||
const body = JSON.stringify({
|
||||
model,
|
||||
instructions: SECURITY_EVALUATOR_SYSTEM_PROMPT,
|
||||
input: userMessage,
|
||||
max_output_tokens: LLM_EVAL_MAX_OUTPUT_TOKENS,
|
||||
text: {
|
||||
format: {
|
||||
type: 'json_object',
|
||||
},
|
||||
},
|
||||
})
|
||||
|
||||
let response: Response | null = null
|
||||
for (let attempt = 0; attempt <= MAX_RETRIES; attempt++) {
|
||||
response = await fetch('https://api.openai.com/v1/responses', {
|
||||
method: 'POST',
|
||||
headers: {
|
||||
'Content-Type': 'application/json',
|
||||
Authorization: `Bearer ${apiKey}`,
|
||||
},
|
||||
body,
|
||||
})
|
||||
|
||||
if (response.status === 429 || response.status >= 500) {
|
||||
if (attempt < MAX_RETRIES) {
|
||||
const delay = 2 ** attempt * 2000 + Math.random() * 1000
|
||||
console.log(
|
||||
`[llmEval] Rate limited (${response.status}), retrying in ${Math.round(delay)}ms (attempt ${attempt + 1}/${MAX_RETRIES})`,
|
||||
)
|
||||
await new Promise((r) => setTimeout(r, delay))
|
||||
continue
|
||||
}
|
||||
}
|
||||
break
|
||||
}
|
||||
|
||||
if (!response || !response.ok) {
|
||||
const errorText = response ? await response.text() : 'No response'
|
||||
await storeError(`OpenAI API error (${response?.status}): ${errorText.slice(0, 200)}`)
|
||||
return
|
||||
}
|
||||
|
||||
const payload = (await response.json()) as unknown
|
||||
raw = extractResponseText(payload)
|
||||
} catch (error) {
|
||||
await storeError(
|
||||
`OpenAI API call failed: ${error instanceof Error ? error.message : String(error)}`,
|
||||
)
|
||||
return
|
||||
}
|
||||
|
||||
if (!raw) {
|
||||
await storeError('Empty response from OpenAI')
|
||||
return
|
||||
}
|
||||
|
||||
// 8. Parse response
|
||||
const result = parseLlmEvalResponse(raw)
|
||||
|
||||
if (!result) {
|
||||
console.error(`[llmEval] Raw response (first 500 chars): ${raw.slice(0, 500)}`)
|
||||
await storeError('Failed to parse LLM evaluation response')
|
||||
return
|
||||
}
|
||||
|
||||
// 9. Store result
|
||||
await ctx.runMutation(internal.skills.updateVersionLlmAnalysisInternal, {
|
||||
versionId: args.versionId,
|
||||
llmAnalysis: {
|
||||
status: verdictToStatus(result.verdict),
|
||||
verdict: result.verdict,
|
||||
confidence: result.confidence,
|
||||
summary: result.summary,
|
||||
dimensions: result.dimensions,
|
||||
guidance: result.guidance,
|
||||
findings: result.findings || undefined,
|
||||
model,
|
||||
checkedAt: Date.now(),
|
||||
},
|
||||
})
|
||||
|
||||
console.log(
|
||||
`[llmEval] Evaluated ${skill.slug}@${version.version}: ${result.verdict} (${result.confidence} confidence)`,
|
||||
)
|
||||
|
||||
// Moderation visibility is finalized by VT results.
|
||||
// LLM eval only stores analysis payload on the version.
|
||||
},
|
||||
})
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Convenience: evaluate a single skill by slug (for testing / manual runs)
|
||||
// Usage: npx convex run llmEval:evaluateBySlug '{"slug": "transcribeexx"}'
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
export const evaluateBySlug = internalAction({
|
||||
args: {
|
||||
slug: v.string(),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const skill = (await ctx.runQuery(internal.skills.getSkillBySlugInternal, {
|
||||
slug: args.slug,
|
||||
})) as Doc<'skills'> | null
|
||||
|
||||
if (!skill) {
|
||||
console.error(`[llmEval:bySlug] Skill "${args.slug}" not found`)
|
||||
return { error: 'Skill not found' }
|
||||
}
|
||||
|
||||
if (!skill.latestVersionId) {
|
||||
console.error(`[llmEval:bySlug] Skill "${args.slug}" has no published version`)
|
||||
return { error: 'No published version' }
|
||||
}
|
||||
|
||||
console.log(`[llmEval:bySlug] Evaluating ${args.slug} (versionId: ${skill.latestVersionId})`)
|
||||
|
||||
await ctx.scheduler.runAfter(0, internal.llmEval.evaluateWithLlm, {
|
||||
versionId: skill.latestVersionId,
|
||||
})
|
||||
|
||||
return { ok: true, slug: args.slug, versionId: skill.latestVersionId }
|
||||
},
|
||||
})
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Backfill action (Phase 2)
|
||||
// Schedules individual evaluateWithLlm actions for each skill in the batch,
|
||||
// then self-schedules the next batch. Each eval runs as its own action
|
||||
// invocation so we don't hit Convex action timeouts.
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
export const backfillLlmEval = internalAction({
|
||||
args: {
|
||||
cursor: v.optional(v.number()),
|
||||
batchSize: v.optional(v.number()),
|
||||
accTotal: v.optional(v.number()),
|
||||
accScheduled: v.optional(v.number()),
|
||||
accSkipped: v.optional(v.number()),
|
||||
startTime: v.optional(v.number()),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const startTime = args.startTime ?? Date.now()
|
||||
const apiKey = process.env.OPENAI_API_KEY
|
||||
if (!apiKey) {
|
||||
console.log('[llmEval:backfill] OPENAI_API_KEY not configured')
|
||||
return { error: 'OPENAI_API_KEY not configured' }
|
||||
}
|
||||
|
||||
const batchSize = args.batchSize ?? 25
|
||||
const cursor = args.cursor ?? 0
|
||||
let accTotal = args.accTotal ?? 0
|
||||
let accScheduled = args.accScheduled ?? 0
|
||||
let accSkipped = args.accSkipped ?? 0
|
||||
|
||||
const batch = await ctx.runQuery(internal.skills.getActiveSkillBatchForLlmBackfillInternal, {
|
||||
cursor,
|
||||
batchSize,
|
||||
})
|
||||
|
||||
if (batch.skills.length === 0 && batch.done) {
|
||||
console.log('[llmEval:backfill] No more skills to evaluate')
|
||||
return { total: accTotal, scheduled: accScheduled, skipped: accSkipped }
|
||||
}
|
||||
|
||||
console.log(
|
||||
`[llmEval:backfill] Processing batch of ${batch.skills.length} skills (cursor=${cursor}, accumulated=${accTotal})`,
|
||||
)
|
||||
|
||||
for (const { versionId, slug } of batch.skills) {
|
||||
// Re-evaluate all (full file content reading upgrade)
|
||||
const version = (await ctx.runQuery(internal.skills.getVersionByIdInternal, {
|
||||
versionId,
|
||||
})) as Doc<'skillVersions'> | null
|
||||
|
||||
if (!version) {
|
||||
accSkipped++
|
||||
continue
|
||||
}
|
||||
|
||||
// Schedule each evaluation as a separate action invocation
|
||||
await ctx.scheduler.runAfter(0, internal.llmEval.evaluateWithLlm, { versionId })
|
||||
accScheduled++
|
||||
console.log(`[llmEval:backfill] Scheduled eval for ${slug}`)
|
||||
}
|
||||
|
||||
accTotal += batch.skills.length
|
||||
|
||||
if (!batch.done) {
|
||||
// Delay the next batch slightly to avoid overwhelming the scheduler
|
||||
// when all evals from this batch are also running
|
||||
console.log(
|
||||
`[llmEval:backfill] Scheduling next batch (cursor=${batch.nextCursor}, total so far=${accTotal})`,
|
||||
)
|
||||
await ctx.scheduler.runAfter(5_000, internal.llmEval.backfillLlmEval, {
|
||||
cursor: batch.nextCursor,
|
||||
batchSize,
|
||||
accTotal,
|
||||
accScheduled,
|
||||
accSkipped,
|
||||
startTime,
|
||||
})
|
||||
return { status: 'continuing', totalSoFar: accTotal }
|
||||
}
|
||||
|
||||
const durationMs = Date.now() - startTime
|
||||
const result = {
|
||||
total: accTotal,
|
||||
scheduled: accScheduled,
|
||||
skipped: accSkipped,
|
||||
durationMs,
|
||||
}
|
||||
console.log('[llmEval:backfill] Complete:', result)
|
||||
return result
|
||||
},
|
||||
})
|
||||
+282
-2
@@ -12,12 +12,34 @@ vi.mock('./_generated/api', () => ({
|
||||
'applySkillFingerprintBackfillPatchInternal',
|
||||
),
|
||||
backfillSkillFingerprintsInternal: Symbol('backfillSkillFingerprintsInternal'),
|
||||
getEmptySkillCleanupPageInternal: Symbol('getEmptySkillCleanupPageInternal'),
|
||||
applyEmptySkillCleanupInternal: Symbol('applyEmptySkillCleanupInternal'),
|
||||
nominateUserForEmptySkillSpamInternal: Symbol('nominateUserForEmptySkillSpamInternal'),
|
||||
cleanupEmptySkillsInternal: Symbol('cleanupEmptySkillsInternal'),
|
||||
nominateEmptySkillSpammersInternal: Symbol('nominateEmptySkillSpammersInternal'),
|
||||
},
|
||||
skills: {
|
||||
getVersionByIdInternal: Symbol('skills.getVersionByIdInternal'),
|
||||
getOwnerSkillActivityInternal: Symbol('skills.getOwnerSkillActivityInternal'),
|
||||
},
|
||||
users: {
|
||||
getByIdInternal: Symbol('users.getByIdInternal'),
|
||||
},
|
||||
},
|
||||
}))
|
||||
|
||||
const { backfillSkillFingerprintsInternalHandler, backfillSkillSummariesInternalHandler } =
|
||||
await import('./maintenance')
|
||||
vi.mock('./lib/skillSummary', () => ({
|
||||
generateSkillSummary: vi.fn(),
|
||||
}))
|
||||
|
||||
const {
|
||||
backfillSkillFingerprintsInternalHandler,
|
||||
backfillSkillSummariesInternalHandler,
|
||||
cleanupEmptySkillsInternalHandler,
|
||||
nominateEmptySkillSpammersInternalHandler,
|
||||
} = await import('./maintenance')
|
||||
const { internal } = await import('./_generated/api')
|
||||
const { generateSkillSummary } = await import('./lib/skillSummary')
|
||||
|
||||
function makeBlob(text: string) {
|
||||
return { text: () => Promise.resolve(text) } as unknown as Blob
|
||||
@@ -30,6 +52,8 @@ describe('maintenance backfill', () => {
|
||||
{
|
||||
kind: 'ok',
|
||||
skillId: 'skills:1',
|
||||
skillSlug: 'skill-1',
|
||||
skillDisplayName: 'Skill 1',
|
||||
versionId: 'skillVersions:1',
|
||||
skillSummary: '>',
|
||||
versionParsed: { frontmatter: { description: '>' } },
|
||||
@@ -73,6 +97,8 @@ describe('maintenance backfill', () => {
|
||||
{
|
||||
kind: 'ok',
|
||||
skillId: 'skills:1',
|
||||
skillSlug: 'skill-1',
|
||||
skillDisplayName: 'Skill 1',
|
||||
versionId: 'skillVersions:1',
|
||||
skillSummary: '>',
|
||||
versionParsed: { frontmatter: { description: '>' } },
|
||||
@@ -102,6 +128,8 @@ describe('maintenance backfill', () => {
|
||||
{
|
||||
kind: 'ok',
|
||||
skillId: 'skills:1',
|
||||
skillSlug: 'skill-1',
|
||||
skillDisplayName: 'Skill 1',
|
||||
versionId: 'skillVersions:1',
|
||||
skillSummary: null,
|
||||
versionParsed: { frontmatter: {} },
|
||||
@@ -123,6 +151,49 @@ describe('maintenance backfill', () => {
|
||||
expect(result.stats.missingStorageBlob).toBe(1)
|
||||
expect(runMutation).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('fills empty summary via AI when useAi is enabled', async () => {
|
||||
vi.mocked(generateSkillSummary).mockResolvedValue('AI generated summary.')
|
||||
|
||||
const runQuery = vi.fn().mockResolvedValue({
|
||||
items: [
|
||||
{
|
||||
kind: 'ok',
|
||||
skillId: 'skills:1',
|
||||
skillSlug: 'ai-skill',
|
||||
skillDisplayName: 'AI Skill',
|
||||
versionId: 'skillVersions:1',
|
||||
skillSummary: null,
|
||||
versionParsed: { frontmatter: {} },
|
||||
readmeStorageId: 'storage:1',
|
||||
},
|
||||
],
|
||||
cursor: null,
|
||||
isDone: true,
|
||||
})
|
||||
|
||||
const runMutation = vi.fn().mockResolvedValue({ ok: true })
|
||||
const storageGet = vi.fn().mockResolvedValue(makeBlob('# AI Skill\n\nUseful automation.'))
|
||||
|
||||
const result = await backfillSkillSummariesInternalHandler(
|
||||
{ runQuery, runMutation, storage: { get: storageGet } } as never,
|
||||
{ dryRun: false, batchSize: 10, maxBatches: 1, useAi: true },
|
||||
)
|
||||
|
||||
expect(result.ok).toBe(true)
|
||||
expect(result.stats.skillsPatched).toBe(1)
|
||||
expect(result.stats.aiSummariesPatched).toBe(1)
|
||||
expect(runMutation).toHaveBeenCalledWith(expect.anything(), {
|
||||
skillId: 'skills:1',
|
||||
versionId: 'skillVersions:1',
|
||||
summary: 'AI generated summary.',
|
||||
parsed: {
|
||||
frontmatter: {},
|
||||
metadata: undefined,
|
||||
clawdis: undefined,
|
||||
},
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
describe('maintenance fingerprint backfill', () => {
|
||||
@@ -268,3 +339,212 @@ describe('maintenance fingerprint backfill', () => {
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
describe('maintenance empty skill cleanup', () => {
|
||||
it('dryRun detects empty skills and returns nominations', async () => {
|
||||
const runQuery = vi.fn().mockImplementation(async (endpoint: unknown) => {
|
||||
if (endpoint === internal.maintenance.getEmptySkillCleanupPageInternal) {
|
||||
return {
|
||||
items: [
|
||||
{
|
||||
skillId: 'skills:1',
|
||||
slug: 'spam-skill',
|
||||
ownerUserId: 'users:1',
|
||||
latestVersionId: 'skillVersions:1',
|
||||
softDeletedAt: undefined,
|
||||
summary: 'Expert guidance for spam-skill.',
|
||||
},
|
||||
],
|
||||
cursor: null,
|
||||
isDone: true,
|
||||
}
|
||||
}
|
||||
if (endpoint === internal.skills.getVersionByIdInternal) {
|
||||
return {
|
||||
_id: 'skillVersions:1',
|
||||
files: [{ path: 'SKILL.md', size: 120, storageId: 'storage:1' }],
|
||||
}
|
||||
}
|
||||
if (endpoint === internal.users.getByIdInternal) {
|
||||
return { _id: 'users:1', handle: 'spammer', _creationTime: Date.now() }
|
||||
}
|
||||
if (endpoint === internal.skills.getOwnerSkillActivityInternal) {
|
||||
return []
|
||||
}
|
||||
throw new Error(`Unexpected endpoint: ${String(endpoint)}`)
|
||||
})
|
||||
|
||||
const runMutation = vi.fn()
|
||||
const storageGet = vi
|
||||
.fn()
|
||||
.mockResolvedValue(
|
||||
makeBlob(`# Demo\n- Step-by-step tutorials\n- Tips and techniques\n- Project ideas`),
|
||||
)
|
||||
|
||||
const result = await cleanupEmptySkillsInternalHandler(
|
||||
{ runQuery, runMutation, storage: { get: storageGet } } as never,
|
||||
{ dryRun: true, batchSize: 10, maxBatches: 1, nominationThreshold: 1 },
|
||||
)
|
||||
|
||||
expect(result.ok).toBe(true)
|
||||
expect(result.isDone).toBe(true)
|
||||
expect(result.cursor).toBeNull()
|
||||
expect(result.stats.emptyDetected).toBe(1)
|
||||
expect(result.stats.skillsDeleted).toBe(0)
|
||||
expect(result.nominations).toEqual([
|
||||
{
|
||||
userId: 'users:1',
|
||||
handle: 'spammer',
|
||||
emptySkillCount: 1,
|
||||
sampleSlugs: ['spam-skill'],
|
||||
},
|
||||
])
|
||||
expect(runMutation).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('apply mode deletes empty skills', async () => {
|
||||
const runQuery = vi.fn().mockImplementation(async (endpoint: unknown) => {
|
||||
if (endpoint === internal.maintenance.getEmptySkillCleanupPageInternal) {
|
||||
return {
|
||||
items: [
|
||||
{
|
||||
skillId: 'skills:1',
|
||||
slug: 'spam-a',
|
||||
ownerUserId: 'users:1',
|
||||
latestVersionId: 'skillVersions:1',
|
||||
summary: 'Expert guidance for spam-a.',
|
||||
},
|
||||
{
|
||||
skillId: 'skills:2',
|
||||
slug: 'spam-b',
|
||||
ownerUserId: 'users:1',
|
||||
latestVersionId: 'skillVersions:2',
|
||||
summary: 'Expert guidance for spam-b.',
|
||||
},
|
||||
],
|
||||
cursor: null,
|
||||
isDone: true,
|
||||
}
|
||||
}
|
||||
if (endpoint === internal.skills.getVersionByIdInternal) {
|
||||
return {
|
||||
files: [{ path: 'SKILL.md', size: 120, storageId: 'storage:1' }],
|
||||
}
|
||||
}
|
||||
if (endpoint === internal.users.getByIdInternal) {
|
||||
return { _id: 'users:1', handle: 'spammer', _creationTime: Date.now() }
|
||||
}
|
||||
if (endpoint === internal.skills.getOwnerSkillActivityInternal) {
|
||||
return []
|
||||
}
|
||||
throw new Error(`Unexpected endpoint: ${String(endpoint)}`)
|
||||
})
|
||||
|
||||
const runMutation = vi.fn().mockImplementation(async (endpoint: unknown) => {
|
||||
if (endpoint === internal.maintenance.applyEmptySkillCleanupInternal) {
|
||||
return { deleted: true }
|
||||
}
|
||||
throw new Error(`Unexpected mutation endpoint: ${String(endpoint)}`)
|
||||
})
|
||||
|
||||
const storageGet = vi
|
||||
.fn()
|
||||
.mockResolvedValue(
|
||||
makeBlob(`# Demo\n- Step-by-step tutorials\n- Tips and techniques\n- Project ideas`),
|
||||
)
|
||||
|
||||
const result = await cleanupEmptySkillsInternalHandler(
|
||||
{ runQuery, runMutation, storage: { get: storageGet } } as never,
|
||||
{ dryRun: false, batchSize: 10, maxBatches: 1, nominationThreshold: 2 },
|
||||
)
|
||||
|
||||
expect(result.ok).toBe(true)
|
||||
expect(result.isDone).toBe(true)
|
||||
expect(result.cursor).toBeNull()
|
||||
expect(result.stats.emptyDetected).toBe(2)
|
||||
expect(result.stats.skillsDeleted).toBe(2)
|
||||
expect(result.nominations).toEqual([
|
||||
{
|
||||
userId: 'users:1',
|
||||
handle: 'spammer',
|
||||
emptySkillCount: 2,
|
||||
sampleSlugs: ['spam-a', 'spam-b'],
|
||||
},
|
||||
])
|
||||
})
|
||||
})
|
||||
|
||||
describe('maintenance empty skill nominations', () => {
|
||||
it('creates ban nominations from backfilled empty deletions', async () => {
|
||||
const runQuery = vi.fn().mockImplementation(async (endpoint: unknown, args: unknown) => {
|
||||
if (endpoint === internal.maintenance.getEmptySkillCleanupPageInternal) {
|
||||
const cursor = (args as { cursor?: string | undefined }).cursor
|
||||
if (!cursor) {
|
||||
return {
|
||||
items: [
|
||||
{
|
||||
skillId: 'skills:1',
|
||||
slug: 'spam-a',
|
||||
ownerUserId: 'users:1',
|
||||
softDeletedAt: 1,
|
||||
moderationReason: 'quality.empty.backfill',
|
||||
},
|
||||
{
|
||||
skillId: 'skills:2',
|
||||
slug: 'spam-b',
|
||||
ownerUserId: 'users:1',
|
||||
softDeletedAt: 1,
|
||||
moderationReason: 'quality.empty.backfill',
|
||||
},
|
||||
],
|
||||
cursor: 'next',
|
||||
isDone: false,
|
||||
}
|
||||
}
|
||||
return {
|
||||
items: [
|
||||
{
|
||||
skillId: 'skills:3',
|
||||
slug: 'valid-hidden',
|
||||
ownerUserId: 'users:2',
|
||||
softDeletedAt: 1,
|
||||
moderationReason: 'scanner.vt.suspicious',
|
||||
},
|
||||
],
|
||||
cursor: null,
|
||||
isDone: true,
|
||||
}
|
||||
}
|
||||
if (endpoint === internal.users.getByIdInternal) {
|
||||
return { _id: 'users:1', handle: 'spammer' }
|
||||
}
|
||||
throw new Error(`Unexpected query endpoint: ${String(endpoint)}`)
|
||||
})
|
||||
|
||||
const runMutation = vi.fn().mockImplementation(async (endpoint: unknown) => {
|
||||
if (endpoint === internal.maintenance.nominateUserForEmptySkillSpamInternal) {
|
||||
return { created: true }
|
||||
}
|
||||
throw new Error(`Unexpected mutation endpoint: ${String(endpoint)}`)
|
||||
})
|
||||
|
||||
const result = await nominateEmptySkillSpammersInternalHandler(
|
||||
{ runQuery, runMutation } as never,
|
||||
{ batchSize: 10, maxBatches: 2, nominationThreshold: 2 },
|
||||
)
|
||||
|
||||
expect(result.ok).toBe(true)
|
||||
expect(result.isDone).toBe(true)
|
||||
expect(result.stats.usersFlagged).toBe(1)
|
||||
expect(result.stats.nominationsCreated).toBe(1)
|
||||
expect(result.stats.nominationsExisting).toBe(0)
|
||||
expect(result.nominations).toEqual([
|
||||
{
|
||||
userId: 'users:1',
|
||||
handle: 'spammer',
|
||||
emptySkillCount: 2,
|
||||
sampleSlugs: ['spam-a', 'spam-b'],
|
||||
},
|
||||
])
|
||||
})
|
||||
})
|
||||
|
||||
+589
-11
@@ -5,16 +5,26 @@ import type { ActionCtx } from './_generated/server'
|
||||
import { action, internalAction, internalMutation, internalQuery } from './_generated/server'
|
||||
import { assertRole, requireUserFromAction } from './lib/access'
|
||||
import { buildSkillSummaryBackfillPatch, type ParsedSkillData } from './lib/skillBackfill'
|
||||
import {
|
||||
computeQualitySignals,
|
||||
evaluateQuality,
|
||||
getTrustTier,
|
||||
type TrustTier,
|
||||
} from './lib/skillQuality'
|
||||
import { generateSkillSummary } from './lib/skillSummary'
|
||||
import { hashSkillFiles } from './lib/skills'
|
||||
|
||||
const DEFAULT_BATCH_SIZE = 50
|
||||
const MAX_BATCH_SIZE = 200
|
||||
const DEFAULT_MAX_BATCHES = 20
|
||||
const MAX_MAX_BATCHES = 200
|
||||
const DEFAULT_EMPTY_SKILL_MAX_README_BYTES = 8000
|
||||
const DEFAULT_EMPTY_SKILL_NOMINATION_THRESHOLD = 3
|
||||
|
||||
type BackfillStats = {
|
||||
skillsScanned: number
|
||||
skillsPatched: number
|
||||
aiSummariesPatched: number
|
||||
versionsPatched: number
|
||||
missingLatestVersion: number
|
||||
missingReadme: number
|
||||
@@ -25,6 +35,8 @@ type BackfillPageItem =
|
||||
| {
|
||||
kind: 'ok'
|
||||
skillId: Id<'skills'>
|
||||
skillSlug: string
|
||||
skillDisplayName: string
|
||||
versionId: Id<'skillVersions'>
|
||||
skillSummary: Doc<'skills'>['summary']
|
||||
versionParsed: Doc<'skillVersions'>['parsed']
|
||||
@@ -80,6 +92,8 @@ export const getSkillBackfillPageInternal = internalQuery({
|
||||
items.push({
|
||||
kind: 'ok',
|
||||
skillId: skill._id,
|
||||
skillSlug: skill.slug,
|
||||
skillDisplayName: skill.displayName,
|
||||
versionId: version._id,
|
||||
skillSummary: skill.summary,
|
||||
versionParsed: version.parsed,
|
||||
@@ -120,28 +134,37 @@ export type BackfillActionArgs = {
|
||||
dryRun?: boolean
|
||||
batchSize?: number
|
||||
maxBatches?: number
|
||||
useAi?: boolean
|
||||
cursor?: string
|
||||
}
|
||||
|
||||
export type BackfillActionResult = { ok: true; stats: BackfillStats }
|
||||
export type BackfillActionResult = {
|
||||
ok: true
|
||||
stats: BackfillStats
|
||||
isDone: boolean
|
||||
cursor: string | null
|
||||
}
|
||||
|
||||
export async function backfillSkillSummariesInternalHandler(
|
||||
ctx: ActionCtx,
|
||||
args: BackfillActionArgs,
|
||||
): Promise<BackfillActionResult> {
|
||||
const dryRun = Boolean(args.dryRun)
|
||||
const useAi = Boolean(args.useAi)
|
||||
const batchSize = clampInt(args.batchSize ?? DEFAULT_BATCH_SIZE, 1, MAX_BATCH_SIZE)
|
||||
const maxBatches = clampInt(args.maxBatches ?? DEFAULT_MAX_BATCHES, 1, MAX_MAX_BATCHES)
|
||||
|
||||
const totals: BackfillStats = {
|
||||
skillsScanned: 0,
|
||||
skillsPatched: 0,
|
||||
aiSummariesPatched: 0,
|
||||
versionsPatched: 0,
|
||||
missingLatestVersion: 0,
|
||||
missingReadme: 0,
|
||||
missingStorageBlob: 0,
|
||||
}
|
||||
|
||||
let cursor: string | null = null
|
||||
let cursor: string | null = args.cursor ?? null
|
||||
let isDone = false
|
||||
|
||||
for (let i = 0; i < maxBatches; i++) {
|
||||
@@ -181,8 +204,24 @@ export async function backfillSkillSummariesInternalHandler(
|
||||
currentParsed: item.versionParsed as ParsedSkillData,
|
||||
})
|
||||
|
||||
if (!patch.summary && !patch.parsed) continue
|
||||
if (patch.summary) totals.skillsPatched++
|
||||
let nextSummary = patch.summary
|
||||
const missingSummary = !item.skillSummary?.trim()
|
||||
if (!nextSummary && useAi && missingSummary) {
|
||||
nextSummary = await generateSkillSummary({
|
||||
slug: item.skillSlug,
|
||||
displayName: item.skillDisplayName,
|
||||
readmeText,
|
||||
})
|
||||
}
|
||||
|
||||
const shouldPatchSummary =
|
||||
typeof nextSummary === 'string' && nextSummary.trim() && nextSummary !== item.skillSummary
|
||||
|
||||
if (!shouldPatchSummary && !patch.parsed) continue
|
||||
if (shouldPatchSummary) {
|
||||
totals.skillsPatched++
|
||||
if (!patch.summary) totals.aiSummariesPatched++
|
||||
}
|
||||
if (patch.parsed) totals.versionsPatched++
|
||||
|
||||
if (dryRun) continue
|
||||
@@ -190,7 +229,7 @@ export async function backfillSkillSummariesInternalHandler(
|
||||
await ctx.runMutation(internal.maintenance.applySkillBackfillPatchInternal, {
|
||||
skillId: item.skillId,
|
||||
versionId: item.versionId,
|
||||
summary: patch.summary,
|
||||
summary: shouldPatchSummary ? nextSummary : undefined,
|
||||
parsed: patch.parsed,
|
||||
})
|
||||
}
|
||||
@@ -198,11 +237,7 @@ export async function backfillSkillSummariesInternalHandler(
|
||||
if (isDone) break
|
||||
}
|
||||
|
||||
if (!isDone) {
|
||||
throw new ConvexError('Backfill incomplete (maxBatches reached)')
|
||||
}
|
||||
|
||||
return { ok: true as const, stats: totals }
|
||||
return { ok: true as const, stats: totals, isDone, cursor }
|
||||
}
|
||||
|
||||
export const backfillSkillSummariesInternal = internalAction({
|
||||
@@ -210,6 +245,8 @@ export const backfillSkillSummariesInternal = internalAction({
|
||||
dryRun: v.optional(v.boolean()),
|
||||
batchSize: v.optional(v.number()),
|
||||
maxBatches: v.optional(v.number()),
|
||||
useAi: v.optional(v.boolean()),
|
||||
cursor: v.optional(v.string()),
|
||||
},
|
||||
handler: backfillSkillSummariesInternalHandler,
|
||||
})
|
||||
@@ -219,6 +256,8 @@ export const backfillSkillSummaries: ReturnType<typeof action> = action({
|
||||
dryRun: v.optional(v.boolean()),
|
||||
batchSize: v.optional(v.number()),
|
||||
maxBatches: v.optional(v.number()),
|
||||
useAi: v.optional(v.boolean()),
|
||||
cursor: v.optional(v.string()),
|
||||
},
|
||||
handler: async (ctx, args): Promise<BackfillActionResult> => {
|
||||
const { user } = await requireUserFromAction(ctx)
|
||||
@@ -231,7 +270,7 @@ export const backfillSkillSummaries: ReturnType<typeof action> = action({
|
||||
})
|
||||
|
||||
export const scheduleBackfillSkillSummaries: ReturnType<typeof action> = action({
|
||||
args: { dryRun: v.optional(v.boolean()) },
|
||||
args: { dryRun: v.optional(v.boolean()), useAi: v.optional(v.boolean()) },
|
||||
handler: async (ctx, args) => {
|
||||
const { user } = await requireUserFromAction(ctx)
|
||||
assertRole(user, ['admin'])
|
||||
@@ -239,11 +278,43 @@ export const scheduleBackfillSkillSummaries: ReturnType<typeof action> = action(
|
||||
dryRun: Boolean(args.dryRun),
|
||||
batchSize: DEFAULT_BATCH_SIZE,
|
||||
maxBatches: DEFAULT_MAX_BATCHES,
|
||||
useAi: Boolean(args.useAi),
|
||||
})
|
||||
return { ok: true as const }
|
||||
},
|
||||
})
|
||||
|
||||
export const continueSkillSummaryBackfillJobInternal = internalAction({
|
||||
args: {
|
||||
cursor: v.optional(v.string()),
|
||||
batchSize: v.optional(v.number()),
|
||||
useAi: v.optional(v.boolean()),
|
||||
},
|
||||
handler: async (ctx, args): Promise<BackfillActionResult> => {
|
||||
const result = await backfillSkillSummariesInternalHandler(ctx, {
|
||||
dryRun: false,
|
||||
cursor: args.cursor,
|
||||
batchSize: args.batchSize ?? DEFAULT_BATCH_SIZE,
|
||||
maxBatches: 1,
|
||||
useAi: Boolean(args.useAi),
|
||||
})
|
||||
|
||||
if (!result.isDone && result.cursor) {
|
||||
await ctx.scheduler.runAfter(
|
||||
0,
|
||||
internal.maintenance.continueSkillSummaryBackfillJobInternal,
|
||||
{
|
||||
cursor: result.cursor,
|
||||
batchSize: args.batchSize ?? DEFAULT_BATCH_SIZE,
|
||||
useAi: Boolean(args.useAi),
|
||||
},
|
||||
)
|
||||
}
|
||||
|
||||
return result
|
||||
},
|
||||
})
|
||||
|
||||
type FingerprintBackfillStats = {
|
||||
versionsScanned: number
|
||||
versionsPatched: number
|
||||
@@ -833,6 +904,513 @@ export const scheduleBackfillSkillBadgeTable: ReturnType<typeof action> = action
|
||||
},
|
||||
})
|
||||
|
||||
type EmptySkillCleanupPageItem = {
|
||||
skillId: Id<'skills'>
|
||||
slug: string
|
||||
ownerUserId: Id<'users'>
|
||||
latestVersionId?: Id<'skillVersions'>
|
||||
softDeletedAt?: number
|
||||
moderationReason?: string
|
||||
summary?: string
|
||||
}
|
||||
|
||||
type EmptySkillCleanupPageResult = {
|
||||
items: EmptySkillCleanupPageItem[]
|
||||
cursor: string | null
|
||||
isDone: boolean
|
||||
}
|
||||
|
||||
type EmptySkillCleanupStats = {
|
||||
skillsScanned: number
|
||||
skillsEvaluated: number
|
||||
emptyDetected: number
|
||||
skillsDeleted: number
|
||||
missingLatestVersion: number
|
||||
missingVersionDoc: number
|
||||
missingReadme: number
|
||||
missingStorageBlob: number
|
||||
skippedLargeReadme: number
|
||||
}
|
||||
|
||||
type EmptySkillCleanupNomination = {
|
||||
userId: Id<'users'>
|
||||
handle: string | null
|
||||
emptySkillCount: number
|
||||
sampleSlugs: string[]
|
||||
}
|
||||
|
||||
export type EmptySkillCleanupActionArgs = {
|
||||
cursor?: string
|
||||
dryRun?: boolean
|
||||
batchSize?: number
|
||||
maxBatches?: number
|
||||
maxReadmeBytes?: number
|
||||
nominationThreshold?: number
|
||||
}
|
||||
|
||||
export type EmptySkillCleanupActionResult = {
|
||||
ok: true
|
||||
cursor: string | null
|
||||
isDone: boolean
|
||||
stats: EmptySkillCleanupStats
|
||||
nominations: EmptySkillCleanupNomination[]
|
||||
}
|
||||
|
||||
export const getEmptySkillCleanupPageInternal = internalQuery({
|
||||
args: {
|
||||
cursor: v.optional(v.string()),
|
||||
batchSize: v.optional(v.number()),
|
||||
},
|
||||
handler: async (ctx, args): Promise<EmptySkillCleanupPageResult> => {
|
||||
const batchSize = clampInt(args.batchSize ?? DEFAULT_BATCH_SIZE, 1, MAX_BATCH_SIZE)
|
||||
const { page, isDone, continueCursor } = await ctx.db
|
||||
.query('skills')
|
||||
.order('asc')
|
||||
.paginate({ cursor: args.cursor ?? null, numItems: batchSize })
|
||||
|
||||
return {
|
||||
items: page.map((skill) => ({
|
||||
skillId: skill._id,
|
||||
slug: skill.slug,
|
||||
ownerUserId: skill.ownerUserId,
|
||||
latestVersionId: skill.latestVersionId,
|
||||
softDeletedAt: skill.softDeletedAt,
|
||||
moderationReason: skill.moderationReason,
|
||||
summary: skill.summary,
|
||||
})),
|
||||
cursor: continueCursor,
|
||||
isDone,
|
||||
}
|
||||
},
|
||||
})
|
||||
|
||||
export const applyEmptySkillCleanupInternal = internalMutation({
|
||||
args: {
|
||||
skillId: v.id('skills'),
|
||||
reason: v.string(),
|
||||
quality: v.object({
|
||||
score: v.number(),
|
||||
trustTier: v.union(v.literal('low'), v.literal('medium'), v.literal('trusted')),
|
||||
signals: v.object({
|
||||
bodyChars: v.number(),
|
||||
bodyWords: v.number(),
|
||||
uniqueWordRatio: v.number(),
|
||||
headingCount: v.number(),
|
||||
bulletCount: v.number(),
|
||||
templateMarkerHits: v.number(),
|
||||
genericSummary: v.boolean(),
|
||||
cjkChars: v.optional(v.number()),
|
||||
}),
|
||||
}),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const skill = await ctx.db.get(args.skillId)
|
||||
if (!skill) return { deleted: false as const, reason: 'missing_skill' as const }
|
||||
if (skill.softDeletedAt) return { deleted: false as const, reason: 'already_deleted' as const }
|
||||
|
||||
const now = Date.now()
|
||||
await ctx.db.patch(skill._id, {
|
||||
softDeletedAt: now,
|
||||
moderationStatus: 'hidden',
|
||||
moderationReason: 'quality.empty.backfill',
|
||||
moderationNotes: args.reason,
|
||||
quality: {
|
||||
score: args.quality.score,
|
||||
decision: 'reject',
|
||||
trustTier: args.quality.trustTier,
|
||||
similarRecentCount: 0,
|
||||
reason: args.reason,
|
||||
signals: args.quality.signals,
|
||||
evaluatedAt: now,
|
||||
},
|
||||
updatedAt: now,
|
||||
})
|
||||
|
||||
await ctx.db.insert('auditLogs', {
|
||||
actorUserId: skill.ownerUserId,
|
||||
action: 'skill.delete.empty.backfill',
|
||||
targetType: 'skill',
|
||||
targetId: skill._id,
|
||||
metadata: {
|
||||
slug: skill.slug,
|
||||
score: args.quality.score,
|
||||
trustTier: args.quality.trustTier,
|
||||
signals: args.quality.signals,
|
||||
},
|
||||
createdAt: now,
|
||||
})
|
||||
|
||||
return {
|
||||
deleted: true as const,
|
||||
ownerUserId: skill.ownerUserId,
|
||||
slug: skill.slug,
|
||||
}
|
||||
},
|
||||
})
|
||||
|
||||
export const nominateUserForEmptySkillSpamInternal = internalMutation({
|
||||
args: {
|
||||
userId: v.id('users'),
|
||||
emptySkillCount: v.number(),
|
||||
sampleSlugs: v.array(v.string()),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const existing = await ctx.db
|
||||
.query('auditLogs')
|
||||
.withIndex('by_target', (q) => q.eq('targetType', 'user').eq('targetId', args.userId))
|
||||
.filter((q) => q.eq(q.field('action'), 'user.ban.nomination.empty-skill-spam'))
|
||||
.first()
|
||||
if (existing) return { created: false as const }
|
||||
|
||||
const now = Date.now()
|
||||
await ctx.db.insert('auditLogs', {
|
||||
actorUserId: args.userId,
|
||||
action: 'user.ban.nomination.empty-skill-spam',
|
||||
targetType: 'user',
|
||||
targetId: args.userId,
|
||||
metadata: {
|
||||
emptySkillCount: args.emptySkillCount,
|
||||
sampleSlugs: args.sampleSlugs.slice(0, 10),
|
||||
},
|
||||
createdAt: now,
|
||||
})
|
||||
|
||||
return { created: true as const }
|
||||
},
|
||||
})
|
||||
|
||||
export async function cleanupEmptySkillsInternalHandler(
|
||||
ctx: ActionCtx,
|
||||
args: EmptySkillCleanupActionArgs,
|
||||
): Promise<EmptySkillCleanupActionResult> {
|
||||
const dryRun = args.dryRun !== false
|
||||
const batchSize = clampInt(args.batchSize ?? DEFAULT_BATCH_SIZE, 1, MAX_BATCH_SIZE)
|
||||
const maxBatches = clampInt(args.maxBatches ?? DEFAULT_MAX_BATCHES, 1, MAX_MAX_BATCHES)
|
||||
const maxReadmeBytes = clampInt(
|
||||
args.maxReadmeBytes ?? DEFAULT_EMPTY_SKILL_MAX_README_BYTES,
|
||||
256,
|
||||
65536,
|
||||
)
|
||||
const nominationThreshold = clampInt(
|
||||
args.nominationThreshold ?? DEFAULT_EMPTY_SKILL_NOMINATION_THRESHOLD,
|
||||
1,
|
||||
100,
|
||||
)
|
||||
|
||||
const totals: EmptySkillCleanupStats = {
|
||||
skillsScanned: 0,
|
||||
skillsEvaluated: 0,
|
||||
emptyDetected: 0,
|
||||
skillsDeleted: 0,
|
||||
missingLatestVersion: 0,
|
||||
missingVersionDoc: 0,
|
||||
missingReadme: 0,
|
||||
missingStorageBlob: 0,
|
||||
skippedLargeReadme: 0,
|
||||
}
|
||||
|
||||
const ownerTrustCache = new Map<string, { trustTier: TrustTier; handle: string | null }>()
|
||||
const emptyByOwner = new Map<string, EmptySkillCleanupNomination>()
|
||||
|
||||
let cursor: string | null = args.cursor ?? null
|
||||
let isDone = false
|
||||
const now = Date.now()
|
||||
|
||||
for (let i = 0; i < maxBatches; i++) {
|
||||
const page = (await ctx.runQuery(internal.maintenance.getEmptySkillCleanupPageInternal, {
|
||||
cursor: cursor ?? undefined,
|
||||
batchSize,
|
||||
})) as EmptySkillCleanupPageResult
|
||||
|
||||
cursor = page.cursor
|
||||
isDone = page.isDone
|
||||
|
||||
for (const item of page.items) {
|
||||
totals.skillsScanned++
|
||||
if (item.softDeletedAt) continue
|
||||
|
||||
if (!item.latestVersionId) {
|
||||
totals.missingLatestVersion++
|
||||
continue
|
||||
}
|
||||
|
||||
const version = (await ctx.runQuery(internal.skills.getVersionByIdInternal, {
|
||||
versionId: item.latestVersionId,
|
||||
})) as Doc<'skillVersions'> | null
|
||||
if (!version) {
|
||||
totals.missingVersionDoc++
|
||||
continue
|
||||
}
|
||||
|
||||
const readmeFile = version.files.find((file) => {
|
||||
const lower = file.path.toLowerCase()
|
||||
return lower === 'skill.md' || lower === 'skills.md'
|
||||
})
|
||||
if (!readmeFile) {
|
||||
totals.missingReadme++
|
||||
continue
|
||||
}
|
||||
|
||||
if (readmeFile.size > maxReadmeBytes) {
|
||||
totals.skippedLargeReadme++
|
||||
continue
|
||||
}
|
||||
|
||||
const blob = await ctx.storage.get(readmeFile.storageId)
|
||||
if (!blob) {
|
||||
totals.missingStorageBlob++
|
||||
continue
|
||||
}
|
||||
const readmeText = await blob.text()
|
||||
totals.skillsEvaluated++
|
||||
|
||||
const ownerKey = String(item.ownerUserId)
|
||||
let ownerTrust = ownerTrustCache.get(ownerKey)
|
||||
if (!ownerTrust) {
|
||||
const owner = (await ctx.runQuery(internal.users.getByIdInternal, {
|
||||
userId: item.ownerUserId,
|
||||
})) as Doc<'users'> | null
|
||||
const ownerActivity = (await ctx.runQuery(internal.skills.getOwnerSkillActivityInternal, {
|
||||
ownerUserId: item.ownerUserId,
|
||||
limit: 60,
|
||||
})) as Array<{
|
||||
slug: string
|
||||
summary?: string
|
||||
createdAt: number
|
||||
latestVersionId?: Id<'skillVersions'>
|
||||
}>
|
||||
|
||||
const ownerCreatedAt = owner?.createdAt ?? owner?._creationTime ?? now
|
||||
ownerTrust = {
|
||||
trustTier: getTrustTier(now - ownerCreatedAt, ownerActivity.length),
|
||||
handle: owner?.handle ?? null,
|
||||
}
|
||||
ownerTrustCache.set(ownerKey, ownerTrust)
|
||||
}
|
||||
|
||||
const qualitySignals = computeQualitySignals({
|
||||
readmeText,
|
||||
summary: item.summary ?? undefined,
|
||||
})
|
||||
const quality = evaluateQuality({
|
||||
signals: qualitySignals,
|
||||
trustTier: ownerTrust.trustTier,
|
||||
similarRecentCount: 0,
|
||||
})
|
||||
if (quality.decision !== 'reject') continue
|
||||
|
||||
totals.emptyDetected++
|
||||
|
||||
const nomination = emptyByOwner.get(ownerKey) ?? {
|
||||
userId: item.ownerUserId,
|
||||
handle: ownerTrust.handle,
|
||||
emptySkillCount: 0,
|
||||
sampleSlugs: [],
|
||||
}
|
||||
nomination.emptySkillCount += 1
|
||||
if (nomination.sampleSlugs.length < 10 && !nomination.sampleSlugs.includes(item.slug)) {
|
||||
nomination.sampleSlugs.push(item.slug)
|
||||
}
|
||||
emptyByOwner.set(ownerKey, nomination)
|
||||
|
||||
if (dryRun) continue
|
||||
|
||||
const result = await ctx.runMutation(internal.maintenance.applyEmptySkillCleanupInternal, {
|
||||
skillId: item.skillId,
|
||||
reason: quality.reason,
|
||||
quality: {
|
||||
score: quality.score,
|
||||
trustTier: quality.trustTier,
|
||||
signals: quality.signals,
|
||||
},
|
||||
})
|
||||
if (result.deleted) totals.skillsDeleted++
|
||||
}
|
||||
|
||||
if (isDone) break
|
||||
}
|
||||
|
||||
const nominations = Array.from(emptyByOwner.values())
|
||||
.filter((entry) => entry.emptySkillCount >= nominationThreshold)
|
||||
.sort((a, b) => b.emptySkillCount - a.emptySkillCount)
|
||||
|
||||
return {
|
||||
ok: true as const,
|
||||
cursor,
|
||||
isDone,
|
||||
stats: totals,
|
||||
nominations: nominations.slice(0, 200),
|
||||
}
|
||||
}
|
||||
|
||||
export const cleanupEmptySkillsInternal = internalAction({
|
||||
args: {
|
||||
cursor: v.optional(v.string()),
|
||||
dryRun: v.optional(v.boolean()),
|
||||
batchSize: v.optional(v.number()),
|
||||
maxBatches: v.optional(v.number()),
|
||||
maxReadmeBytes: v.optional(v.number()),
|
||||
nominationThreshold: v.optional(v.number()),
|
||||
},
|
||||
handler: cleanupEmptySkillsInternalHandler,
|
||||
})
|
||||
|
||||
export const cleanupEmptySkills: ReturnType<typeof action> = action({
|
||||
args: {
|
||||
cursor: v.optional(v.string()),
|
||||
dryRun: v.optional(v.boolean()),
|
||||
batchSize: v.optional(v.number()),
|
||||
maxBatches: v.optional(v.number()),
|
||||
maxReadmeBytes: v.optional(v.number()),
|
||||
nominationThreshold: v.optional(v.number()),
|
||||
},
|
||||
handler: async (ctx, args): Promise<EmptySkillCleanupActionResult> => {
|
||||
const { user } = await requireUserFromAction(ctx)
|
||||
assertRole(user, ['admin'])
|
||||
return ctx.runAction(internal.maintenance.cleanupEmptySkillsInternal, args)
|
||||
},
|
||||
})
|
||||
|
||||
type EmptySkillBanNominationStats = {
|
||||
skillsScanned: number
|
||||
usersFlagged: number
|
||||
nominationsCreated: number
|
||||
nominationsExisting: number
|
||||
}
|
||||
|
||||
export type EmptySkillBanNominationActionArgs = {
|
||||
cursor?: string
|
||||
batchSize?: number
|
||||
maxBatches?: number
|
||||
nominationThreshold?: number
|
||||
}
|
||||
|
||||
export type EmptySkillBanNominationActionResult = {
|
||||
ok: true
|
||||
cursor: string | null
|
||||
isDone: boolean
|
||||
stats: EmptySkillBanNominationStats
|
||||
nominations: EmptySkillCleanupNomination[]
|
||||
}
|
||||
|
||||
export async function nominateEmptySkillSpammersInternalHandler(
|
||||
ctx: ActionCtx,
|
||||
args: EmptySkillBanNominationActionArgs,
|
||||
): Promise<EmptySkillBanNominationActionResult> {
|
||||
const batchSize = clampInt(args.batchSize ?? DEFAULT_BATCH_SIZE, 1, MAX_BATCH_SIZE)
|
||||
const maxBatches = clampInt(args.maxBatches ?? DEFAULT_MAX_BATCHES, 1, MAX_MAX_BATCHES)
|
||||
const nominationThreshold = clampInt(
|
||||
args.nominationThreshold ?? DEFAULT_EMPTY_SKILL_NOMINATION_THRESHOLD,
|
||||
1,
|
||||
100,
|
||||
)
|
||||
|
||||
const totals: EmptySkillBanNominationStats = {
|
||||
skillsScanned: 0,
|
||||
usersFlagged: 0,
|
||||
nominationsCreated: 0,
|
||||
nominationsExisting: 0,
|
||||
}
|
||||
|
||||
const ownerHandleCache = new Map<string, string | null>()
|
||||
const emptyByOwner = new Map<string, EmptySkillCleanupNomination>()
|
||||
|
||||
let cursor: string | null = args.cursor ?? null
|
||||
let isDone = false
|
||||
|
||||
for (let i = 0; i < maxBatches; i++) {
|
||||
const page = (await ctx.runQuery(internal.maintenance.getEmptySkillCleanupPageInternal, {
|
||||
cursor: cursor ?? undefined,
|
||||
batchSize,
|
||||
})) as EmptySkillCleanupPageResult
|
||||
|
||||
cursor = page.cursor
|
||||
isDone = page.isDone
|
||||
|
||||
for (const item of page.items) {
|
||||
totals.skillsScanned++
|
||||
if (!item.softDeletedAt) continue
|
||||
if (item.moderationReason !== 'quality.empty.backfill') continue
|
||||
|
||||
const ownerKey = String(item.ownerUserId)
|
||||
let handle = ownerHandleCache.get(ownerKey)
|
||||
if (handle === undefined) {
|
||||
const owner = (await ctx.runQuery(internal.users.getByIdInternal, {
|
||||
userId: item.ownerUserId,
|
||||
})) as Doc<'users'> | null
|
||||
handle = owner?.handle ?? null
|
||||
ownerHandleCache.set(ownerKey, handle)
|
||||
}
|
||||
|
||||
const nomination = emptyByOwner.get(ownerKey) ?? {
|
||||
userId: item.ownerUserId,
|
||||
handle,
|
||||
emptySkillCount: 0,
|
||||
sampleSlugs: [],
|
||||
}
|
||||
nomination.emptySkillCount += 1
|
||||
if (nomination.sampleSlugs.length < 10 && !nomination.sampleSlugs.includes(item.slug)) {
|
||||
nomination.sampleSlugs.push(item.slug)
|
||||
}
|
||||
emptyByOwner.set(ownerKey, nomination)
|
||||
}
|
||||
|
||||
if (isDone) break
|
||||
}
|
||||
|
||||
const nominations = Array.from(emptyByOwner.values())
|
||||
.filter((entry) => entry.emptySkillCount >= nominationThreshold)
|
||||
.sort((a, b) => b.emptySkillCount - a.emptySkillCount)
|
||||
totals.usersFlagged = nominations.length
|
||||
|
||||
if (isDone) {
|
||||
for (const nomination of nominations) {
|
||||
const result = await ctx.runMutation(
|
||||
internal.maintenance.nominateUserForEmptySkillSpamInternal,
|
||||
{
|
||||
userId: nomination.userId,
|
||||
emptySkillCount: nomination.emptySkillCount,
|
||||
sampleSlugs: nomination.sampleSlugs,
|
||||
},
|
||||
)
|
||||
if (result.created) totals.nominationsCreated++
|
||||
else totals.nominationsExisting++
|
||||
}
|
||||
}
|
||||
|
||||
return {
|
||||
ok: true as const,
|
||||
cursor,
|
||||
isDone,
|
||||
stats: totals,
|
||||
nominations: nominations.slice(0, 200),
|
||||
}
|
||||
}
|
||||
|
||||
export const nominateEmptySkillSpammersInternal = internalAction({
|
||||
args: {
|
||||
cursor: v.optional(v.string()),
|
||||
batchSize: v.optional(v.number()),
|
||||
maxBatches: v.optional(v.number()),
|
||||
nominationThreshold: v.optional(v.number()),
|
||||
},
|
||||
handler: nominateEmptySkillSpammersInternalHandler,
|
||||
})
|
||||
|
||||
export const nominateEmptySkillSpammers: ReturnType<typeof action> = action({
|
||||
args: {
|
||||
cursor: v.optional(v.string()),
|
||||
batchSize: v.optional(v.number()),
|
||||
maxBatches: v.optional(v.number()),
|
||||
nominationThreshold: v.optional(v.number()),
|
||||
},
|
||||
handler: async (ctx, args): Promise<EmptySkillBanNominationActionResult> => {
|
||||
const { user } = await requireUserFromAction(ctx)
|
||||
assertRole(user, ['admin'])
|
||||
return ctx.runAction(internal.maintenance.nominateEmptySkillSpammersInternal, args)
|
||||
},
|
||||
})
|
||||
|
||||
function clampInt(value: number, min: number, max: number) {
|
||||
const rounded = Math.trunc(value)
|
||||
if (!Number.isFinite(rounded)) return min
|
||||
|
||||
+44
-9
@@ -1,7 +1,11 @@
|
||||
import { v } from 'convex/values'
|
||||
import { internalMutation } from './_generated/server'
|
||||
import { internalMutation, internalQuery } from './_generated/server'
|
||||
|
||||
export const checkRateLimitInternal = internalMutation({
|
||||
/**
|
||||
* Read-only rate limit check. Returns current status without writing anything.
|
||||
* This eliminates write conflicts for denied requests entirely.
|
||||
*/
|
||||
export const getRateLimitStatusInternal = internalQuery({
|
||||
args: {
|
||||
key: v.string(),
|
||||
limit: v.number(),
|
||||
@@ -20,6 +24,43 @@ export const checkRateLimitInternal = internalMutation({
|
||||
.withIndex('by_key_window', (q) => q.eq('key', args.key).eq('windowStart', windowStart))
|
||||
.unique()
|
||||
|
||||
const count = existing?.count ?? 0
|
||||
const allowed = count < args.limit
|
||||
return {
|
||||
allowed,
|
||||
remaining: Math.max(0, args.limit - count),
|
||||
limit: args.limit,
|
||||
resetAt,
|
||||
}
|
||||
},
|
||||
})
|
||||
|
||||
/**
|
||||
* Consume one rate limit token. Only call this after getRateLimitStatusInternal
|
||||
* returns allowed=true. Includes a double-check to handle races between the
|
||||
* query and this mutation.
|
||||
*/
|
||||
export const consumeRateLimitInternal = internalMutation({
|
||||
args: {
|
||||
key: v.string(),
|
||||
limit: v.number(),
|
||||
windowMs: v.number(),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const now = Date.now()
|
||||
const windowStart = Math.floor(now / args.windowMs) * args.windowMs
|
||||
|
||||
const existing = await ctx.db
|
||||
.query('rateLimits')
|
||||
.withIndex('by_key_window', (q) => q.eq('key', args.key).eq('windowStart', windowStart))
|
||||
.unique()
|
||||
|
||||
// Double-check: another request may have consumed the last token
|
||||
// between our query and this mutation
|
||||
if (existing && existing.count >= args.limit) {
|
||||
return { allowed: false, remaining: 0 }
|
||||
}
|
||||
|
||||
if (!existing) {
|
||||
await ctx.db.insert('rateLimits', {
|
||||
key: args.key,
|
||||
@@ -28,11 +69,7 @@ export const checkRateLimitInternal = internalMutation({
|
||||
limit: args.limit,
|
||||
updatedAt: now,
|
||||
})
|
||||
return { allowed: true, remaining: Math.max(0, args.limit - 1), limit: args.limit, resetAt }
|
||||
}
|
||||
|
||||
if (existing.count >= args.limit) {
|
||||
return { allowed: false, remaining: 0, limit: args.limit, resetAt }
|
||||
return { allowed: true, remaining: Math.max(0, args.limit - 1) }
|
||||
}
|
||||
|
||||
await ctx.db.patch(existing._id, {
|
||||
@@ -43,8 +80,6 @@ export const checkRateLimitInternal = internalMutation({
|
||||
return {
|
||||
allowed: true,
|
||||
remaining: Math.max(0, args.limit - existing.count - 1),
|
||||
limit: args.limit,
|
||||
resetAt,
|
||||
}
|
||||
},
|
||||
})
|
||||
|
||||
+134
-29
@@ -3,8 +3,6 @@ import { defineSchema, defineTable } from 'convex/server'
|
||||
import { v } from 'convex/values'
|
||||
import { EMBEDDING_DIMENSIONS } from './lib/embeddings'
|
||||
|
||||
const authSchema = authTables as unknown as Record<string, ReturnType<typeof defineTable>>
|
||||
|
||||
const users = defineTable({
|
||||
name: v.optional(v.string()),
|
||||
image: v.optional(v.string()),
|
||||
@@ -17,7 +15,12 @@ const users = defineTable({
|
||||
displayName: v.optional(v.string()),
|
||||
bio: v.optional(v.string()),
|
||||
role: v.optional(v.union(v.literal('admin'), v.literal('moderator'), v.literal('user'))),
|
||||
githubCreatedAt: v.optional(v.number()),
|
||||
githubFetchedAt: v.optional(v.number()),
|
||||
deactivatedAt: v.optional(v.number()),
|
||||
purgedAt: v.optional(v.number()),
|
||||
deletedAt: v.optional(v.number()),
|
||||
banReason: v.optional(v.string()),
|
||||
createdAt: v.optional(v.number()),
|
||||
updatedAt: v.optional(v.number()),
|
||||
})
|
||||
@@ -29,6 +32,7 @@ const skills = defineTable({
|
||||
slug: v.string(),
|
||||
displayName: v.string(),
|
||||
summary: v.optional(v.string()),
|
||||
resourceId: v.optional(v.string()),
|
||||
ownerUserId: v.id('users'),
|
||||
canonicalSkillId: v.optional(v.id('skills')),
|
||||
forkOf: v.optional(
|
||||
@@ -42,39 +46,64 @@ const skills = defineTable({
|
||||
latestVersionId: v.optional(v.id('skillVersions')),
|
||||
tags: v.record(v.string(), v.id('skillVersions')),
|
||||
softDeletedAt: v.optional(v.number()),
|
||||
badges: v.object({
|
||||
redactionApproved: v.optional(
|
||||
v.object({
|
||||
byUserId: v.id('users'),
|
||||
at: v.number(),
|
||||
}),
|
||||
),
|
||||
highlighted: v.optional(
|
||||
v.object({
|
||||
byUserId: v.id('users'),
|
||||
at: v.number(),
|
||||
}),
|
||||
),
|
||||
official: v.optional(
|
||||
v.object({
|
||||
byUserId: v.id('users'),
|
||||
at: v.number(),
|
||||
}),
|
||||
),
|
||||
deprecated: v.optional(
|
||||
v.object({
|
||||
byUserId: v.id('users'),
|
||||
at: v.number(),
|
||||
}),
|
||||
),
|
||||
}),
|
||||
badges: v.optional(
|
||||
v.object({
|
||||
redactionApproved: v.optional(
|
||||
v.object({
|
||||
byUserId: v.id('users'),
|
||||
at: v.number(),
|
||||
}),
|
||||
),
|
||||
highlighted: v.optional(
|
||||
v.object({
|
||||
byUserId: v.id('users'),
|
||||
at: v.number(),
|
||||
}),
|
||||
),
|
||||
official: v.optional(
|
||||
v.object({
|
||||
byUserId: v.id('users'),
|
||||
at: v.number(),
|
||||
}),
|
||||
),
|
||||
deprecated: v.optional(
|
||||
v.object({
|
||||
byUserId: v.id('users'),
|
||||
at: v.number(),
|
||||
}),
|
||||
),
|
||||
}),
|
||||
),
|
||||
moderationStatus: v.optional(
|
||||
v.union(v.literal('active'), v.literal('hidden'), v.literal('removed')),
|
||||
),
|
||||
moderationNotes: v.optional(v.string()),
|
||||
moderationReason: v.optional(v.string()),
|
||||
quality: v.optional(
|
||||
v.object({
|
||||
score: v.number(),
|
||||
decision: v.union(v.literal('pass'), v.literal('quarantine'), v.literal('reject')),
|
||||
trustTier: v.union(v.literal('low'), v.literal('medium'), v.literal('trusted')),
|
||||
similarRecentCount: v.number(),
|
||||
reason: v.string(),
|
||||
signals: v.object({
|
||||
bodyChars: v.number(),
|
||||
bodyWords: v.number(),
|
||||
uniqueWordRatio: v.number(),
|
||||
headingCount: v.number(),
|
||||
bulletCount: v.number(),
|
||||
templateMarkerHits: v.number(),
|
||||
genericSummary: v.boolean(),
|
||||
cjkChars: v.optional(v.number()),
|
||||
}),
|
||||
evaluatedAt: v.number(),
|
||||
}),
|
||||
),
|
||||
moderationFlags: v.optional(v.array(v.string())),
|
||||
lastReviewedAt: v.optional(v.number()),
|
||||
// VT scan tracking
|
||||
scanLastCheckedAt: v.optional(v.number()),
|
||||
scanCheckCount: v.optional(v.number()),
|
||||
hiddenAt: v.optional(v.number()),
|
||||
hiddenBy: v.optional(v.id('users')),
|
||||
reportCount: v.optional(v.number()),
|
||||
@@ -104,6 +133,17 @@ const skills = defineTable({
|
||||
.index('by_stats_installs_all_time', ['statsInstallsAllTime', 'updatedAt'])
|
||||
.index('by_batch', ['batch'])
|
||||
.index('by_active_updated', ['softDeletedAt', 'updatedAt'])
|
||||
.index('by_active_created', ['softDeletedAt', 'createdAt'])
|
||||
.index('by_active_name', ['softDeletedAt', 'displayName'])
|
||||
.index('by_active_stats_downloads', ['softDeletedAt', 'statsDownloads', 'updatedAt'])
|
||||
.index('by_active_stats_stars', ['softDeletedAt', 'statsStars', 'updatedAt'])
|
||||
.index('by_active_stats_installs_all_time', [
|
||||
'softDeletedAt',
|
||||
'statsInstallsAllTime',
|
||||
'updatedAt',
|
||||
])
|
||||
.index('by_canonical', ['canonicalSkillId'])
|
||||
.index('by_fork_of', ['forkOf.skillId'])
|
||||
|
||||
const souls = defineTable({
|
||||
slug: v.string(),
|
||||
@@ -150,9 +190,42 @@ const skillVersions = defineTable({
|
||||
createdBy: v.id('users'),
|
||||
createdAt: v.number(),
|
||||
softDeletedAt: v.optional(v.number()),
|
||||
sha256hash: v.optional(v.string()),
|
||||
vtAnalysis: v.optional(
|
||||
v.object({
|
||||
status: v.string(),
|
||||
verdict: v.optional(v.string()),
|
||||
analysis: v.optional(v.string()),
|
||||
source: v.optional(v.string()),
|
||||
checkedAt: v.number(),
|
||||
}),
|
||||
),
|
||||
llmAnalysis: v.optional(
|
||||
v.object({
|
||||
status: v.string(),
|
||||
verdict: v.optional(v.string()),
|
||||
confidence: v.optional(v.string()),
|
||||
summary: v.optional(v.string()),
|
||||
dimensions: v.optional(
|
||||
v.array(
|
||||
v.object({
|
||||
name: v.string(),
|
||||
label: v.string(),
|
||||
rating: v.string(),
|
||||
detail: v.string(),
|
||||
}),
|
||||
),
|
||||
),
|
||||
guidance: v.optional(v.string()),
|
||||
findings: v.optional(v.string()),
|
||||
model: v.optional(v.string()),
|
||||
checkedAt: v.number(),
|
||||
}),
|
||||
),
|
||||
})
|
||||
.index('by_skill', ['skillId'])
|
||||
.index('by_skill_version', ['skillId', 'version'])
|
||||
.index('by_sha256hash', ['sha256hash'])
|
||||
|
||||
const soulVersions = defineTable({
|
||||
soulId: v.id('souls'),
|
||||
@@ -273,6 +346,8 @@ const skillStatEvents = defineTable({
|
||||
v.literal('download'),
|
||||
v.literal('star'),
|
||||
v.literal('unstar'),
|
||||
v.literal('comment'),
|
||||
v.literal('uncomment'),
|
||||
v.literal('install_new'),
|
||||
v.literal('install_reactivate'),
|
||||
v.literal('install_deactivate'),
|
||||
@@ -332,6 +407,7 @@ const skillReports = defineTable({
|
||||
createdAt: v.number(),
|
||||
})
|
||||
.index('by_skill', ['skillId'])
|
||||
.index('by_skill_createdAt', ['skillId', 'createdAt'])
|
||||
.index('by_user', ['userId'])
|
||||
.index('by_skill_user', ['skillId', 'userId'])
|
||||
|
||||
@@ -375,6 +451,24 @@ const auditLogs = defineTable({
|
||||
.index('by_actor', ['actorUserId'])
|
||||
.index('by_target', ['targetType', 'targetId'])
|
||||
|
||||
const vtScanLogs = defineTable({
|
||||
type: v.union(v.literal('daily_rescan'), v.literal('backfill'), v.literal('pending_poll')),
|
||||
total: v.number(),
|
||||
updated: v.number(),
|
||||
unchanged: v.number(),
|
||||
errors: v.number(),
|
||||
flaggedSkills: v.optional(
|
||||
v.array(
|
||||
v.object({
|
||||
slug: v.string(),
|
||||
status: v.string(),
|
||||
}),
|
||||
),
|
||||
),
|
||||
durationMs: v.number(),
|
||||
createdAt: v.number(),
|
||||
}).index('by_type_date', ['type', 'createdAt'])
|
||||
|
||||
const apiTokens = defineTable({
|
||||
userId: v.id('users'),
|
||||
label: v.string(),
|
||||
@@ -397,6 +491,15 @@ const rateLimits = defineTable({
|
||||
.index('by_key_window', ['key', 'windowStart'])
|
||||
.index('by_key', ['key'])
|
||||
|
||||
const downloadDedupes = defineTable({
|
||||
skillId: v.id('skills'),
|
||||
identityHash: v.string(),
|
||||
hourStart: v.number(),
|
||||
createdAt: v.number(),
|
||||
})
|
||||
.index('by_skill_identity_hour', ['skillId', 'identityHash', 'hourStart'])
|
||||
.index('by_hour', ['hourStart'])
|
||||
|
||||
const githubBackupSyncState = defineTable({
|
||||
key: v.string(),
|
||||
cursor: v.optional(v.string()),
|
||||
@@ -442,7 +545,7 @@ const userSkillRootInstalls = defineTable({
|
||||
.index('by_skill', ['skillId'])
|
||||
|
||||
export default defineSchema({
|
||||
...authSchema,
|
||||
...authTables,
|
||||
users,
|
||||
skills,
|
||||
souls,
|
||||
@@ -464,8 +567,10 @@ export default defineSchema({
|
||||
stars,
|
||||
soulStars,
|
||||
auditLogs,
|
||||
vtScanLogs,
|
||||
apiTokens,
|
||||
rateLimits,
|
||||
downloadDedupes,
|
||||
githubBackupSyncState,
|
||||
userSyncRoots,
|
||||
userSkillInstalls,
|
||||
|
||||
+368
-2
@@ -1,12 +1,378 @@
|
||||
/* @vitest-environment node */
|
||||
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import { __test } from './search'
|
||||
import { describe, expect, it, vi } from 'vitest'
|
||||
import { tokenize } from './lib/searchText'
|
||||
import { __test, hydrateResults, lexicalFallbackSkills, searchSkills } from './search'
|
||||
|
||||
const { generateEmbeddingMock, getSkillBadgeMapsMock } = vi.hoisted(() => ({
|
||||
generateEmbeddingMock: vi.fn(),
|
||||
getSkillBadgeMapsMock: vi.fn(),
|
||||
}))
|
||||
|
||||
vi.mock('./lib/embeddings', () => ({
|
||||
generateEmbedding: generateEmbeddingMock,
|
||||
}))
|
||||
|
||||
vi.mock('./lib/badges', () => ({
|
||||
getSkillBadgeMaps: getSkillBadgeMapsMock,
|
||||
isSkillHighlighted: (skill: { badges?: Record<string, unknown> }) =>
|
||||
Boolean(skill.badges?.highlighted),
|
||||
}))
|
||||
|
||||
type WrappedHandler = {
|
||||
_handler: (
|
||||
ctx: unknown,
|
||||
args: unknown,
|
||||
) => Promise<Array<{ skill: { slug: string; _id: string } }>>
|
||||
}
|
||||
|
||||
const searchSkillsHandler = (searchSkills as unknown as WrappedHandler)._handler
|
||||
const lexicalFallbackSkillsHandler = (lexicalFallbackSkills as unknown as WrappedHandler)._handler
|
||||
const hydrateResultsHandler = (
|
||||
hydrateResults as unknown as {
|
||||
_handler: (
|
||||
ctx: unknown,
|
||||
args: unknown,
|
||||
) => Promise<Array<{ skill: { slug: string; _id: string } }>>
|
||||
}
|
||||
)._handler
|
||||
|
||||
describe('search helpers', () => {
|
||||
it('returns fallback results when vector candidates are empty', async () => {
|
||||
generateEmbeddingMock.mockResolvedValueOnce([0, 1, 2])
|
||||
const fallback = [
|
||||
{
|
||||
skill: makePublicSkill({ id: 'skills:orf', slug: 'orf', displayName: 'ORF' }),
|
||||
version: null,
|
||||
ownerHandle: 'steipete',
|
||||
},
|
||||
]
|
||||
const runQuery = vi
|
||||
.fn()
|
||||
.mockResolvedValueOnce([])
|
||||
.mockResolvedValueOnce([])
|
||||
.mockResolvedValueOnce(fallback)
|
||||
|
||||
const result = await searchSkillsHandler(
|
||||
{
|
||||
vectorSearch: vi.fn().mockResolvedValue([]),
|
||||
runQuery,
|
||||
},
|
||||
{ query: 'orf', limit: 10 },
|
||||
)
|
||||
|
||||
expect(result).toHaveLength(1)
|
||||
expect(result[0].skill.slug).toBe('orf')
|
||||
expect(runQuery).toHaveBeenLastCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({ query: 'orf', queryTokens: ['orf'] }),
|
||||
)
|
||||
})
|
||||
|
||||
it('applies highlightedOnly filtering in lexical fallback', async () => {
|
||||
const highlighted = makeSkillDoc({
|
||||
id: 'skills:hl',
|
||||
slug: 'orf-highlighted',
|
||||
displayName: 'ORF Highlighted',
|
||||
})
|
||||
const plain = makeSkillDoc({ id: 'skills:plain', slug: 'orf-plain', displayName: 'ORF Plain' })
|
||||
getSkillBadgeMapsMock.mockResolvedValueOnce(
|
||||
new Map([
|
||||
['skills:hl', { highlighted: { byUserId: 'users:mod', at: 1 } }],
|
||||
['skills:plain', {}],
|
||||
]),
|
||||
)
|
||||
|
||||
const result = await lexicalFallbackSkillsHandler(
|
||||
makeLexicalCtx({
|
||||
exactSlugSkill: null,
|
||||
recentSkills: [highlighted, plain],
|
||||
}),
|
||||
{ query: 'orf', queryTokens: ['orf'], highlightedOnly: true, limit: 10 },
|
||||
)
|
||||
|
||||
expect(result).toHaveLength(1)
|
||||
expect(result[0].skill.slug).toBe('orf-highlighted')
|
||||
})
|
||||
|
||||
it('applies nonSuspiciousOnly filtering in lexical fallback', async () => {
|
||||
const suspicious = makeSkillDoc({
|
||||
id: 'skills:suspicious',
|
||||
slug: 'orf-suspicious',
|
||||
displayName: 'ORF Suspicious',
|
||||
moderationFlags: ['flagged.suspicious'],
|
||||
})
|
||||
const clean = makeSkillDoc({ id: 'skills:clean', slug: 'orf-clean', displayName: 'ORF Clean' })
|
||||
getSkillBadgeMapsMock.mockResolvedValueOnce(
|
||||
new Map([
|
||||
['skills:suspicious', {}],
|
||||
['skills:clean', {}],
|
||||
]),
|
||||
)
|
||||
|
||||
const result = await lexicalFallbackSkillsHandler(
|
||||
makeLexicalCtx({
|
||||
exactSlugSkill: null,
|
||||
recentSkills: [suspicious, clean],
|
||||
}),
|
||||
{ query: 'orf', queryTokens: ['orf'], nonSuspiciousOnly: true, limit: 10 },
|
||||
)
|
||||
|
||||
expect(result).toHaveLength(1)
|
||||
expect(result[0].skill.slug).toBe('orf-clean')
|
||||
})
|
||||
|
||||
it('includes exact slug match from by_slug even when recent scan is empty', async () => {
|
||||
const exactSlugSkill = makeSkillDoc({ id: 'skills:orf', slug: 'orf', displayName: 'ORF' })
|
||||
getSkillBadgeMapsMock.mockResolvedValueOnce(new Map([['skills:orf', {}]]))
|
||||
const ctx = makeLexicalCtx({
|
||||
exactSlugSkill,
|
||||
recentSkills: [],
|
||||
})
|
||||
|
||||
const result = await lexicalFallbackSkillsHandler(ctx, {
|
||||
query: 'orf',
|
||||
queryTokens: ['orf'],
|
||||
limit: 10,
|
||||
})
|
||||
|
||||
expect(result).toHaveLength(1)
|
||||
expect(result[0].skill.slug).toBe('orf')
|
||||
expect(ctx.db.query).toHaveBeenCalledWith('skills')
|
||||
})
|
||||
|
||||
it('dedupes overlap and enforces rank + limit across vector and fallback', async () => {
|
||||
generateEmbeddingMock.mockResolvedValueOnce([0, 1, 2])
|
||||
const vectorEntries = [
|
||||
{
|
||||
embeddingId: 'skillEmbeddings:a',
|
||||
skill: makePublicSkill({
|
||||
id: 'skills:a',
|
||||
slug: 'foo-a',
|
||||
displayName: 'Foo Alpha',
|
||||
downloads: 10,
|
||||
}),
|
||||
version: null,
|
||||
ownerHandle: 'one',
|
||||
},
|
||||
{
|
||||
embeddingId: 'skillEmbeddings:b',
|
||||
skill: makePublicSkill({
|
||||
id: 'skills:b',
|
||||
slug: 'foo-b',
|
||||
displayName: 'Foo Beta',
|
||||
downloads: 2,
|
||||
}),
|
||||
version: null,
|
||||
ownerHandle: 'two',
|
||||
},
|
||||
]
|
||||
const fallbackEntries = [
|
||||
{
|
||||
skill: makePublicSkill({
|
||||
id: 'skills:a',
|
||||
slug: 'foo-a',
|
||||
displayName: 'Foo Alpha',
|
||||
downloads: 10,
|
||||
}),
|
||||
version: null,
|
||||
ownerHandle: 'one',
|
||||
},
|
||||
{
|
||||
skill: makePublicSkill({
|
||||
id: 'skills:c',
|
||||
slug: 'foo-c',
|
||||
displayName: 'Foo Classic',
|
||||
downloads: 1,
|
||||
}),
|
||||
version: null,
|
||||
ownerHandle: 'three',
|
||||
},
|
||||
]
|
||||
|
||||
const runQuery = vi
|
||||
.fn()
|
||||
.mockResolvedValueOnce(vectorEntries)
|
||||
.mockResolvedValueOnce([])
|
||||
.mockResolvedValueOnce(fallbackEntries)
|
||||
|
||||
const result = await searchSkillsHandler(
|
||||
{
|
||||
vectorSearch: vi.fn().mockResolvedValue([
|
||||
{ _id: 'skillEmbeddings:a', _score: 0.4 },
|
||||
{ _id: 'skillEmbeddings:b', _score: 0.9 },
|
||||
]),
|
||||
runQuery,
|
||||
},
|
||||
{ query: 'foo', limit: 2 },
|
||||
)
|
||||
|
||||
expect(result).toHaveLength(2)
|
||||
expect(result[0].skill.slug).toBe('foo-b')
|
||||
expect(new Set(result.map((entry: { skill: { _id: string } }) => entry.skill._id)).size).toBe(2)
|
||||
})
|
||||
|
||||
it('filters suspicious vector results in hydrateResults when requested', async () => {
|
||||
const result = await hydrateResultsHandler(
|
||||
{
|
||||
db: {
|
||||
get: vi.fn(async (id: string) => {
|
||||
if (id === 'skillEmbeddings:1') {
|
||||
return { _id: 'skillEmbeddings:1', skillId: 'skills:1', versionId: 'skillVersions:1' }
|
||||
}
|
||||
if (id === 'skills:1') {
|
||||
return makeSkillDoc({
|
||||
id: 'skills:1',
|
||||
slug: 'suspicious',
|
||||
displayName: 'Suspicious',
|
||||
moderationFlags: ['flagged.suspicious'],
|
||||
})
|
||||
}
|
||||
if (id === 'users:owner') return { _id: 'users:owner', handle: 'owner' }
|
||||
if (id === 'skillVersions:1') return { _id: 'skillVersions:1', version: '1.0.0' }
|
||||
return null
|
||||
}),
|
||||
},
|
||||
},
|
||||
{ embeddingIds: ['skillEmbeddings:1'], nonSuspiciousOnly: true },
|
||||
)
|
||||
|
||||
expect(result).toHaveLength(0)
|
||||
})
|
||||
|
||||
it('advances candidate limit until max', () => {
|
||||
expect(__test.getNextCandidateLimit(50, 1000)).toBe(100)
|
||||
expect(__test.getNextCandidateLimit(800, 1000)).toBe(1000)
|
||||
expect(__test.getNextCandidateLimit(1000, 1000)).toBeNull()
|
||||
})
|
||||
|
||||
it('boosts exact slug/name matches over loose matches', () => {
|
||||
const queryTokens = tokenize('notion')
|
||||
const exactScore = __test.scoreSkillResult(queryTokens, 0.4, 'Notion Sync', 'notion-sync', 5)
|
||||
const looseScore = __test.scoreSkillResult(queryTokens, 0.6, 'Notes Sync', 'notes-sync', 500)
|
||||
expect(exactScore).toBeGreaterThan(looseScore)
|
||||
})
|
||||
|
||||
it('adds a popularity prior for equally relevant matches', () => {
|
||||
const queryTokens = tokenize('notion')
|
||||
const lowDownloads = __test.scoreSkillResult(
|
||||
queryTokens,
|
||||
0.5,
|
||||
'Notion Helper',
|
||||
'notion-helper',
|
||||
0,
|
||||
)
|
||||
const highDownloads = __test.scoreSkillResult(
|
||||
queryTokens,
|
||||
0.5,
|
||||
'Notion Helper',
|
||||
'notion-helper',
|
||||
1000,
|
||||
)
|
||||
expect(highDownloads).toBeGreaterThan(lowDownloads)
|
||||
})
|
||||
|
||||
it('merges fallback matches without duplicate skill ids', () => {
|
||||
const primary = [
|
||||
{
|
||||
embeddingId: 'skillEmbeddings:1',
|
||||
skill: { _id: 'skills:1' },
|
||||
},
|
||||
] as unknown as Parameters<typeof __test.mergeUniqueBySkillId>[0]
|
||||
const fallback = [
|
||||
{
|
||||
skill: { _id: 'skills:1' },
|
||||
},
|
||||
{
|
||||
skill: { _id: 'skills:2' },
|
||||
},
|
||||
] as unknown as Parameters<typeof __test.mergeUniqueBySkillId>[1]
|
||||
|
||||
const merged = __test.mergeUniqueBySkillId(primary, fallback)
|
||||
expect(merged).toHaveLength(2)
|
||||
expect(merged.map((entry) => entry.skill._id)).toEqual(['skills:1', 'skills:2'])
|
||||
})
|
||||
})
|
||||
|
||||
function makePublicSkill(params: {
|
||||
id: string
|
||||
slug: string
|
||||
displayName: string
|
||||
downloads?: number
|
||||
}) {
|
||||
return {
|
||||
_id: params.id,
|
||||
_creationTime: 1,
|
||||
slug: params.slug,
|
||||
displayName: params.displayName,
|
||||
summary: `${params.displayName} summary`,
|
||||
ownerUserId: 'users:owner',
|
||||
canonicalSkillId: undefined,
|
||||
forkOf: undefined,
|
||||
latestVersionId: 'skillVersions:1',
|
||||
tags: {},
|
||||
badges: {},
|
||||
stats: {
|
||||
downloads: params.downloads ?? 0,
|
||||
installsCurrent: 0,
|
||||
installsAllTime: 0,
|
||||
stars: 0,
|
||||
versions: 1,
|
||||
comments: 0,
|
||||
},
|
||||
createdAt: 1,
|
||||
updatedAt: 1,
|
||||
}
|
||||
}
|
||||
|
||||
function makeSkillDoc(params: {
|
||||
id: string
|
||||
slug: string
|
||||
displayName: string
|
||||
moderationFlags?: string[]
|
||||
moderationReason?: string
|
||||
}) {
|
||||
return {
|
||||
...makePublicSkill(params),
|
||||
_creationTime: 1,
|
||||
moderationStatus: 'active',
|
||||
moderationFlags: params.moderationFlags ?? [],
|
||||
moderationReason: params.moderationReason,
|
||||
softDeletedAt: undefined,
|
||||
}
|
||||
}
|
||||
|
||||
function makeLexicalCtx(params: {
|
||||
exactSlugSkill: ReturnType<typeof makeSkillDoc> | null
|
||||
recentSkills: Array<ReturnType<typeof makeSkillDoc>>
|
||||
}) {
|
||||
return {
|
||||
db: {
|
||||
query: vi.fn((table: string) => {
|
||||
if (table !== 'skills') throw new Error(`Unexpected table ${table}`)
|
||||
return {
|
||||
withIndex: (index: string) => {
|
||||
if (index === 'by_slug') {
|
||||
return {
|
||||
unique: vi.fn().mockResolvedValue(params.exactSlugSkill),
|
||||
}
|
||||
}
|
||||
if (index === 'by_active_updated') {
|
||||
return {
|
||||
order: () => ({
|
||||
take: vi.fn().mockResolvedValue(params.recentSkills),
|
||||
}),
|
||||
}
|
||||
}
|
||||
throw new Error(`Unexpected index ${index}`)
|
||||
},
|
||||
}
|
||||
}),
|
||||
get: vi.fn(async (id: string) => {
|
||||
if (id.startsWith('users:')) return { _id: id, handle: 'owner' }
|
||||
if (id.startsWith('skillVersions:')) return { _id: id, version: '1.0.0' }
|
||||
return null
|
||||
}),
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
+209
-16
@@ -6,26 +6,94 @@ import { getSkillBadgeMaps, isSkillHighlighted, type SkillBadgeMap } from './lib
|
||||
import { generateEmbedding } from './lib/embeddings'
|
||||
import { toPublicSkill, toPublicSoul } from './lib/public'
|
||||
import { matchesExactTokens, tokenize } from './lib/searchText'
|
||||
import { isSkillSuspicious } from './lib/skillSafety'
|
||||
|
||||
type HydratedEntry = {
|
||||
embeddingId: Id<'skillEmbeddings'>
|
||||
type SkillSearchEntry = {
|
||||
embeddingId?: Id<'skillEmbeddings'>
|
||||
skill: NonNullable<ReturnType<typeof toPublicSkill>>
|
||||
version: Doc<'skillVersions'> | null
|
||||
ownerHandle: string | null
|
||||
}
|
||||
|
||||
type SearchResult = HydratedEntry & { score: number }
|
||||
type SearchResult = SkillSearchEntry & { score: number }
|
||||
|
||||
const SLUG_EXACT_BOOST = 1.4
|
||||
const SLUG_PREFIX_BOOST = 0.8
|
||||
const NAME_EXACT_BOOST = 1.1
|
||||
const NAME_PREFIX_BOOST = 0.6
|
||||
const POPULARITY_WEIGHT = 0.08
|
||||
const FALLBACK_SCAN_LIMIT = 1200
|
||||
|
||||
function getNextCandidateLimit(current: number, max: number) {
|
||||
const next = Math.min(current * 2, max)
|
||||
return next > current ? next : null
|
||||
}
|
||||
|
||||
function matchesAllTokens(
|
||||
queryTokens: string[],
|
||||
candidateTokens: string[],
|
||||
matcher: (candidate: string, query: string) => boolean,
|
||||
) {
|
||||
if (queryTokens.length === 0 || candidateTokens.length === 0) return false
|
||||
return queryTokens.every((queryToken) =>
|
||||
candidateTokens.some((candidateToken) => matcher(candidateToken, queryToken)),
|
||||
)
|
||||
}
|
||||
|
||||
function getLexicalBoost(queryTokens: string[], displayName: string, slug: string) {
|
||||
const slugTokens = tokenize(slug)
|
||||
const nameTokens = tokenize(displayName)
|
||||
|
||||
let boost = 0
|
||||
if (matchesAllTokens(queryTokens, slugTokens, (candidate, query) => candidate === query)) {
|
||||
boost += SLUG_EXACT_BOOST
|
||||
} else if (
|
||||
matchesAllTokens(queryTokens, slugTokens, (candidate, query) => candidate.startsWith(query))
|
||||
) {
|
||||
boost += SLUG_PREFIX_BOOST
|
||||
}
|
||||
|
||||
if (matchesAllTokens(queryTokens, nameTokens, (candidate, query) => candidate === query)) {
|
||||
boost += NAME_EXACT_BOOST
|
||||
} else if (
|
||||
matchesAllTokens(queryTokens, nameTokens, (candidate, query) => candidate.startsWith(query))
|
||||
) {
|
||||
boost += NAME_PREFIX_BOOST
|
||||
}
|
||||
|
||||
return boost
|
||||
}
|
||||
|
||||
function scoreSkillResult(
|
||||
queryTokens: string[],
|
||||
vectorScore: number,
|
||||
displayName: string,
|
||||
slug: string,
|
||||
downloads: number,
|
||||
) {
|
||||
const lexicalBoost = getLexicalBoost(queryTokens, displayName, slug)
|
||||
const popularityBoost = Math.log1p(Math.max(downloads, 0)) * POPULARITY_WEIGHT
|
||||
return vectorScore + lexicalBoost + popularityBoost
|
||||
}
|
||||
|
||||
function mergeUniqueBySkillId(primary: SkillSearchEntry[], fallback: SkillSearchEntry[]) {
|
||||
if (fallback.length === 0) return primary
|
||||
const out = [...primary]
|
||||
const seen = new Set(primary.map((entry) => entry.skill._id))
|
||||
for (const entry of fallback) {
|
||||
if (seen.has(entry.skill._id)) continue
|
||||
seen.add(entry.skill._id)
|
||||
out.push(entry)
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
export const searchSkills: ReturnType<typeof action> = action({
|
||||
args: {
|
||||
query: v.string(),
|
||||
limit: v.optional(v.number()),
|
||||
highlightedOnly: v.optional(v.boolean()),
|
||||
nonSuspiciousOnly: v.optional(v.boolean()),
|
||||
},
|
||||
handler: async (ctx, args): Promise<SearchResult[]> => {
|
||||
const query = args.query.trim()
|
||||
@@ -43,9 +111,9 @@ export const searchSkills: ReturnType<typeof action> = action({
|
||||
// Convex vectorSearch max limit is 256; clamp candidate sizes accordingly.
|
||||
const maxCandidate = Math.min(Math.max(limit * 10, 200), 256)
|
||||
let candidateLimit = Math.min(Math.max(limit * 3, 50), 256)
|
||||
let hydrated: HydratedEntry[] = []
|
||||
let hydrated: SkillSearchEntry[] = []
|
||||
let scoreById = new Map<Id<'skillEmbeddings'>, number>()
|
||||
let exactMatches: HydratedEntry[] = []
|
||||
let exactMatches: SkillSearchEntry[] = []
|
||||
|
||||
while (candidateLimit <= maxCandidate) {
|
||||
const results = await ctx.vectorSearch('skillEmbeddings', 'by_embedding', {
|
||||
@@ -56,7 +124,8 @@ export const searchSkills: ReturnType<typeof action> = action({
|
||||
|
||||
hydrated = (await ctx.runQuery(internal.search.hydrateResults, {
|
||||
embeddingIds: results.map((result) => result._id),
|
||||
})) as HydratedEntry[]
|
||||
nonSuspiciousOnly: args.nonSuspiciousOnly,
|
||||
})) as SkillSearchEntry[]
|
||||
|
||||
scoreById = new Map<Id<'skillEmbeddings'>, number>(
|
||||
results.map((result) => [result._id, result._score]),
|
||||
@@ -95,12 +164,35 @@ export const searchSkills: ReturnType<typeof action> = action({
|
||||
candidateLimit = nextLimit
|
||||
}
|
||||
|
||||
return exactMatches
|
||||
.map((entry) => ({
|
||||
...entry,
|
||||
score: scoreById.get(entry.embeddingId) ?? 0,
|
||||
}))
|
||||
const fallbackMatches =
|
||||
exactMatches.length >= limit
|
||||
? []
|
||||
: ((await ctx.runQuery(internal.search.lexicalFallbackSkills, {
|
||||
query,
|
||||
queryTokens,
|
||||
limit: Math.min(Math.max(limit * 4, 200), FALLBACK_SCAN_LIMIT),
|
||||
highlightedOnly: args.highlightedOnly,
|
||||
nonSuspiciousOnly: args.nonSuspiciousOnly,
|
||||
})) as SkillSearchEntry[])
|
||||
|
||||
const mergedMatches = mergeUniqueBySkillId(exactMatches, fallbackMatches)
|
||||
|
||||
return mergedMatches
|
||||
.map((entry) => {
|
||||
const vectorScore = entry.embeddingId ? (scoreById.get(entry.embeddingId) ?? 0) : 0
|
||||
return {
|
||||
...entry,
|
||||
score: scoreSkillResult(
|
||||
queryTokens,
|
||||
vectorScore,
|
||||
entry.skill.displayName,
|
||||
entry.skill.slug,
|
||||
entry.skill.stats.downloads,
|
||||
),
|
||||
}
|
||||
})
|
||||
.filter((entry) => entry.skill)
|
||||
.sort((a, b) => b.score - a.score || b.skill.stats.downloads - a.skill.stats.downloads)
|
||||
.slice(0, limit)
|
||||
},
|
||||
})
|
||||
@@ -114,8 +206,11 @@ export const getBadgeMapsForSkills = internalQuery({
|
||||
})
|
||||
|
||||
export const hydrateResults = internalQuery({
|
||||
args: { embeddingIds: v.array(v.id('skillEmbeddings')) },
|
||||
handler: async (ctx, args): Promise<HydratedEntry[]> => {
|
||||
args: {
|
||||
embeddingIds: v.array(v.id('skillEmbeddings')),
|
||||
nonSuspiciousOnly: v.optional(v.boolean()),
|
||||
},
|
||||
handler: async (ctx, args): Promise<SkillSearchEntry[]> => {
|
||||
const ownerHandleCache = new Map<Id<'users'>, Promise<string | null>>()
|
||||
|
||||
const getOwnerHandle = (ownerUserId: Id<'users'>) => {
|
||||
@@ -128,12 +223,13 @@ export const hydrateResults = internalQuery({
|
||||
return handlePromise
|
||||
}
|
||||
|
||||
const entries = await Promise.all(
|
||||
const entries: Array<SkillSearchEntry | null> = await Promise.all(
|
||||
args.embeddingIds.map(async (embeddingId) => {
|
||||
const embedding = await ctx.db.get(embeddingId)
|
||||
if (!embedding) return null
|
||||
const skill = await ctx.db.get(embedding.skillId)
|
||||
if (!skill || skill.softDeletedAt) return null
|
||||
if (args.nonSuspiciousOnly && isSkillSuspicious(skill)) return null
|
||||
const [version, ownerHandle] = await Promise.all([
|
||||
ctx.db.get(embedding.versionId),
|
||||
getOwnerHandle(skill.ownerUserId),
|
||||
@@ -144,7 +240,98 @@ export const hydrateResults = internalQuery({
|
||||
}),
|
||||
)
|
||||
|
||||
return entries.filter((entry): entry is HydratedEntry => entry !== null)
|
||||
return entries.filter((entry): entry is SkillSearchEntry => entry !== null)
|
||||
},
|
||||
})
|
||||
|
||||
export const lexicalFallbackSkills = internalQuery({
|
||||
args: {
|
||||
query: v.string(),
|
||||
queryTokens: v.array(v.string()),
|
||||
limit: v.optional(v.number()),
|
||||
highlightedOnly: v.optional(v.boolean()),
|
||||
nonSuspiciousOnly: v.optional(v.boolean()),
|
||||
},
|
||||
handler: async (ctx, args): Promise<SkillSearchEntry[]> => {
|
||||
const limit = Math.min(Math.max(args.limit ?? 200, 10), FALLBACK_SCAN_LIMIT)
|
||||
const seenSkillIds = new Set<Id<'skills'>>()
|
||||
const candidateSkills: Doc<'skills'>[] = []
|
||||
|
||||
const slugQuery = args.query.trim().toLowerCase()
|
||||
if (/^[a-z0-9][a-z0-9-]*$/.test(slugQuery)) {
|
||||
const exactSlugSkill = await ctx.db
|
||||
.query('skills')
|
||||
.withIndex('by_slug', (q) => q.eq('slug', slugQuery))
|
||||
.unique()
|
||||
if (
|
||||
exactSlugSkill &&
|
||||
!exactSlugSkill.softDeletedAt &&
|
||||
(!args.nonSuspiciousOnly || !isSkillSuspicious(exactSlugSkill))
|
||||
) {
|
||||
seenSkillIds.add(exactSlugSkill._id)
|
||||
candidateSkills.push(exactSlugSkill)
|
||||
}
|
||||
}
|
||||
|
||||
const recentSkills = await ctx.db
|
||||
.query('skills')
|
||||
.withIndex('by_active_updated', (q) => q.eq('softDeletedAt', undefined))
|
||||
.order('desc')
|
||||
.take(FALLBACK_SCAN_LIMIT)
|
||||
|
||||
for (const skill of recentSkills) {
|
||||
if (seenSkillIds.has(skill._id)) continue
|
||||
if (args.nonSuspiciousOnly && isSkillSuspicious(skill)) continue
|
||||
seenSkillIds.add(skill._id)
|
||||
candidateSkills.push(skill)
|
||||
}
|
||||
|
||||
const matched = candidateSkills.filter((skill) =>
|
||||
matchesExactTokens(args.queryTokens, [skill.displayName, skill.slug, skill.summary]),
|
||||
)
|
||||
if (matched.length === 0) return []
|
||||
|
||||
const ownerHandleCache = new Map<Id<'users'>, Promise<string | null>>()
|
||||
const getOwnerHandle = (ownerUserId: Id<'users'>) => {
|
||||
const cached = ownerHandleCache.get(ownerUserId)
|
||||
if (cached) return cached
|
||||
const handlePromise = ctx.db
|
||||
.get(ownerUserId)
|
||||
.then((owner) => owner?.handle ?? owner?._id ?? null)
|
||||
ownerHandleCache.set(ownerUserId, handlePromise)
|
||||
return handlePromise
|
||||
}
|
||||
|
||||
const entries = await Promise.all(
|
||||
matched.map(async (skill) => {
|
||||
const [version, ownerHandle] = await Promise.all([
|
||||
skill.latestVersionId ? ctx.db.get(skill.latestVersionId) : Promise.resolve(null),
|
||||
getOwnerHandle(skill.ownerUserId),
|
||||
])
|
||||
const publicSkill = toPublicSkill(skill)
|
||||
if (!publicSkill) return null
|
||||
return { skill: publicSkill, version, ownerHandle }
|
||||
}),
|
||||
)
|
||||
const validEntries = entries.filter((entry): entry is SkillSearchEntry => entry !== null)
|
||||
if (validEntries.length === 0) return []
|
||||
|
||||
const badgeMap = await getSkillBadgeMaps(
|
||||
ctx,
|
||||
validEntries.map((entry) => entry.skill._id),
|
||||
)
|
||||
const withBadges = validEntries.map((entry) => ({
|
||||
...entry,
|
||||
skill: {
|
||||
...entry.skill,
|
||||
badges: badgeMap.get(entry.skill._id) ?? {},
|
||||
},
|
||||
}))
|
||||
|
||||
const filtered = args.highlightedOnly
|
||||
? withBadges.filter((entry) => isSkillHighlighted(entry.skill))
|
||||
: withBadges
|
||||
return filtered.slice(0, limit)
|
||||
},
|
||||
})
|
||||
|
||||
@@ -251,4 +438,10 @@ export const getSkillBadgeMapsInternal = internalQuery({
|
||||
},
|
||||
})
|
||||
|
||||
export const __test = { getNextCandidateLimit }
|
||||
export const __test = {
|
||||
getNextCandidateLimit,
|
||||
matchesAllTokens,
|
||||
getLexicalBoost,
|
||||
scoreSkillResult,
|
||||
mergeUniqueBySkillId,
|
||||
}
|
||||
|
||||
+1
-1
@@ -7,7 +7,7 @@ export type SoulSeed = {
|
||||
}
|
||||
|
||||
export const SOUL_SEED_HANDLE = 'seed'
|
||||
export const SOUL_SEED_DISPLAY_NAME = 'OpenClaw Seed'
|
||||
export const SOUL_SEED_DISPLAY_NAME = 'ClawHub Seed'
|
||||
export const SOUL_SEED_KEY = 'seed:souls-v1'
|
||||
|
||||
// biome-ignore format: seed payload
|
||||
|
||||
@@ -0,0 +1,110 @@
|
||||
/* @vitest-environment node */
|
||||
import { describe, expect, it } from 'vitest'
|
||||
|
||||
// Test the aggregateEvents function by importing and testing the module logic
|
||||
// Since aggregateEvents is not exported, we test the behavior indirectly through
|
||||
// the event processing contract
|
||||
|
||||
describe('skill stat events - comment delta handling', () => {
|
||||
it('aggregates comment and uncomment events into net deltas', () => {
|
||||
// Simulate the aggregation logic from processSkillStatEventsAction
|
||||
type EventKind =
|
||||
| 'download'
|
||||
| 'star'
|
||||
| 'unstar'
|
||||
| 'comment'
|
||||
| 'uncomment'
|
||||
| 'install_new'
|
||||
| 'install_reactivate'
|
||||
| 'install_deactivate'
|
||||
| 'install_clear'
|
||||
|
||||
const events: { kind: EventKind; occurredAt: number }[] = [
|
||||
{ kind: 'star', occurredAt: 1000 },
|
||||
{ kind: 'comment', occurredAt: 2000 },
|
||||
{ kind: 'comment', occurredAt: 3000 },
|
||||
{ kind: 'uncomment', occurredAt: 4000 },
|
||||
{ kind: 'download', occurredAt: 5000 },
|
||||
]
|
||||
|
||||
// Replicate the aggregation logic
|
||||
const result = {
|
||||
downloads: 0,
|
||||
stars: 0,
|
||||
comments: 0,
|
||||
installsAllTime: 0,
|
||||
installsCurrent: 0,
|
||||
downloadEvents: [] as number[],
|
||||
installNewEvents: [] as number[],
|
||||
}
|
||||
|
||||
for (const event of events) {
|
||||
switch (event.kind) {
|
||||
case 'download':
|
||||
result.downloads += 1
|
||||
result.downloadEvents.push(event.occurredAt)
|
||||
break
|
||||
case 'star':
|
||||
result.stars += 1
|
||||
break
|
||||
case 'unstar':
|
||||
result.stars -= 1
|
||||
break
|
||||
case 'comment':
|
||||
result.comments += 1
|
||||
break
|
||||
case 'uncomment':
|
||||
result.comments -= 1
|
||||
break
|
||||
case 'install_new':
|
||||
result.installsAllTime += 1
|
||||
result.installsCurrent += 1
|
||||
result.installNewEvents.push(event.occurredAt)
|
||||
break
|
||||
case 'install_reactivate':
|
||||
result.installsCurrent += 1
|
||||
break
|
||||
case 'install_deactivate':
|
||||
result.installsCurrent -= 1
|
||||
break
|
||||
}
|
||||
}
|
||||
|
||||
expect(result.stars).toBe(1)
|
||||
expect(result.comments).toBe(1) // 2 comments - 1 uncomment
|
||||
expect(result.downloads).toBe(1)
|
||||
expect(result.downloadEvents).toEqual([5000])
|
||||
})
|
||||
|
||||
it('should include comments in delta check (regression test for dropped comments)', () => {
|
||||
// This test verifies the fix: the condition guard in applyAggregatedStatsAndUpdateCursor
|
||||
// must include comments !== 0 so comment-only batches are not skipped
|
||||
const delta = {
|
||||
downloads: 0,
|
||||
stars: 0,
|
||||
comments: 3,
|
||||
installsAllTime: 0,
|
||||
installsCurrent: 0,
|
||||
}
|
||||
|
||||
// The OLD buggy condition (missing comments):
|
||||
const oldCondition =
|
||||
delta.downloads !== 0 ||
|
||||
delta.stars !== 0 ||
|
||||
delta.installsAllTime !== 0 ||
|
||||
delta.installsCurrent !== 0
|
||||
|
||||
// The FIXED condition (includes comments):
|
||||
const fixedCondition =
|
||||
delta.downloads !== 0 ||
|
||||
delta.stars !== 0 ||
|
||||
delta.comments !== 0 ||
|
||||
delta.installsAllTime !== 0 ||
|
||||
delta.installsCurrent !== 0
|
||||
|
||||
// With only comment deltas, the old condition would skip the patch
|
||||
expect(oldCondition).toBe(false)
|
||||
// The fixed condition correctly triggers the patch
|
||||
expect(fixedCondition).toBe(true)
|
||||
})
|
||||
})
|
||||
@@ -35,6 +35,8 @@ export type StatEventKind =
|
||||
| 'download'
|
||||
| 'star'
|
||||
| 'unstar'
|
||||
| 'comment'
|
||||
| 'uncomment'
|
||||
| 'install_new'
|
||||
| 'install_reactivate'
|
||||
| 'install_deactivate'
|
||||
@@ -86,6 +88,7 @@ export async function insertStatEvent(
|
||||
type AggregatedDeltas = {
|
||||
downloads: number
|
||||
stars: number
|
||||
comments: number
|
||||
installsAllTime: number
|
||||
installsCurrent: number
|
||||
/** Original timestamps for each download event (for daily stats bucketing) */
|
||||
@@ -117,6 +120,7 @@ function aggregateEvents(events: Doc<'skillStatEvents'>[]): AggregatedDeltas {
|
||||
const result: AggregatedDeltas = {
|
||||
downloads: 0,
|
||||
stars: 0,
|
||||
comments: 0,
|
||||
installsAllTime: 0,
|
||||
installsCurrent: 0,
|
||||
downloadEvents: [],
|
||||
@@ -135,6 +139,12 @@ function aggregateEvents(events: Doc<'skillStatEvents'>[]): AggregatedDeltas {
|
||||
case 'unstar':
|
||||
result.stars -= 1
|
||||
break
|
||||
case 'comment':
|
||||
result.comments += 1
|
||||
break
|
||||
case 'uncomment':
|
||||
result.comments -= 1
|
||||
break
|
||||
case 'install_new':
|
||||
// New user installing for the first time: count toward both lifetime and current
|
||||
result.installsAllTime += 1
|
||||
@@ -231,12 +241,14 @@ export const processSkillStatEventsInternal = internalMutation({
|
||||
if (
|
||||
deltas.downloads !== 0 ||
|
||||
deltas.stars !== 0 ||
|
||||
deltas.comments !== 0 ||
|
||||
deltas.installsAllTime !== 0 ||
|
||||
deltas.installsCurrent !== 0
|
||||
) {
|
||||
const patch = applySkillStatDeltas(skill, {
|
||||
downloads: deltas.downloads,
|
||||
stars: deltas.stars,
|
||||
comments: deltas.comments,
|
||||
installsAllTime: deltas.installsAllTime,
|
||||
installsCurrent: deltas.installsCurrent,
|
||||
})
|
||||
@@ -285,7 +297,7 @@ export const processSkillStatEventsInternal = internalMutation({
|
||||
|
||||
const CURSOR_KEY = 'skill_stat_events'
|
||||
const EVENT_BATCH_SIZE = 500
|
||||
const MAX_SKILLS_PER_RUN = 500
|
||||
const MAX_SKILLS_PER_RUN = 50
|
||||
|
||||
/**
|
||||
* Fetch a batch of events after the given cursor (by _creationTime).
|
||||
@@ -332,6 +344,7 @@ const skillDeltaValidator = v.object({
|
||||
skillId: v.id('skills'),
|
||||
downloads: v.number(),
|
||||
stars: v.number(),
|
||||
comments: v.number(),
|
||||
installsAllTime: v.number(),
|
||||
installsCurrent: v.number(),
|
||||
downloadEvents: v.array(v.number()),
|
||||
@@ -366,12 +379,14 @@ export const applyAggregatedStatsAndUpdateCursor = internalMutation({
|
||||
if (
|
||||
delta.downloads !== 0 ||
|
||||
delta.stars !== 0 ||
|
||||
delta.comments !== 0 ||
|
||||
delta.installsAllTime !== 0 ||
|
||||
delta.installsCurrent !== 0
|
||||
) {
|
||||
const patch = applySkillStatDeltas(skill, {
|
||||
downloads: delta.downloads,
|
||||
stars: delta.stars,
|
||||
comments: delta.comments,
|
||||
installsAllTime: delta.installsAllTime,
|
||||
installsCurrent: delta.installsCurrent,
|
||||
})
|
||||
@@ -438,6 +453,7 @@ export const processSkillStatEventsAction = internalAction({
|
||||
{
|
||||
downloads: number
|
||||
stars: number
|
||||
comments: number
|
||||
installsAllTime: number
|
||||
installsCurrent: number
|
||||
downloadEvents: number[]
|
||||
@@ -471,6 +487,7 @@ export const processSkillStatEventsAction = internalAction({
|
||||
skillDelta = {
|
||||
downloads: 0,
|
||||
stars: 0,
|
||||
comments: 0,
|
||||
installsAllTime: 0,
|
||||
installsCurrent: 0,
|
||||
downloadEvents: [],
|
||||
@@ -491,6 +508,12 @@ export const processSkillStatEventsAction = internalAction({
|
||||
case 'unstar':
|
||||
skillDelta.stars -= 1
|
||||
break
|
||||
case 'comment':
|
||||
skillDelta.comments += 1
|
||||
break
|
||||
case 'uncomment':
|
||||
skillDelta.comments -= 1
|
||||
break
|
||||
case 'install_new':
|
||||
skillDelta.installsAllTime += 1
|
||||
skillDelta.installsCurrent += 1
|
||||
|
||||
@@ -0,0 +1,349 @@
|
||||
import { describe, expect, it, vi } from 'vitest'
|
||||
import {
|
||||
approveSkillByHashInternal,
|
||||
clearOwnerSuspiciousFlagsInternal,
|
||||
escalateByVtInternal,
|
||||
insertVersion,
|
||||
} from './skills'
|
||||
|
||||
type WrappedHandler<TArgs> = {
|
||||
_handler: (ctx: unknown, args: TArgs) => Promise<unknown>
|
||||
}
|
||||
|
||||
const insertVersionHandler = (insertVersion as unknown as WrappedHandler<Record<string, unknown>>)
|
||||
._handler
|
||||
const approveSkillByHashHandler = (
|
||||
approveSkillByHashInternal as unknown as WrappedHandler<Record<string, unknown>>
|
||||
)._handler
|
||||
const escalateByVtHandler = (
|
||||
escalateByVtInternal as unknown as WrappedHandler<Record<string, unknown>>
|
||||
)._handler
|
||||
const clearOwnerSuspiciousFlagsHandler = (
|
||||
clearOwnerSuspiciousFlagsInternal as unknown as WrappedHandler<Record<string, unknown>>
|
||||
)._handler
|
||||
|
||||
function createPublishArgs(overrides?: Partial<Record<string, unknown>>) {
|
||||
return {
|
||||
userId: 'users:owner',
|
||||
slug: 'spam-skill',
|
||||
displayName: 'Spam Skill',
|
||||
version: '1.0.0',
|
||||
changelog: 'Initial release',
|
||||
changelogSource: 'user',
|
||||
tags: ['latest'],
|
||||
fingerprint: 'f'.repeat(64),
|
||||
files: [
|
||||
{
|
||||
path: 'SKILL.md',
|
||||
size: 128,
|
||||
storageId: '_storage:1',
|
||||
sha256: 'a'.repeat(64),
|
||||
contentType: 'text/markdown',
|
||||
},
|
||||
],
|
||||
parsed: {
|
||||
frontmatter: { description: 'test' },
|
||||
metadata: {},
|
||||
clawdis: {},
|
||||
},
|
||||
embedding: [0.1, 0.2],
|
||||
...overrides,
|
||||
}
|
||||
}
|
||||
|
||||
describe('skills anti-spam guards', () => {
|
||||
it('blocks low-trust users after hourly new-skill cap', async () => {
|
||||
const now = Date.now()
|
||||
const ownerSkills = Array.from({ length: 5 }, (_, i) => ({
|
||||
_id: `skills:${i}`,
|
||||
createdAt: now - i * 10_000,
|
||||
}))
|
||||
|
||||
const db = {
|
||||
get: vi.fn(async () => ({
|
||||
_id: 'users:owner',
|
||||
_creationTime: now - 2 * 24 * 60 * 60 * 1000,
|
||||
createdAt: now - 2 * 24 * 60 * 60 * 1000,
|
||||
deletedAt: undefined,
|
||||
})),
|
||||
query: vi.fn((table: string) => {
|
||||
if (table === 'skills') {
|
||||
return {
|
||||
withIndex: (name: string) => {
|
||||
if (name === 'by_slug') {
|
||||
return { unique: async () => null }
|
||||
}
|
||||
if (name === 'by_owner') {
|
||||
return {
|
||||
order: () => ({
|
||||
take: async () => ownerSkills,
|
||||
}),
|
||||
}
|
||||
}
|
||||
throw new Error(`unexpected index ${name}`)
|
||||
},
|
||||
}
|
||||
}
|
||||
throw new Error(`unexpected table ${table}`)
|
||||
}),
|
||||
}
|
||||
|
||||
await expect(
|
||||
insertVersionHandler({ db } as never, createPublishArgs() as never),
|
||||
).rejects.toThrow(/max 5 new skills per hour/i)
|
||||
})
|
||||
|
||||
it('keeps suspicious skills visible for low-trust publishers', async () => {
|
||||
const patch = vi.fn(async () => {})
|
||||
const version = { _id: 'skillVersions:1', skillId: 'skills:1' }
|
||||
const skill = {
|
||||
_id: 'skills:1',
|
||||
slug: 'spam-skill',
|
||||
ownerUserId: 'users:owner',
|
||||
moderationFlags: undefined,
|
||||
moderationReason: undefined,
|
||||
}
|
||||
const owner = {
|
||||
_id: 'users:owner',
|
||||
_creationTime: Date.now() - 2 * 24 * 60 * 60 * 1000,
|
||||
createdAt: Date.now() - 2 * 24 * 60 * 60 * 1000,
|
||||
deletedAt: undefined,
|
||||
}
|
||||
|
||||
const db = {
|
||||
get: vi.fn(async (id: string) => {
|
||||
if (id === 'skills:1') return skill
|
||||
if (id === 'users:owner') return owner
|
||||
return null
|
||||
}),
|
||||
query: vi.fn((table: string) => {
|
||||
if (table === 'skillVersions') {
|
||||
return {
|
||||
withIndex: () => ({
|
||||
unique: async () => version,
|
||||
}),
|
||||
}
|
||||
}
|
||||
if (table === 'skills') {
|
||||
return {
|
||||
withIndex: (name: string) => {
|
||||
if (name === 'by_owner') {
|
||||
return {
|
||||
order: () => ({
|
||||
take: async () => [],
|
||||
}),
|
||||
}
|
||||
}
|
||||
throw new Error(`unexpected skills index ${name}`)
|
||||
},
|
||||
}
|
||||
}
|
||||
throw new Error(`unexpected table ${table}`)
|
||||
}),
|
||||
patch,
|
||||
}
|
||||
|
||||
await approveSkillByHashHandler(
|
||||
{ db, scheduler: { runAfter: vi.fn() } } as never,
|
||||
{
|
||||
sha256hash: 'h'.repeat(64),
|
||||
scanner: 'vt',
|
||||
status: 'suspicious',
|
||||
} as never,
|
||||
)
|
||||
|
||||
expect(patch).toHaveBeenCalledWith(
|
||||
'skills:1',
|
||||
expect.objectContaining({
|
||||
moderationStatus: 'active',
|
||||
moderationReason: 'scanner.vt.suspicious',
|
||||
moderationFlags: ['flagged.suspicious'],
|
||||
}),
|
||||
)
|
||||
})
|
||||
|
||||
it('keeps admin-owned skills non-suspicious for suspicious scanner verdicts', async () => {
|
||||
const patch = vi.fn(async () => {})
|
||||
const version = { _id: 'skillVersions:1', skillId: 'skills:1' }
|
||||
const skill = {
|
||||
_id: 'skills:1',
|
||||
slug: 'trusted-skill',
|
||||
ownerUserId: 'users:owner',
|
||||
moderationFlags: ['flagged.suspicious'],
|
||||
moderationReason: 'scanner.vt.suspicious',
|
||||
}
|
||||
const owner = {
|
||||
_id: 'users:owner',
|
||||
role: 'admin',
|
||||
_creationTime: Date.now() - 60 * 24 * 60 * 60 * 1000,
|
||||
createdAt: Date.now() - 60 * 24 * 60 * 60 * 1000,
|
||||
deletedAt: undefined,
|
||||
}
|
||||
|
||||
const db = {
|
||||
get: vi.fn(async (id: string) => {
|
||||
if (id === 'skills:1') return skill
|
||||
if (id === 'users:owner') return owner
|
||||
return null
|
||||
}),
|
||||
query: vi.fn((table: string) => {
|
||||
if (table === 'skillVersions') {
|
||||
return {
|
||||
withIndex: () => ({
|
||||
unique: async () => version,
|
||||
}),
|
||||
}
|
||||
}
|
||||
if (table === 'skills') {
|
||||
return {
|
||||
withIndex: (name: string) => {
|
||||
if (name === 'by_owner') {
|
||||
return {
|
||||
order: () => ({
|
||||
take: async () => [],
|
||||
}),
|
||||
}
|
||||
}
|
||||
throw new Error(`unexpected skills index ${name}`)
|
||||
},
|
||||
}
|
||||
}
|
||||
throw new Error(`unexpected table ${table}`)
|
||||
}),
|
||||
patch,
|
||||
}
|
||||
|
||||
await approveSkillByHashHandler(
|
||||
{ db, scheduler: { runAfter: vi.fn() } } as never,
|
||||
{
|
||||
sha256hash: 'h'.repeat(64),
|
||||
scanner: 'llm',
|
||||
status: 'suspicious',
|
||||
} as never,
|
||||
)
|
||||
|
||||
expect(patch).toHaveBeenCalledWith(
|
||||
'skills:1',
|
||||
expect.objectContaining({
|
||||
moderationStatus: 'active',
|
||||
moderationReason: 'scanner.llm.clean',
|
||||
moderationFlags: undefined,
|
||||
}),
|
||||
)
|
||||
})
|
||||
|
||||
it('vt suspicious escalation does not keep suspicious flags for admin owners', async () => {
|
||||
const patch = vi.fn(async () => {})
|
||||
const version = { _id: 'skillVersions:1', skillId: 'skills:1' }
|
||||
const skill = {
|
||||
_id: 'skills:1',
|
||||
slug: 'trusted-skill',
|
||||
ownerUserId: 'users:owner',
|
||||
moderationFlags: ['flagged.suspicious'],
|
||||
moderationReason: 'scanner.llm.suspicious',
|
||||
}
|
||||
const owner = {
|
||||
_id: 'users:owner',
|
||||
role: 'admin',
|
||||
deletedAt: undefined,
|
||||
}
|
||||
|
||||
const db = {
|
||||
get: vi.fn(async (id: string) => {
|
||||
if (id === 'skills:1') return skill
|
||||
if (id === 'users:owner') return owner
|
||||
return null
|
||||
}),
|
||||
query: vi.fn((table: string) => {
|
||||
if (table === 'skillVersions') {
|
||||
return {
|
||||
withIndex: () => ({
|
||||
unique: async () => version,
|
||||
}),
|
||||
}
|
||||
}
|
||||
throw new Error(`unexpected table ${table}`)
|
||||
}),
|
||||
patch,
|
||||
}
|
||||
|
||||
await escalateByVtHandler(
|
||||
{ db, scheduler: { runAfter: vi.fn() } } as never,
|
||||
{
|
||||
sha256hash: 'h'.repeat(64),
|
||||
status: 'suspicious',
|
||||
} as never,
|
||||
)
|
||||
|
||||
expect(patch).toHaveBeenCalledWith(
|
||||
'skills:1',
|
||||
expect.objectContaining({
|
||||
moderationFlags: undefined,
|
||||
moderationReason: 'scanner.llm.clean',
|
||||
}),
|
||||
)
|
||||
})
|
||||
|
||||
it('bulk-clears suspicious flags/reasons for privileged owner skills', async () => {
|
||||
const patch = vi.fn(async () => {})
|
||||
const owner = {
|
||||
_id: 'users:owner',
|
||||
role: 'admin',
|
||||
deletedAt: undefined,
|
||||
}
|
||||
const skills = [
|
||||
{
|
||||
_id: 'skills:1',
|
||||
moderationFlags: ['flagged.suspicious'],
|
||||
moderationReason: 'scanner.vt.suspicious',
|
||||
moderationStatus: 'hidden',
|
||||
softDeletedAt: undefined,
|
||||
},
|
||||
{
|
||||
_id: 'skills:2',
|
||||
moderationFlags: undefined,
|
||||
moderationReason: 'scanner.llm.clean',
|
||||
moderationStatus: 'active',
|
||||
softDeletedAt: undefined,
|
||||
},
|
||||
]
|
||||
|
||||
const db = {
|
||||
get: vi.fn(async (id: string) => {
|
||||
if (id === 'users:owner') return owner
|
||||
return null
|
||||
}),
|
||||
query: vi.fn((table: string) => {
|
||||
if (table === 'skills') {
|
||||
return {
|
||||
withIndex: (name: string) => {
|
||||
if (name !== 'by_owner') throw new Error(`unexpected skills index ${name}`)
|
||||
return {
|
||||
order: () => ({
|
||||
take: async () => skills,
|
||||
}),
|
||||
}
|
||||
},
|
||||
}
|
||||
}
|
||||
throw new Error(`unexpected table ${table}`)
|
||||
}),
|
||||
patch,
|
||||
}
|
||||
|
||||
const result = await clearOwnerSuspiciousFlagsHandler(
|
||||
{ db } as never,
|
||||
{ ownerUserId: 'users:owner', limit: 20 } as never,
|
||||
)
|
||||
|
||||
expect(result).toEqual({ inspected: 2, updated: 1 })
|
||||
expect(patch).toHaveBeenCalledWith(
|
||||
'skills:1',
|
||||
expect.objectContaining({
|
||||
moderationFlags: undefined,
|
||||
moderationReason: 'scanner.vt.clean',
|
||||
moderationStatus: 'active',
|
||||
}),
|
||||
)
|
||||
})
|
||||
})
|
||||
+1926
-190
File diff suppressed because it is too large
Load Diff
+10
-2
@@ -145,6 +145,14 @@ export const getVersionById = query({
|
||||
handler: async (ctx, args) => ctx.db.get(args.versionId),
|
||||
})
|
||||
|
||||
export const getVersionsByIdsInternal = internalQuery({
|
||||
args: { versionIds: v.array(v.id('soulVersions')) },
|
||||
handler: async (ctx, args) => {
|
||||
const versions = await Promise.all(args.versionIds.map((id) => ctx.db.get(id)))
|
||||
return versions.filter((v): v is NonNullable<typeof v> => v !== null)
|
||||
},
|
||||
})
|
||||
|
||||
export const getVersionByIdInternal = internalQuery({
|
||||
args: { versionId: v.id('soulVersions') },
|
||||
handler: async (ctx, args) => ctx.db.get(args.versionId),
|
||||
@@ -386,7 +394,7 @@ export const insertVersion = internalMutation({
|
||||
handler: async (ctx, args) => {
|
||||
const userId = args.userId
|
||||
const user = await ctx.db.get(userId)
|
||||
if (!user || user.deletedAt) throw new Error('User not found')
|
||||
if (!user || user.deletedAt || user.deactivatedAt) throw new Error('User not found')
|
||||
|
||||
const soulMatches = await ctx.db
|
||||
.query('souls')
|
||||
@@ -508,7 +516,7 @@ export const setSoulSoftDeletedInternal = internalMutation({
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const user = await ctx.db.get(args.userId)
|
||||
if (!user || user.deletedAt) throw new Error('User not found')
|
||||
if (!user || user.deletedAt || user.deactivatedAt) throw new Error('User not found')
|
||||
|
||||
const slug = args.slug.trim().toLowerCase()
|
||||
if (!slug) throw new Error('Slug required')
|
||||
|
||||
@@ -200,6 +200,102 @@ function buildSkillStatPatch(skill: Doc<'skills'>) {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Reconcile skill stats by counting actual records in source-of-truth tables.
|
||||
*
|
||||
* This fixes stats that got out of sync due to missed events, cursor issues,
|
||||
* or bugs in the event processing pipeline. It counts:
|
||||
* - stars: actual records in the `stars` table for each skill
|
||||
* - comments: actual records in the `comments` table for each skill
|
||||
*
|
||||
* Downloads and installs are event-sourced only (no separate table to count from),
|
||||
* so they cannot be reconciled this way.
|
||||
*/
|
||||
export const reconcileSkillStarCounts = internalMutation({
|
||||
args: {
|
||||
cursor: v.optional(v.string()),
|
||||
batchSize: v.optional(v.number()),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const batchSize = clampInt(args.batchSize ?? 50, 1, 200)
|
||||
const now = Date.now()
|
||||
|
||||
const { page, isDone, continueCursor } = await ctx.db
|
||||
.query('skills')
|
||||
.order('asc')
|
||||
.paginate({ cursor: args.cursor ?? null, numItems: batchSize })
|
||||
|
||||
let patched = 0
|
||||
for (const skill of page) {
|
||||
// Count actual star records for this skill
|
||||
const starRecords = await ctx.db
|
||||
.query('stars')
|
||||
.withIndex('by_skill_user', (q) => q.eq('skillId', skill._id))
|
||||
.collect()
|
||||
const actualStars = starRecords.length
|
||||
|
||||
// Count actual comment records for this skill
|
||||
const commentRecords = await ctx.db
|
||||
.query('comments')
|
||||
.withIndex('by_skill', (q) => q.eq('skillId', skill._id))
|
||||
.collect()
|
||||
const actualComments = commentRecords.filter((c) => !c.softDeletedAt).length
|
||||
|
||||
// Check if stats are out of sync
|
||||
if (skill.stats.stars !== actualStars || skill.stats.comments !== actualComments) {
|
||||
const updatedStats = {
|
||||
...skill.stats,
|
||||
stars: actualStars,
|
||||
comments: actualComments,
|
||||
}
|
||||
await ctx.db.patch(skill._id, {
|
||||
statsStars: actualStars,
|
||||
stats: updatedStats,
|
||||
updatedAt: now,
|
||||
})
|
||||
patched += 1
|
||||
}
|
||||
}
|
||||
|
||||
return {
|
||||
scanned: page.length,
|
||||
patched,
|
||||
cursor: isDone ? null : continueCursor,
|
||||
isDone,
|
||||
}
|
||||
},
|
||||
})
|
||||
|
||||
export const runReconcileSkillStarCountsInternal = internalAction({
|
||||
args: {
|
||||
batchSize: v.optional(v.number()),
|
||||
maxBatches: v.optional(v.number()),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const batchSize = clampInt(args.batchSize ?? 50, 1, 200)
|
||||
const maxBatches = clampInt(args.maxBatches ?? 10, 1, 50)
|
||||
|
||||
let cursor: string | undefined
|
||||
let totalScanned = 0
|
||||
let totalPatched = 0
|
||||
|
||||
for (let i = 0; i < maxBatches; i++) {
|
||||
const result = (await ctx.runMutation(internal.statsMaintenance.reconcileSkillStarCounts, {
|
||||
cursor,
|
||||
batchSize,
|
||||
})) as { scanned: number; patched: number; cursor: string | null; isDone: boolean }
|
||||
|
||||
totalScanned += result.scanned
|
||||
totalPatched += result.patched
|
||||
|
||||
if (result.isDone) break
|
||||
cursor = result.cursor ?? undefined
|
||||
}
|
||||
|
||||
return { scanned: totalScanned, patched: totalPatched }
|
||||
},
|
||||
})
|
||||
|
||||
function clampInt(value: number, min: number, max: number) {
|
||||
return Math.min(Math.max(value, min), max)
|
||||
}
|
||||
|
||||
+21
-3
@@ -1,7 +1,25 @@
|
||||
{
|
||||
"extends": "../tsconfig.json",
|
||||
/* This TypeScript project config describes the environment that
|
||||
* Convex functions run in and is used to typecheck them.
|
||||
* You can modify it, but some settings are required to use Convex.
|
||||
*/
|
||||
"compilerOptions": {
|
||||
/* These settings are not required by Convex and can be modified. */
|
||||
"allowJs": true,
|
||||
"strict": true,
|
||||
"moduleResolution": "Bundler",
|
||||
"skipLibCheck": true
|
||||
}
|
||||
"jsx": "react-jsx",
|
||||
"skipLibCheck": true,
|
||||
"allowSyntheticDefaultImports": true,
|
||||
|
||||
/* These compiler options are required by Convex */
|
||||
"target": "ESNext",
|
||||
"lib": ["ES2022", "dom", "dom.iterable"],
|
||||
"forceConsistentCasingInFileNames": true,
|
||||
"module": "ESNext",
|
||||
"isolatedModules": true,
|
||||
"noEmit": true
|
||||
},
|
||||
"include": ["./**/*"],
|
||||
"exclude": ["./_generated"]
|
||||
}
|
||||
|
||||
+1
-1
@@ -14,7 +14,7 @@ export const generateUploadUrlForUserInternal = internalMutation({
|
||||
args: { userId: v.id('users') },
|
||||
handler: async (ctx, args) => {
|
||||
const user = await ctx.db.get(args.userId)
|
||||
if (!user || user.deletedAt) throw new Error('User not found')
|
||||
if (!user || user.deletedAt || user.deactivatedAt) throw new Error('User not found')
|
||||
return ctx.storage.generateUploadUrl()
|
||||
},
|
||||
})
|
||||
|
||||
@@ -0,0 +1,90 @@
|
||||
import { afterEach, describe, expect, it, vi } from 'vitest'
|
||||
|
||||
vi.mock('./lib/access', async () => {
|
||||
const actual = await vi.importActual<typeof import('./lib/access')>('./lib/access')
|
||||
return { ...actual, requireUser: vi.fn() }
|
||||
})
|
||||
|
||||
const { requireUser } = await import('./lib/access')
|
||||
const { ensureHandler } = await import('./users')
|
||||
|
||||
function makeCtx() {
|
||||
const patch = vi.fn()
|
||||
const get = vi.fn()
|
||||
return { ctx: { db: { patch, get } } as never, patch, get }
|
||||
}
|
||||
|
||||
describe('ensureHandler', () => {
|
||||
afterEach(() => {
|
||||
vi.mocked(requireUser).mockReset()
|
||||
})
|
||||
|
||||
it('updates handle and display name when GitHub login changes', async () => {
|
||||
const { ctx, patch } = makeCtx()
|
||||
vi.mocked(requireUser).mockResolvedValue({
|
||||
userId: 'users:1',
|
||||
user: {
|
||||
_creationTime: 1,
|
||||
handle: 'old-handle',
|
||||
displayName: 'old-handle',
|
||||
name: 'new-handle',
|
||||
email: 'old@example.com',
|
||||
role: 'user',
|
||||
createdAt: 1,
|
||||
},
|
||||
} as never)
|
||||
|
||||
await ensureHandler(ctx)
|
||||
|
||||
expect(patch).toHaveBeenCalledWith('users:1', {
|
||||
handle: 'new-handle',
|
||||
displayName: 'new-handle',
|
||||
updatedAt: expect.any(Number),
|
||||
})
|
||||
})
|
||||
|
||||
it('does not override a custom display name when syncing handle', async () => {
|
||||
const { ctx, patch } = makeCtx()
|
||||
vi.mocked(requireUser).mockResolvedValue({
|
||||
userId: 'users:2',
|
||||
user: {
|
||||
_creationTime: 1,
|
||||
handle: 'old-handle',
|
||||
displayName: 'Custom Name',
|
||||
name: 'new-handle',
|
||||
role: 'user',
|
||||
createdAt: 1,
|
||||
},
|
||||
} as never)
|
||||
|
||||
await ensureHandler(ctx)
|
||||
|
||||
expect(patch).toHaveBeenCalledWith('users:2', {
|
||||
handle: 'new-handle',
|
||||
updatedAt: expect.any(Number),
|
||||
})
|
||||
})
|
||||
|
||||
it('fills display name from existing handle when missing', async () => {
|
||||
const { ctx, patch } = makeCtx()
|
||||
vi.mocked(requireUser).mockResolvedValue({
|
||||
userId: 'users:3',
|
||||
user: {
|
||||
_creationTime: 1,
|
||||
handle: 'steady-handle',
|
||||
displayName: undefined,
|
||||
name: undefined,
|
||||
email: undefined,
|
||||
role: 'user',
|
||||
createdAt: 1,
|
||||
},
|
||||
} as never)
|
||||
|
||||
await ensureHandler(ctx)
|
||||
|
||||
expect(patch).toHaveBeenCalledWith('users:3', {
|
||||
displayName: 'steady-handle',
|
||||
updatedAt: expect.any(Number),
|
||||
})
|
||||
})
|
||||
})
|
||||
+414
-35
@@ -1,9 +1,12 @@
|
||||
import { getAuthUserId } from '@convex-dev/auth/server'
|
||||
import { v } from 'convex/values'
|
||||
import { internal } from './_generated/api'
|
||||
import { internalQuery, mutation, query } from './_generated/server'
|
||||
import { assertAdmin, requireUser } from './lib/access'
|
||||
import type { Doc, Id } from './_generated/dataModel'
|
||||
import type { MutationCtx } from './_generated/server'
|
||||
import { internalMutation, internalQuery, mutation, query } from './_generated/server'
|
||||
import { assertAdmin, assertModerator, requireUser } from './lib/access'
|
||||
import { toPublicUser } from './lib/public'
|
||||
import { buildUserSearchResults } from './lib/userSearch'
|
||||
|
||||
const DEFAULT_ROLE = 'user'
|
||||
const ADMIN_HANDLE = 'steipete'
|
||||
@@ -18,41 +21,128 @@ export const getByIdInternal = internalQuery({
|
||||
handler: async (ctx, args) => ctx.db.get(args.userId),
|
||||
})
|
||||
|
||||
export const getGitHubProviderAccountIdInternal = internalQuery({
|
||||
args: { userId: v.id('users') },
|
||||
handler: async (ctx, args) => {
|
||||
const account = await ctx.db
|
||||
.query('authAccounts')
|
||||
.withIndex('userIdAndProvider', (q) => q.eq('userId', args.userId).eq('provider', 'github'))
|
||||
.unique()
|
||||
return account?.providerAccountId ?? null
|
||||
},
|
||||
})
|
||||
|
||||
export const searchInternal = internalQuery({
|
||||
args: {
|
||||
actorUserId: v.id('users'),
|
||||
query: v.optional(v.string()),
|
||||
limit: v.optional(v.number()),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const actor = await ctx.db.get(args.actorUserId)
|
||||
if (!actor || actor.deletedAt || actor.deactivatedAt) throw new Error('Unauthorized')
|
||||
assertAdmin(actor)
|
||||
|
||||
const limit = Math.min(Math.max(args.limit ?? 20, 1), 200)
|
||||
const users = await ctx.db.query('users').order('desc').collect()
|
||||
const result = buildUserSearchResults(users, args.query)
|
||||
const items = result.items.slice(0, limit).map((user) => ({
|
||||
userId: user._id,
|
||||
handle: user.handle ?? null,
|
||||
displayName: user.displayName ?? null,
|
||||
name: user.name ?? null,
|
||||
role: user.role ?? null,
|
||||
}))
|
||||
return { items, total: result.total }
|
||||
},
|
||||
})
|
||||
export const updateGithubMetaInternal = internalMutation({
|
||||
args: {
|
||||
userId: v.id('users'),
|
||||
githubCreatedAt: v.number(),
|
||||
githubFetchedAt: v.number(),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
await ctx.db.patch(args.userId, {
|
||||
githubCreatedAt: args.githubCreatedAt,
|
||||
githubFetchedAt: args.githubFetchedAt,
|
||||
updatedAt: args.githubFetchedAt,
|
||||
})
|
||||
},
|
||||
})
|
||||
|
||||
export const me = query({
|
||||
args: {},
|
||||
handler: async (ctx) => {
|
||||
const userId = await getAuthUserId(ctx)
|
||||
if (!userId) return null
|
||||
const user = await ctx.db.get(userId)
|
||||
if (!user || user.deletedAt) return null
|
||||
if (!user || user.deletedAt || user.deactivatedAt) return null
|
||||
return user
|
||||
},
|
||||
})
|
||||
|
||||
export const ensure = mutation({
|
||||
args: {},
|
||||
handler: async (ctx) => {
|
||||
const { userId, user } = await requireUser(ctx)
|
||||
const now = Date.now()
|
||||
const updates: Record<string, unknown> = {}
|
||||
|
||||
const handle = user.handle ?? user.name ?? user.email?.split('@')[0]
|
||||
if (!user.handle && handle) updates.handle = handle
|
||||
if (!user.displayName) updates.displayName = handle
|
||||
if (!user.role) {
|
||||
updates.role = handle === ADMIN_HANDLE ? 'admin' : DEFAULT_ROLE
|
||||
}
|
||||
if (!user.createdAt) updates.createdAt = user._creationTime
|
||||
updates.updatedAt = now
|
||||
|
||||
if (Object.keys(updates).length > 0) {
|
||||
await ctx.db.patch(userId, updates)
|
||||
}
|
||||
|
||||
return ctx.db.get(userId)
|
||||
},
|
||||
handler: ensureHandler,
|
||||
})
|
||||
|
||||
function normalizeHandle(handle: string | undefined) {
|
||||
const normalized = handle?.trim()
|
||||
return normalized ? normalized : undefined
|
||||
}
|
||||
|
||||
function deriveHandle(args: { existingHandle?: string; githubLogin?: string; email?: string }) {
|
||||
// Prefer the GitHub login; only fall back to email-derived handle when we don't already have one.
|
||||
if (args.githubLogin) return args.githubLogin
|
||||
if (!args.existingHandle && args.email) return args.email.split('@')[0]?.trim() || undefined
|
||||
return undefined
|
||||
}
|
||||
|
||||
function computeEnsureUpdates(user: Doc<'users'>) {
|
||||
const updates: Record<string, unknown> = {}
|
||||
|
||||
const existingHandle = normalizeHandle(user.handle)
|
||||
const githubLogin = normalizeHandle(user.name)
|
||||
const derivedHandle = deriveHandle({
|
||||
existingHandle,
|
||||
githubLogin,
|
||||
email: user.email,
|
||||
})
|
||||
const baseHandle = derivedHandle ?? existingHandle
|
||||
|
||||
if (derivedHandle && existingHandle !== derivedHandle) {
|
||||
updates.handle = derivedHandle
|
||||
}
|
||||
|
||||
const displayName = normalizeHandle(user.displayName)
|
||||
if (!displayName && baseHandle) {
|
||||
updates.displayName = baseHandle
|
||||
} else if (derivedHandle && displayName === existingHandle) {
|
||||
updates.displayName = derivedHandle
|
||||
}
|
||||
|
||||
if (!user.role) {
|
||||
updates.role = baseHandle === ADMIN_HANDLE ? 'admin' : DEFAULT_ROLE
|
||||
}
|
||||
|
||||
if (!user.createdAt) updates.createdAt = user._creationTime
|
||||
|
||||
return updates
|
||||
}
|
||||
|
||||
export async function ensureHandler(ctx: MutationCtx) {
|
||||
const { userId, user } = await requireUser(ctx)
|
||||
const updates = computeEnsureUpdates(user)
|
||||
|
||||
if (Object.keys(updates).length > 0) {
|
||||
updates.updatedAt = Date.now()
|
||||
await ctx.db.patch(userId, updates)
|
||||
}
|
||||
|
||||
return ctx.db.get(userId)
|
||||
}
|
||||
|
||||
export const updateProfile = mutation({
|
||||
args: {
|
||||
displayName: v.string(),
|
||||
@@ -72,21 +162,52 @@ export const deleteAccount = mutation({
|
||||
args: {},
|
||||
handler: async (ctx) => {
|
||||
const { userId } = await requireUser(ctx)
|
||||
const now = Date.now()
|
||||
|
||||
const tokens = await ctx.db
|
||||
.query('apiTokens')
|
||||
.withIndex('by_user', (q) => q.eq('userId', userId))
|
||||
.collect()
|
||||
for (const token of tokens) {
|
||||
if (!token.revokedAt) {
|
||||
await ctx.db.patch(token._id, { revokedAt: now })
|
||||
}
|
||||
}
|
||||
|
||||
await ctx.db.patch(userId, {
|
||||
deletedAt: Date.now(),
|
||||
updatedAt: Date.now(),
|
||||
deactivatedAt: now,
|
||||
purgedAt: now,
|
||||
deletedAt: undefined,
|
||||
banReason: undefined,
|
||||
role: 'user',
|
||||
handle: undefined,
|
||||
displayName: undefined,
|
||||
name: undefined,
|
||||
image: undefined,
|
||||
email: undefined,
|
||||
emailVerificationTime: undefined,
|
||||
phone: undefined,
|
||||
phoneVerificationTime: undefined,
|
||||
isAnonymous: undefined,
|
||||
bio: undefined,
|
||||
githubCreatedAt: undefined,
|
||||
githubFetchedAt: undefined,
|
||||
updatedAt: now,
|
||||
})
|
||||
await ctx.runMutation(internal.telemetry.clearUserTelemetryInternal, { userId })
|
||||
},
|
||||
})
|
||||
|
||||
export const list = query({
|
||||
args: { limit: v.optional(v.number()) },
|
||||
args: { limit: v.optional(v.number()), search: v.optional(v.string()) },
|
||||
handler: async (ctx, args) => {
|
||||
const { user } = await requireUser(ctx)
|
||||
assertAdmin(user)
|
||||
const limit = args.limit ?? 50
|
||||
return ctx.db.query('users').order('desc').take(limit)
|
||||
const limit = Math.min(Math.max(args.limit ?? 50, 1), 200)
|
||||
const query = args.search?.trim().toLowerCase()
|
||||
const users = await ctx.db.query('users').order('desc').collect()
|
||||
const result = buildUserSearchResults(users, query)
|
||||
return { items: result.items.slice(0, limit), total: result.total }
|
||||
},
|
||||
})
|
||||
|
||||
@@ -108,15 +229,273 @@ export const setRole = mutation({
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const { user } = await requireUser(ctx)
|
||||
assertAdmin(user)
|
||||
await ctx.db.patch(args.userId, { role: args.role, updatedAt: Date.now() })
|
||||
return setRoleWithActor(ctx, user, args.userId, args.role)
|
||||
},
|
||||
})
|
||||
|
||||
export const setRoleInternal = internalMutation({
|
||||
args: {
|
||||
actorUserId: v.id('users'),
|
||||
targetUserId: v.id('users'),
|
||||
role: v.union(v.literal('admin'), v.literal('moderator'), v.literal('user')),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const actor = await ctx.db.get(args.actorUserId)
|
||||
if (!actor || actor.deletedAt || actor.deactivatedAt) throw new Error('User not found')
|
||||
return setRoleWithActor(ctx, actor, args.targetUserId, args.role)
|
||||
},
|
||||
})
|
||||
|
||||
async function setRoleWithActor(
|
||||
ctx: MutationCtx,
|
||||
actor: Doc<'users'>,
|
||||
targetUserId: Id<'users'>,
|
||||
role: 'admin' | 'moderator' | 'user',
|
||||
) {
|
||||
assertAdmin(actor)
|
||||
const target = await ctx.db.get(targetUserId)
|
||||
if (!target) throw new Error('User not found')
|
||||
const now = Date.now()
|
||||
await ctx.db.patch(targetUserId, { role, updatedAt: now })
|
||||
await ctx.db.insert('auditLogs', {
|
||||
actorUserId: actor._id,
|
||||
action: 'role.change',
|
||||
targetType: 'user',
|
||||
targetId: targetUserId,
|
||||
metadata: { role },
|
||||
createdAt: now,
|
||||
})
|
||||
return { ok: true as const, role }
|
||||
}
|
||||
|
||||
export const banUser = mutation({
|
||||
args: { userId: v.id('users'), reason: v.optional(v.string()) },
|
||||
handler: async (ctx, args) => {
|
||||
const { user } = await requireUser(ctx)
|
||||
return banUserWithActor(ctx, user, args.userId, args.reason)
|
||||
},
|
||||
})
|
||||
|
||||
export const banUserInternal = internalMutation({
|
||||
args: {
|
||||
actorUserId: v.id('users'),
|
||||
targetUserId: v.id('users'),
|
||||
reason: v.optional(v.string()),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const actor = await ctx.db.get(args.actorUserId)
|
||||
if (!actor || actor.deletedAt || actor.deactivatedAt) throw new Error('User not found')
|
||||
return banUserWithActor(ctx, actor, args.targetUserId, args.reason)
|
||||
},
|
||||
})
|
||||
|
||||
export const unbanUser = mutation({
|
||||
args: { userId: v.id('users'), reason: v.optional(v.string()) },
|
||||
handler: async (ctx, args) => {
|
||||
const { user } = await requireUser(ctx)
|
||||
return unbanUserWithActor(ctx, user, args.userId, args.reason)
|
||||
},
|
||||
})
|
||||
|
||||
export const unbanUserInternal = internalMutation({
|
||||
args: {
|
||||
actorUserId: v.id('users'),
|
||||
targetUserId: v.id('users'),
|
||||
reason: v.optional(v.string()),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const actor = await ctx.db.get(args.actorUserId)
|
||||
if (!actor || actor.deletedAt || actor.deactivatedAt) throw new Error('User not found')
|
||||
return unbanUserWithActor(ctx, actor, args.targetUserId, args.reason)
|
||||
},
|
||||
})
|
||||
|
||||
async function banUserWithActor(
|
||||
ctx: MutationCtx,
|
||||
actor: Doc<'users'>,
|
||||
targetUserId: Id<'users'>,
|
||||
reasonRaw?: string,
|
||||
) {
|
||||
assertModerator(actor)
|
||||
|
||||
if (targetUserId === actor._id) throw new Error('Cannot ban yourself')
|
||||
|
||||
const target = await ctx.db.get(targetUserId)
|
||||
if (!target) throw new Error('User not found')
|
||||
if (target.role === 'admin' && actor.role !== 'admin') {
|
||||
throw new Error('Forbidden')
|
||||
}
|
||||
|
||||
const now = Date.now()
|
||||
const reason = reasonRaw?.trim()
|
||||
if (reason && reason.length > 500) {
|
||||
throw new Error('Reason too long (max 500 chars)')
|
||||
}
|
||||
if (target.deletedAt || target.deactivatedAt) {
|
||||
return { ok: true as const, alreadyBanned: true, deletedSkills: 0 }
|
||||
}
|
||||
|
||||
const skills = await ctx.db
|
||||
.query('skills')
|
||||
.withIndex('by_owner', (q) => q.eq('ownerUserId', targetUserId))
|
||||
.collect()
|
||||
|
||||
for (const skill of skills) {
|
||||
await ctx.scheduler.runAfter(0, internal.skills.hardDeleteInternal, {
|
||||
skillId: skill._id,
|
||||
actorUserId: actor._id,
|
||||
})
|
||||
}
|
||||
|
||||
const tokens = await ctx.db
|
||||
.query('apiTokens')
|
||||
.withIndex('by_user', (q) => q.eq('userId', targetUserId))
|
||||
.collect()
|
||||
for (const token of tokens) {
|
||||
await ctx.db.patch(token._id, { revokedAt: now })
|
||||
}
|
||||
|
||||
await ctx.db.patch(targetUserId, {
|
||||
deletedAt: now,
|
||||
role: 'user',
|
||||
updatedAt: now,
|
||||
banReason: reason || undefined,
|
||||
})
|
||||
|
||||
await ctx.runMutation(internal.telemetry.clearUserTelemetryInternal, { userId: targetUserId })
|
||||
|
||||
await ctx.db.insert('auditLogs', {
|
||||
actorUserId: actor._id,
|
||||
action: 'user.ban',
|
||||
targetType: 'user',
|
||||
targetId: targetUserId,
|
||||
metadata: { deletedSkills: skills.length, reason: reason || undefined },
|
||||
createdAt: now,
|
||||
})
|
||||
|
||||
return { ok: true as const, alreadyBanned: false, deletedSkills: skills.length }
|
||||
}
|
||||
|
||||
async function unbanUserWithActor(
|
||||
ctx: MutationCtx,
|
||||
actor: Doc<'users'>,
|
||||
targetUserId: Id<'users'>,
|
||||
reasonRaw?: string,
|
||||
) {
|
||||
assertAdmin(actor)
|
||||
if (targetUserId === actor._id) throw new Error('Cannot unban yourself')
|
||||
|
||||
const target = await ctx.db.get(targetUserId)
|
||||
if (!target) throw new Error('User not found')
|
||||
if (target.deactivatedAt) {
|
||||
throw new Error('Cannot unban a permanently deleted account')
|
||||
}
|
||||
if (!target.deletedAt) {
|
||||
return { ok: true as const, alreadyUnbanned: true }
|
||||
}
|
||||
|
||||
const reason = reasonRaw?.trim()
|
||||
if (reason && reason.length > 500) {
|
||||
throw new Error('Reason too long (max 500 chars)')
|
||||
}
|
||||
|
||||
const now = Date.now()
|
||||
await ctx.db.patch(targetUserId, {
|
||||
deletedAt: undefined,
|
||||
banReason: undefined,
|
||||
role: 'user',
|
||||
updatedAt: now,
|
||||
})
|
||||
|
||||
await ctx.db.insert('auditLogs', {
|
||||
actorUserId: actor._id,
|
||||
action: 'user.unban',
|
||||
targetType: 'user',
|
||||
targetId: targetUserId,
|
||||
metadata: { reason: reason || undefined },
|
||||
createdAt: now,
|
||||
})
|
||||
|
||||
return { ok: true as const, alreadyUnbanned: false }
|
||||
}
|
||||
|
||||
/**
|
||||
* Auto-ban a user whose skill was flagged malicious by VT.
|
||||
* Skips moderators/admins. No actor required — this is a system-level action.
|
||||
*/
|
||||
export const autobanMalwareAuthorInternal = internalMutation({
|
||||
args: {
|
||||
ownerUserId: v.id('users'),
|
||||
sha256hash: v.string(),
|
||||
slug: v.string(),
|
||||
},
|
||||
handler: async (ctx, args) => {
|
||||
const target = await ctx.db.get(args.ownerUserId)
|
||||
if (!target) return { ok: false, reason: 'user_not_found' }
|
||||
if (target.deletedAt || target.deactivatedAt) return { ok: true, alreadyBanned: true }
|
||||
|
||||
// Never auto-ban moderators or admins
|
||||
if (target.role === 'admin' || target.role === 'moderator') {
|
||||
console.log(`[autoban] Skipping ${target.handle ?? args.ownerUserId}: role=${target.role}`)
|
||||
return { ok: false, reason: 'protected_role' }
|
||||
}
|
||||
|
||||
const now = Date.now()
|
||||
|
||||
// Soft-delete all their skills
|
||||
const skills = await ctx.db
|
||||
.query('skills')
|
||||
.withIndex('by_owner', (q) => q.eq('ownerUserId', args.ownerUserId))
|
||||
.collect()
|
||||
|
||||
for (const skill of skills) {
|
||||
if (!skill.softDeletedAt) {
|
||||
await ctx.db.patch(skill._id, { softDeletedAt: now, updatedAt: now })
|
||||
}
|
||||
}
|
||||
|
||||
// Revoke all API tokens
|
||||
const tokens = await ctx.db
|
||||
.query('apiTokens')
|
||||
.withIndex('by_user', (q) => q.eq('userId', args.ownerUserId))
|
||||
.collect()
|
||||
for (const token of tokens) {
|
||||
if (!token.revokedAt) {
|
||||
await ctx.db.patch(token._id, { revokedAt: now })
|
||||
}
|
||||
}
|
||||
|
||||
// Ban the user
|
||||
await ctx.db.patch(args.ownerUserId, {
|
||||
deletedAt: now,
|
||||
role: 'user',
|
||||
updatedAt: now,
|
||||
banReason: 'malware auto-ban',
|
||||
})
|
||||
|
||||
await ctx.runMutation(internal.telemetry.clearUserTelemetryInternal, {
|
||||
userId: args.ownerUserId,
|
||||
})
|
||||
|
||||
// Audit log — use the target as actor since there's no human actor
|
||||
await ctx.db.insert('auditLogs', {
|
||||
actorUserId: user._id,
|
||||
action: 'role.change',
|
||||
actorUserId: args.ownerUserId,
|
||||
action: 'user.autoban.malware',
|
||||
targetType: 'user',
|
||||
targetId: args.userId,
|
||||
metadata: { role: args.role },
|
||||
createdAt: Date.now(),
|
||||
targetId: args.ownerUserId,
|
||||
metadata: {
|
||||
trigger: 'vt.malicious',
|
||||
sha256hash: args.sha256hash,
|
||||
slug: args.slug,
|
||||
deletedSkills: skills.length,
|
||||
},
|
||||
createdAt: now,
|
||||
})
|
||||
|
||||
console.warn(
|
||||
`[autoban] Banned ${target.handle ?? args.ownerUserId} — malicious skill: ${args.slug}`,
|
||||
)
|
||||
|
||||
return { ok: true, alreadyBanned: false, deletedSkills: skills.length }
|
||||
},
|
||||
})
|
||||
|
||||
+1262
File diff suppressed because it is too large
Load Diff
@@ -22,6 +22,7 @@ Reading order (new contributor):
|
||||
Feature/ops docs (already present):
|
||||
|
||||
- `docs/spec.md`: product + implementation spec (data model + flows).
|
||||
- `docs/security.md`: moderation, reporting, bans, upload gating.
|
||||
- `docs/telemetry.md`: what `clawhub sync` reports; opt-out.
|
||||
- `docs/webhook.md`: Discord webhook events/payload.
|
||||
- `docs/diffing.md`: version-to-version diff UI spec.
|
||||
|
||||
+51
-1
@@ -61,11 +61,22 @@ Stores your API token + cached registry URL.
|
||||
|
||||
- Lists latest updated skills via `/api/v1/skills?limit=...` (sorted by `updatedAt` desc).
|
||||
- Flags:
|
||||
- `--limit <n>` (1–200, default: 25)
|
||||
- `--limit <n>` (1-200, default: 25)
|
||||
- `--sort newest|downloads|rating|installs|installsAllTime|trending` (default: newest)
|
||||
- `--json` (machine-readable output)
|
||||
- Output: `<slug> v<version> <age> <summary>` (summary truncated to 50 chars).
|
||||
|
||||
### `inspect <slug>`
|
||||
|
||||
- Fetches skill metadata and version files without installing.
|
||||
- `--version <version>`: inspect a specific version (default: latest).
|
||||
- `--tag <tag>`: inspect a tagged version (e.g. `latest`).
|
||||
- `--versions`: list version history (first page).
|
||||
- `--limit <n>`: max versions to list (1-200).
|
||||
- `--files`: list files for the selected version.
|
||||
- `--file <path>`: fetch raw file content (text files only; 200KB limit).
|
||||
- `--json`: machine-readable output.
|
||||
|
||||
### `install <slug>`
|
||||
|
||||
- Resolves latest version via `/api/v1/skills/<slug>`.
|
||||
@@ -92,6 +103,45 @@ Stores your API token + cached registry URL.
|
||||
- Publishes via `POST /api/v1/skills` (multipart).
|
||||
- Requires semver: `--version 1.2.3`.
|
||||
|
||||
### `delete <slug>`
|
||||
|
||||
- Soft-delete a skill (moderator/admin only).
|
||||
- Calls `DELETE /api/v1/skills/{slug}`.
|
||||
- `--yes` skips confirmation.
|
||||
|
||||
### `undelete <slug>`
|
||||
|
||||
- Restore a hidden skill (moderator/admin only).
|
||||
- Calls `POST /api/v1/skills/{slug}/undelete`.
|
||||
- `--yes` skips confirmation.
|
||||
|
||||
### `hide <slug>`
|
||||
|
||||
- Hide a skill (moderator/admin only).
|
||||
- Alias for `delete`.
|
||||
|
||||
### `unhide <slug>`
|
||||
|
||||
- Unhide a skill (moderator/admin only).
|
||||
- Alias for `undelete`.
|
||||
|
||||
### `ban-user <handleOrId>`
|
||||
|
||||
- Ban a user and delete owned skills (moderator/admin only).
|
||||
- Calls `POST /api/v1/users/ban`.
|
||||
- `--id` treats the argument as a user id instead of a handle.
|
||||
- `--fuzzy` resolves the handle via fuzzy user search (admin only).
|
||||
- `--reason` records an optional ban reason.
|
||||
- `--yes` skips confirmation.
|
||||
|
||||
### `set-role <handleOrId> <role>`
|
||||
|
||||
- Change a user role (admin only).
|
||||
- Calls `POST /api/v1/users/role`.
|
||||
- `--id` treats the argument as a user id instead of a handle.
|
||||
- `--fuzzy` resolves the handle via fuzzy user search (admin only).
|
||||
- `--yes` skips confirmation.
|
||||
|
||||
### `sync`
|
||||
|
||||
- Scans for local skill folders and publishes new/changed ones.
|
||||
|
||||
+2
-1
@@ -7,7 +7,7 @@ read_when:
|
||||
|
||||
# Deploy
|
||||
|
||||
OpenClaw is two deployables:
|
||||
ClawHub is two deployables:
|
||||
|
||||
- Web app (TanStack Start) → typically Vercel.
|
||||
- Convex backend → Convex deployment (serves `/api/...` routes).
|
||||
@@ -30,6 +30,7 @@ Ensure Convex env is set (auth + embeddings):
|
||||
- `OPENAI_API_KEY`
|
||||
- `SITE_URL` (your web app URL)
|
||||
- Optional webhook env (see `docs/webhook.md`)
|
||||
- Optional: `GITHUB_TOKEN` (recommended; raises GitHub account lookup limit used by publish gate)
|
||||
|
||||
## 2) Deploy web app (Vercel)
|
||||
|
||||
|
||||
+1
-1
@@ -10,7 +10,7 @@ read_when:
|
||||
## Goals
|
||||
- Compare any file between two versions.
|
||||
- Default compare: `latest` vs `previous` (SemVer precedence).
|
||||
- UX feels native to OpenClaw (theme + typography + motion).
|
||||
- UX feels native to ClawHub (theme + typography + motion).
|
||||
- Inline or side-by-side toggle.
|
||||
- Public access.
|
||||
|
||||
|
||||
+83
-1
@@ -19,11 +19,17 @@ Enforced per IP + per API key:
|
||||
|
||||
- Read: 120/min per IP, 600/min per key
|
||||
- Write: 30/min per IP, 120/min per key
|
||||
- Download: 20/min per IP, 120/min per key (`/api/v1/download`)
|
||||
|
||||
Headers:
|
||||
|
||||
- `X-RateLimit-Limit`, `X-RateLimit-Remaining`, `X-RateLimit-Reset`, `Retry-After` (when limited)
|
||||
|
||||
IP source:
|
||||
|
||||
- Uses `cf-connecting-ip` first, then falls back to `x-real-ip`, `x-forwarded-for`, or `fly-client-ip`.
|
||||
- Set `TRUST_FORWARDED_IPS=false` to disable forwarded-header fallback.
|
||||
|
||||
## Public endpoints (no auth)
|
||||
|
||||
### `GET /api/v1/search`
|
||||
@@ -40,6 +46,10 @@ Response:
|
||||
{ "results": [{ "score": 0.123, "slug": "gifgrep", "displayName": "GifGrep", "summary": "…", "version": "1.2.3", "updatedAt": 1730000000000 }] }
|
||||
```
|
||||
|
||||
Notes:
|
||||
|
||||
- Results are returned in relevance order (embedding similarity + exact slug/name token boosts + popularity prior from downloads).
|
||||
|
||||
### `GET /api/v1/skills`
|
||||
|
||||
Query params:
|
||||
@@ -121,6 +131,7 @@ Notes:
|
||||
|
||||
- If neither `version` nor `tag` is provided, the latest version is used.
|
||||
- Soft-deleted versions return `410`.
|
||||
- Download stats are counted as unique identities per hour (`userId` when API token is valid, otherwise IP).
|
||||
|
||||
## Auth endpoints (Bearer token)
|
||||
|
||||
@@ -143,7 +154,78 @@ Publishes a new version.
|
||||
|
||||
### `DELETE /api/v1/skills/{slug}` / `POST /api/v1/skills/{slug}/undelete`
|
||||
|
||||
Soft-delete / restore a skill (owner/admin only).
|
||||
Soft-delete / restore a skill (moderator/admin only).
|
||||
|
||||
### `POST /api/v1/users/ban`
|
||||
|
||||
Ban a user and hard-delete owned skills (moderator/admin only).
|
||||
|
||||
Body:
|
||||
|
||||
```json
|
||||
{ "handle": "user_handle", "reason": "optional ban reason" }
|
||||
```
|
||||
|
||||
or
|
||||
|
||||
```json
|
||||
{ "userId": "users_...", "reason": "optional ban reason" }
|
||||
```
|
||||
|
||||
Response:
|
||||
|
||||
```json
|
||||
{ "ok": true, "alreadyBanned": false, "deletedSkills": 3 }
|
||||
```
|
||||
|
||||
### `POST /api/v1/users/role`
|
||||
|
||||
Change a user role (admin only).
|
||||
|
||||
Body:
|
||||
|
||||
```json
|
||||
{ "handle": "user_handle", "role": "moderator" }
|
||||
```
|
||||
|
||||
or
|
||||
|
||||
```json
|
||||
{ "userId": "users_...", "role": "admin" }
|
||||
```
|
||||
|
||||
Response:
|
||||
|
||||
```json
|
||||
{ "ok": true, "role": "moderator" }
|
||||
```
|
||||
|
||||
### `GET /api/v1/users`
|
||||
|
||||
List or search users (admin only).
|
||||
|
||||
Query params:
|
||||
|
||||
- `q` (optional): search query
|
||||
- `query` (optional): alias for `q`
|
||||
- `limit` (optional): max results (default 20, max 200)
|
||||
|
||||
Response:
|
||||
|
||||
```json
|
||||
{
|
||||
"items": [
|
||||
{
|
||||
"userId": "users_...",
|
||||
"handle": "user_handle",
|
||||
"displayName": "User",
|
||||
"name": "User",
|
||||
"role": "moderator"
|
||||
}
|
||||
],
|
||||
"total": 1
|
||||
}
|
||||
```
|
||||
|
||||
### `POST /api/v1/stars/{slug}` / `DELETE /api/v1/stars/{slug}`
|
||||
|
||||
|
||||
+1
-1
@@ -20,7 +20,7 @@ Example (starter):
|
||||
|
||||
```json
|
||||
{
|
||||
"name": "OpenClaw",
|
||||
"name": "ClawHub",
|
||||
"logo": "public/logo.svg",
|
||||
"navigation": [
|
||||
{ "group": "Start", "pages": ["docs/README", "docs/quickstart"] },
|
||||
|
||||
@@ -0,0 +1,77 @@
|
||||
---
|
||||
summary: 'Security + moderation controls (reports, bans, upload gating).'
|
||||
read_when:
|
||||
- Working on moderation or abuse controls
|
||||
- Reviewing upload restrictions
|
||||
- Troubleshooting hidden/removed skills
|
||||
---
|
||||
|
||||
# Security + Moderation
|
||||
|
||||
## Roles + permissions
|
||||
|
||||
- user: upload skills/souls (subject to GitHub age gate), report skills.
|
||||
- moderator: hide/restore skills, view hidden skills, unhide, soft-delete, ban users (except admins).
|
||||
- admin: all moderator actions + hard delete skills, change owners, change roles.
|
||||
|
||||
## Reporting + auto-hide
|
||||
|
||||
- Reports are unique per user + skill.
|
||||
- Report reason required (trimmed, max 500 chars). Abuse of reporting may result in account bans.
|
||||
- Per-user cap: 20 **active** reports.
|
||||
- Active = skill exists, not soft-deleted, not `moderationStatus = removed`,
|
||||
and the owner is not banned.
|
||||
- Auto-hide: when unique reports exceed 3 (4th report), the skill is:
|
||||
- soft-deleted (`softDeletedAt`)
|
||||
- `moderationStatus = hidden`
|
||||
- `moderationReason = auto.reports`
|
||||
- embeddings visibility set to `deleted`
|
||||
- audit log entry: `skill.auto_hide`
|
||||
- Public queries hide non-active moderation statuses; staff can still access via
|
||||
staff-only queries and unhide/restore/delete/ban.
|
||||
- Skills directory supports an optional "Hide suspicious" filter to exclude
|
||||
active-but-flagged (`flagged.suspicious`) entries from browse/search results.
|
||||
|
||||
## Bans
|
||||
|
||||
- Banning a user:
|
||||
- hard-deletes all owned skills
|
||||
- revokes API tokens
|
||||
- sets `deletedAt` on the user
|
||||
- Admins can manually unban (`deletedAt` + `banReason` cleared); revoked API tokens
|
||||
stay revoked and should be recreated by the user.
|
||||
- Optional ban reason is stored in `users.banReason` and audit logs.
|
||||
- Moderators cannot ban admins; nobody can ban themselves.
|
||||
- Report counters effectively reset because deleted/banned skills are no longer
|
||||
considered active in the per-user report cap.
|
||||
|
||||
## User account deletion
|
||||
|
||||
- User-initiated deletion is irreversible.
|
||||
- Deletion flow:
|
||||
- sets `deactivatedAt` + `purgedAt`
|
||||
- revokes API tokens
|
||||
- clears profile/contact fields
|
||||
- clears telemetry
|
||||
- Deleted accounts cannot be restored by logging in again.
|
||||
- Published skills remain public.
|
||||
|
||||
## Upload gate (GitHub account age)
|
||||
|
||||
- Skill + soul publish actions require GitHub account age ≥ 7 days.
|
||||
- Lookup uses GitHub `created_at` fetched by the immutable GitHub numeric ID (`providerAccountId`)
|
||||
and caches on the user:
|
||||
- `githubCreatedAt` (source of truth)
|
||||
- `githubFetchedAt` (fetch timestamp; set when `githubCreatedAt` is populated)
|
||||
- Gate applies to web uploads, CLI publish, and GitHub import.
|
||||
- If GitHub responds `403` or `429`, publish fails with:
|
||||
- `GitHub API rate limit exceeded — please try again in a few minutes`
|
||||
- To reduce rate-limit failures, set `GITHUB_TOKEN` in Convex env for authenticated
|
||||
GitHub API requests.
|
||||
|
||||
## Empty-skill cleanup (backfill)
|
||||
|
||||
- Cleanup uses quality heuristics plus trust tier to identify very thin/templated
|
||||
skills.
|
||||
- Word counting is language-aware (`Intl.Segmenter` with fallback), reducing
|
||||
false positives for non-space-separated languages.
|
||||
@@ -35,6 +35,99 @@ Workdir install state (written by the CLI):
|
||||
- The server extracts metadata from frontmatter during publish.
|
||||
- `description` is used as the skill summary in the UI/search.
|
||||
|
||||
## Frontmatter metadata
|
||||
|
||||
Skill metadata is declared in the YAML frontmatter at the top of your `SKILL.md`. This tells the registry (and security analysis) what your skill needs to run.
|
||||
|
||||
### Basic frontmatter
|
||||
|
||||
```yaml
|
||||
---
|
||||
name: my-skill
|
||||
description: Short summary of what this skill does.
|
||||
version: 1.0.0
|
||||
---
|
||||
```
|
||||
|
||||
### Runtime metadata (`metadata.openclaw`)
|
||||
|
||||
Declare your skill's runtime requirements under `metadata.openclaw` (aliases: `metadata.clawdbot`, `metadata.clawdis`).
|
||||
|
||||
```yaml
|
||||
---
|
||||
name: my-skill
|
||||
description: Manage tasks via the Todoist API.
|
||||
metadata:
|
||||
openclaw:
|
||||
requires:
|
||||
env:
|
||||
- TODOIST_API_KEY
|
||||
bins:
|
||||
- curl
|
||||
primaryEnv: TODOIST_API_KEY
|
||||
---
|
||||
```
|
||||
|
||||
### Full field reference
|
||||
|
||||
| Field | Type | Description |
|
||||
|-------|------|-------------|
|
||||
| `requires.env` | `string[]` | Environment variables your skill expects. |
|
||||
| `requires.bins` | `string[]` | CLI binaries that must all be installed. |
|
||||
| `requires.anyBins` | `string[]` | CLI binaries where at least one must exist. |
|
||||
| `requires.config` | `string[]` | Config file paths your skill reads. |
|
||||
| `primaryEnv` | `string` | The main credential env var for your skill. |
|
||||
| `always` | `boolean` | If `true`, skill is always active (no explicit install needed). |
|
||||
| `skillKey` | `string` | Override the skill's invocation key. |
|
||||
| `emoji` | `string` | Display emoji for the skill. |
|
||||
| `homepage` | `string` | URL to the skill's homepage or docs. |
|
||||
| `os` | `string[]` | OS restrictions (e.g. `["macos"]`, `["linux"]`). |
|
||||
| `install` | `array` | Install specs for dependencies (see below). |
|
||||
| `nix` | `object` | Nix plugin spec (see README). |
|
||||
| `config` | `object` | Clawdbot config spec (see README). |
|
||||
|
||||
### Install specs
|
||||
|
||||
If your skill needs dependencies installed, declare them in the `install` array:
|
||||
|
||||
```yaml
|
||||
metadata:
|
||||
openclaw:
|
||||
install:
|
||||
- kind: brew
|
||||
formula: jq
|
||||
bins: [jq]
|
||||
- kind: node
|
||||
package: typescript
|
||||
bins: [tsc]
|
||||
```
|
||||
|
||||
Supported install kinds: `brew`, `node`, `go`, `uv`.
|
||||
|
||||
### Why this matters
|
||||
|
||||
ClawHub's security analysis checks that what your skill declares matches what it actually does. If your code references `TODOIST_API_KEY` but your frontmatter doesn't declare it under `requires.env`, the analysis will flag a metadata mismatch. Keeping declarations accurate helps your skill pass review and helps users understand what they're installing.
|
||||
|
||||
### Example: complete frontmatter
|
||||
|
||||
```yaml
|
||||
---
|
||||
name: todoist-cli
|
||||
description: Manage Todoist tasks, projects, and labels from the command line.
|
||||
version: 1.2.0
|
||||
metadata:
|
||||
openclaw:
|
||||
requires:
|
||||
env:
|
||||
- TODOIST_API_KEY
|
||||
bins:
|
||||
- curl
|
||||
primaryEnv: TODOIST_API_KEY
|
||||
emoji: "\u2705"
|
||||
homepage: https://github.com/example/todoist-cli
|
||||
---
|
||||
```
|
||||
|
||||
## Allowed files
|
||||
|
||||
Only “text-based” files are accepted by publish.
|
||||
|
||||
+8
-6
@@ -1,12 +1,12 @@
|
||||
---
|
||||
summary: "OpenClaw spec: skills registry, versioning, vector search, moderation"
|
||||
summary: "ClawHub spec: skills registry, versioning, vector search, moderation"
|
||||
read_when:
|
||||
- Bootstrapping OpenClaw
|
||||
- Bootstrapping ClawHub
|
||||
- Implementing schema/auth/search/versioning
|
||||
- Reviewing API and upload/download flows
|
||||
---
|
||||
|
||||
# OpenClaw — product + implementation spec (v1)
|
||||
# ClawHub — product + implementation spec (v1)
|
||||
|
||||
## Goals
|
||||
- onlycrabs.ai mode for sharing `SOUL.md` bundles (host-based entry point).
|
||||
@@ -123,8 +123,9 @@ From SKILL.md frontmatter + AgentSkills + Clawdis extensions:
|
||||
## Auth + roles
|
||||
- Convex Auth with GitHub OAuth App.
|
||||
- Default role `user`; bootstrap `steipete` to `admin` on first login.
|
||||
- Management console: moderators can hide/restore skills + mark duplicates; admins can change owners, approve badges, and hard-delete.
|
||||
- Management console: moderators can hide/restore skills + mark duplicates + ban users; admins can change owners, approve badges, hard-delete skills, and ban users (deletes owned skills).
|
||||
- Role changes are admin-only and audited.
|
||||
- Reporting: any user can report skills; per-user cap 20 active reports; skills auto-hide after >3 unique reports (mods can review/unhide/delete/ban).
|
||||
|
||||
## Upload flow (50MB per version)
|
||||
1) Client requests upload session.
|
||||
@@ -135,9 +136,10 @@ From SKILL.md frontmatter + AgentSkills + Clawdis extensions:
|
||||
- file extensions/text content
|
||||
- SKILL.md exists and frontmatter parseable
|
||||
- version uniqueness
|
||||
- GitHub account age ≥ 7 days
|
||||
5) Server stores files + metadata, sets `latest` tag, updates stats.
|
||||
|
||||
Soul upload flow: same as skills, but only `SOUL.md` is allowed in the bundle.
|
||||
Soul upload flow: same as skills (including GitHub account age checks), but only `SOUL.md` is allowed.
|
||||
Seed data lives in `convex/seed.ts` for local dev.
|
||||
|
||||
## Versioning + tags
|
||||
@@ -160,7 +162,7 @@ Seed data lives in `convex/seed.ts` for local dev.
|
||||
- Home: search + filters + trending/featured + “Highlighted” badge.
|
||||
- Skill detail: README render, files list, version history, tags, stats, badges.
|
||||
- Upload/edit: file picker + version + tag + changelog.
|
||||
- Account settings: name + delete account (soft delete).
|
||||
- Account settings: name + delete account (permanent, non-recoverable; published skills stay public).
|
||||
- Admin: user role management + badge approvals + audit log.
|
||||
|
||||
## Testing + quality
|
||||
|
||||
+2
-2
@@ -7,7 +7,7 @@ read_when:
|
||||
|
||||
# Telemetry
|
||||
|
||||
OpenClaw uses **minimal telemetry** to compute **install counts** (what’s actually in use) and to power better sorting/filtering.
|
||||
ClawHub uses **minimal telemetry** to compute **install counts** (what’s actually in use) and to power better sorting/filtering.
|
||||
This is based on the CLI `clawhub sync` command.
|
||||
|
||||
## When telemetry is collected
|
||||
@@ -70,7 +70,7 @@ This is evaluated lazily (on the next telemetry report) to avoid background jobs
|
||||
|
||||
## Transparency + user controls
|
||||
|
||||
OpenClaw provides a private “Installed” tab on your own profile:
|
||||
ClawHub provides a private “Installed” tab on your own profile:
|
||||
|
||||
- Shows the exact roots + installed skills we store.
|
||||
- Includes a **JSON export** view.
|
||||
|
||||
@@ -23,6 +23,12 @@ read_when:
|
||||
- Set `OPENAI_API_KEY` in the Convex environment (not only locally).
|
||||
- Re-run `bunx convex dev` / `bunx convex deploy` after setting env.
|
||||
|
||||
## `publish` fails with `GitHub API rate limit exceeded`
|
||||
|
||||
- This is the GitHub account-age gate lookup hitting unauthenticated limits.
|
||||
- Set `GITHUB_TOKEN` in Convex environment to use authenticated GitHub API limits.
|
||||
- Retry publish after a short wait if the limit was already exhausted.
|
||||
|
||||
## `sync` says “No skills found”
|
||||
|
||||
- `sync` looks for folders containing `SKILL.md` (or `skill.md`).
|
||||
|
||||
+2
-2
@@ -6,7 +6,7 @@ read_when:
|
||||
|
||||
# Webhooks (Discord)
|
||||
|
||||
OpenClaw can post Discord embeds when skills are published or highlighted.
|
||||
ClawHub can post Discord embeds when skills are published or highlighted.
|
||||
|
||||
## Setup
|
||||
|
||||
@@ -44,7 +44,7 @@ Discord receives a JSON payload with a single embed:
|
||||
{ "name": "Owner", "value": "@owner", "inline": true },
|
||||
{ "name": "Tags", "value": "latest, discord", "inline": false }
|
||||
],
|
||||
"footer": { "text": "OpenClaw" }
|
||||
"footer": { "text": "ClawHub" }
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
@@ -20,7 +20,6 @@ const REQUEST_TIMEOUT_MS = 15_000
|
||||
try {
|
||||
setGlobalDispatcher(
|
||||
new Agent({
|
||||
allowH2: true,
|
||||
connect: { timeout: REQUEST_TIMEOUT_MS },
|
||||
}),
|
||||
)
|
||||
@@ -61,7 +60,7 @@ async function makeTempConfig(registry: string, token: string | null) {
|
||||
|
||||
async function fetchWithTimeout(input: RequestInfo | URL, init?: RequestInit) {
|
||||
const controller = new AbortController()
|
||||
const timeout = setTimeout(() => controller.abort('Timeout'), REQUEST_TIMEOUT_MS)
|
||||
const timeout = setTimeout(() => controller.abort(new Error('Timeout')), REQUEST_TIMEOUT_MS)
|
||||
try {
|
||||
return await fetch(input, { ...init, signal: controller.signal })
|
||||
} finally {
|
||||
@@ -505,4 +504,49 @@ describe('clawhub e2e', () => {
|
||||
await rm(cfg.dir, { recursive: true, force: true })
|
||||
}
|
||||
}, 180_000)
|
||||
|
||||
it('delete returns proper error for non-existent skill', async () => {
|
||||
const registry = process.env.CLAWDHUB_REGISTRY?.trim() || 'https://clawdhub.com'
|
||||
const site = process.env.CLAWDHUB_SITE?.trim() || 'https://clawdhub.com'
|
||||
const token = mustGetToken() ?? (await readGlobalConfig())?.token ?? null
|
||||
if (!token) {
|
||||
throw new Error('Missing token. Set CLAWDHUB_E2E_TOKEN or run: bun clawdhub auth login')
|
||||
}
|
||||
|
||||
const cfg = await makeTempConfig(registry, token)
|
||||
const workdir = await mkdtemp(join(tmpdir(), 'clawdhub-e2e-delete-'))
|
||||
const nonExistentSlug = `non-existent-skill-${Date.now()}`
|
||||
|
||||
try {
|
||||
const del = spawnSync(
|
||||
'bun',
|
||||
[
|
||||
'clawdhub',
|
||||
'delete',
|
||||
nonExistentSlug,
|
||||
'--yes',
|
||||
'--site',
|
||||
site,
|
||||
'--registry',
|
||||
registry,
|
||||
'--workdir',
|
||||
workdir,
|
||||
],
|
||||
{
|
||||
cwd: process.cwd(),
|
||||
env: { ...process.env, CLAWDHUB_CONFIG_PATH: cfg.path, CLAWDHUB_DISABLE_TELEMETRY: '1' },
|
||||
encoding: 'utf8',
|
||||
},
|
||||
)
|
||||
// Should fail with non-zero exit code
|
||||
expect(del.status).not.toBe(0)
|
||||
// Error should mention "not found" - not generic "Unauthorized"
|
||||
const output = (del.stdout + del.stderr).toLowerCase()
|
||||
expect(output).toMatch(/not found|404|does not exist/i)
|
||||
expect(output).not.toMatch(/unauthorized/i)
|
||||
} finally {
|
||||
await rm(workdir, { recursive: true, force: true })
|
||||
await rm(cfg.dir, { recursive: true, force: true })
|
||||
}
|
||||
}, 30_000)
|
||||
})
|
||||
|
||||
@@ -43,7 +43,7 @@ test('header menu routes render', async ({ page }) => {
|
||||
|
||||
if (label === 'Search') {
|
||||
await expect(page).toHaveURL(/\/?(\?|$)/)
|
||||
await expect(page.locator('h1', { hasText: 'OpenClaw' })).toBeVisible()
|
||||
await expect(page.locator('h1', { hasText: 'ClawHub' })).toBeVisible()
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
+37
-37
@@ -1,28 +1,28 @@
|
||||
{
|
||||
"name": "clawhub",
|
||||
"private": true,
|
||||
"type": "module",
|
||||
"workspaces": [
|
||||
"packages/*"
|
||||
],
|
||||
"type": "module",
|
||||
"scripts": {
|
||||
"preinstall": "bunx only-allow bun",
|
||||
"dev": "bun --bun vite dev --port 3000",
|
||||
"build": "bun --bun vite build",
|
||||
"preview": "bun --bun vite preview",
|
||||
"docs:list": "bun scripts/docs-list.ts",
|
||||
"check:peers": "bun scripts/check-peer-deps.ts",
|
||||
"convex:deploy": "bunx convex deploy --typecheck=disable --yes",
|
||||
"coverage": "vitest run --coverage",
|
||||
"dev": "bun --bun vite dev --port 3000",
|
||||
"docs:list": "bun scripts/docs-list.ts",
|
||||
"format": "oxfmt --write",
|
||||
"lint": "bun run lint:oxlint",
|
||||
"lint:fix": "oxlint --type-aware --tsconfig ./tsconfig.oxlint.json ./src ./convex ./packages/clawdhub/src ./packages/schema/src --fix && bun run format",
|
||||
"lint:oxlint": "oxlint --type-aware --tsconfig ./tsconfig.oxlint.json ./src ./convex ./packages/clawdhub/src ./packages/schema/src",
|
||||
"preinstall": "bunx only-allow bun",
|
||||
"preview": "bun --bun vite preview",
|
||||
"test": "vitest run",
|
||||
"test:watch": "vitest",
|
||||
"test:e2e": "vitest run -c vitest.e2e.config.ts",
|
||||
"test:e2e:local": "bash scripts/run-playwright-local.sh",
|
||||
"test:pw": "playwright test",
|
||||
"coverage": "vitest run --coverage",
|
||||
"convex:deploy": "bunx convex deploy --typecheck=disable --yes",
|
||||
"lint": "bun run lint:biome && bun run lint:oxlint",
|
||||
"lint:biome": "biome check .",
|
||||
"lint:oxlint": "oxlint --type-aware --tsconfig ./tsconfig.oxlint.json ./src ./convex ./packages/clawdhub/src ./packages/schema/src",
|
||||
"format": "biome format --write ."
|
||||
"test:watch": "vitest"
|
||||
},
|
||||
"dependencies": {
|
||||
"@auth/core": "^0.37.4",
|
||||
@@ -35,49 +35,49 @@
|
||||
"@radix-ui/react-toggle-group": "^1.1.11",
|
||||
"@resvg/resvg-wasm": "^2.6.2",
|
||||
"@tailwindcss/vite": "^4.1.18",
|
||||
"@tanstack/react-devtools": "^0.9.2",
|
||||
"@tanstack/react-router": "^1.151.6",
|
||||
"@tanstack/react-router-devtools": "^1.151.6",
|
||||
"@tanstack/react-start": "^1.152.0",
|
||||
"@tanstack/router-plugin": "^1.151.6",
|
||||
"@tanstack/react-devtools": "^0.9.4",
|
||||
"@tanstack/react-router": "^1.157.18",
|
||||
"@tanstack/react-router-devtools": "^1.157.18",
|
||||
"@tanstack/react-start": "^1.157.18",
|
||||
"@tanstack/router-plugin": "^1.157.18",
|
||||
"@vercel/analytics": "^1.6.1",
|
||||
"clawhub-schema": "workspace:*",
|
||||
"clsx": "^2.1.1",
|
||||
"convex": "^1.31.6",
|
||||
"convex-helpers": "^0.1.111",
|
||||
"convex": "^1.31.7",
|
||||
"fflate": "^0.8.2",
|
||||
"h3": "2.0.1-rc.8",
|
||||
"lucide-react": "^0.562.0",
|
||||
"h3": "2.0.1-rc.11",
|
||||
"lucide-react": "^0.563.0",
|
||||
"monaco-editor": "^0.55.1",
|
||||
"nitro": "^3.0.1-alpha.1",
|
||||
"react": "^19.2.3",
|
||||
"react-dom": "^19.2.3",
|
||||
"nitro": "^3.0.1-alpha.2",
|
||||
"react": "^19.2.4",
|
||||
"react-dom": "^19.2.4",
|
||||
"react-markdown": "^10.1.0",
|
||||
"remark-gfm": "^4.0.1",
|
||||
"semver": "^7.7.3",
|
||||
"tailwind-merge": "^3.4.0",
|
||||
"tailwindcss": "^4.1.18",
|
||||
"vite-tsconfig-paths": "^6.0.4",
|
||||
"vite-tsconfig-paths": "^6.0.5",
|
||||
"yaml": "^2.8.2"
|
||||
},
|
||||
"devDependencies": {
|
||||
"@biomejs/biome": "^2.3.11",
|
||||
"@playwright/test": "^1.57.0",
|
||||
"@tanstack/devtools-vite": "^0.4.1",
|
||||
"@playwright/test": "^1.58.1",
|
||||
"@tanstack/devtools-vite": "^0.5.0",
|
||||
"@testing-library/dom": "^10.4.1",
|
||||
"@testing-library/react": "^16.3.1",
|
||||
"@types/node": "^25.0.9",
|
||||
"@types/react": "^19.2.8",
|
||||
"@testing-library/react": "^16.3.2",
|
||||
"@types/node": "^25.2.0",
|
||||
"@types/react": "^19.2.10",
|
||||
"@types/react-dom": "^19.2.3",
|
||||
"@types/semver": "^7.7.1",
|
||||
"@vitejs/plugin-react": "^5.1.2",
|
||||
"@vitest/coverage-v8": "^4.0.17",
|
||||
"jsdom": "^27.4.0",
|
||||
"only-allow": "^1.2.1",
|
||||
"oxlint": "^1.39.0",
|
||||
"oxlint-tsgolint": "^0.11.1",
|
||||
"@vitest/coverage-v8": "^4.0.18",
|
||||
"jsdom": "^28.0.0",
|
||||
"only-allow": "^1.2.2",
|
||||
"oxfmt": "0.32.0",
|
||||
"oxlint": "^1.42.0",
|
||||
"oxlint-tsgolint": "^0.11.4",
|
||||
"typescript": "^5.9.3",
|
||||
"undici": "^7.19.2",
|
||||
"vite": "^7.3.1",
|
||||
"vitest": "^4.0.17"
|
||||
"vitest": "^4.0.18"
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
# `clawhub`
|
||||
|
||||
OpenClaw CLI — install, update, search, and publish agent skills as folders.
|
||||
ClawHub CLI — install, update, search, and publish agent skills as folders.
|
||||
|
||||
## Install
|
||||
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
{
|
||||
"name": "clawhub",
|
||||
"version": "0.4.0",
|
||||
"description": "OpenClaw CLI \\u2014 install, update, search, and publish agent skills.",
|
||||
"version": "0.6.1",
|
||||
"description": "ClawHub CLI \\u2014 install, update, search, and publish agent skills.",
|
||||
"license": "MIT",
|
||||
"type": "module",
|
||||
"bin": {
|
||||
|
||||
@@ -60,7 +60,7 @@ describe('browserAuth', () => {
|
||||
const response = await fetch(server.redirectUri)
|
||||
expect(response.status).toBe(200)
|
||||
const text = await response.text()
|
||||
expect(text).toContain('OpenClaw CLI Login')
|
||||
expect(text).toContain('ClawHub CLI Login')
|
||||
server.close()
|
||||
})
|
||||
|
||||
|
||||
@@ -127,7 +127,7 @@ const CALLBACK_HTML = `<!doctype html>
|
||||
<html lang="en">
|
||||
<meta charset="utf-8" />
|
||||
<meta name="viewport" content="width=device-width, initial-scale=1" />
|
||||
<title>OpenClaw CLI Login</title>
|
||||
<title>ClawHub CLI Login</title>
|
||||
<style>
|
||||
:root { color-scheme: light dark; }
|
||||
body { font-family: ui-sans-serif, system-ui, -apple-system, Segoe UI, sans-serif; padding: 24px; }
|
||||
|
||||
@@ -5,7 +5,14 @@ import { Command } from 'commander'
|
||||
import { getCliBuildLabel, getCliVersion } from './cli/buildInfo.js'
|
||||
import { resolveClawdbotDefaultWorkspace } from './cli/clawdbotConfig.js'
|
||||
import { cmdLoginFlow, cmdLogout, cmdWhoami } from './cli/commands/auth.js'
|
||||
import { cmdDeleteSkill, cmdUndeleteSkill } from './cli/commands/delete.js'
|
||||
import {
|
||||
cmdDeleteSkill,
|
||||
cmdHideSkill,
|
||||
cmdUndeleteSkill,
|
||||
cmdUnhideSkill,
|
||||
} from './cli/commands/delete.js'
|
||||
import { cmdInspect } from './cli/commands/inspect.js'
|
||||
import { cmdBanUser, cmdSetRole } from './cli/commands/moderation.js'
|
||||
import { cmdPublish } from './cli/commands/publish.js'
|
||||
import { cmdExplore, cmdInstall, cmdList, cmdSearch, cmdUpdate } from './cli/commands/skills.js'
|
||||
import { cmdStarSkill } from './cli/commands/star.js'
|
||||
@@ -20,7 +27,7 @@ import { readGlobalConfig } from './config.js'
|
||||
const program = new Command()
|
||||
.name('clawhub')
|
||||
.description(
|
||||
`${styleTitle(`OpenClaw CLI ${getCliBuildLabel()}`)}\n${styleEnvBlock(
|
||||
`${styleTitle(`ClawHub CLI ${getCliBuildLabel()}`)}\n${styleEnvBlock(
|
||||
'install, update, search, and publish agent skills.',
|
||||
)}`,
|
||||
)
|
||||
@@ -221,6 +228,22 @@ program
|
||||
await cmdExplore(opts, { limit, sort: options.sort, json: options.json })
|
||||
})
|
||||
|
||||
program
|
||||
.command('inspect')
|
||||
.description('Fetch skill metadata and files without installing')
|
||||
.argument('<slug>', 'Skill slug')
|
||||
.option('--version <version>', 'Version to inspect')
|
||||
.option('--tag <tag>', 'Tag to inspect (default: latest)')
|
||||
.option('--versions', 'List version history (first page)')
|
||||
.option('--limit <n>', 'Max versions to list (1-200)', (value) => Number.parseInt(value, 10))
|
||||
.option('--files', 'List files for the selected version')
|
||||
.option('--file <path>', 'Fetch raw file content (text <= 200KB)')
|
||||
.option('--json', 'Output JSON')
|
||||
.action(async (slug, options) => {
|
||||
const opts = await resolveGlobalOpts()
|
||||
await cmdInspect(opts, slug, options)
|
||||
})
|
||||
|
||||
program
|
||||
.command('publish')
|
||||
.description('Publish skill from folder')
|
||||
@@ -238,7 +261,7 @@ program
|
||||
|
||||
program
|
||||
.command('delete')
|
||||
.description('Soft-delete a skill (owner/admin only)')
|
||||
.description('Soft-delete a skill (moderator/admin only)')
|
||||
.argument('<slug>', 'Skill slug')
|
||||
.option('--yes', 'Skip confirmation')
|
||||
.action(async (slug, options) => {
|
||||
@@ -246,9 +269,19 @@ program
|
||||
await cmdDeleteSkill(opts, slug, options, isInputAllowed())
|
||||
})
|
||||
|
||||
program
|
||||
.command('hide')
|
||||
.description('Hide a skill (moderator/admin only)')
|
||||
.argument('<slug>', 'Skill slug')
|
||||
.option('--yes', 'Skip confirmation')
|
||||
.action(async (slug, options) => {
|
||||
const opts = await resolveGlobalOpts()
|
||||
await cmdHideSkill(opts, slug, options, isInputAllowed())
|
||||
})
|
||||
|
||||
program
|
||||
.command('undelete')
|
||||
.description('Restore a soft-deleted skill (owner/admin only)')
|
||||
.description('Restore a hidden skill (moderator/admin only)')
|
||||
.argument('<slug>', 'Skill slug')
|
||||
.option('--yes', 'Skip confirmation')
|
||||
.action(async (slug, options) => {
|
||||
@@ -256,6 +289,42 @@ program
|
||||
await cmdUndeleteSkill(opts, slug, options, isInputAllowed())
|
||||
})
|
||||
|
||||
program
|
||||
.command('unhide')
|
||||
.description('Unhide a skill (moderator/admin only)')
|
||||
.argument('<slug>', 'Skill slug')
|
||||
.option('--yes', 'Skip confirmation')
|
||||
.action(async (slug, options) => {
|
||||
const opts = await resolveGlobalOpts()
|
||||
await cmdUnhideSkill(opts, slug, options, isInputAllowed())
|
||||
})
|
||||
|
||||
program
|
||||
.command('ban-user')
|
||||
.description('Ban a user and delete owned skills (moderator/admin only)')
|
||||
.argument('<handleOrId>', 'User handle (default) or user id')
|
||||
.option('--id', 'Treat argument as user id')
|
||||
.option('--fuzzy', 'Resolve handle via fuzzy user search (admin only)')
|
||||
.option('--reason <reason>', 'Ban reason (optional)')
|
||||
.option('--yes', 'Skip confirmation')
|
||||
.action(async (handleOrId, options) => {
|
||||
const opts = await resolveGlobalOpts()
|
||||
await cmdBanUser(opts, handleOrId, options, isInputAllowed())
|
||||
})
|
||||
|
||||
program
|
||||
.command('set-role')
|
||||
.description('Change a user role (admin only)')
|
||||
.argument('<handleOrId>', 'User handle (default) or user id')
|
||||
.argument('<role>', 'user | moderator | admin')
|
||||
.option('--id', 'Treat argument as user id')
|
||||
.option('--fuzzy', 'Resolve handle via fuzzy user search (admin only)')
|
||||
.option('--yes', 'Skip confirmation')
|
||||
.action(async (handleOrId, role, options) => {
|
||||
const opts = await resolveGlobalOpts()
|
||||
await cmdSetRole(opts, handleOrId, role, options, isInputAllowed())
|
||||
})
|
||||
|
||||
program
|
||||
.command('star')
|
||||
.description('Add a skill to your highlights')
|
||||
|
||||
@@ -0,0 +1,14 @@
|
||||
import { readGlobalConfig } from '../config.js'
|
||||
import { fail } from './ui.js'
|
||||
|
||||
export async function getOptionalAuthToken(): Promise<string | undefined> {
|
||||
const cfg = await readGlobalConfig()
|
||||
return cfg?.token ?? undefined
|
||||
}
|
||||
|
||||
export async function requireAuthToken(): Promise<string> {
|
||||
const token = await getOptionalAuthToken()
|
||||
if (!token) fail('Not logged in. Run: clawhub login')
|
||||
return token
|
||||
}
|
||||
|
||||
@@ -3,6 +3,7 @@ import { readGlobalConfig, writeGlobalConfig } from '../../config.js'
|
||||
import { discoverRegistryFromSite } from '../../discovery.js'
|
||||
import { apiRequest } from '../../http.js'
|
||||
import { ApiRoutes, ApiV1WhoamiResponseSchema } from '../../schema/index.js'
|
||||
import { requireAuthToken } from '../authToken.js'
|
||||
import { getRegistry } from '../registry.js'
|
||||
import type { GlobalOpts } from '../types.js'
|
||||
import { createSpinner, fail, formatError, openInBrowser, promptHidden } from '../ui.js'
|
||||
@@ -37,7 +38,8 @@ export async function cmdLoginFlow(
|
||||
|
||||
const result = await receiver.waitForResult()
|
||||
const registry = result.registry?.trim() || opts.registry
|
||||
await cmdLogin({ ...opts, registry }, result.token, inputAllowed)
|
||||
const registrySource = result.registry?.trim() ? 'cli' : opts.registrySource
|
||||
await cmdLogin({ ...opts, registry, registrySource }, result.token, inputAllowed)
|
||||
}
|
||||
|
||||
export async function cmdLogin(
|
||||
@@ -47,7 +49,7 @@ export async function cmdLogin(
|
||||
) {
|
||||
if (!tokenFlag && !inputAllowed) fail('Token required (use --token or remove --no-input)')
|
||||
|
||||
const token = tokenFlag || (await promptHidden('OpenClaw token: '))
|
||||
const token = tokenFlag || (await promptHidden('ClawHub token: '))
|
||||
if (!token) fail('Token required')
|
||||
|
||||
const registry = await getRegistry(opts, { cache: true })
|
||||
@@ -77,9 +79,7 @@ export async function cmdLogout(opts: GlobalOpts) {
|
||||
}
|
||||
|
||||
export async function cmdWhoami(opts: GlobalOpts) {
|
||||
const cfg = await readGlobalConfig()
|
||||
const token = cfg?.token
|
||||
if (!token) fail('Not logged in. Run: clawhub login')
|
||||
const token = await requireAuthToken()
|
||||
const registry = await getRegistry(opts, { cache: true })
|
||||
|
||||
const spinner = createSpinner('Checking token')
|
||||
|
||||
@@ -3,8 +3,8 @@
|
||||
import { afterEach, describe, expect, it, vi } from 'vitest'
|
||||
import type { GlobalOpts } from '../types'
|
||||
|
||||
vi.mock('../../config.js', () => ({
|
||||
readGlobalConfig: vi.fn(async () => ({ registry: 'https://clawhub.ai', token: 'tkn' })),
|
||||
vi.mock('../authToken.js', () => ({
|
||||
requireAuthToken: vi.fn(async () => 'tkn'),
|
||||
}))
|
||||
|
||||
vi.mock('../registry.js', () => ({
|
||||
@@ -29,7 +29,7 @@ vi.mock('../ui.js', () => ({
|
||||
promptConfirm: vi.fn(async () => true),
|
||||
}))
|
||||
|
||||
const { cmdDeleteSkill, cmdUndeleteSkill } = await import('./delete')
|
||||
const { cmdDeleteSkill, cmdHideSkill, cmdUndeleteSkill, cmdUnhideSkill } = await import('./delete')
|
||||
|
||||
function makeOpts(): GlobalOpts {
|
||||
return {
|
||||
@@ -49,6 +49,8 @@ describe('delete/undelete', () => {
|
||||
it('requires --yes when input is disabled', async () => {
|
||||
await expect(cmdDeleteSkill(makeOpts(), 'demo', {}, false)).rejects.toThrow(/--yes/i)
|
||||
await expect(cmdUndeleteSkill(makeOpts(), 'demo', {}, false)).rejects.toThrow(/--yes/i)
|
||||
await expect(cmdHideSkill(makeOpts(), 'demo', {}, false)).rejects.toThrow(/--yes/i)
|
||||
await expect(cmdUnhideSkill(makeOpts(), 'demo', {}, false)).rejects.toThrow(/--yes/i)
|
||||
})
|
||||
|
||||
it('calls delete endpoint with --yes', async () => {
|
||||
@@ -70,4 +72,20 @@ describe('delete/undelete', () => {
|
||||
expect.anything(),
|
||||
)
|
||||
})
|
||||
|
||||
it('supports hide/unhide aliases', async () => {
|
||||
mockApiRequest.mockResolvedValue({ ok: true })
|
||||
await cmdHideSkill(makeOpts(), 'demo', { yes: true }, false)
|
||||
await cmdUnhideSkill(makeOpts(), 'demo', { yes: true }, false)
|
||||
expect(mockApiRequest).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({ method: 'DELETE', path: '/api/v1/skills/demo' }),
|
||||
expect.anything(),
|
||||
)
|
||||
expect(mockApiRequest).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({ method: 'POST', path: '/api/v1/skills/demo/undelete' }),
|
||||
expect.anything(),
|
||||
)
|
||||
})
|
||||
})
|
||||
|
||||
@@ -1,15 +1,43 @@
|
||||
import { readGlobalConfig } from '../../config.js'
|
||||
import { apiRequest } from '../../http.js'
|
||||
import { ApiRoutes, ApiV1DeleteResponseSchema, parseArk } from '../../schema/index.js'
|
||||
import { requireAuthToken } from '../authToken.js'
|
||||
import { getRegistry } from '../registry.js'
|
||||
import type { GlobalOpts } from '../types.js'
|
||||
import { createSpinner, fail, formatError, isInteractive, promptConfirm } from '../ui.js'
|
||||
|
||||
async function requireToken() {
|
||||
const cfg = await readGlobalConfig()
|
||||
const token = cfg?.token
|
||||
if (!token) fail('Not logged in. Run: clawhub login')
|
||||
return token
|
||||
type SkillActionLabels = {
|
||||
verb: string
|
||||
progress: string
|
||||
past: string
|
||||
promptSuffix?: string
|
||||
}
|
||||
|
||||
const deleteLabels: SkillActionLabels = {
|
||||
verb: 'Delete',
|
||||
progress: 'Deleting',
|
||||
past: 'Deleted',
|
||||
promptSuffix: 'soft delete, requires moderator/admin',
|
||||
}
|
||||
|
||||
const undeleteLabels: SkillActionLabels = {
|
||||
verb: 'Undelete',
|
||||
progress: 'Undeleting',
|
||||
past: 'Undeleted',
|
||||
promptSuffix: 'requires moderator/admin',
|
||||
}
|
||||
|
||||
const hideLabels: SkillActionLabels = {
|
||||
verb: 'Hide',
|
||||
progress: 'Hiding',
|
||||
past: 'Hidden',
|
||||
promptSuffix: 'requires moderator/admin',
|
||||
}
|
||||
|
||||
const unhideLabels: SkillActionLabels = {
|
||||
verb: 'Unhide',
|
||||
progress: 'Unhiding',
|
||||
past: 'Unhidden',
|
||||
promptSuffix: 'requires moderator/admin',
|
||||
}
|
||||
|
||||
export async function cmdDeleteSkill(
|
||||
@@ -17,6 +45,7 @@ export async function cmdDeleteSkill(
|
||||
slugArg: string,
|
||||
options: { yes?: boolean },
|
||||
inputAllowed: boolean,
|
||||
labels: SkillActionLabels = deleteLabels,
|
||||
) {
|
||||
const slug = slugArg.trim().toLowerCase()
|
||||
if (!slug) fail('Slug required')
|
||||
@@ -24,20 +53,20 @@ export async function cmdDeleteSkill(
|
||||
|
||||
if (!options.yes) {
|
||||
if (!allowPrompt) fail('Pass --yes (no input)')
|
||||
const ok = await promptConfirm(`Delete ${slug}? (soft delete)`)
|
||||
const ok = await promptConfirm(formatPrompt(labels, slug))
|
||||
if (!ok) return
|
||||
}
|
||||
|
||||
const token = await requireToken()
|
||||
const token = await requireAuthToken()
|
||||
const registry = await getRegistry(opts, { cache: true })
|
||||
const spinner = createSpinner(`Deleting ${slug}`)
|
||||
const spinner = createSpinner(`${labels.progress} ${slug}`)
|
||||
try {
|
||||
const result = await apiRequest(
|
||||
registry,
|
||||
{ method: 'DELETE', path: `${ApiRoutes.skills}/${encodeURIComponent(slug)}`, token },
|
||||
ApiV1DeleteResponseSchema,
|
||||
)
|
||||
spinner.succeed(`OK. Deleted ${slug}`)
|
||||
spinner.succeed(`OK. ${labels.past} ${slug}`)
|
||||
return parseArk(ApiV1DeleteResponseSchema, result, 'Delete response')
|
||||
} catch (error) {
|
||||
spinner.fail(formatError(error))
|
||||
@@ -50,6 +79,7 @@ export async function cmdUndeleteSkill(
|
||||
slugArg: string,
|
||||
options: { yes?: boolean },
|
||||
inputAllowed: boolean,
|
||||
labels: SkillActionLabels = undeleteLabels,
|
||||
) {
|
||||
const slug = slugArg.trim().toLowerCase()
|
||||
if (!slug) fail('Slug required')
|
||||
@@ -57,13 +87,13 @@ export async function cmdUndeleteSkill(
|
||||
|
||||
if (!options.yes) {
|
||||
if (!allowPrompt) fail('Pass --yes (no input)')
|
||||
const ok = await promptConfirm(`Undelete ${slug}?`)
|
||||
const ok = await promptConfirm(formatPrompt(labels, slug))
|
||||
if (!ok) return
|
||||
}
|
||||
|
||||
const token = await requireToken()
|
||||
const token = await requireAuthToken()
|
||||
const registry = await getRegistry(opts, { cache: true })
|
||||
const spinner = createSpinner(`Undeleting ${slug}`)
|
||||
const spinner = createSpinner(`${labels.progress} ${slug}`)
|
||||
try {
|
||||
const result = await apiRequest(
|
||||
registry,
|
||||
@@ -74,10 +104,33 @@ export async function cmdUndeleteSkill(
|
||||
},
|
||||
ApiV1DeleteResponseSchema,
|
||||
)
|
||||
spinner.succeed(`OK. Undeleted ${slug}`)
|
||||
spinner.succeed(`OK. ${labels.past} ${slug}`)
|
||||
return parseArk(ApiV1DeleteResponseSchema, result, 'Undelete response')
|
||||
} catch (error) {
|
||||
spinner.fail(formatError(error))
|
||||
throw error
|
||||
}
|
||||
}
|
||||
|
||||
export async function cmdHideSkill(
|
||||
opts: GlobalOpts,
|
||||
slugArg: string,
|
||||
options: { yes?: boolean },
|
||||
inputAllowed: boolean,
|
||||
) {
|
||||
return cmdDeleteSkill(opts, slugArg, options, inputAllowed, hideLabels)
|
||||
}
|
||||
|
||||
export async function cmdUnhideSkill(
|
||||
opts: GlobalOpts,
|
||||
slugArg: string,
|
||||
options: { yes?: boolean },
|
||||
inputAllowed: boolean,
|
||||
) {
|
||||
return cmdUndeleteSkill(opts, slugArg, options, inputAllowed, unhideLabels)
|
||||
}
|
||||
|
||||
function formatPrompt(labels: SkillActionLabels, slug: string) {
|
||||
const suffix = labels.promptSuffix ? ` (${labels.promptSuffix})` : ''
|
||||
return `${labels.verb} ${slug}?${suffix}`
|
||||
}
|
||||
|
||||
@@ -0,0 +1,128 @@
|
||||
/* @vitest-environment node */
|
||||
|
||||
import { afterEach, describe, expect, it, vi } from 'vitest'
|
||||
import { ApiRoutes } from '../../schema/index.js'
|
||||
import type { GlobalOpts } from '../types'
|
||||
|
||||
const mockApiRequest = vi.fn()
|
||||
const mockFetchText = vi.fn()
|
||||
vi.mock('../../http.js', () => ({
|
||||
apiRequest: (...args: unknown[]) => mockApiRequest(...args),
|
||||
fetchText: (...args: unknown[]) => mockFetchText(...args),
|
||||
}))
|
||||
|
||||
const mockGetRegistry = vi.fn(async () => 'https://clawhub.ai')
|
||||
vi.mock('../registry.js', () => ({
|
||||
getRegistry: () => mockGetRegistry(),
|
||||
}))
|
||||
|
||||
const mockGetOptionalAuthToken = vi.fn(async () => undefined as string | undefined)
|
||||
vi.mock('../authToken.js', () => ({
|
||||
getOptionalAuthToken: () => mockGetOptionalAuthToken(),
|
||||
}))
|
||||
|
||||
const mockSpinner = {
|
||||
stop: vi.fn(),
|
||||
fail: vi.fn(),
|
||||
start: vi.fn(),
|
||||
succeed: vi.fn(),
|
||||
isSpinning: false,
|
||||
text: '',
|
||||
}
|
||||
vi.mock('../ui.js', () => ({
|
||||
createSpinner: vi.fn(() => mockSpinner),
|
||||
fail: (message: string) => {
|
||||
throw new Error(message)
|
||||
},
|
||||
formatError: (error: unknown) => (error instanceof Error ? error.message : String(error)),
|
||||
}))
|
||||
|
||||
const { cmdInspect } = await import('./inspect')
|
||||
|
||||
const mockLog = vi.spyOn(console, 'log').mockImplementation(() => {})
|
||||
const mockWrite = vi.spyOn(process.stdout, 'write').mockImplementation(() => true)
|
||||
|
||||
function makeOpts(): GlobalOpts {
|
||||
return {
|
||||
workdir: '/work',
|
||||
dir: '/work/skills',
|
||||
site: 'https://clawhub.ai',
|
||||
registry: 'https://clawhub.ai',
|
||||
registrySource: 'default',
|
||||
}
|
||||
}
|
||||
|
||||
afterEach(() => {
|
||||
vi.clearAllMocks()
|
||||
mockLog.mockClear()
|
||||
mockWrite.mockClear()
|
||||
})
|
||||
|
||||
describe('cmdInspect', () => {
|
||||
it('fetches latest version files when --files is set', async () => {
|
||||
mockApiRequest
|
||||
.mockResolvedValueOnce({
|
||||
skill: {
|
||||
slug: 'demo',
|
||||
displayName: 'Demo',
|
||||
summary: null,
|
||||
tags: { latest: '1.2.3' },
|
||||
stats: {},
|
||||
createdAt: 1,
|
||||
updatedAt: 2,
|
||||
},
|
||||
latestVersion: { version: '1.2.3', createdAt: 3, changelog: 'init' },
|
||||
owner: null,
|
||||
})
|
||||
.mockResolvedValueOnce({
|
||||
skill: { slug: 'demo', displayName: 'Demo' },
|
||||
version: { version: '1.2.3', createdAt: 3, changelog: 'init', files: [] },
|
||||
})
|
||||
|
||||
await cmdInspect(makeOpts(), 'demo', { files: true })
|
||||
|
||||
const firstArgs = mockApiRequest.mock.calls[0]?.[1]
|
||||
const secondArgs = mockApiRequest.mock.calls[1]?.[1]
|
||||
expect(firstArgs?.path).toBe(`${ApiRoutes.skills}/${encodeURIComponent('demo')}`)
|
||||
expect(secondArgs?.path).toBe(
|
||||
`${ApiRoutes.skills}/${encodeURIComponent('demo')}/versions/${encodeURIComponent('1.2.3')}`,
|
||||
)
|
||||
})
|
||||
|
||||
it('uses tag param when fetching a file', async () => {
|
||||
mockApiRequest
|
||||
.mockResolvedValueOnce({
|
||||
skill: {
|
||||
slug: 'demo',
|
||||
displayName: 'Demo',
|
||||
summary: null,
|
||||
tags: { latest: '2.0.0' },
|
||||
stats: {},
|
||||
createdAt: 1,
|
||||
updatedAt: 2,
|
||||
},
|
||||
latestVersion: { version: '2.0.0', createdAt: 3, changelog: 'init' },
|
||||
owner: null,
|
||||
})
|
||||
.mockResolvedValueOnce({
|
||||
skill: { slug: 'demo', displayName: 'Demo' },
|
||||
version: { version: '2.0.0', createdAt: 3, changelog: 'init', files: [] },
|
||||
})
|
||||
mockFetchText.mockResolvedValue('content')
|
||||
|
||||
await cmdInspect(makeOpts(), 'demo', { file: 'SKILL.md', tag: 'latest' })
|
||||
|
||||
const fetchArgs = mockFetchText.mock.calls[0]?.[1]
|
||||
const url = new URL(String(fetchArgs?.url))
|
||||
expect(url.pathname).toBe('/api/v1/skills/demo/file')
|
||||
expect(url.searchParams.get('path')).toBe('SKILL.md')
|
||||
expect(url.searchParams.get('tag')).toBe('latest')
|
||||
expect(url.searchParams.get('version')).toBeNull()
|
||||
})
|
||||
|
||||
it('rejects when both version and tag are provided', async () => {
|
||||
await expect(
|
||||
cmdInspect(makeOpts(), 'demo', { version: '1.0.0', tag: 'latest' }),
|
||||
).rejects.toThrow('Use either --version or --tag')
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,294 @@
|
||||
import { apiRequest, fetchText } from '../../http.js'
|
||||
import {
|
||||
ApiRoutes,
|
||||
ApiV1SkillResponseSchema,
|
||||
ApiV1SkillVersionListResponseSchema,
|
||||
ApiV1SkillVersionResponseSchema,
|
||||
} from '../../schema/index.js'
|
||||
import { getOptionalAuthToken } from '../authToken.js'
|
||||
import { getRegistry } from '../registry.js'
|
||||
import type { GlobalOpts } from '../types.js'
|
||||
import { createSpinner, fail, formatError } from '../ui.js'
|
||||
|
||||
type InspectOptions = {
|
||||
version?: string
|
||||
tag?: string
|
||||
versions?: boolean
|
||||
limit?: number
|
||||
files?: boolean
|
||||
file?: string
|
||||
json?: boolean
|
||||
}
|
||||
|
||||
type FileEntry = {
|
||||
path: string
|
||||
size: number | null
|
||||
sha256: string | null
|
||||
contentType: string | null
|
||||
}
|
||||
|
||||
export async function cmdInspect(opts: GlobalOpts, slug: string, options: InspectOptions = {}) {
|
||||
const trimmed = slug.trim()
|
||||
if (!trimmed) fail('Slug required')
|
||||
if (options.version && options.tag) fail('Use either --version or --tag')
|
||||
|
||||
const token = await getOptionalAuthToken()
|
||||
const registry = await getRegistry(opts, { cache: true })
|
||||
const spinner = createSpinner('Fetching skill')
|
||||
try {
|
||||
const skillResult = await apiRequest(
|
||||
registry,
|
||||
{ method: 'GET', path: `${ApiRoutes.skills}/${encodeURIComponent(trimmed)}`, token },
|
||||
ApiV1SkillResponseSchema,
|
||||
)
|
||||
|
||||
if (!skillResult.skill) {
|
||||
spinner.fail('Skill not found')
|
||||
return
|
||||
}
|
||||
|
||||
const skill = skillResult.skill
|
||||
const tags = normalizeTags(skill.tags)
|
||||
const latestVersion = skillResult.latestVersion?.version ?? tags.latest ?? null
|
||||
const taggedVersion = options.tag ? (tags[options.tag] ?? null) : null
|
||||
if (options.tag && !taggedVersion) {
|
||||
spinner.fail(`Unknown tag "${options.tag}"`)
|
||||
return
|
||||
}
|
||||
const requestedVersion = options.version ?? taggedVersion ?? null
|
||||
|
||||
let versionResult: { version: unknown; skill: unknown } | null = null
|
||||
if (options.files || options.file || options.version || options.tag) {
|
||||
const targetVersion = requestedVersion ?? latestVersion
|
||||
if (!targetVersion) fail('Could not resolve latest version')
|
||||
spinner.text = `Fetching ${trimmed}@${targetVersion}`
|
||||
versionResult = await apiRequest(
|
||||
registry,
|
||||
{
|
||||
method: 'GET',
|
||||
path: `${ApiRoutes.skills}/${encodeURIComponent(trimmed)}/versions/${encodeURIComponent(
|
||||
targetVersion,
|
||||
)}`,
|
||||
token,
|
||||
},
|
||||
ApiV1SkillVersionResponseSchema,
|
||||
)
|
||||
}
|
||||
|
||||
let versionsList: { items?: unknown[]; nextCursor?: string | null } | null = null
|
||||
if (options.versions) {
|
||||
const limit = clampLimit(options.limit ?? 25, 25)
|
||||
const url = new URL(`${ApiRoutes.skills}/${encodeURIComponent(trimmed)}/versions`, registry)
|
||||
url.searchParams.set('limit', String(limit))
|
||||
spinner.text = `Fetching versions (${limit})`
|
||||
versionsList = await apiRequest(
|
||||
registry,
|
||||
{ method: 'GET', url: url.toString(), token },
|
||||
ApiV1SkillVersionListResponseSchema,
|
||||
)
|
||||
}
|
||||
|
||||
let fileContent: string | null = null
|
||||
if (options.file) {
|
||||
const url = new URL(`${ApiRoutes.skills}/${encodeURIComponent(trimmed)}/file`, registry)
|
||||
url.searchParams.set('path', options.file)
|
||||
if (options.version) {
|
||||
url.searchParams.set('version', options.version)
|
||||
} else if (options.tag) {
|
||||
url.searchParams.set('tag', options.tag)
|
||||
} else if (latestVersion) {
|
||||
url.searchParams.set('version', latestVersion)
|
||||
}
|
||||
spinner.text = `Fetching ${options.file}`
|
||||
fileContent = await fetchText(registry, { url: url.toString(), token })
|
||||
}
|
||||
|
||||
spinner.stop()
|
||||
|
||||
const output = {
|
||||
skill: skillResult.skill,
|
||||
latestVersion: skillResult.latestVersion,
|
||||
owner: skillResult.owner,
|
||||
version: versionResult?.version ?? null,
|
||||
versions: versionsList?.items ?? null,
|
||||
file: options.file ? { path: options.file, content: fileContent } : null,
|
||||
}
|
||||
|
||||
if (options.json) {
|
||||
console.log(JSON.stringify(output, null, 2))
|
||||
return
|
||||
}
|
||||
|
||||
const shouldPrintMeta = !options.file || options.files || options.versions || options.version
|
||||
if (shouldPrintMeta) {
|
||||
printSkillSummary({
|
||||
skill,
|
||||
latestVersion: skillResult.latestVersion,
|
||||
owner: skillResult.owner,
|
||||
})
|
||||
}
|
||||
|
||||
if (shouldPrintMeta && versionResult?.version) {
|
||||
printVersionSummary(versionResult.version)
|
||||
}
|
||||
|
||||
if (versionsList?.items && Array.isArray(versionsList.items)) {
|
||||
if (versionsList.items.length === 0) {
|
||||
console.log('No versions found.')
|
||||
} else {
|
||||
console.log('Versions:')
|
||||
for (const item of versionsList.items) {
|
||||
console.log(formatVersionLine(item))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (versionResult?.version) {
|
||||
const files = normalizeFiles((versionResult.version as { files?: unknown }).files)
|
||||
if (options.files) {
|
||||
if (files.length === 0) {
|
||||
console.log('No files found.')
|
||||
} else {
|
||||
console.log('Files:')
|
||||
for (const file of files) {
|
||||
console.log(formatFileLine(file))
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (options.file && fileContent !== null) {
|
||||
if (shouldPrintMeta) console.log(`\n${options.file}:\n`)
|
||||
process.stdout.write(fileContent)
|
||||
if (!fileContent.endsWith('\n')) process.stdout.write('\n')
|
||||
}
|
||||
} catch (error) {
|
||||
spinner.fail(formatError(error))
|
||||
throw error
|
||||
}
|
||||
}
|
||||
|
||||
function printSkillSummary(result: {
|
||||
skill: {
|
||||
slug: string
|
||||
displayName: string
|
||||
summary?: string | null
|
||||
tags?: unknown
|
||||
stats?: unknown
|
||||
createdAt: number
|
||||
updatedAt: number
|
||||
}
|
||||
latestVersion?: { version: string; createdAt: number; changelog: string } | null
|
||||
owner?: { handle?: string | null; displayName?: string | null; image?: string | null } | null
|
||||
}) {
|
||||
const { skill } = result
|
||||
console.log(`${skill.slug} ${skill.displayName}`)
|
||||
if (skill.summary) console.log(`Summary: ${skill.summary}`)
|
||||
const owner = result.owner?.handle || result.owner?.displayName
|
||||
if (owner) console.log(`Owner: ${owner}`)
|
||||
console.log(`Created: ${formatTimestamp(skill.createdAt)}`)
|
||||
console.log(`Updated: ${formatTimestamp(skill.updatedAt)}`)
|
||||
if (result.latestVersion?.version) {
|
||||
console.log(`Latest: ${result.latestVersion.version}`)
|
||||
}
|
||||
const tags = normalizeTags(skill.tags)
|
||||
const tagEntries = Object.entries(tags)
|
||||
if (tagEntries.length > 0) {
|
||||
console.log(`Tags: ${tagEntries.map(([tag, version]) => `${tag}=${version}`).join(', ')}`)
|
||||
}
|
||||
}
|
||||
|
||||
function printVersionSummary(version: unknown) {
|
||||
if (!version || typeof version !== 'object') return
|
||||
const entry = version as { version?: unknown; createdAt?: unknown; changelog?: unknown }
|
||||
const value = typeof entry.version === 'string' ? entry.version : null
|
||||
if (!value) return
|
||||
console.log(`Selected: ${value}`)
|
||||
if (typeof entry.createdAt === 'number') {
|
||||
console.log(`Selected At: ${formatTimestamp(entry.createdAt)}`)
|
||||
}
|
||||
if (typeof entry.changelog === 'string' && entry.changelog.trim()) {
|
||||
console.log(`Changelog: ${truncate(entry.changelog, 120)}`)
|
||||
}
|
||||
}
|
||||
|
||||
function normalizeTags(tags: unknown): Record<string, string> {
|
||||
if (!tags || typeof tags !== 'object') return {}
|
||||
const entries = Object.entries(tags as Record<string, unknown>)
|
||||
const resolved: Record<string, string> = {}
|
||||
for (const [tag, version] of entries) {
|
||||
if (typeof version === 'string') resolved[tag] = version
|
||||
}
|
||||
return resolved
|
||||
}
|
||||
|
||||
function normalizeFiles(files: unknown): FileEntry[] {
|
||||
if (!Array.isArray(files)) return []
|
||||
return files
|
||||
.map((file) => {
|
||||
if (!file || typeof file !== 'object') return null
|
||||
const entry = file as {
|
||||
path?: unknown
|
||||
size?: unknown
|
||||
sha256?: unknown
|
||||
contentType?: unknown
|
||||
}
|
||||
if (typeof entry.path !== 'string') return null
|
||||
const size = typeof entry.size === 'number' ? entry.size : Number(entry.size)
|
||||
const sha256 = typeof entry.sha256 === 'string' ? entry.sha256 : null
|
||||
const contentType = typeof entry.contentType === 'string' ? entry.contentType : null
|
||||
return {
|
||||
path: entry.path,
|
||||
size: Number.isFinite(size) ? size : null,
|
||||
sha256,
|
||||
contentType,
|
||||
}
|
||||
})
|
||||
.filter((entry): entry is FileEntry => Boolean(entry))
|
||||
}
|
||||
|
||||
function formatVersionLine(item: unknown) {
|
||||
if (!item || typeof item !== 'object') return '-'
|
||||
const entry = item as { version?: unknown; createdAt?: unknown; changelog?: unknown }
|
||||
const version = typeof entry.version === 'string' ? entry.version : '?'
|
||||
const createdAt =
|
||||
typeof entry.createdAt === 'number' ? formatTimestamp(entry.createdAt) : 'unknown'
|
||||
const changelog = typeof entry.changelog === 'string' ? entry.changelog : ''
|
||||
const snippet = changelog ? ` ${truncate(changelog, 80)}` : ''
|
||||
return `${version} ${createdAt}${snippet}`
|
||||
}
|
||||
|
||||
function formatFileLine(file: FileEntry) {
|
||||
const size = file.size === null ? '?' : formatBytes(file.size)
|
||||
const sha = file.sha256 ?? '?'
|
||||
const type = file.contentType ? ` ${file.contentType}` : ''
|
||||
return `${file.path} ${size} ${sha}${type}`
|
||||
}
|
||||
|
||||
function formatTimestamp(timestamp: number) {
|
||||
if (!Number.isFinite(timestamp)) return 'unknown'
|
||||
return new Date(timestamp).toISOString()
|
||||
}
|
||||
|
||||
function formatBytes(bytes: number) {
|
||||
if (!Number.isFinite(bytes)) return '?'
|
||||
const units = ['B', 'KB', 'MB', 'GB']
|
||||
let value = bytes
|
||||
let index = 0
|
||||
while (value >= 1024 && index < units.length - 1) {
|
||||
value /= 1024
|
||||
index += 1
|
||||
}
|
||||
const rounded = value >= 10 ? Math.round(value) : Math.round(value * 10) / 10
|
||||
return `${rounded}${units[index]}`
|
||||
}
|
||||
|
||||
function clampLimit(limit: number, fallback: number) {
|
||||
if (!Number.isFinite(limit)) return fallback
|
||||
return Math.min(Math.max(1, Math.round(limit)), 200)
|
||||
}
|
||||
|
||||
function truncate(str: string, maxLen: number) {
|
||||
if (str.length <= maxLen) return str
|
||||
return `${str.slice(0, maxLen - 3)}...`
|
||||
}
|
||||
@@ -0,0 +1,199 @@
|
||||
/* @vitest-environment node */
|
||||
|
||||
import { afterEach, describe, expect, it, vi } from 'vitest'
|
||||
import type { GlobalOpts } from '../types'
|
||||
|
||||
vi.mock('../authToken.js', () => ({
|
||||
requireAuthToken: vi.fn(async () => 'tkn'),
|
||||
}))
|
||||
|
||||
vi.mock('../registry.js', () => ({
|
||||
getRegistry: vi.fn(async () => 'https://clawhub.ai'),
|
||||
}))
|
||||
|
||||
const mockApiRequest = vi.fn()
|
||||
vi.mock('../../http.js', () => ({
|
||||
apiRequest: (registry: unknown, args: unknown, schema?: unknown) =>
|
||||
mockApiRequest(registry, args, schema),
|
||||
}))
|
||||
|
||||
vi.mock('../ui.js', () => ({
|
||||
createSpinner: vi.fn(() => ({ succeed: vi.fn(), fail: vi.fn() })),
|
||||
fail: (message: string) => {
|
||||
throw new Error(message)
|
||||
},
|
||||
formatError: (error: unknown) => (error instanceof Error ? error.message : String(error)),
|
||||
isInteractive: () => false,
|
||||
promptConfirm: vi.fn(async () => true),
|
||||
}))
|
||||
|
||||
const { cmdBanUser, cmdSetRole } = await import('./moderation')
|
||||
|
||||
function makeOpts(): GlobalOpts {
|
||||
return {
|
||||
workdir: '/work',
|
||||
dir: '/work/skills',
|
||||
site: 'https://clawhub.ai',
|
||||
registry: 'https://clawhub.ai',
|
||||
registrySource: 'default',
|
||||
}
|
||||
}
|
||||
|
||||
afterEach(() => {
|
||||
vi.clearAllMocks()
|
||||
})
|
||||
|
||||
describe('cmdBanUser', () => {
|
||||
it('requires --yes when input is disabled', async () => {
|
||||
await expect(cmdBanUser(makeOpts(), 'demo', {}, false)).rejects.toThrow(/--yes/i)
|
||||
})
|
||||
|
||||
it('posts handle payload', async () => {
|
||||
mockApiRequest.mockResolvedValueOnce({ ok: true, alreadyBanned: false, deletedSkills: 1 })
|
||||
await cmdBanUser(makeOpts(), 'hightower6eu', { yes: true }, false)
|
||||
expect(mockApiRequest).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({
|
||||
method: 'POST',
|
||||
path: '/api/v1/users/ban',
|
||||
body: { handle: 'hightower6eu' },
|
||||
}),
|
||||
expect.anything(),
|
||||
)
|
||||
})
|
||||
|
||||
it('includes reason when provided', async () => {
|
||||
mockApiRequest.mockResolvedValueOnce({ ok: true, alreadyBanned: false, deletedSkills: 0 })
|
||||
await cmdBanUser(
|
||||
makeOpts(),
|
||||
'hightower6eu',
|
||||
{ yes: true, reason: 'malware distribution' },
|
||||
false,
|
||||
)
|
||||
expect(mockApiRequest).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({
|
||||
method: 'POST',
|
||||
path: '/api/v1/users/ban',
|
||||
body: { handle: 'hightower6eu', reason: 'malware distribution' },
|
||||
}),
|
||||
expect.anything(),
|
||||
)
|
||||
})
|
||||
|
||||
it('posts user id payload when --id is set', async () => {
|
||||
mockApiRequest.mockResolvedValueOnce({ ok: true, alreadyBanned: false, deletedSkills: 0 })
|
||||
await cmdBanUser(makeOpts(), 'user_123', { yes: true, id: true }, false)
|
||||
expect(mockApiRequest).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({
|
||||
method: 'POST',
|
||||
path: '/api/v1/users/ban',
|
||||
body: { userId: 'user_123' },
|
||||
}),
|
||||
expect.anything(),
|
||||
)
|
||||
})
|
||||
|
||||
it('resolves user via fuzzy search', async () => {
|
||||
mockApiRequest
|
||||
.mockResolvedValueOnce({
|
||||
items: [
|
||||
{
|
||||
userId: 'users_123',
|
||||
handle: 'moonshine-100rze',
|
||||
displayName: null,
|
||||
name: null,
|
||||
role: 'user',
|
||||
},
|
||||
],
|
||||
total: 1,
|
||||
})
|
||||
.mockResolvedValueOnce({ ok: true, alreadyBanned: false, deletedSkills: 0 })
|
||||
await cmdBanUser(makeOpts(), 'moonshine-100rze', { yes: true, fuzzy: true }, false)
|
||||
expect(mockApiRequest).toHaveBeenNthCalledWith(
|
||||
1,
|
||||
expect.anything(),
|
||||
expect.objectContaining({
|
||||
method: 'GET',
|
||||
path: expect.stringContaining('/api/v1/users?'),
|
||||
}),
|
||||
expect.anything(),
|
||||
)
|
||||
expect(mockApiRequest).toHaveBeenNthCalledWith(
|
||||
2,
|
||||
expect.anything(),
|
||||
expect.objectContaining({
|
||||
method: 'POST',
|
||||
path: '/api/v1/users/ban',
|
||||
body: { userId: 'users_123' },
|
||||
}),
|
||||
expect.anything(),
|
||||
)
|
||||
})
|
||||
|
||||
it('fails fuzzy search with multiple matches when not interactive', async () => {
|
||||
mockApiRequest.mockResolvedValueOnce({
|
||||
items: [
|
||||
{
|
||||
userId: 'users_1',
|
||||
handle: 'moonshine-100rze',
|
||||
displayName: null,
|
||||
name: null,
|
||||
role: null,
|
||||
},
|
||||
{
|
||||
userId: 'users_2',
|
||||
handle: 'moonshine-100rze2',
|
||||
displayName: null,
|
||||
name: null,
|
||||
role: null,
|
||||
},
|
||||
],
|
||||
total: 2,
|
||||
})
|
||||
await expect(
|
||||
cmdBanUser(makeOpts(), 'moonshine', { yes: true, fuzzy: true }, false),
|
||||
).rejects.toThrow(/multiple users matched/i)
|
||||
})
|
||||
})
|
||||
|
||||
describe('cmdSetRole', () => {
|
||||
it('requires --yes when input is disabled', async () => {
|
||||
await expect(cmdSetRole(makeOpts(), 'demo', 'moderator', {}, false)).rejects.toThrow(/--yes/i)
|
||||
})
|
||||
|
||||
it('rejects invalid roles', async () => {
|
||||
await expect(cmdSetRole(makeOpts(), 'demo', 'owner', { yes: true }, false)).rejects.toThrow(
|
||||
/role/i,
|
||||
)
|
||||
})
|
||||
|
||||
it('posts handle payload', async () => {
|
||||
mockApiRequest.mockResolvedValueOnce({ ok: true, role: 'moderator' })
|
||||
await cmdSetRole(makeOpts(), 'hightower6eu', 'moderator', { yes: true }, false)
|
||||
expect(mockApiRequest).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({
|
||||
method: 'POST',
|
||||
path: '/api/v1/users/role',
|
||||
body: { handle: 'hightower6eu', role: 'moderator' },
|
||||
}),
|
||||
expect.anything(),
|
||||
)
|
||||
})
|
||||
|
||||
it('posts user id payload when --id is set', async () => {
|
||||
mockApiRequest.mockResolvedValueOnce({ ok: true, role: 'admin' })
|
||||
await cmdSetRole(makeOpts(), 'user_123', 'admin', { yes: true, id: true }, false)
|
||||
expect(mockApiRequest).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({
|
||||
method: 'POST',
|
||||
path: '/api/v1/users/role',
|
||||
body: { userId: 'user_123', role: 'admin' },
|
||||
}),
|
||||
expect.anything(),
|
||||
)
|
||||
})
|
||||
})
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user