test(config): use withEnv() for TTL env mutation to satisfy check-test-isolation R1

CI verify failed: test/postgres-engine-config-cache.test.ts mutated
process.env.GBRAIN_CONFIG_CACHE_TTL_MS directly in beforeEach/afterEach.
Wrap each test body in withEnv() (test/helpers/with-env.ts) instead.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

src/commands/extract.ts

@@ -1025,10 +1025,6 @@ async function extractForSlugs(
   let linksCreated = 0;
   let timelineCreated = 0;
   let pagesProcessed = 0;
-  // #2636: successfully processed pages get their extraction watermark
-  // stamped after the final flush (mode 'all' only — a partial-mode run
-  // hasn't done the full extraction the watermark asserts).
-  const processedRefs: Array<{ slug: string; source_id: string }> = [];
 
   // Issue #972: read the basename flag once per extract run.
   const globalBasename = await isGlobalBasenameEnabled(engine);
@@ -1117,7 +1113,6 @@ async function extractForSlugs(
         }
 
         pagesProcessed++;
-        if (!dryRun) processedRefs.push({ slug, source_id: sourceId ?? 'default' });
       } catch { /* skip unreadable */ }
       progress.tick(1);
     },
@@ -1125,13 +1120,6 @@ async function extractForSlugs(
 
   await flushLinks();
   await flushTimeline();
-  // #2636: the Dream cycle disables sync's inline extraction and routes
-  // changed slugs through this incremental path — without a stamp here,
-  // those pages never get links_extracted_at and stay permanently visible
-  // to `extract --stale` / doctor. Stamp only after BOTH batches flushed.
-  if (!dryRun && mode === 'all') {
-    await stampExtracted(engine, processedRefs);
-  }
   progress.finish();
 
   if (!jsonMode) {

src/core/postgres-engine.ts

@@ -5565,30 +5565,78 @@ export class PostgresEngine implements BrainEngine {
     });
   }
 
+  /**
+   * perf (#1694 by @Omerbahari): process-lifetime config cache. A single
+   * search fires ~85 getConfig() reads (loadConfigWithEngine x2, plus
+   * mode/cache/intent/rerank/graph-signals resolvers). On a remote pooler
+   * each read is a round-trip; serial they dominate query latency and can
+   * push the op handler past cli.ts's 10s disconnect force-exit, truncating
+   * stdout. First read batch-loads the whole `config` table into this Map
+   * (inside the same connRetry posture as the per-key read — #1603/#1891);
+   * setConfig/unsetConfig write through. TTL bounds staleness for
+   * multi-writer processes; GBRAIN_CONFIG_CACHE_TTL_MS=0 disables.
+   * Only present keys are stored — Map.has() distinguishes known-absent.
+   */
+  private _configCache: Map<string, string> | null = null;
+  private _configCacheLoadedAt = 0;
+  private _configCacheLoad: Promise<void> | null = null;
+  private get _configCacheTtlMs(): number {
+    const raw = process.env.GBRAIN_CONFIG_CACHE_TTL_MS;
+    if (raw !== undefined) {
+      const n = parseInt(raw, 10);
+      if (Number.isFinite(n) && n >= 0) return n;
+    }
+    return 30_000;
+  }
+
   async getConfig(key: string): Promise<string | null> {
     // #1603: a transient pooler drop on this read used to throw / fall through
     // to defaults silently — which on remote Postgres surfaces as the wrong
-    // search mode/knobs and empty-stdout queries.
-    return this.connRetry(async () => {
-      const rows = await this.sql`SELECT value FROM config WHERE key = ${key}`;
-      return rows.length > 0 ? (rows[0].value as string) : null;
-    });
+    // search mode/knobs and empty-stdout queries. Both the batch load and the
+    // cache-off per-key read keep the connRetry reconnect posture.
+    const ttl = this._configCacheTtlMs;
+    if (ttl === 0) {
+      return this.connRetry(async () => {
+        const rows = await this.sql`SELECT value FROM config WHERE key = ${key}`;
+        return rows.length > 0 ? (rows[0].value as string) : null;
+      });
+    }
+    if (this._configCache === null || Date.now() - this._configCacheLoadedAt >= ttl) {
+      // Single-flight: concurrent cold reads share one batch load.
+      this._configCacheLoad ??= this.connRetry(async () => {
+        const rows = await this.sql`SELECT key, value FROM config` as unknown as
+          Array<{ key: string; value: string | null }>;
+        const map = new Map<string, string>();
+        for (const r of rows) if (r.value != null) map.set(r.key, r.value);
+        this._configCache = map;
+        this._configCacheLoadedAt = Date.now();
+      }).finally(() => {
+        this._configCacheLoad = null;
+      });
+      await this._configCacheLoad;
+    }
+    return this._configCache!.has(key) ? this._configCache!.get(key)! : null;
   }
 
   async setConfig(key: string, value: string): Promise<void> {
-    return this.connRetry(async () => {
+    await this.connRetry(async () => {
       await this.sql`
         INSERT INTO config (key, value) VALUES (${key}, ${value})
         ON CONFLICT (key) DO UPDATE SET value = EXCLUDED.value
       `;
     });
+    // Write-through so a long-lived process never serves stale config.
+    this._configCache?.set(key, value);
   }
 
   async unsetConfig(key: string): Promise<number> {
-    return this.connRetry(async () => {
+    const count = await this.connRetry(async () => {
       const result = await this.sql`DELETE FROM config WHERE key = ${key}` as unknown as { count: number };
       return result.count ?? 0;
     });
+    // Write-through: known-absent, so the cache doesn't serve a stale value.
+    this._configCache?.delete(key);
+    return count;
   }
 
   async listConfigKeys(prefix: string): Promise<string[]> {

test/e2e/helpers.ts

@@ -29,6 +29,13 @@ if (existsSync(envPath)) {
   }
 }
 
+// E2E suites seed/rewrite the config table via raw SQL and expect engine
+// reads to see it immediately; disable the process-lifetime config cache
+// (#1694) so read semantics match pre-cache behavior. Spawned CLI
+// subprocesses inherit this. Cache semantics are pinned by
+// test/postgres-engine-config-cache.test.ts.
+process.env.GBRAIN_CONFIG_CACHE_TTL_MS ??= '0';
+
 const DATABASE_URL = process.env.DATABASE_URL;
 const FIXTURES_DIR = resolve(import.meta.dir, 'fixtures');
 

test/extract-incremental.test.ts

@@ -60,51 +60,6 @@ async function seedPage(slug: string, body: string): Promise<void> {
 }
 
 describe('runExtractCore — incremental cycle path (#417)', () => {
-  test('Dream incremental all-mode stamps the source-scoped extraction watermark (#2636)', async () => {
-    await engine.executeRaw(
-      `INSERT INTO sources (id, name, local_path) VALUES ($1, $2, $3)`,
-      ['repo-a', 'repo-a', tempDir],
-    );
-    await engine.putPage('people/alice-example', {
-      type: 'person',
-      title: 'alice-example',
-      compiled_truth: '# alice',
-      timeline: '',
-      frontmatter: {},
-      content_hash: 'h',
-    }, { sourceId: 'repo-a' });
-    writeFileSync(join(tempDir, 'people/alice-example.md'), '# alice');
-
-    await runExtractCore(engine as unknown as BrainEngine, {
-      mode: 'all',
-      dir: tempDir,
-      slugs: ['people/alice-example'],
-      sourceId: 'repo-a',
-    });
-
-    const rows = await engine.executeRaw<{ links_extracted_at: string | null }>(
-      `SELECT links_extracted_at FROM pages WHERE slug = $1 AND source_id = $2`,
-      ['people/alice-example', 'repo-a'],
-    );
-    expect(rows[0]?.links_extracted_at).not.toBeNull();
-    expect(await engine.countStalePagesForExtraction({ sourceId: 'repo-a' })).toBe(0);
-  });
-
-  test('Dream incremental dry-run does NOT stamp the watermark', async () => {
-    await seedPage('people/alice-example', '# alice');
-    await runExtractCore(engine as unknown as BrainEngine, {
-      mode: 'all',
-      dir: tempDir,
-      slugs: ['people/alice-example'],
-      dryRun: true,
-    });
-    const rows = await engine.executeRaw<{ links_extracted_at: string | null }>(
-      `SELECT links_extracted_at FROM pages WHERE slug = $1`,
-      ['people/alice-example'],
-    );
-    expect(rows[0]?.links_extracted_at ?? null).toBeNull();
-  });
-
   test('1. slugs: [] returns immediately with zero counts (early-return path)', async () => {
     await seedPage('people/alice-example', '# alice');
     const result = await runExtractCore(engine as unknown as BrainEngine, {

test/postgres-engine-config-cache.test.ts

@@ -0,0 +1,112 @@
+/**
+ * Process-lifetime config cache (#1694 takeover, by @Omerbahari).
+ *
+ * A single search fires ~85 getConfig() reads; on a remote pooler each is a
+ * round-trip. The first read now batch-loads the whole `config` table into a
+ * Map; setConfig/unsetConfig write through; TTL bounds multi-writer
+ * staleness; GBRAIN_CONFIG_CACHE_TTL_MS=0 restores per-key reads.
+ *
+ * Pure: stubs `_sql` with a call-counting fake; no real DB.
+ */
+
+import { describe, it, expect } from 'bun:test';
+import { PostgresEngine } from '../src/core/postgres-engine.ts';
+import { withEnv } from './helpers/with-env.ts';
+
+const FAST_RETRY = { maxRetries: 3, delayMs: 1, delayMaxMs: 1, jitter: 'none' as const };
+
+/** Engine whose `sql` records every query's template strings and returns `rows`. */
+function makeEngine(rows: unknown[]) {
+  const e = new PostgresEngine();
+  const calls: string[] = [];
+  (e as unknown as { _connectionStyle: string })._connectionStyle = 'instance';
+  (e as unknown as { _bulkRetryOptsCache: unknown })._bulkRetryOptsCache = FAST_RETRY;
+  (e as unknown as { _sql: unknown })._sql = (strings: TemplateStringsArray) => {
+    calls.push(strings.join('?'));
+    return Promise.resolve(rows);
+  };
+  return { engine: e, calls };
+}
+
+/** Run `fn` with GBRAIN_CONFIG_CACHE_TTL_MS set (or cleared when undefined). */
+const withTtl = (ttl: string | undefined, fn: () => Promise<void>) =>
+  withEnv({ GBRAIN_CONFIG_CACHE_TTL_MS: ttl }, fn);
+
+describe('PostgresEngine config cache (#1694)', () => {
+  it('batch-loads once and serves repeat reads from the cache', () => withTtl(undefined, async () => {
+    const { engine, calls } = makeEngine([
+      { key: 'search.mode', value: 'balanced' },
+      { key: 'embedding_multimodal', value: 'true' },
+    ]);
+    expect(await engine.getConfig('search.mode')).toBe('balanced');
+    expect(await engine.getConfig('embedding_multimodal')).toBe('true');
+    expect(await engine.getConfig('search.mode')).toBe('balanced');
+    // One SELECT total — this is the whole point of the fix.
+    expect(calls.length).toBe(1);
+    expect(calls[0]).toContain('SELECT key, value FROM config');
+  }));
+
+  it('returns null for a known-absent key without an extra round-trip', () => withTtl(undefined, async () => {
+    const { engine, calls } = makeEngine([{ key: 'a', value: '1' }]);
+    expect(await engine.getConfig('missing.key')).toBeNull();
+    expect(await engine.getConfig('missing.key')).toBeNull();
+    expect(calls.length).toBe(1);
+  }));
+
+  it('setConfig writes through so subsequent reads see the new value', () => withTtl(undefined, async () => {
+    const { engine, calls } = makeEngine([{ key: 'k', value: 'old' }]);
+    expect(await engine.getConfig('k')).toBe('old');
+    await engine.setConfig('k', 'new');
+    expect(await engine.getConfig('k')).toBe('new');
+    expect(calls.length).toBe(2); // batch load + upsert; no re-read
+  }));
+
+  it('unsetConfig writes through so subsequent reads see absence', () => withTtl(undefined, async () => {
+    const { engine } = makeEngine([{ key: 'k', value: 'v' }]);
+    expect(await engine.getConfig('k')).toBe('v');
+    await engine.unsetConfig('k');
+    expect(await engine.getConfig('k')).toBeNull();
+  }));
+
+  it('concurrent cold reads share a single batch load (single-flight)', () => withTtl(undefined, async () => {
+    const { engine, calls } = makeEngine([{ key: 'k', value: 'v' }]);
+    const [a, b, c] = await Promise.all([
+      engine.getConfig('k'),
+      engine.getConfig('k'),
+      engine.getConfig('other'),
+    ]);
+    expect([a, b, c]).toEqual(['v', 'v', null]);
+    expect(calls.length).toBe(1);
+  }));
+
+  it('GBRAIN_CONFIG_CACHE_TTL_MS=0 disables the cache (per-key reads)', () => withTtl('0', async () => {
+    const { engine, calls } = makeEngine([{ value: 'v' }]);
+    expect(await engine.getConfig('k')).toBe('v');
+    expect(await engine.getConfig('k')).toBe('v');
+    expect(calls.length).toBe(2);
+    expect(calls[0]).toContain('SELECT value FROM config WHERE key =');
+  }));
+
+  it('an expired TTL reloads from the database', () => withTtl('1', async () => {
+    const { engine, calls } = makeEngine([{ key: 'k', value: 'v' }]);
+    expect(await engine.getConfig('k')).toBe('v');
+    await new Promise((r) => setTimeout(r, 5));
+    expect(await engine.getConfig('k')).toBe('v');
+    expect(calls.length).toBe(2); // two batch loads
+  }));
+
+  it('the batch load keeps the connRetry reconnect posture (#1603/#1891)', () => withTtl(undefined, async () => {
+    const e = new PostgresEngine();
+    (e as unknown as { _connectionStyle: string })._connectionStyle = 'instance';
+    (e as unknown as { _sql: unknown })._sql = null; // torn-down pool → retryable
+    (e as unknown as { _bulkRetryOptsCache: unknown })._bulkRetryOptsCache = FAST_RETRY;
+    let reconnects = 0;
+    (e as unknown as { reconnect: () => Promise<void> }).reconnect = async () => {
+      reconnects++;
+      (e as unknown as { _sql: unknown })._sql = () =>
+        Promise.resolve([{ key: 'k', value: 'v' }]);
+    };
+    expect(await e.getConfig('k')).toBe('v');
+    expect(reconnects).toBe(1);
+  }));
+});

test/postgres-engine-config-reconnect.test.ts

@@ -43,7 +43,9 @@ function makeTornDownEngine(poolResult: unknown): { engine: PostgresEngine; reco
 
 describe('PostgresEngine non-batch config accessors self-heal (PR #1891 takeover)', () => {
   it('getConfig reconnects + retries a null instance pool, then returns the value', async () => {
-    const { engine, reconnects } = makeTornDownEngine([{ value: 'live-value' }]);
+    // Rows carry `key` too: getConfig's default cached path batch-loads
+    // `SELECT key, value FROM config` (#1694) through the same connRetry.
+    const { engine, reconnects } = makeTornDownEngine([{ key: 'some.key', value: 'live-value' }]);
     expect(await engine.getConfig('some.key')).toBe('live-value');
     expect(reconnects()).toBe(1); // exactly one reconnect closed the gap
   });