test(migrate): use withEnv() for GBRAIN_HOME mutation (check:test-isolation R1)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

src/commands/apply-migrations.ts

@@ -438,13 +438,6 @@ export async function runApplyMigrations(args: string[]): Promise<void> {
       const result = await m.orchestrator(orchestratorOptsFrom(cli));
       if (result.status === 'failed') {
         console.error(`Migration v${m.version} reported status=failed.`);
-        // Surface each failed phase's detail — the ledger records it, but
-        // the operator needs it on stderr to act (#921).
-        for (const p of result.phases) {
-          if (p.status === 'failed') {
-            console.error(`  phase ${p.name}: ${p.detail ?? '(no detail)'}`);
-          }
-        }
         // Record the attempt as 'partial' (not 'complete') so the cap counts
         // it. Don't let a failed orchestrator look like it never ran.
         try {

src/commands/migrate-engine.ts

@@ -3,7 +3,11 @@
  *
  * Usage:
  *   gbrain migrate --to supabase [--url <connection_string>]
+ *     (--url is persisted to config.json, mode 0600, so the migrated brain
+ *      works without env — #1271)
  *   gbrain migrate --to pglite [--path <db_path>]
+ *     (an explicit --path destination is bootstrapped with its own
+ *      <path>/.gbrain/config.json so GBRAIN_HOME=<path> just works — #1271)
  *   gbrain migrate --to <engine> --force  (overwrite non-empty target)
  */
 
@@ -11,9 +15,9 @@ import { createEngine } from '../core/engine-factory.ts';
 import { loadConfig, saveConfig, toEngineConfig, gbrainPath, effectiveEnvDatabaseUrl, type GBrainConfig } from '../core/config.ts';
 import type { BrainEngine } from '../core/engine.ts';
 import type { EngineConfig } from '../core/types.ts';
-import { writeFileSync, readFileSync, existsSync, unlinkSync } from 'fs';
+import { writeFileSync, readFileSync, existsSync, unlinkSync, mkdirSync, chmodSync } from 'fs';
 import { createHash } from 'crypto';
-import { resolve } from 'path';
+import { resolve, join } from 'path';
 import { createProgress } from '../core/progress.ts';
 import { getCliOptions, cliOptsToProgressOptions } from '../core/cli-options.ts';
 
@@ -59,6 +63,31 @@ export interface MigrateManifest {
   started_at: string;
 }
 
+/**
+ * #1271 Finding 1: make an explicit `--to pglite --path P` destination usable
+ * as a standalone brain. Writes `P/.gbrain/config.json` (mode 0600, plus a
+ * `*` .gitignore) so `GBRAIN_HOME=P` resolves without a manual `gbrain init`.
+ * Never clobbers an existing config at the destination. Returns the written
+ * config path, or null when skipped.
+ */
+export function bootstrapDestinationConfig(dbPath: string): string | null {
+  const abs = resolve(dbPath);
+  const dir = join(abs, '.gbrain');
+  const file = join(dir, 'config.json');
+  if (existsSync(file)) return null;
+  mkdirSync(dir, { recursive: true });
+  const cfg: GBrainConfig = { engine: 'pglite', database_path: abs };
+  writeFileSync(file, JSON.stringify(cfg, null, 2) + '\n', { mode: 0o600 });
+  try { chmodSync(file, 0o600); } catch { /* platform-specific */ }
+  // Same worktree-safety pattern as saveConfig()'s ensureGitignore, scoped
+  // to the destination home. Don't clobber a user-customized .gitignore.
+  const gitignore = join(dir, '.gitignore');
+  if (!existsSync(gitignore)) {
+    writeFileSync(gitignore, '*\n', { mode: 0o600 });
+  }
+  return file;
+}
+
 export function migrationTargetId(config: EngineConfig): string {
   const locator = config.engine === 'postgres'
     ? config.database_url ?? ''
@@ -352,6 +381,25 @@ export async function runMigrateEngine(sourceEngine: BrainEngine, args: string[]
   };
   saveConfig(newConfig);
 
+  // #1271 Finding 2 (by design, but say it out loud): the connection string
+  // is persisted so the migrated brain works without env. Mode 0600.
+  if (opts.targetEngine === 'postgres' && opts.targetUrl) {
+    console.error('Note: the --url connection string (including credentials) is persisted to config.json (mode 0600).');
+  }
+
+  // #1271 Finding 1: an explicit --path destination doubles as a standalone
+  // GBRAIN_HOME. Best-effort — never fail a completed migration over it.
+  if (opts.targetEngine === 'pglite' && opts.targetPath) {
+    try {
+      const written = bootstrapDestinationConfig(opts.targetPath);
+      if (written) {
+        console.log(`Destination bootstrapped: ${written} (usable via GBRAIN_HOME=${resolve(opts.targetPath)})`);
+      }
+    } catch (e) {
+      console.warn(`  WARN could not bootstrap destination config: ${e instanceof Error ? e.message : String(e)}`);
+    }
+  }
+
   // Clean up
   clearManifest();
 

src/commands/migrations/v0_32_2.ts

@@ -186,6 +186,17 @@ async function phaseBFenceFacts(
     const localPathById = new Map<string, string | null>();
     for (const s of sources) localPathById.set(s.id, s.local_path);
 
+    // Dirty-tree refusal: check every source's local_path before writing.
+    for (const [id, localPath] of localPathById) {
+      if (localPath && isLocalPathDirty(localPath)) {
+        return {
+          name: 'fence_facts',
+          status: 'failed',
+          detail: `source "${id}" has uncommitted changes in ${localPath}. Commit or stash, then re-run.`,
+        };
+      }
+    }
+
     // Walk legacy rows in (source_id, entity_slug) groups for per-page
     // atomic writes.
     const legacy = await engine.executeRaw<LegacyFactRow>(
@@ -224,21 +235,6 @@ async function phaseBFenceFacts(
       groups.set(key, list);
     }
 
-    // Dirty-tree refusal: check ONLY the sources we are about to write
-    // into. A dirty tree in an unrelated source (or zero fenceable rows
-    // at all) must not block a no-op or a targeted backfill (#927).
-    const targetSourceIds = new Set([...groups.keys()].map(k => k.split('\0')[0]));
-    for (const id of targetSourceIds) {
-      const localPath = localPathById.get(id);
-      if (localPath && isLocalPathDirty(localPath)) {
-        return {
-          name: 'fence_facts',
-          status: 'failed',
-          detail: `source "${id}" has uncommitted changes in ${localPath}. Commit or stash, then re-run.`,
-        };
-      }
-    }
-
     for (const [key, group] of groups) {
       const [sourceId, entitySlug] = key.split('\0');
       const localPath = localPathById.get(sourceId)!;

test/apply-migrations.test.ts

@@ -180,16 +180,3 @@ describe('runApplyMigrations exit codes (v0.36.1.x #1062)', () => {
     expect(src).toMatch(/All migrations up to date[\s\S]{0,80}process\.exit\(0\)/);
   });
 });
-
-// #921: a failed orchestrator must print each failed phase's detail to
-// stderr — not just "reported status=failed" — so the operator can act
-// without digging through the ledger.
-describe('failed migration prints phase detail (#921)', () => {
-  test('runner loops result.phases and console.errors failed phase details', async () => {
-    const { readFileSync } = await import('fs');
-    const src = readFileSync('src/commands/apply-migrations.ts', 'utf8');
-    expect(src).toMatch(
-      /reported status=failed[\s\S]{0,400}for \(const p of result\.phases\)[\s\S]{0,200}p\.status === 'failed'[\s\S]{0,200}console\.error\([\s\S]{0,80}p\.name[\s\S]{0,80}p\.detail/,
-    );
-  });
-});

test/migrate-engine-dest-bootstrap.test.ts

@@ -0,0 +1,40 @@
+import { describe, expect, test } from 'bun:test';
+import { mkdtempSync, mkdirSync, readFileSync, statSync, writeFileSync } from 'fs';
+import { tmpdir } from 'os';
+import { join, resolve } from 'path';
+import { bootstrapDestinationConfig } from '../src/commands/migrate-engine.ts';
+import { loadConfigFileOnly } from '../src/core/config.ts';
+import { withEnv } from './helpers/with-env.ts';
+
+describe('migrate --to pglite destination bootstrap (#1271)', () => {
+  test('writes <path>/.gbrain/config.json so GBRAIN_HOME=<path> resolves a brain', async () => {
+    const dest = mkdtempSync(join(tmpdir(), 'gbrain-dest-'));
+    const written = bootstrapDestinationConfig(dest);
+    const file = join(dest, '.gbrain', 'config.json');
+    expect(written).toBe(file);
+
+    const cfg = JSON.parse(readFileSync(file, 'utf-8'));
+    expect(cfg.engine).toBe('pglite');
+    expect(cfg.database_path).toBe(resolve(dest));
+    expect(statSync(file).mode & 0o777).toBe(0o600);
+    // worktree safety: destination home is git-ignored like saveConfig()'s home
+    expect(readFileSync(join(dest, '.gbrain', '.gitignore'), 'utf-8')).toBe('*\n');
+
+    // The exact failure mode from #1271: config resolution under
+    // GBRAIN_HOME=<path> used to find nothing ("No brain configured").
+    await withEnv({ GBRAIN_HOME: dest }, () => {
+      const loaded = loadConfigFileOnly();
+      expect(loaded?.engine).toBe('pglite');
+      expect(loaded?.database_path).toBe(resolve(dest));
+    });
+  });
+
+  test('never clobbers an existing destination config', () => {
+    const dest = mkdtempSync(join(tmpdir(), 'gbrain-dest-'));
+    mkdirSync(join(dest, '.gbrain'), { recursive: true });
+    writeFileSync(join(dest, '.gbrain', 'config.json'), '{"engine":"postgres"}\n');
+
+    expect(bootstrapDestinationConfig(dest)).toBe(null);
+    expect(JSON.parse(readFileSync(join(dest, '.gbrain', 'config.json'), 'utf-8')).engine).toBe('postgres');
+  });
+});

test/migrations-v0_32_2.test.ts

@@ -10,11 +10,10 @@
  * __setTestEngineOverride so we don't need a configured brain.
  */
 
-import { describe, test, expect, beforeAll, afterAll, beforeEach, afterEach } from 'bun:test';
+import { describe, test, expect, beforeAll, afterAll, beforeEach } from 'bun:test';
 import { mkdtempSync, rmSync, existsSync, readFileSync, writeFileSync, mkdirSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { join } from 'node:path';
-import { execFileSync } from 'node:child_process';
 
 import { PGLiteEngine } from '../src/core/pglite-engine.ts';
 import { v0_32_2, __setTestEngineOverride, __testing } from '../src/commands/migrations/v0_32_2.ts';
@@ -239,52 +238,6 @@ describe('phaseBFenceFacts — happy path backfill', () => {
   });
 });
 
-describe('phaseBFenceFacts — dirty-tree refusal scoping (#927)', () => {
-  let dirtyDir: string;
-
-  beforeEach(async () => {
-    // A second source whose local_path is a git repo with uncommitted changes.
-    dirtyDir = mkdtempSync(join(tmpdir(), 'mig-v0_32_2-dirty-'));
-    execFileSync('git', ['-C', dirtyDir, 'init', '-q']);
-    writeFileSync(join(dirtyDir, 'uncommitted.md'), 'dirty', 'utf-8');
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    await (engine as any).db.query(
-      `INSERT INTO sources (id, name, local_path) VALUES ('other', 'other', $1)`,
-      [dirtyDir],
-    );
-  });
-
-  afterEach(async () => {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    await (engine as any).db.query(`DELETE FROM sources WHERE id = 'other'`);
-    rmSync(dirtyDir, { recursive: true, force: true });
-  });
-
-  test('no legacy facts at all → complete, dirty unrelated source ignored', async () => {
-    const r = await __testing.phaseBFenceFacts(engine, OPTS);
-    expect(r.status).toBe('complete');
-    expect(r.detail).toContain('scanned=0');
-  });
-
-  test('facts scoped to a clean source fence despite dirty unrelated source', async () => {
-    await seedLegacyFact({ entity_slug: 'people/alice', fact: 'Founded Acme' });
-
-    const r = await __testing.phaseBFenceFacts(engine, OPTS);
-    expect(r.status).toBe('complete');
-    expect(r.detail).toContain('fenced=1');
-    expect(existsSync(join(brainDir, 'people/alice.md'))).toBe(true);
-  });
-
-  test('still refuses when the TARGETED source is dirty', async () => {
-    await seedLegacyFact({ entity_slug: 'people/alice', fact: 'F1', source_id: 'other' });
-
-    const r = await __testing.phaseBFenceFacts(engine, OPTS);
-    expect(r.status).toBe('failed');
-    expect(r.detail).toContain('"other"');
-    expect(r.detail).toContain('uncommitted changes');
-  });
-});
-
 describe('phaseCVerify', () => {
   test('returns complete when fence + DB row counts match', async () => {
     await seedLegacyFact({ entity_slug: 'people/alice', fact: 'F1' });