admin/clawhub
1
0
Fork 0
mirror of https://github.com/openclaw/clawhub.git synced 2026-08-14 08:52:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove CLAW-480 recovery bypass (#3003)

Browse Source
This commit is contained in:
Patrick Erichsen
2026-07-07 19:13:55 -05:00
committed by GitHub
parent fb722afebf
commit dc0fd6d6c8
2 changed files with 2 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files
convex/lib/skillPublish.test.ts
+1 -22
View File
@@ -556,10 +556,7 @@ description: Security scanner smoke fixture.
versionId: "skillVersions:demo",
embeddingId: "skillEmbeddings:demo",
});
expect(runMutation).toHaveBeenCalledWith(expect.anything(), {
...insertArgs,
bypassNewSkillRateLimit: true,
});
expect(runMutation).toHaveBeenCalledWith(expect.anything(), insertArgs);
expect(scheduler.runAfter).toHaveBeenCalledWith(0, expect.anything(), {
versionId: "skillVersions:demo",
});
@@ -575,24 +572,6 @@ description: Security scanner smoke fixture.
});
});
it("does not bypass new-skill limits for attempts created after the recovery cutoff", () => {
const insertArgs = {
userId: "users:1",
slug: "future-staged-skill",
version: "1.0.0",
};
expect(
__test.withStagedFinalizationRateLimitBypass(insertArgs, Date.parse("2026-07-07T15:27:10Z")),
).toBe(insertArgs);
expect(
__test.withStagedFinalizationRateLimitBypass(
{ ...insertArgs, bypassNewSkillRateLimit: true },
Date.parse("2026-07-07T15:27:10Z"),
),
).toEqual({ ...insertArgs, bypassNewSkillRateLimit: true });
});
it("releases the staged publish finalization claim when insertion fails", async () => {
const insertArgs = {
userId: "users:1",
convex/lib/skillPublish.ts
+1 -23
View File
@@ -49,8 +49,6 @@ const QUALITY_WINDOW_MS = 24 * 60 * 60 * 1000;
const QUALITY_ACTIVITY_LIMIT = 60;
const PLATFORM_SKILL_LICENSE = "MIT-0" as const;
const SECURITY_SCAN_ENQUEUE_BACKUP_DELAY_MS = 15_000;
// Frozen after the CLAW-480 rollback snapshot. Remove after the incident cohort is drained.
const CLAW_480_RECOVERY_ATTEMPT_CUTOFF_MS = Date.parse("2026-07-07T15:27:09Z");
const MAX_PUBLISH_SUMMARY_LENGTH = 300;
type FingerprintFile = { path: string; sha256: string };
@@ -567,10 +565,7 @@ export async function finalizeSkillPublishAttempt(
let publishResult: PublishResult;
try {
const skillInsertArgs = withStagedFinalizationRateLimitBypass(
await prepareSkillInsertArgsForFinalization(ctx, claim.skillInsertArgs),
claim.createdAt,
);
const skillInsertArgs = await prepareSkillInsertArgsForFinalization(ctx, claim.skillInsertArgs);
publishResult = (await ctx.runMutation(
internal.skills.insertVersion,
skillInsertArgs as never,
@@ -603,22 +598,6 @@ export async function finalizeSkillPublishAttempt(
return publishResult;
}
function withStagedFinalizationRateLimitBypass(rawInsertArgs: unknown, attemptCreatedAt: number) {
if (!rawInsertArgs || typeof rawInsertArgs !== "object" || Array.isArray(rawInsertArgs)) {
return rawInsertArgs;
}
if (
attemptCreatedAt > CLAW_480_RECOVERY_ATTEMPT_CUTOFF_MS &&
(rawInsertArgs as Record<string, unknown>).bypassNewSkillRateLimit !== true
) {
return rawInsertArgs;
}
return {
...rawInsertArgs,
bypassNewSkillRateLimit: true,
};
}
async function prepareSkillInsertArgsForFinalization(
ctx: ActionCtx,
rawInsertArgs: unknown,
@@ -843,7 +822,6 @@ export const __test = {
toStructuralFingerprint,
derivePublishFilesFromStorage,
buildSkillPublishAttemptIdempotencyKey,
withStagedFinalizationRateLimitBypass,
};
export async function queueHighlightedWebhook(ctx: MutationCtx, skillId: Id<"skills">) {