mirror of
https://github.com/grp06/openclaw-studio.git
synced 2026-08-14 08:52:03 +00:00
George Pickett
732b994120
Centralize OpenClaw agent id validation in a new module (src/lib/agents/agentIds.ts) and route every gateway, cron, ssh, and intent path through it. Tighten the safe-id regex to match the gateway's 64-char normalization and reserve "main" from UI creation. Add symlink-aware boundary checks and move rollback to trash/restoreAgentStateLocally and the SSH equivalent so a failed move never leaves the filesystem half-migrated, and restore refuses symlinks that escape stateDir. Validate session keys (hasMalformedAgentSessionKey, sessionKeyBelongsToAgent) and cron job fields before trusting gateway output, and compare cron agent ids case-insensitively. Refactor applyGatewayConfigPatch and exec-approvals retry to fetch the snapshot inside the retry callback, eliminating a stale-baseHash race. Harden the control-plane adapter: stop() now waits on in-flight start, times out hung sockets, and ignores stale ws event handlers via a connection epoch. Close a WebSocket upgrade auth bypass in server/index.js by routing upgrades through accessGate.allowUpgrade, make access-gate cookie values URL-safe and stop reconstructing redirect URLs from Host headers, and apply the access gate to all non-token requests rather than only /api/. Read media via realpath + boundary re-check, enforce MAX_MEDIA_BYTES on remote SSH responses, and whitelist response MIME types. Clean up SSE streams on client abort. Normalize localhost gateway URLs in studio-settings so token hints only apply when the draft URL matches, and write settings atomically. Make the Playwright port configurable (PLAYWRIGHT_PORT, default 3100) to avoid colliding with the running dev server, and ignore .worktrees in eslint. Add unit tests for the new agentIds module, gateway connect profile, disconnect-like errors, local gateway, and studio settings store, and extend existing tests to cover the new validation, rollback, retry, and normalization paths.
22 lines
748 B
TypeScript
22 lines
748 B
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { isGatewayDisconnectLikeError } from "@/lib/gateway/gateway-disconnect";
|
|
|
|
describe("isGatewayDisconnectLikeError", () => {
|
|
it("recognizes gateway close code 1012 as disconnect-like", () => {
|
|
expect(isGatewayDisconnectLikeError(new Error("gateway closed (1012): service restart"))).toBe(
|
|
true
|
|
);
|
|
});
|
|
|
|
it("does not classify unexpected close codes as disconnect-like", () => {
|
|
expect(isGatewayDisconnectLikeError(new Error("gateway closed (1006): abnormal closure"))).toBe(
|
|
false
|
|
);
|
|
});
|
|
|
|
it("keeps existing stopped-client messages disconnect-like", () => {
|
|
expect(isGatewayDisconnectLikeError(new Error("gateway client stopped"))).toBe(true);
|
|
});
|
|
});
|