mirror of
https://github.com/openclaw/lobster.git
synced 2026-08-14 08:52:48 +00:00
main
6
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Yiğit ERDOĞANandClaude Opus 5
|
096f5fedcb |
fix: workflow steps keep waiting for the model after timeout_ms expires (#132)
* fix(llm): honor step timeouts and cancellation during model calls llm.invoke never read ctx.signal, and both adapter helpers called fetch without one, so nothing could end a request once it was in flight. A workflow step with timeout_ms kept waiting for the adapter and, when the model eventually answered, reported the step as completed well past its budget. Shell steps already honor the same signal, so the two step kinds disagreed about what timeout_ms means. Thread ctx.signal into both adapter fetch calls, check it before each attempt so an already-cancelled run does not pay for another call, and rethrow abort errors unwrapped: the workflow runner recognizes timeouts and external cancellation by the error's identity, so wrapping them in "request failed" would misreport the outcome even once the request stops. * fix(llm): stop waiting for adapters that ignore the cancellation signal Threading the signal into fetch only covers the HTTP adapters. An injected ctx.llmAdapters adapter is awaited directly, so one that never observes ctx.signal still holds a timed-out step open for as long as it likes, which leaves SDK and tool-runtime users on the weaker timeout contract the rest of this change removes. Await the adapter call against the signal instead of the adapter alone. The adapter's own work cannot be killed from here, but the step stops waiting on it and the abort reason reaches the workflow unchanged. Cooperative adapters are unaffected: they still receive ctx and can end their own work. * fix(llm): do not finish a cancelled run from cached results Run-state and file-cache hits return before any adapter call, so a run that was already cancelled still completed successfully from cached data. That contradicts the rest of this change: the same invocation reports cancellation when it has to reach a model and success when it does not, purely on cache contents. Check the signal once at entry, before either lookup. The retry-loop check stays, since cancellation can also arrive between validation attempts. * docs(readme): state the cancellation contract for injected LLM adapters Racing an adapter promise against the step signal restores workflow liveness, but it cannot cancel work the adapter has already started: an injected adapter that ignores `ctx.signal` keeps its model request running after Lobster stops awaiting it, and a configured retry can then overlap it. That is a contract for the host to meet, so the host-facing docs have to say it rather than leaving it to be discovered from a duplicated charge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014Bu6MvbjKGtfRiNesARMyZ * fix(llm): re-check cancellation after each awaited reuse boundary The entry check only caught a run that was already cancelled when the command started. Draining pipeline input waits on the upstream step, and the run-state and cache lookups are file I/O, so a step timeout could fire during any of them and the reuse branch would still return its stored answer as a successful result. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011gD5sJTbh2jn1uvgNCmkLq * fix(llm): do not report a step that finished after its deadline The cancellation checks stopped at the adapter call, but both return paths then await run-state and cache writes. A deadline crossed during those writes was never observed, so the step returned success and the workflow cleared its timer -- a model step could still complete late. The check goes after both writes rather than between them: the answer has already been paid for, and leaving it stored lets the retry replay it instead of calling the model a second time. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011gD5sJTbh2jn1uvgNCmkLq * test(llm): let the persistence tests run where the state fix has not landed The two cancellation-during-write tests let the command create the cache namespace directory itself, which is where #125 throws on Windows: the recursive mkdir reports an extended-length path and the chain sync then opens `<dir>\C:`. Both tests failed there before reaching an assertion, so this branch added two Windows failures over main for a reason that is not its own. Creating the directory up front is what the seeded-cache tests in this file already do. ensureDirectory only syncs a chain it created, so an existing directory never reaches the broken path, and the tests still fail against the code they cover -- now on the missing rejection rather than on ENOENT. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwU1bvb9Pt3cR662P52CTp * fix(llm): let a host's own abort reason still read as cancellation The workflow runner classifies cancellation by name alone: only `AbortError` or `ABORT_ERR` bypasses the step's retry and `on_error` policy. Every abort path here rejected with `signal.reason` untouched, so a host that calls `controller.abort(new Error("stop"))` handed the runner an ordinary-looking error. A cancelled `llm.invoke` step under `on_error: continue` was recorded as a step failure and the run carried on -- returning `status: "ok"` for a run the host had cancelled. The gap is narrow, which is why it survived earlier review. An HTTP adapter is saved by fetch rejecting with its own `AbortError`, and the runner's own step timer is not affected. It opens only on the injected `ctx.llmAdapters` path, where this command's rejection is the only thing the runner ever sees. Normalize at the boundary instead of guessing upstream: a reason that already reads as an abort passes through untouched, anything else keeps its message and moves to `cause` under an abort-identified error. The host's reason is never discarded, and callers that already match on `AbortError` keep matching. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WHhk7xRwXzYcSXvw2kp5F5 * fix(llm): watch an adapter that rejects after aborting the run `abortable` guards against an adapter that ignores `ctx.signal`, but its already-aborted branch rejected the wrapper and returned before anything was attached to the adapter's own promise. An adapter that cancels the run from inside its own `invoke` -- an SDK client tearing itself down on a fatal error -- and then rejects leaves that rejection unobserved. The step still fails correctly, with the `AbortError` the runner needs. The damage lands afterwards: under Node's default unhandled-rejection handling the process exits on an error nothing is waiting for, seconds after the run was cancelled cleanly. Attach settlement handling first in both branches, so the promise is watched before an abort can win the race. Removing a listener that was never added is harmless, which keeps the two paths one shape. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011hFZxjivm9JTTvmRjQ4A8S --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> |
||
|
Yiğit ERDOĞANandClaude Opus 5
|
e88e8d3970 |
fix: cached LLM answers are returned when temperature or max output tokens change (#130)
* fix(llm): key the response cache on sampling parameters --temperature and --max-output-tokens were sent to the adapter but left out of the cache key, so changing either one replayed the previous answer instead of calling the model. The same key drives --state-key reuse, so a resumed workflow replayed the stale answer too. Hash each parameter only when it is set, guarding on the same predicate that decides whether it goes on the wire. stableStringify sorts keys, so an invocation that sets neither serializes exactly as before and keeps its current hash - the cache is content-addressed by filename and a blanket key change would orphan every entry written by an earlier release. metadata stays out: it is set unconditionally with --metadata-json and carries correlation data rather than decode-time parameters, so hashing it would invalidate existing caches and collapse the hit rate. --schema-version already covers callers who want metadata to segment the cache. * fix(llm): version the cache identity so old entries cannot replay sampling Keying only the parameters that were supplied kept the omitted-parameter key byte-identical to what earlier releases wrote. That preserved existing caches, but it also left one collision: an entry those releases stored for a request sampled at an explicit temperature sits under the key a request that omits sampling computes, so after upgrading, an unsampled request could be served a sampled answer. Put both parameters in the payload unconditionally, with `null` as the identity of an omitted one, and add a version field to the payload. Entries written under the previous identity are unreachable rather than ambiguous: the cost is one re-invocation per prompt after upgrade, never a wrong replay. The key-stability test is replaced by its inverse — a cache entry written under the pre-upgrade key is not returned to a request that omits sampling. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6UVfFPP39RkoYx5jZ3KKM --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> |
||
|
xingzhouandPeter Steinberger
|
c440ca57d1 |
fix(runtime): cancelled workflows no longer continue external commands (#119)
* fix(runtime): stop process-backed work on cancellation
* fix(runtime): invalidate cancelled resume state
* Revert "fix(runtime): invalidate cancelled resume state"
This reverts commit
|
||
|
Vincent Koc
|
d9a0fe7e02 | style: format lobster sources | ||
|
Peter Steinberger
|
e4514ecad5 | style: format with oxfmt | ||
|
Vignesh Natarajan
|
e1947c9414 | feat: add generic llm invoke adapters |