Files
gbrain/test/init-nudge.test.ts
T
Garry TanandClaude Fable 5 6411150071 v0.45.11.0 feat(bootstrap): OOBE hand-off (own the brain + cold-start) + DX polish waves (#4047)
* feat(bootstrap): TTY DX exploration harness + Krug onboarding fix wave

Add a real-PTY exploration harness and land 16 verified "Don't Make Me
Think" fixes on the paste-in install experience for Claude Code and Codex.

Harness:
- test/helpers/tty-harness.ts — spawns any CLI (gbrain/claude/codex) under a
  real pseudo-terminal (Bun terminal: spawn), timestamps every output burst,
  and turns silence windows into a measurable stall report. Hermetic; pure
  helpers unit-tested in test/tty-harness.test.ts.
- scripts/dx-explore.ts — drives the fresh-user funnel (help / init / real
  claude-install / real codex-install / manual drive mode), writing
  transcripts to .context/dx-runs/ (gitignored).

Fixes (all adversarially verified against the code first):
- Keyless bare `gbrain init` completes in keyless mode instead of exit 1;
  multi-key non-TTY auto-picks the canonical default; typo stays fail-loud.
- Provider picker probe-gates ollama (daemon-up != model-pulled) and offers
  an explicit "continue keyless" option that is the bare-Enter default.
- Fresh-brain init prints one schema-setup line instead of ~240 migration
  names (GBRAIN_MIGRATE_VERBOSE=1 restores detail).
- Init epilogue: memory-verbs funnel is last-on-screen; skills advisory
  compacted for init; Mod Status trimmed.
- PGLite live-serve lock error names the fix (close the agent session).
- Mode-picker banner interpolates the applied mode; expansion-key gate is
  Anthropic/OpenAI/Google, not OpenAI-only.
- Missing `claude` binary skips MCP but still installs hooks; honest copy.
- Foreign MCP-registration removal targets the conflicting scope and fails
  loud if it does not land.
- Upgrade marker compares the running binary to latest and self-spawns via
  execPath, so a current/newer binary no longer nags from a stale cache.
- interview --set/--skip after --confirm warns it voided the confirmation.
- init --help matches behavior; init --supabase fails loud on non-TTY.
- Provider capabilities attributed per provider across README / runbook /
  questions bank / bootstrap.md.
- First-run tour: restart-first, prompt 3 true on day one, withheld on FAIL;
  README gives Codex the same scripted magic moment.
- Empty-brain "0 takes" onboard nudge suppressed.
- Broken settings.local.json aborts the hooks write fail-closed instead of
  silently dropping the user's permissions.

Regenerated cli-flag-registry.generated.ts and llms-full.txt.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(bootstrap): second DX polish wave — clean the success screen + honest copy (F17-F21)

Follow-up to the DX fix wave, closing the top-5 remaining gaps the scorecard
flagged (all human-facing polish, not survival):

F17 — machine markers no longer leak to humans:
- verify report drops the `[D3.6]` plan-tag from the first_run_tour detail.
- the raw `UPGRADE_AVAILABLE <cur> <latest>` marker line prints ONLY on a
  non-TTY stderr (parsers still get it); an interactive human sees just the
  "gbrain X -> Y available" sentence.
- per-migration "what changed" notices (v123/v124, incl. the #2704 ref) are
  suppressed on a FRESH-install replay via a module quiet flag; upgrades still
  narrate. (GBRAIN_MIGRATE_VERBOSE=1 restores them.)

F18 — one obvious next action on the init success screen: the memory-verbs
demo is the single "→ Do this next" hero, last on screen; import/migrate/doctor
collapse into one terse "More:" footer; the graph block only shows for a
non-empty brain.

F19 — README "moment it clicks" is now the genuine cross-session brain
round-trip (remember → restart → recall), explicitly distinguished from the
identity-file recall, on both the Codex and Claude Code paths.

F20 — the compact init skills advisory is human-voiced (no `[AGENT]`
stage-direction on the human-facing success screen; the mode-picker's
agent-directed block stays gated to the non-TTY channel).

F21 — time promise reconciled: headline is ~15 min (personal-agent path) /
~30 min (always-on OpenClaw/Hermes); the runbook's search-mode line no longer
claims "balanced" when keyless applies "conservative". README hooks copy says
"on by default, with an opt-out" to match the runbook.

Regenerated llms-full.txt.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(bootstrap): address two-model adversarial review of the DX wave

Fixes the regressions the 5-specialist + red-team + Claude/Codex adversarial
pass found in the F1–F21 changes, each with a test:

- Keyless upgrade hint pointed at `config set embedding_model`, which config.ts
  hard-refuses as a schema-sizing no-op — now names the working re-init recipe
  (`gbrain init --force --pglite --embedding-model <id>`), zero-key AND multi-key
  paths.
- Multi-key TTY picker offered "continue keyless" but the caller aborted on it —
  now honors keyless like the zero-key path.
- Detached update-refresh spawn used a `/gbrain$/` basename check that misfires
  for a renamed/official-named compiled binary (`gbrain-darwin-arm64`) and
  prepends the /$bunfs entrypoint — now detects dev-vs-compiled by the runtime
  basename (bun|node) so the refresh always runs.
- `bootstrap status` reported the wire phase "done" on a hooks-only receipt
  (host CLI missing at wire time) — now "partial" with a re-run hint, so a
  resuming agent doesn't trust a false complete.
- Post-repair MCP mismatch re-verifies and aborts instead of blessing a
  registration a racing writer may have re-claimed.
- probeOpenAICompat's abort timer now spans the body read (was cleared before
  it), so a stalled `/v1/models` body can't hang init past the 1s cap.
- Centralized the 4-copy stale-cache upgrade predicate into
  `pendingUpgradeVersion`; UPGRADE_AVAILABLE gains a GBRAIN_FORCE_UPGRADE_MARKER
  override for PTY-based agent harnesses.
- Mode picker's expansion-key gate adds GEMINI_API_KEY; picker prompt is
  article-aware ("an embedding" / "a chat"); dead `!brainEmpty` clause removed;
  migrate.ts try/finally widened + stamp failures named in quiet mode.
- DX harness: credential copies scrubbed even on SIGINT/interrupt (+chmod 600),
  child process TREE reaped on teardown, advisory made fail-open, KEY_MAP typed
  as a literal union.

New tests: migrate quiet-replay, self-upgrade pending predicate + negative
cache cases, bootstrap 127/scoped-remove/broken-settings dispatch, interview
invalidation flag, verify tour-withheld-on-FAIL, init keyless/supabase/multi-key,
init-nudge branches, ai-probes model parsing. Regenerated flag registry +
template-repo.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* v0.45.8.0 fix(bootstrap): onboarding DX polish wave (F17-F21) + review fixes

DX fix wave on the paste-in install/first-run experience for Claude Code and
Codex, driven by a new real-PTY exploration harness. Keyless init completes
instead of erroring, the migration wall collapses to one line, the success
screen leads with one action, and the "magic moment" copy points at the genuine
cross-session round-trip. Full detail in CHANGELOG.

Version trio + openclaw manifest + runbook stamp bumped to 0.45.8.0; CHANGELOG
release entry; TODOS onboarding-DX follow-ups filed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(bootstrap): OOBE hand-off — you own the brain, cold-start is skill #1

A working install now ends by making the two facts that matter actually land:

- `gbrain bootstrap verify` prints (and returns as `handoff` in --json) an
  ownership block — the actual private-repo URL with what owning it means
  (read it, `gbrain bootstrap attach` on machine two, delete it and the brain
  is gone), or the local-only variant pointing at `gbrain bootstrap repo` —
  followed by the ONE next action: run the cold-start skill (Gmail/calendar/
  contacts via ClawVisor, an OAuth vault so the agent never holds raw tokens;
  or offline archives), one consented phase at a time. Withheld on FAIL like
  the tour; shape stays unconditional for machine consumers.
- cold-start ships in the downstream bundle (61 skills): its plugin exclusion
  ("host onboarding flow") predated the v0.45 personal-agent bootstrap and is
  deliberately reversed — the paste-in audience is exactly who day-one
  onboarding is for. It now LEADS the recommended set (ahead of book-mirror:
  every flagship skill only becomes magical once the brain holds the user's
  real life).
- New drift guard: every recommended slug must be scaffoldable from the
  plugin bundle — recommended-but-unscaffoldable is a dead-end CTA and now
  fails the suite.
- Runbook Hand off rewritten around the two must-land facts + the on-the-spot
  cold-start offer; README's Codex and Claude Code paths carry the same two
  follow-ups.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* v0.45.10.0 feat(bootstrap): the OOBE hand-off release

Version trio + runbook stamp + template tree to 0.45.10.0; CHANGELOG entry;
llms bundles regenerated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(ci): stop memory-verbs-conformance leaking a fake-keyed gateway into shard-mates

The deterministic-embedder helper configures the MODULE-GLOBAL gateway with a
fake OpenAI key; the file's afterAll never reset it. The bunfig preload's
per-test restore only fires when the gateway is UNCONFIGURED, so the fake-keyed
config persisted for every later file in the shard process — turn-context's
corpus writes then embedded against real OpenAI and 401'd (CI shard-8 failure;
shard re-binning from this branch's new test files exposed it).

Fix both sides: conformance's afterAll now resetGateway()s back to the preload
baseline and nulls both test transports; turn-context's beforeAll does the same
defensively so it stays hermetic regardless of shard composition.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-13 15:35:05 -07:00

141 lines
5.2 KiB
TypeScript

/**
* Unit tests for src/core/onboard/init-nudge.ts (runInitNudge).
*
* runInitNudge fires 6 parallel COUNT probes (stale chunks, entities, linked
* entities, timeline entities, takes, total pages) and prints a one-line
* nudge to stderr. These tests pin the DX-wave behavior:
* - EMPTY brain (pages count 0) → the whole nudge is suppressed, even
* when takes === 0 (no "0 takes" jargon-noise on first init)
* - pages probe REJECTS → fail-open sentinel treats the brain as
* non-empty, so the takes nudge still fires
* - non-empty + healthy + one rejected arm → partial-checks notice
* - non-empty + takes 0 → "0 takes" opportunity nudge
*
* The gate is process.stderr.isTTY (NOT process.env), so monkeypatching it
* here does not trip the serial-isolation rules for env-mutating tests.
* Both isTTY and stderr.write are restored in finally.
*/
import { describe, test, expect } from 'bun:test';
import { runInitNudge } from '../src/core/onboard/init-nudge.ts';
import type { BrainEngine } from '../src/core/engine.ts';
/** Per-probe result: a count, or an Error to make that arm reject. */
interface ProbeCounts {
stale?: number | Error;
entities?: number | Error;
linked?: number | Error;
timeline?: number | Error;
takes?: number | Error;
pages?: number | Error;
}
/**
* Stub engine shaped like { executeRaw: async (sql) => [...] }. Routes each
* of runInitNudge's 6 COUNT queries by a distinctive SQL fragment. Order
* matters: the linked/timeline queries also contain "type IN ('person'",
* so they are matched first.
*/
function stubEngine(counts: ProbeCounts): BrainEngine {
const route = (sql: string): number | Error => {
if (sql.includes('content_chunks')) return counts.stale ?? 0;
if (sql.includes('FROM takes')) return counts.takes ?? 0;
if (sql.includes('FROM links')) return counts.linked ?? 0;
if (sql.includes('timeline_entries')) return counts.timeline ?? 0;
if (sql.includes("type IN ('person'")) return counts.entities ?? 0;
// 6th probe: SELECT COUNT(*) FROM pages WHERE deleted_at IS NULL
return counts.pages ?? 0;
};
return {
executeRaw: async (sql: string) => {
const r = route(sql);
if (r instanceof Error) throw r;
return [{ count: r }];
},
} as unknown as BrainEngine;
}
/**
* Run the nudge with stderr forced to look like a TTY and its writes
* captured. Restores both in finally so no other test sees the patch.
*/
async function runNudgeCaptured(engine: BrainEngine): Promise<string> {
const origIsTTY = process.stderr.isTTY;
const origWrite = process.stderr.write;
let out = '';
try {
(process.stderr as unknown as { isTTY: boolean }).isTTY = true;
process.stderr.write = ((chunk: unknown) => {
out += String(chunk);
return true;
}) as typeof process.stderr.write;
await runInitNudge(engine);
} finally {
process.stderr.write = origWrite;
(process.stderr as unknown as { isTTY: boolean | undefined }).isTTY = origIsTTY;
}
return out;
}
describe('runInitNudge — empty-brain suppression', () => {
test('empty brain (pages 0, takes 0) prints NOTHING', async () => {
const out = await runNudgeCaptured(
stubEngine({ stale: 0, entities: 0, linked: 0, timeline: 0, takes: 0, pages: 0 }),
);
expect(out).toBe('');
});
});
describe('runInitNudge — pages probe failure is fail-open', () => {
test('pages probe REJECTS with takes 0 → nudge still fires with "0 takes"', async () => {
// The -1 sentinel means "count unknown" — treat as non-empty so the
// pre-existing behavior (nudge on 0 takes) is preserved.
const out = await runNudgeCaptured(
stubEngine({
stale: 0,
entities: 0,
linked: 0,
timeline: 0,
takes: 0,
pages: new Error('pages probe failed'),
}),
);
expect(out).toContain('Brain has opportunities');
expect(out).toContain('0 takes');
});
});
describe('runInitNudge — partial-checks notice', () => {
test('non-empty healthy brain with one rejected arm → "Init checks incomplete"', async () => {
// pages > 0 (non-empty), takes > 0 (no opportunity part), entities 0
// (coverage arms vacuous), stale 0 — but the linked probe rejects, so
// partial=true with zero parts → the incomplete-checks line.
const out = await runNudgeCaptured(
stubEngine({
stale: 0,
entities: 0,
linked: new Error('linked probe failed'),
timeline: 0,
takes: 5,
pages: 10,
}),
);
expect(out).toContain('Init checks incomplete');
expect(out).toContain('(5/6)');
expect(out).toContain('gbrain onboard --check');
expect(out).not.toContain('Brain has opportunities');
});
});
describe('runInitNudge — non-empty brain opportunities', () => {
test('non-empty brain with takes 0 → "Brain has opportunities: 0 takes"', async () => {
const out = await runNudgeCaptured(
stubEngine({ stale: 0, entities: 0, linked: 0, timeline: 0, takes: 0, pages: 10 }),
);
expect(out).toContain('Brain has opportunities: 0 takes');
expect(out).toContain("Run 'gbrain onboard --check' to see the plan");
// All 6 probes succeeded — no partial-checks suffix.
expect(out).not.toContain('checks complete');
});
});