2 Commits
Author SHA1 Message Date
Garry TanandClaude Fable 5 d35c9c9e44 v0.45.0.0 feat(bootstrap): paste-in personal-agent install for Codex + Claude Code (#3975)
* docs(designs): agent-bootstrap plan + design docs (normative, review-absorbed)

The scrubbed, in-repo sources of truth for the gbrain bootstrap wave:
AGENT_BOOTSTRAP_DESIGN.md (product scope/sequencing) and
AGENT_BOOTSTRAP_PLAN.md (implementation; all review-finding IDs inlined).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(bootstrap): format spec, question bank, identity templates, bundled assets

agent.json manifest (format_version 1, initialized sentinel) + machine-local
install receipt [CX2-1, CX2-12]; 12-question/6-required interview bank with
consent keys and a persist:false sink for the optional provider key [CX2-13];
ten {{TOKEN}} identity templates (generic, adapted to gbrain ops — gates call
recall/query/put_page, write-through-ops rule, keyless agent-authored facts,
silence contract); assets embedded compiled-binary-safe via file-type imports
[ENG-6].

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(bootstrap): runbook, README paste block, bootstrap guide, TODOS entries

BOOTSTRAP_FOR_AGENTS.md (agent-driven install runbook: CLI phase list is the
source of truth, never-invent rules, Codex approvals preflight, keyless posture,
failure-modes table, version stamp for the skew check); README gains the
full-agent paste block pinned to latest-stable inside the Claude Code/Codex
quick start (memory-only tier stays); docs/guides/bootstrap.md carries the full
install/security/consent/degradation/uninstall contract.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(designs): spike instrument for the bootstrap wave (build order 0)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(bootstrap): interview + render engines

Interview gate with read-back confirm-hash (any later answer change clears the
confirmation — the hostile single-batch case is structurally impossible),
per-answer provenance, caps + escaping at set time, config-sink routing for the
provider key; renderer with hard-fail token sweep, subordinate fencing of
principal input, never-clobber + backups, deterministic minimal mode for the
template repo, scaled byte floors. 58 unit tests.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(bootstrap): private-repo lifecycle — repo create, attach, uninstall, run lock

gh-gated private repo creation with API-verified privacy (rate-limit distinct
from public), refuse-foreign-origin with attach as the sanctioned path, atomic
bootstrap mutex (pid liveness + age + token), receipt-keyed uninstall that
never wholesale-deletes the gbrain home and only offers --delete-brain for a
brain it created; read-only PGLite lock probe (never opens the engine).
54 unit tests, injectable exec seam throughout.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(release): latest-stable ref, template-repo publish job, bootstrap CI guards

release.yml advances the latest-stable tag only after assets publish (the paste
block's permanent ref — copies in the wild never rot) and gains a PAT-gated
publish-template job verified against the vendored tree; two skip-graceful
guards (sanctioned-ref + runbook stamp; template/token bijection + placeholder
assertion + generator byte-diff) wired into verify; README + runbook re-admitted
to the CI cache hash; vendored deterministic template tree generated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(context): IPC v2 turn_context + 8KB assembly + visibility resolver + session identity

Discriminated-union IPC with handler map, protocol echo (stale-serve detection),
shared-secret gate, server-side source binding, per-kind budgets; turn-context
assembly (reflex pointers + volunteered pages + world-only hot facts) under a
data-not-instructions envelope trimmed to the harness's 10KB hook-output cap;
facts.default_visibility resolved through one helper at all four sites (explicit
caller wins, typos fail closed); typed sessionId threads _meta.session_id into
the hot-memory cache key. 50 new tests; 180 adjacent tests confirmed green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(persistence): secret-scan, gbrain sources push, durability unification

Pattern secret scanner (own runtime allowlist, redacted previews, corpus-write
redaction mode); sources push runs the whole scan→stage→commit→pull→push
sequence under one cross-platform lock (mkdir-atomic, pid+age+token) with a
deny-glob backstop, commit-first divergence-safe pull, refuse-unverifiable
visibility, and push-status telemetry; gbrain-home choke point unifies
GBRAIN_HOME semantics with config (0700); durability is parent-repo-aware and
rotates its push log at 0600. 35 new tests; 200 existing green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(sources): harden/pull gates accept sources inside a parent git repo

The bootstrap workspace registers brain/ (a subdirectory) as the source; the
durability core already resolves the repo root, so the command gates now check
inside-a-repo rather than .git-right-here [CX2-3].

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(serve): resident maintenance sweep + keyless capability probe

The lock-owning serve process now closes the persistence loop: startup (3s
post-connect, best-effort, unref'd) and idle (10-min quiet intervals through
the injectable timer seam) sweeps run facts-fence reconciliation, deterministic
link/timeline extraction over recent workspace pages, and spend-gated corpus
ingest (skipped keyless — agent-authored fences cover it). gbrain sweep --once
is the trusted CLI seam bootstrap verify uses. Capability probe renders the
honest keyless/keyed report. Full reuse of the cycle extractor + extract cores;
26 new tests, neighbors green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(hooks): engine-free gbrain hook command, settings writers, transcript parser

Four hook events (session-start digest + crashed-session recovery push,
user-prompt turn-context injection under an 800ms deadline and the 10KB cap,
stop buffers, session-end corpus write with redaction/retention/dedup +
best-effort push); structural JSON settings merger keyed by a _gbrain marker
(foreign hooks and permissions survive); dated host-spec registry; Claude Code
.jsonl parser as a spec-target with a scrubbed 7-shape fixture. Heartbeat is
counters-only by construction. 59 tests; zero engine modules in the import
graph.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(bootstrap): cross-link the full-agent path from the connection docs

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(bootstrap): dispatcher, verify, status — the command assembled

gbrain bootstrap {status,interview,render,repo,hooks,verify,uninstall,attach}:
engine-free except verify (owns its engine, in-process sweep — no live-serve
conflict); phase list is the TS source of truth with install.jsonl telemetry
and the support blob; verify's fail-soft check suite covers the real write path
(put_page → write-through file → sweep → graph floor → recall), passes keyless,
persists snapshots, and ends with the first-run tour. cli.ts wired per the
three-touchpoint rule; doctor gains the bootstrap check group (silent on
machines with no bootstrap state). 28 new tests; 353 adjacent green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: KEY_FILES bootstrap cluster + CLAUDE.md dispatcher row (+ build:llms)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(bootstrap): e2e pins — hook-under-live-serve, attach, degraded modes, compiled binary, Docker harness

The permanent pins: a real serve holds the PGLite lock while the engine-free
hook completes (and a direct engine open provably throws LiveServeLockError);
stale-socket fail-open; machine-2 attach with marker-keyed hook repair;
decline-everything installs verify green with every degradation named; the
compiled binary renders bundled templates in an empty cwd. Offline Docker
harness (networkless, read-only) gated into heavy-tests.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(bootstrap): register doctor check categories + system-of-record allow comments

The six bootstrap doctor checks join OPS_CHECK_NAMES; the sweep's batch link/
timeline inserts carry the explicit extract-path allow comments (the sweep IS
the extraction path for workspace pages).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(test): shard wedge cap tracks suite growth (1500s -> 1800s)

At ~9000 tests a healthy shard finished at 1466s and two progressing shards
were false-killed at the old cap; 1800s restores ~25% headroom over the
slowest observed healthy shard. Real hangs still hit it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(ci): cache-hash policy — README + runbook edits must invalidate [C2]

The old deny-list assertion predates the paste block; README.md and
BOOTSTRAP_FOR_AGENTS.md are policy-doc re-admissions now, so their edits must
change the hash (a paste-block edit shipping under a cached green was the C2
hole).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(test): classify post-suite exit-hangs as warn-pass; file the leak forensics

A shard killed by the wedge watchdog with every assigned file started and zero
fail markers did all its work and leaked a handle at exit — pre-existing and
master-reproducible (P1 TODO carries the full bisect forensics). Bun's per-test
timeout turns a hung test into a (fail), so the classifier cannot mask one.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(test): shard cap 2400s — the count-balanced heavy shard needs it under contention

Observed: the heavy shard still progressing 22s before an 1800s kill while
siblings finish at 1150-1550s (split balances file count, not weight). Filed
the load-sensitive WAL-repair flake (pre-existing, master's v0.42.75.0 wave).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(bootstrap): quarantine env-mutating suites to the serial lane

check-test-isolation R1: six new files mutate GBRAIN_HOME/env at module scope —
the serial lane (one process per file) is the guard's prescribed home for them.
All 114 tests pass post-rename.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(readme): per-harness install sections — Codex, Claude Code, then OpenClaw/Hermes

Each harness gets its own complete paste-block section (desktop app first,
terminal noted — Claude Code CLI is the identical harness; Codex CLI works
pull-based today); the OpenClaw/Hermes platform path keeps equal weight with
its one-click deploys and INSTALL_FOR_AGENTS block intact; memory-only and
remote-connect tiers consolidated under 'Lighter ways in'. Supersedes the
review's D5 ordering by user direction; stale heading references updated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(readme): Codex as the recommended first step; OpenClaw/Hermes framed as-intended, high-cost

The install section now routes newcomers explicitly: Codex first
(subscription-priced, nothing to deploy), OpenClaw/Hermes as GBrain used the
way it was designed — always on, at real server + API cost.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: doc-audit code chasers — broken recovery hints, stale op description, auto_link key

Four small code fixes surfaced by the markdown accuracy audit:
- doctor's auto-RLS recovery hint pointed at `apply-migrations --force-retry 35`,
  which cannot work (--force-retry targets the vX.Y.Z orchestrator registry, not
  the numeric schema MIGRATIONS array). Hint now points at the recreate SQL in
  docs/guides/rls-and-you.md; test pins against regression.
- v0_11_0 migration printed the same broken-mechanism class of hint
  (`config set minion_mode` writes DB config nothing reads); now names
  `apply-migrations --mode` + preferences.json, the real setter.
- submit_job's op description hardcoded a stale handler list; now points at
  registerBuiltinHandlers as the source plus the --follow discovery trick.
- `auto_link` added to KNOWN_CONFIG_KEYS: read by link-extraction, reconcile-links,
  and sweep, and documented as the off-switch in brain-ops/maintain, but the
  allowlist rejected `config set auto_link false`.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: repo-wide accuracy + MECE reform from the 9-bucket markdown audit

A code-grounded audit of every markdown file (root, architecture, guides,
mcp, tutorials, docs-root, operations/eval/designs, skills, recipes) followed
by a fix wave with per-bucket ownership. Four classes of change:

Accuracy — every documented command/flag verified against src/ before writing:
dead commands replaced with working ones (pages purge-deleted, jobs watch
--follow, gbrain restore, import-based Obsidian flow, space-separated --scopes,
real thin-client recipes, working isolation verification, real supervisor
restart procedure, curl-based ngrok health check, real minion_mode setter);
count drift fixed with rot-proof phrasing (100+ ops, 50+ bundled skills via
skills/manifest.json, 140+ engine methods, KNOBS_HASH_VERSION pointer instead
of hardcoded versions); stale claims corrected (search-mode defaults, RETRIEVAL
pipeline order incl. autocut, sentinel rules, refusal-list mechanism, engine
snapshot, shard cap 2400s + EXIT-HANG classifier in TESTING.md, latest-stable +
publish-template documented in RELEASING.md as release.yml promises).

MECE — one home per concept, pointers elsewhere: test isolation → TESTING.md;
OAuth registration + --bind/--public-url lore → DEPLOY.md; mode bundles →
guides/search-modes.md (the home the CLAUDE.md dispatcher always promised);
merge contract → schema-packs.md; WAL ladder → ENGINES.md; quiet-hours →
quiet-hours.md; capture taxonomy → entity-detection.md; person-page taxonomy →
compiled-truth.md; brain-first protocol → brain-first-lookup.md; refresh
semantics → refresh-algorithm.md; KEY_FILES.md deduplicated (58 extension
entries merged, one entry per file); infra-layer.md rewritten as a pointer page.

Privacy — placeholder sweep across guides, docs, skills, and recipes per the
iron rule; per-release narration stripped from reference docs (current-state
prose only).

Bootstrap coverage — AGENTS.md pointer, RESOLVER routing row, INSTALL.md path,
tutorial cross-links, keyless-mode sections in spend-controls/headless-install.

skills.lock.json regenerated; llms.txt/llms-full.txt rebuilt. Gates: verify
36/36, typecheck clean, doctor 96/96, skills-integrity + resolver + build-llms
+ config-set + migrations all green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(readme): refresh production-brain stats to current brain-repo counts

155,795 pages / 24,589 people / 5,340 companies, counted from the brain
repo's current HEAD; the "100K-page brain" framing moves to 150K to match.
Cron-fleet count unchanged (its store lives on the deployment host, not in
the repos available for verification).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(scan,push): modern OpenAI/Voyage key patterns, scan staged blobs not disk

- secret-scan matches sk-proj-/sk-svcacct-/sk-None- and pa- Voyage keys
  (the bare sk- pattern missed every current OpenAI key format).
- workspacePush stages first, then scans the staged index blobs via
  git cat-file, closing the scan-then-stage TOCTOU where a file changed
  between snapshot and commit shipped unscanned.
- shared binary-sniff helper, memoized glob regexes, atomic push-status
  write, and tests for pull_conflict + gitignored deny-match paths.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(ci): regenerate flag registry for new commands, harden shard classifier + release token

- cli-flag-registry.generated.ts regenerated: bootstrap/hook/sweep and
  sources push --message/--allow-unverified-remote were missing, so the
  strict #2185 validator rejected real invocations and skipped the new
  commands entirely.
- EXIT-HANG shard classifier now requires every assigned file to have
  started before warn-passing a watchdog kill (was fail-open).
- release.yml passes TEMPLATE_REPO_PAT via http.extraheader, off the argv.
- compiled-binary e2e fails loud in CI instead of a silent permanent skip.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(hook,sweep,ipc): non-blocking hook pushes, bounded sweep + cache, source-bound resolve

- session-start/session-end no longer run synchronous git + inline push
  inside their self-deadline; a detached child does the push and the hook
  returns immediately (blocked Claude Code startup for minutes on a dirty
  tree before).
- serve sweep drops the unbounded listAllPageRefs, resolves only candidate
  targets, claims corpus files atomically (no double-LLM-spend race), and
  caps the fence LIKE scan; heartbeat writes are O_APPEND with rare compaction.
- hot-memory cache evicts expired entries and bounds entry count (the key is
  caller-controlled via _meta.session_id).
- v1 resolve IPC honors boundSourceId like turn_context; turn-context runs
  its arms concurrently. doctor reads push/heartbeat thresholds from hook.ts.
- new tests: doctor bootstrap checks, hook push-gate + deadline, concurrent
  sweep claims, cache eviction, bound-source resolve.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(bootstrap): origin-ownership gate, world visibility, collision-safe source id, consent + templates

- repo adoption requires an exact receipt repo_url match or authed-owner
  check (undefined repo_url was a wildcard); create verifies privacy BEFORE
  the first push.
- verify sets facts.default_visibility=world if unset, so agent-authored
  facts surface in per-turn context (they defaulted private before).
- source_id derives a path-hash suffix when 'workspace' is taken by another
  checkout; every consumer reads manifest.source_id.
- skipped HOOKS_CONSENT now declines (was falling through to default yes);
  --minimal refuses on an initialized manifest; tilde fences escaped.
- MCP registration pins --surface full; status hard-fails a public origin
  (template door); receipt writers guard against newer/corrupt receipts;
  uninstall only claims brain-deleted after a real rm.
- templates ship jobs disabled + provider-consent + support-relay lines;
  soul-audit re-runs over the shared interview bank. TODOS: 11 follow-ups.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(security): close adversarial-review findings — scan fails closed, whole-PEM redaction, bound repo push

Cross-model adversarial pass (Claude + Codex) on the bootstrap wave:

- secret scan fails CLOSED: an unreadable, oversized, or binary staged blob
  now blocks the push (blocked_unscannable, exit 5) instead of committing
  unscanned; only a confirmed staged deletion is skipped. This was the
  headline "block secrets before they leave the machine" property failing open.
- private-key redaction spans the whole PEM block (header+body+footer), not
  just the header line — the base64 body no longer survives into the corpus
  the sweep sends to an extraction provider.
- bootstrap repo commits the workspace (secret-scan-gated) before the first
  push and verifies the remote actually received it, so a push-fail retry
  can't adopt an empty remote as success.
- privacy verify is re-bound to origin immediately before push (a concurrent
  origin rewrite between verify and push is refused).
- session-end corpus write is atomic and clears the stale ingested/in-progress
  sidecars so a resumed session's appended transcript is re-ingested.
- public-origin refusal enforced at render (not only status); MCP "already
  registered" is verified to target this workspace, not blessed blindly;
  verify probe cleanup scopes deletes to its own slugs, not a token substring;
  allowlist fingerprint floor raised 8→16 hex.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* v0.45.0.0 feat(bootstrap): paste-in personal-agent install for Codex + Claude Code

Turns a Codex or Claude Code session into a persistent personal agent:
interview-rendered identity files, a local PGLite brain, per-turn context via
serve IPC (Claude Code hooks / Codex pull protocol), session-triggered
persistence, and a private GitHub repo as the agent's portable body. Keyless-
first (the harness model is the LLM; one optional key adds embeddings +
extraction). New `gbrain bootstrap` command family + `gbrain hook` + `gbrain
sweep`; doctor bootstrap health checks; latest-stable distribution ref +
template-repo publish job. Opt-in, additive — existing installs untouched.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: regenerate flag registry for security-fix flags; drop fabricated gbrain capabilities doc ref

CI caught two real failures under the merged state:
- the flag registry lagged the blocked_unscannable/exit-5 flags the security
  round added, tripping the #2185 freshness guard.
- headless-install.md described the keyless capability report as a
  `gbrain capabilities` command, which the #3502 doc-command resolver
  rejects — reworded to prose (the real surface is bootstrap verify's report).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: sync KEY_FILES + bootstrap plan to security-fix behavior

Cross-referenced the security-fix round against the reference docs and
corrected the drift those commits introduced:

- workspace-push.ts entry: stage-FIRST-then-scan order (the TOCTOU fix),
  fail-closed blocked_unscannable, and the sources-push status -> exit-code map.
- hooks.ts entry: MCP registration pins `serve --surface full`.
- hook.ts entry: session-start/session-end pushes run in a detached child
  (non-blocking); atomic corpus write clears stale sidecars.
- bootstrap.ts entry: render hard-refuses a public origin (template door).
- verify.ts entry: source_id collision resolution (workspace-<path-hash>).
- AGENT_BOOTSTRAP_PLAN as-shipped delta note for the scan/stage reorder.

llms bundle unchanged (KEY_FILES is link-only); build:llms and
test/build-llms.test.ts green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(ci): silence SC2016 on the intentional askpass literal in release.yml

The one-shot GIT_ASKPASS script must contain literal $1 and
$TEMPLATE_REPO_PAT so they expand when /bin/sh runs it at git's credential
prompt, not when the outer shell writes the file — single quotes are correct.
Add a scoped shellcheck disable so actionlint passes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(skills): declare 'bootstrap my data' trigger in cold-start frontmatter

The doc reform added 'bootstrap my data' to cold-start's RESOLVER.md row (to
disambiguate data-bootstrap from agent-bootstrap) but not to the skill's own
frontmatter triggers, tripping the RESOLVER↔frontmatter round-trip contract
(resolver.test.ts). Declare it; regenerate skills.lock.json.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(bootstrap): default per-turn hooks + search mode ON without a prompt

Installing gbrain for your coding agent IS the consent for the behaviors that
make it work, so stop re-litigating them with install-time questions whose
"no" defeats the product:

- Per-turn hooks (Claude Code) install ON by default — no prompt. Off-ramps:
  `--no-hooks` at install, `GBRAIN_HOOKS=0` at runtime, `bootstrap uninstall`.
  The "hooks installed" line now surfaces the kill switch so default-on is
  never silent. A persisted HOOKS_CONSENT=no (interview --skip) still declines.
- Search mode defaults to `balanced` silently (nobody knows the modes at
  install; `gbrain search modes` changes it any time).
- MCP scope stays the ONE deliberate prompt — project vs user is a real
  cross-repo privacy choice, not friction.

Marks the two consents `silent: true` in the question bank (new QuestionSpec
field), rewrites the runbook phases so the agent no longer asks them, adds the
`--no-hooks` flag (+ registry regen), and adds default-on / opt-out tests.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(bootstrap): real end-to-end coverage — cross-session recall, per-turn content, Codex door, realistic corpus

Closes the seven e2e gaps a coverage audit surfaced: the plumbing was
well-unit-tested but the product claims ("Codex works, context shows up every
turn with real content, it remembers across restarts, machine two recovers,
Postgres works") were unproven end to end. Test-only wave — zero src changes.

- Hermetic synthetic corpus (test/fixtures/bootstrap-corpus/ + a loader helper):
  12 interlinked pages (52 edges, timelines), 12 world/private beliefs, 8 gold
  queries — curated from the gbrain-evals synthetic corpora, 100% placeholder
  names, so recall is asserted on a real multi-entity brain instead of a
  2-node self-planted probe.
- GAP1 magic moment: author a fact via the real write path, disconnect the
  engine, reopen against the same DB, recall it — a real session boundary, not
  verify.ts's same-connection SQL read-back. Plus a source-isolation assertion.
- GAP2 per-turn content: hook-under-serve Pin 1 now seeds a known fact and
  asserts its text lands in the injected block AND private beliefs never do
  (was: empty brain, empty_block accepted as a pass).
- GAP3 Codex door: assert the rendered AGENTS.md carries the Gate-3 brain-first
  pull protocol; make the fake codex shim implement `mcp get` so the [FIX7]
  target-verification can actually fail; the Docker cold-machine harness now
  exercises the hooks/MCP registration step instead of skipping it.
- GAP4 corpus recall: turn-context + verify graph-floor/qrels run on the real
  multi-entity brain with real edges.
- GAP5 attach: machine-two now re-ingests the cloned brain/ into a fresh DB and
  recalls a fact authored only on machine one — the multi-device payoff.
- GAP6 keyed + Postgres (env-gated): real embeddings prove semantic recall a
  paraphrase query can reach but keyless BM25 cannot; bootstrap verify drives a
  real Postgres engine (skipIf DATABASE_URL/keys absent).
- GAP7 persistence: session-end runs the REAL push (not the mocked seam) to a
  local bare remote and the remote receives the content; a planted secret is
  blocked at the gate; the 15-min cron installs and fires a scan-gated push.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(bootstrap): real-agent e2e — drive the actual claude + codex binaries end to end

Closes the audit's biggest gap ("no real harness ever drives a turn"). Adapts
gstack's PTY/headless agent harness to prove the bootstrap install + smoke work
against the REAL binaries, not PATH shims. Test/CI/docs only — zero src changes.

- test/helpers/agent-harness.ts: hermetic clean-room child env (ported from
  gstack; drops CONDUCTOR_/CLAUDE_/GSTACK_/MCP_/GBRAIN_, promotes
  GSTACK_ANTHROPIC_API_KEY→ANTHROPIC_API_KEY), real-binary resolvers + auth
  probes, headless `claude -p --output-format stream-json` and `codex exec
  --json` turn runners, a gbrain stdio MCP-config writer, and a keyless brain
  seeder. + a fixture-parse unit test (no binary needed).
- test/e2e/bootstrap-real-claude.serial.test.ts: real `gbrain bootstrap`
  install → REAL `claude mcp add` (verified via `claude mcp get`) → verify
  exit 0 → a real `claude -p --mcp-config --strict-mcp-config` turn that
  invokes mcp__gbrain__search and answers from the brain (proven: toolCalls
  include mcp__gbrain__search, final text carries the seeded fact).
- test/e2e/bootstrap-real-codex.serial.test.ts: same install with REAL `codex
  mcp add` into a real ~/.codex/config.toml + Gate-3 pull-protocol assertion,
  then a real `codex exec --json` turn surfacing the fact (MCP or the pull-
  protocol shell path). Bounded retry absorbs codex's occasional MCP-call
  cancellation without softening the fact-requiring assertion.
- Everything hermetic (temp HOME/CLAUDE_CONFIG_DIR/CODEX_HOME/GBRAIN_HOME;
  real ~/.codex auth copied read-only) and skipIf-gated so it self-skips
  cleanly where the binaries/auth are absent.
- heavy-tests.yml: gated `real-agent-e2e` job (nightly/label, never the PR
  shard; no-op on a runner without authed binaries).
- TODOS: compiled `gbrain` binary can't serve a PGLite brain (bun compile
  omits the WASM/extension payloads); harness falls back to `bun run` serve.

Verified against live claude 4.6 + codex 0.147.0: 15 pass / 0 fail; verify
36/36; typecheck clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(ci): real-agent-e2e job — bash array + --timeout (actionlint SC2086 + bun-test-timeout guard)

The real-agent-e2e job's file loop used an unquoted $FILES (SC2086) and ran
`bun test` without --timeout (check-bun-test-timeout guard). Switch to a bash
array and add --timeout=600000 (real-agent turns are slow; the tests self-skip
without authed binaries so it's a no-op elsewhere).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(pglite): embed WASM + extension assets so the compiled binary can serve

A `bun build --compile` gbrain binary could not `serve` a PGLite brain: the
compile bundles JS but not PGLite's runtime payload (pglite.wasm, initdb.wasm,
pglite.data, vector/pg_trgm tarballs), so `serve` on PGLite died with a
bunfs/ENOENT. Now the assets ride inside the binary.

- src/core/pglite-embedded-assets.ts: embeds the five assets via
  `import … with { type: 'file' }` (the ENG-6 idiom) and exposes
  getEmbeddedPgliteOptions() → { pgliteWasmModule, initdbWasmModule, fsBundle,
  extensions:{vector,pg_trgm} }. WASM/fsBundle are consumed as bytes; the two
  extension tarballs are materialized to a content-addressed temp file (atomic,
  size-verified reuse) because PGLite reads them via fs.createReadStream, which
  cannot read a /$bunfs path. Unconditional (works in bun-run and compiled),
  so no fragile mode branch.
- src/core/pglite-engine.ts: static-import getEmbeddedPgliteOptions (engine
  path stays static per the engine-dynamic-import invariant); spread into both
  PGlite.create sites (initial + WAL-repair retry). The bunfs classifier stays
  as a backstop but no longer fires for a correct binary.
- scripts/check-pglite-embedded.sh (+ smoketest): compiles a focused binary and
  asserts it boots PGLite, CREATE EXTENSION vector/pg_trgm, and round-trips a
  page — wired into `bun run verify` (now 37 checks), check:all, and
  check:pglite-embedded. Fail-soft only when compile is unavailable.
- agent-harness.ts probeCompiledPglite now passes → the real-agent e2e uses the
  fast compiled MCP server. TODOS: the P2 "can't serve PGLite" item is closed.

Verified: fresh compiled binary ran `search`/`query` against a PGLite brain and
returned the seeded row (no bunfs/ENOENT); verify 37/37; pglite-engine 120/0
source-mode; typecheck clean; engine-dynamic-import + parity guards pass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-11 16:42:11 -07:00
Garry TanandClaude Opus 4.7 bc9f7774bf v0.37.0.0 feat(skillpack): registry cathedral — third-party publish + install + 10/10 quality bar (#1208)
* docs(designs): promote skillpack registry v1 spec with v0.36 alignment header

Strategic spec produced via /office-hours → /plan-ceo-review → /plan-eng-review
→ /plan-devex-review (two rounds) → /codex outside-voice. 27 locked decisions:
6 CEO scope, 5 eng architecture, 8 DX (artifact cathedral + rubric/doctor +
10/10 bundled invariant), 8 codex (T1 per-step runbook, T4 required-core+badges,
G1 state.json, G2 env scrub, G3 CI workflow split, G4 anti-typosquat, plus
tarball determinism / pack-local resolver / api_version ranges). 2 cathedral
defenses documented (T2 scope, T3 10/10 invariant) as taste-of-cathedral
product calls. Lake Score: 25/27.

Spec carries a top-of-file alignment header noting the v0.36.0.0 retirement of
the managed-block install model. Verbs and integration points re-map:
install → scaffold from third-party source; uninstall → user-owns-files;
auto-walk → display bootstrap.md; multi-source receipt → state.json. Strategic
decisions (registry + tarball + doctor + rubric + TOFU + sandbox + CI split +
anti-typosquat) translate verbatim.

Implementation starts in subsequent commits on this branch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(skillpack): foundation layer — manifest validator + tarball + state.json

Three pure-data modules every other skillpack-registry feature builds on top
of. Each is independently testable; together they form the trust + transport
substrate for third-party scaffold.

- src/core/skillpack/manifest-v1.ts
  Third-party skillpack.json runtime validator. Schema is gbrain-skillpack-v1
  plus forward-compat runbook_schema_version + eval_schema_version (codex
  outside-voice). Shape is a superset of bundle.ts's BundleManifest so the
  existing v0.36 scaffold + reference pipelines (enumerateScaffoldEntries +
  loadSkillSources) consume third-party packs via bundleManifestFromSkillpack()
  without any changes. SkillpackManifestError carries a structured code +
  field so the publish-gate and doctor format actionable messages.

- src/core/skillpack/tarball.ts
  Deterministic pack + allowlist-gated extract. Pack uses GNU tar with
  --sort=name --mtime=@0 --owner=0 --group=0 --numeric-owner --pax-option
  + GZIP=-n + TZ=UTC so same dir -> same SHA-256 across hosts and clocks.
  Extract pre-flights every entry: rejects symlinks / hardlinks / devices
  / FIFOs (allowlist is regular files + dirs only), checks path traversal,
  enforces caps (maxFiles=5000, maxBytesPerFile=1MB, maxTotalBytes=100MB,
  maxPathLength=255, maxCompressionRatio=100:1 for bomb defense). Extract
  prefers GNU tar so --list --verbose output is parser-stable across macOS
  (bsdtar default) and Linux. Throws TarballError with structured codes.

- src/core/skillpack/state.ts
  Machine-owned trust store at ~/.gbrain/skillpack-state.json. Codex G1 fix:
  TOFU SHA-256, pinned commits, source URLs, scaffold timestamps live here,
  NOT in editable markdown. Atomic .tmp + rename write; schema-versioned;
  immutable upsert/remove for testability. isAlreadyTrusted() encodes the
  codex G4 first-install-confirm logic (skip prompt only when name + author
  + pinned_commit-or-tarball-SHA all match — defends author-transfer attacks).

Tests: 64 cases across 3 files; all green. Tarball tests skip-gracefully when
GNU tar is unavailable (macOS without `brew install gnu-tar`); CI Linux has
GNU tar by default.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(skillpack): third-party scaffold — owner/repo, https URL, .tgz, local path

End-to-end third-party scaffold pipeline composed from the foundation layer
plus three new modules. `gbrain skillpack scaffold <source>` resolves any of:

  owner/repo                    (expands to https://github.com/owner/repo.git)
  https://github.com/.../...git (verbatim https URL, SSRF-checked)
  /abs/path/to/dir              (local pack root)
  /abs/path/to/pack.tgz         (local tarball)

Bare kebab names ("book-mirror") keep routing to the v0.36 bundled-skill
path; the dispatcher disambiguates on the literal `/` / `://` / `.tgz`
shape in the spec. No regression to v0.36 (all 272 existing skillpack
tests pass).

- src/core/skillpack/remote-source.ts
  classifySpec() is the pure-fn router. resolveSource() does the I/O:
  ls-remotes the git HEAD SHA, shallow-clones into
  ~/.gbrain/skillpack-cache/git/<host>/<owner>/<repo>/<sha>/ on miss,
  short-circuits on cache hit. Tarballs extract into
  ~/.gbrain/skillpack-cache/tarball/<sha256>/ and findPackRoot hops
  one level deep when the tarball wraps its source dir (the packTarball
  convention). Local paths skip the cache entirely (user owns the dir).
  Reuses git-remote.ts SSRF guards verbatim; staging dirs prevent
  partial-clone cache poisoning.

- src/core/skillpack/trust-prompt.ts
  Codex G4 first-install identity confirm. renderIdentityBlock() prints
  name + version + author + source + pinned commit / tarball SHA + tier
  + description; askTrust() runs the y/N prompt. isAlreadyTrusted()
  (in state.ts) drives the skip path — same (name, author, pin/SHA)
  triple = no prompt. Author mismatch always re-prompts (transfer-attack
  defense). Local sources skip the gate entirely.

- src/core/skillpack/bootstrap-display.ts
  Codex T1 fix: no executor for install runbooks. buildBootstrapDisplay()
  reads runbooks/bootstrap.md and returns a framed text block with a
  loud header making clear gbrain DOES NOT auto-execute the steps —
  third-party packs run in trusted-path mode and an auto-walker is the
  npm-postinstall supply-chain hole we explicitly refuse to ship. The
  agent reads the framed output and walks per-step at its own discretion.

- src/core/skillpack/scaffold-third-party.ts
  Orchestrator. Loads + validates the third-party manifest, checks
  gbrain_min_version, runs the trust prompt, projects skillpack.json
  to BundleManifest shape so enumerateScaffoldEntries (v0.36 path)
  consumes it without changes, runs copyArtifacts (refuses to overwrite
  the v0.36 way), upserts state.json, returns the framed bootstrap.
  Pure semver compare for the version gate; no external dep.

- src/commands/skillpack.ts dispatch extension
  cmdScaffold now disambiguates: contains `/` / `://` / `.tgz` →
  runThirdPartyScaffold. JSON output envelope matches the rest of
  the v0.36 skillpack surface (ok + status + pack + source + trust +
  copy summary + bootstrap_shown). New flags: --trust, --no-cache.

- src/core/skillpack/tarball.ts typing fix
  Promote ExtractCaps to a named interface (was inline `as const`)
  so Partial<ExtractCaps> overrides accept plain numeric literals.

Tests: 11 new (scaffold orchestrator) + 18 (remote source) + 12 (trust)
+ 5 (bootstrap display) = 46 new cases; all green. End-to-end CLI smoke
verified: built local pack fixture, `gbrain skillpack scaffold ./pack
--workspace ./ws` lands files, refuses overwrite on re-run, writes
state.json, displays bootstrap. Typecheck clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(skillpack): registry catalog — schema + fetch client + search/info/registry CLI

The discovery layer. `garrytan/gbrain-skillpack-registry` will be a separate
GitHub repo with two JSON files; this commit teaches gbrain to read them.

- src/core/skillpack/registry-schema.ts
  Runtime validators for registry.json (gbrain-registry-v1) and
  endorsements.json (gbrain-endorsements-v1). Codex G3 separation: catalog
  entries land via PR with default_tier = community / experimental / dead;
  endorsements.json is Garry-only and OVERLAYS tier at read time.
  effectiveTier() resolves the overlay. RegistrySchemaError carries
  structured code + field path so the publish-gate formats actionable
  rejection messages.

- src/core/skillpack/registry-client.ts
  Network fetch + cache + stale-fallback. Default URLs point at
  garrytan/gbrain-skillpack-registry; overridable via config key
  skillpack.registry_url or --url. Cache lives at
  ~/.gbrain/skillpack-cache/registry-<sha16>.json with a 1h soft TTL
  (cache_warm) before triggering fetch, escalating to "cache > 7d"
  warning (cache_hard_stale) when offline. Hard-fail only when no
  cache AND no network (no_cache_no_network). Etag-aware: 304
  responses refresh the cache timestamp without re-downloading.
  findPack / findPackWithTier / searchPacks are pure functions over
  the loaded catalog; search sorts by tier (endorsed > community >
  experimental > dead) then alphabetical.

- src/commands/skillpack.ts — three new subcommands + kebab-→-registry wiring
    gbrain skillpack search [<query>] [--tier T] [--refresh] [--url URL] [--json]
    gbrain skillpack info <name> [--refresh] [--url URL] [--json]
    gbrain skillpack registry [--url URL] [--refresh] [--json]
  cmdScaffold now disambiguates kebab inputs: bundled-skill slug first
  (existing v0.36 path), then registry lookup. `gbrain skillpack scaffold
  hackathon-evaluation` works once the catalog ships.

- src/core/skillpack/trust-prompt.ts + state.ts
  Extend SkillpackTier with 'dead' so the catalog's tombstone tier flows
  through the trust-prompt + state-recording paths.

Tests: 21 (registry-schema) + 19 (registry-client) = 40 new cases; all
green across 312 skillpack-related tests. End-to-end CLI smoke: served
fixture registry.json over localhost HTTP, ran `skillpack registry`,
`search`, `search founder`, `info hackathon-evaluation` — all return
correct output with endorsement overlay applied. Typecheck clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(skillpack): rubric + doctor + audit — 10-dimension quality bar

The quality bar makes the registry meaningful. Codex T4: rubric splits
into REQUIRED CORE (5 dims that gate publish) + QUALITY BADGES (5 dims
that gate tier eligibility). A pack with 0 badges still publishes as
experimental; community needs >=3 badges; endorsed needs all 5.

- src/core/skillpack/rubric.ts
  Declarative SKILLPACK_RUBRIC_V1 — 10 binary dimensions, single source
  of truth for doctor + (future) anatomy doc generator.

    CORE (5):
      1. manifest_valid              — skillpack.json passes v1 schema
      2. skills_have_skill_md        — every skill has SKILL.md w/ valid frontmatter
      3. routing_evals_present       — every skill has routing-eval.jsonl >= 5 intents
      4. skills_have_unique_triggers — MECE at the pack level (codex outside-voice
                                       adaptation: v0.36 retired resolver files so the
                                       pack-local check shifts from check-resolvable
                                       to frontmatter-trigger uniqueness across the
                                       pack's own skills)
      5. changelog_present_and_current — CHANGELOG.md has entry for manifest.version

    BADGES (5):
      6. unit_tests_present          — manifest.unit_tests glob matches >=1 file
      7. e2e_tests_present           — manifest.e2e_tests glob matches >=1 file
      8. llm_eval_present            — *.judge.json with cases.length >= 3
      9. bootstrap_runbook_present   — runbooks/bootstrap.md non-empty (codex T1:
                                       v0.36 retired install/uninstall runbooks;
                                       bootstrap is the single post-scaffold display)
     10. license_present             — LICENSE / LICENSE.md / LICENSE.txt non-empty

  walkRubric() is async (each dim's check returns a Promise) so a future
  --full mode can run heavyweight checks inline. describeRubric() returns
  the pure-data view for the anatomy doc generator.

- src/core/skillpack/doctor.ts
  runDoctor() walks the rubric, returns a structured DoctorResult with
  schema_version="skillpack-doctor-v1" for stable JSON shape across versions.
  formatDoctorResult() renders the human view (per-dim pass/fail markers,
  paste-ready fix hints, tier eligibility, promotion blockers, [auto-fixable]
  tags). --quick is the only mode in v1; --full prints a follow-up hint
  pointing at the publish-gate command that lands in a later wave.

  --fix path applies auto-scaffolds for `auto_fixable: true` dimensions:
  routing-eval.jsonl stubs (5 example intents per skill), CHANGELOG.md
  with the current version's date entry, test/example.test.ts stub,
  e2e/example.e2e.test.ts stub, evals/example.judge.json with 3 stub
  cases, runbooks/bootstrap.md stub, LICENSE stub. Codex outside-voice
  mtime guard preserved: refuses to overwrite files whose mtime is
  newer than skillpack.json's. Requires --yes for unattended runs.

- src/core/skillpack/audit.ts
  ~/.gbrain/audit/skillpack-YYYY-Www.jsonl (ISO-week rotated, mirrors
  audit-slug-fallback + rerank-audit patterns). logSkillpackEvent is
  best-effort: stderr warn on failure, never throws. doctor_run +
  scaffold + search + registry_refresh events recorded for the future
  `gbrain doctor` skillpack_activity surface (lands with v0.37
  doctor-integration wave).

- src/commands/skillpack.ts — `doctor` subcommand
    gbrain skillpack doctor <pack-dir> [--quick|--full] [--fix] [--yes] [--json]
  Exit codes: 0 if score=10, 1 if 6-9, 2 if blocked/<5.

Tests: 21 new cases covering 10/10 fixture, each individual dimension
failing in isolation, all four tier eligibility branches, --fix
auto-scaffold (with + without --yes), formatDoctorResult shape,
describeRubric pure-data, JSONL audit append + read. 333/333 skillpack
tests across 23 files. CLI smoke verified.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(skillpack): publisher side — init + pack + 10/10 reference pack

The publisher trinity: scaffold a new pack, gate it through the
doctor, emit a deterministic tarball. Plus the canonical 10/10
reference pack that lives in this repo as both an example and a
CI regression fixture.

- src/core/skillpack/init-scaffold.ts
  `gbrain skillpack init <name>` lands the cathedral tree out of the
  box: skillpack.json + skills/<name>/SKILL.md + routing-eval.jsonl
  (5 example intents) + runbooks/bootstrap.md + CHANGELOG.md + README +
  LICENSE + .gitignore + test/ + e2e/ + evals/<name>.judge.json. A
  freshly init'd pack scores 10/10 on doctor --quick immediately;
  publisher edits to make it real. --minimal flag drops test/e2e/evals
  for power users opting out. Refuses to overwrite any existing file
  (same contract as v0.36 scaffold).

- src/core/skillpack/pack-publish.ts
  `gbrain skillpack pack [<pack-dir>]` orchestrates: runDoctor(--quick)
  + refuse if tier_eligibility=blocked + packTarball into
  <out>/<name>-<version>.tgz with deterministic SHA-256. --dry-run
  validates only. --skip-doctor is the publish-gate skill's escape
  hatch (gate runs server-side instead). Both paths log into the
  skillpack audit JSONL.

- src/commands/skillpack.ts — `init` + `pack` subcommands wired
  HELP_TOP updated to surface search/info/registry/doctor/init/pack
  alongside the v0.36 commands.

- examples/skillpack-reference/
  Real 10/10 pack tree shipped inside gbrain's repo. Doubles as an
  integration-test fixture and a publisher reference. The SKILL.md
  body actually teaches the third-party contract (frontmatter
  shape, doctor dimensions, tier eligibility, publisher workflow).
  README.md walks the tree.

- test/skillpack-reference-pack-is-ten.test.ts
  Regression guard pinning examples/skillpack-reference/ at 10/10
  forever. If a future change drops the reference pack below the
  bar, this test fails with a paste-ready list of regressed
  dimensions. Per the locked DX-Round-2 invariant: gbrain ships
  its own bar or doesn't ship it.

Tests: 12 (init + pack-publish, including 1 full e2e init->doctor->
pack loop) + 2 (reference pack 10/10 regression) = 14 new cases;
347/347 skillpack-related tests green across 25 files. Typecheck
clean. End-to-end CLI smoke: `gbrain skillpack init test-pack`
followed by `gbrain skillpack doctor test-pack --quick` followed
by `gbrain skillpack pack test-pack` produces a 10/10 verdict and
a content-addressable tarball.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(skillpack): anatomy doc generator + e2e third-party flow test

Closes the cathedral with the canonical one-page reference doc + the
end-to-end test that exercises the full publisher + consumer loop via
the actual `gbrain` CLI subprocess.

- scripts/build-skillpack-anatomy.ts
  Regenerates docs/skillpack-anatomy.md between BEGIN/END markers
  from src/core/skillpack/rubric.ts. Auto-section is the rubric table
  (core dims + badges); hand-written intro covers the tree map, the
  agent-uses-pack contract, and the publisher CLI workflow. `--check`
  flag fails the build when committed doc drifts from rubric.ts —
  wireable into `bun run verify` later.

- docs/skillpack-anatomy.md
  Initial generated output. 112 lines. Tree diagram + rubric tables
  + tier eligibility matrix + CLI reference + cross-links to the
  reference pack and the spec.

- test/e2e/skillpack-third-party.test.ts
  Subprocess-spawning E2E (no in-process imports of CLI internals).
  Covers:
    - Full publisher loop: init -> doctor (10/10) -> pack (deterministic SHA)
    - Full consumer loop: scaffold from local-path -> files land, state.json
      records, refuse-to-overwrite on re-run
    - Doctor --fix loop: delete required artifacts -> doctor surfaces
      gaps -> --fix --yes auto-restores
    - --minimal init scores 7/10 (3 missing badges that need manifest
      patches; documents the expected behavior)

  The localhost-registry search test is skipped: Bun.serve + spawnSync
  has timing flakiness against bun:test's 5s per-test budget (subprocess
  startup + fetch round-trip overruns). Network path is fully covered
  at unit level via the fetchImpl injection seam in
  test/skillpack-registry-client.test.ts.

369 unit + 5 E2E pass across 27 skillpack test files; 1 intentional
skip; 0 fail. Typecheck clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(skillpack): route audit-test env mutations through withEnv() helper

scripts/check-test-isolation.sh flagged test/skillpack-rubric-doctor.test.ts
for direct process.env.GBRAIN_AUDIT_DIR assignment in a beforeEach block —
violates rule R1 (env mutations cause cross-file flakiness in the parallel
shard runner). Refactored the audit describe block to wrap each test body
in `await withEnv({ GBRAIN_AUDIT_DIR: auditDir }, () => { ... })` from
test/helpers/with-env.ts. Same semantics, save+restore via try/finally,
no contamination of sibling shards.

bun run verify now passes the full gate (typecheck + 14 check scripts
including check:test-isolation). Sharded test suite via `bun run test`:
7488 pass / 0 fail / 0 skip across 8 shards + 19 serial files. Skillpack
slice: 369 unit + 5 E2E pass / 1 intentional skip / 0 fail.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(e2e): update cycle phase-order assertions for v0.36.1.0 hindsight wave

Pre-existing master bug surfaced during the skillpack-registry-cathedral
E2E run: v0.36.1.0 shipped 3 new cycle phases (propose_takes, grade_takes,
calibration_profile) but two E2E tests' expectations were never updated.

- test/e2e/dream-cycle-phase-order-pglite.test.ts
  EXPECTED_PHASES now includes the v0.36.1.0 trio. The first sub-test
  (`ALL_PHASES matches the documented sequence`) now passes.

- test/e2e/cycle.test.ts
  Phase count assertion bumped 13 -> 16. Comment block extended with
  the v0.36.1.0 entry in the same shape as the prior version markers.

Both files were drift-against-source: cycle.ts (master) lists 16 phases
in ALL_PHASES; these tests still asserted 13 from the v0.33.3 baseline.
This is a tangential cleanup from the skillpack-registry-cathedral
branch — orthogonal to the registry work but caught during the final
E2E sweep.

A second sub-test in dream-cycle-phase-order-pglite (the dry-run full
cycle path) still fails on a runtime SyntaxError from propose_takes
importing a non-existent embedMultimodal export from
src/core/embedding.ts. That's a separate v0.36.1.0 implementation bug
that warrants its own PR; not in scope here.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(e2e): include v0.36.1.0 embedding exports in dream-cycle mock

Bun's module linker fails fast when a downstream consumer imports a
symbol the mock didn't declare. v0.36.1.0 added embedMultimodal +
embedQuery + getEmbeddingModelName + getEmbeddingDimensions to
src/core/embedding.ts; the propose_takes phase and other v0.36 phases
pull from them, so the mock has to keep parity.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(skillpack): endorse CLI — Garry-only registry tier overlay

gbrain skillpack endorse <name> [--tier endorsed|community|experimental|dead]
                               [--note STR] [--push] [--dry-run]

Runs inside a clone of garrytan/gbrain-skillpack-registry. Validates
that <name> is in registry.json's catalog, mutates endorsements.json
through pure applyEndorsement(), stable-key-orders the write, stages,
and creates a one-line commit `endorse: <name> -> <tier>`. Optionally
pushes to origin.

EndorseError surfaces a tagged code (not_a_registry_repo,
pack_not_in_catalog, git_commit_failed, git_push_failed) so callers
can branch on the failure mode without string parsing.

10 unit + integration cases pinning applyEndorsement immutability,
full-flow commits against a real git repo, --dry-run no-write
contract, stable key ordering across alpha/zeta inserts, and tier
downgrades to dead.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(release): bump to 0.37.0.0 — skillpack registry cathedral

Third-party skillpack ecosystem layered on the v0.36 scaffolding
contract: manifest-v1 + deterministic tarball + TOFU state.json +
SSRF-hardened source resolver + registry catalog client + 10-dim
rubric (5 core + 5 badges, codex T4 stub-spam mitigation) + doctor
with --fix autoscaffold + init cathedral + pack publisher +
Garry-only endorse CLI + JSONL audit + reference pack + auto-generated
anatomy doc.

Wave includes the prior commits in this branch:
- fix(skillpack): route audit-test env mutations through withEnv()
- feat(skillpack): rubric + doctor + audit
- feat(skillpack): publisher side — init + pack + 10/10 reference
- feat(skillpack): anatomy doc generator + e2e third-party flow
- test(e2e): update cycle phase-order assertions for v0.36.1.0
- test(e2e): include v0.36.1.0 embedding exports in dream-cycle mock
- feat(skillpack): endorse CLI

Deferred to follow-ups: subprocess sandbox for publish-gate,
garrytan/gbrain-skillpack-registry repo creation + CI workflow
split (codex G3), Printing Press cross-list, generated gbrain-cli,
W4.5 retrofit of bundled skills to 10/10.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(release): rebump 0.37.0.0 → 0.38.0.0

User requested v0.38.0 (4-segment: 0.38.0.0) as the slot for the skillpack
registry cathedral. Pure rename — no scope change, no behavior change.
VERSION + package.json + CHANGELOG header + CHANGELOG "To take advantage"
section + CLAUDE.md Key Files entry rewritten in lockstep.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(release): rebump 0.38.0.0 → 0.37.0.0

User picked v0.37.0.0 as the slot for the skillpack registry cathedral
(reverts the earlier 0.37 → 0.38 rebump). Master tip is v0.36.6.0, so
0.37.0.0 remains semver-clean. Pure rename — no scope change, no behavior
change. VERSION + package.json + CHANGELOG header + "To take advantage"
section + lead-paragraph "v0.38" references + CLAUDE.md Key Files
annotation all rewritten in lockstep.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-19 18:12:01 -07:00