From 952b237c0b94e06786e3ab1c852ec62fe830b232 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Tue, 28 Jul 2026 12:21:29 -0700 Subject: [PATCH] fix(test): update the three remaining KNOBS_HASH_VERSION pins to 14 (#3430) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Missed in the first pass because I ran a targeted set of test files instead of the full suite. CI shards 3, 8 and 10 caught them: test/search/knobs-hash-reranker.test.ts:67 test/cross-modal-phase1.test.ts:139,149 test/search-alias-resolved-boost.test.ts:93 Each carries the running history of why the version moved, so each gets the 13→14 rationale appended rather than just the number swapped. No pins at 13 remain anywhere in test/. --- test/cross-modal-phase1.test.ts | 5 +++-- test/search-alias-resolved-boost.test.ts | 4 ++-- test/search/knobs-hash-reranker.test.ts | 5 ++++- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/test/cross-modal-phase1.test.ts b/test/cross-modal-phase1.test.ts index 177d2030c..c536a742b 100644 --- a/test/cross-modal-phase1.test.ts +++ b/test/cross-modal-phase1.test.ts @@ -136,7 +136,7 @@ describe('D2 — knobsHash differs across cross-modal knob values', () => { return resolveSearchMode({ mode: 'balanced' }); } - test('KNOBS_HASH_VERSION is 13 (cross-modal still appended; 12→13 embedding-provider migration #3390)', () => { + test('KNOBS_HASH_VERSION is 14 (cross-modal still appended; 13→14 compiled_truth boost scope #3430)', () => { // v0.35 ladder: 1→2 reranker, 2→3 floor_ratio. v0.36 piggybacks on v=3 // with 7 cross-modal knobs + column/provider context. v0.40.4 (salem) + // v0.39 T21 (master) bump to v=4 for graph_signals + schema-pack fields. @@ -146,7 +146,8 @@ describe('D2 — knobsHash differs across cross-modal knob values', () => { // v0.43: 9→10 relational recall arm. #1400: 10→11 query-side input_type // finally reaches asymmetric providers — pre-fix rows were keyed on // document-side query vectors. #2825: 11→12 hard-exclude fold (hx=). - expect(KNOBS_HASH_VERSION).toBe(13); + // #3430: 13→14 compiled_truth boost no longer applies at detail=medium. + expect(KNOBS_HASH_VERSION).toBe(14); }); test('flipping unified_multimodal changes the hash', () => { diff --git a/test/search-alias-resolved-boost.test.ts b/test/search-alias-resolved-boost.test.ts index 943c3d5fb..2adb8877c 100644 --- a/test/search-alias-resolved-boost.test.ts +++ b/test/search-alias-resolved-boost.test.ts @@ -89,7 +89,7 @@ describe('alias_resolved boost stage', () => { }); describe('KNOBS_HASH_VERSION', () => { - it('is 13 (12→13 embedding-provider migration invalidates rows written against the prior embedding space, #3390)', () => { - expect(KNOBS_HASH_VERSION).toBe(13); + it('is 14 (13→14 compiled_truth boost no longer applies at detail=medium, so pre-fix rankings must be unreachable, #3430)', () => { + expect(KNOBS_HASH_VERSION).toBe(14); }); }); diff --git a/test/search/knobs-hash-reranker.test.ts b/test/search/knobs-hash-reranker.test.ts index 73493ac0e..8478864e0 100644 --- a/test/search/knobs-hash-reranker.test.ts +++ b/test/search/knobs-hash-reranker.test.ts @@ -64,7 +64,10 @@ describe('KNOBS_HASH_VERSION + version invariants', () => { // pre-fix document-side query vectors must not be served. // #2825: 11→12 to fold the resolved hard-exclude prefix list (hx=) — // cached rows leaked GBRAIN_SEARCH_EXCLUDE'd slugs across processes. - expect(KNOBS_HASH_VERSION).toBe(13); + // #3430: 13→14 — the compiled_truth boost no longer applies at + // detail=medium. Results are cached after fusion, so rows ranked under + // the old boost semantics must not be served under the new ones. + expect(KNOBS_HASH_VERSION).toBe(14); }); test('hash is 16 hex chars regardless of reranker config', () => {